Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >>> In the following test we get stuck by sleeping forever in _dwc3_set_mode() >>> after which dual-role switching doesn't work. >>> >>> On dra7-evm's dual-role port, >>> - Load g_zero gadget driver and enumerate

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

2018-03-05 Thread Andrzej Hajda
On 02.03.2018 14:13, Heikki Krogerus wrote: > Hi, > > On Tue, Feb 27, 2018 at 08:11:29AM +0100, Andrzej Hajda wrote: >> +2. USB-C connector attached to CC controller (s2mm005), HS lines routed >> +to companion PMIC (max77865), SS lines to USB3 PHY and SBU to DisplayPort. >> +DisplayPort video

Re: [usb-next PATCH v11 5/8] usb: host: xhci-mtk: remove custom USB PHY handling

2018-03-05 Thread Sean Wang
Hi, Martin Tested-by: Sean Wang I've tested the series with U2 storage and U3 ethernet devices on both boards MT7623 BPI-R2 and MT7622 RFB1 using xhci-mtk driver, they are still working well. Below is related logs for test devices probing # [ 42.590356] usb

Re: howto debug xhci driver?

2018-03-05 Thread Felipe Balbi
Hi, Bin Liu writes: > I am relatively new to xhci and its driver. I am trying to get a xhci > driver runtime log to understand how it handles usb transactions, but I > don't get much information with dynamic debug (module xhci_hcd) or > enabling xhci trace events. Is there any

RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

2018-03-05 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年2月27日 19:03 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; li...@roeck-us.net; > a.ha...@samsung.com; mark.rutl...@arm.com; yue...@google.com; > Peter

Re: [PATCH v2] usb: phy: mxs: Fix NULL pointer dereference on i.MX23/28

2018-03-05 Thread Felipe Balbi
Fabio Estevam writes: > Hi Felipe, > > On Mon, Jan 22, 2018 at 10:28 AM, Fabio Estevam wrote: >> Hi Felipe, >> >> On Thu, Jan 18, 2018 at 12:22 AM, Fabio Estevam wrote: >>> From: Fabio Estevam >>> >>> Commit

RE: [PATCH v2 02/12] usb: typec: add API to get sink and source config

2018-03-05 Thread Jun Li
> -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年2月26日 21:32 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; li...@roeck-us.net; > a.ha...@samsung.com; mark.rutl...@arm.com; yue...@google.com; > Peter

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Roger Quadros
On 05/03/18 12:41, Baolin Wang wrote: > Hi Roger, > > On 5 March 2018 at 17:45, Roger Quadros wrote: >> Felipe, >> >> On 05/03/18 10:49, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: > Roger Quadros writes: >> In the

Re: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery

2018-03-05 Thread Andrzej Hajda
On 05.03.2018 08:00, Jun Li wrote: > >> -Original Message- >> From: Andrzej Hajda [mailto:a.ha...@samsung.com] >> Sent: 2018年2月27日 16:41 >> To: Jun Li ; gre...@linuxfoundation.org; >> robh...@kernel.org; heikki.kroge...@linux.intel.com; li...@roeck-us.net >> Cc:

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Baolin Wang
On 5 March 2018 at 19:14, Roger Quadros wrote: > On 05/03/18 13:06, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: > Roger Quadros writes: >>> Roger Quadros writes: In the following test we get stuck

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Roger Quadros writes: > On 05/03/18 13:06, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: > Roger Quadros writes: >>> Roger Quadros writes: In the following test we get stuck by sleeping

RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

2018-03-05 Thread Jun Li
> -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月5日 17:54 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; li...@roeck-us.net; > a.ha...@samsung.com; mark.rutl...@arm.com; yue...@google.com; > Peter

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

2018-03-05 Thread Oliver Neukum
On Mon, 2018-03-05 at 08:45 +0100, Marek Szyprowski wrote: > Hi Oliver, > > On 2018-02-27 17:07, Oliver Neukum wrote: > > Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > >> On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > >>> > >>> Note that for this one, it seems we also

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Roger Quadros
Felipe, On 05/03/18 10:49, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: In the following test we get stuck by sleeping forever in _dwc3_set_mode() after which dual-role switching doesn't work. On dra7-evm's

[RFC PATCH] cdc-acm: do not drop data from fast devices

2018-03-05 Thread Romain Izard
There are some devices using their USB CDC-ACM interfaces as a debug port that are able to send data at a very high speed, but with the current driver implementation it is not possible to receive it when using a relatively slow embedded system without dropping an important part of the data. The

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Baolin Wang
Hi Roger, On 5 March 2018 at 17:45, Roger Quadros wrote: > Felipe, > > On 05/03/18 10:49, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: Roger Quadros writes: > In the following test we get stuck by sleeping forever in

RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

2018-03-05 Thread Jun Li
> -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月5日 19:30 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; li...@roeck-us.net; > a.ha...@samsung.com; mark.rutl...@arm.com; yue...@google.com; > Peter

RE: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery

2018-03-05 Thread Jun Li
> -Original Message- > From: Jun Li > Sent: 2018年3月5日 15:52 > To: Rob Herring ; Andrzej Hajda > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; mark.rutl...@arm.com; yue...@google.com; Peter > Chen

Re: [PATH 0/4] usbip: make vhci_hcd.* objects independent of vhci_hcd.0

2018-03-05 Thread Salvador Fandiño
On 02/21/2018 01:35 AM, Shuah Khan wrote: Hi Salvador, On 01/30/2018 01:36 AM, Salvador Fandino wrote: Let me start by explaining the problem that have motivated me to write this patches: I work on the QVD, a virtual desktop platform for Linux. This software runs Linux desktops (i.e. XFCE,

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

2018-03-05 Thread Heikki Krogerus
On Mon, Mar 05, 2018 at 08:53:00AM +, Jun Li wrote: > > On Mon, Feb 26, 2018 at 02:30:53PM +, Jun Li wrote: > > > > > + child = of_get_child_by_name(tcpci->dev->of_node, "connector"); > > > > > + if (!child) { > > > > > + dev_err(tcpci->dev, "failed to get connector

Re: [PATCH v2 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

2018-03-05 Thread Thang Q. Nguyen
On Mon, Jan 29, 2018 at 5:24 PM, Thang Q. Nguyen wrote: > From: Tung Nguyen > > Currently, hcd->shared_hcd always creates and registers to the usb-core. > If, for some reasons, USB3 downstream port is disabled, no roothub port for > USB3.0 is found. This

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> Roger Quadros writes: > Roger Quadros writes: >> In the following test we get stuck by sleeping forever in >> _dwc3_set_mode() >> after which dual-role switching doesn't work. >> >> On

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Roger Quadros
On 05/03/18 13:06, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: Roger Quadros writes: >> Roger Quadros writes: >>> In the following test we get stuck by sleeping forever in >>> _dwc3_set_mode() >>> after which

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Baolin Wang writes: > void dwc3_gadget_exit(struct dwc3 *dwc) > { > + int epnum; > + unsigned long flags; > + > + spin_lock_irqsave(>lock, flags); > + for (epnum = 2; epnum < DWC3_ENDPOINTS_NUM; epnum++) {

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

2018-03-05 Thread Heikki Krogerus
Hi, On Mon, Mar 05, 2018 at 10:35:07AM +, Jun Li wrote: > > So it actually does make sense to define those properties for the > > "connector" node instead of TCPC parent. They are generic "Type-C" > > properties (right?), so we may want to use them with multiport devices as > > well. > > >

Re: WARN_ON(irqs_disabled()) in dma_free_attrs?

2018-03-05 Thread Christoph Hellwig
On Sat, Mar 03, 2018 at 07:19:06PM +0100, Fredrik Noring wrote: > Christoph, Alan, > > > If it is allocating / freeing this memory all the time in the hot path > > it should really use a dma pool (see include/ilinux/dmapool.h). > > The dma coherent APIs aren't really built for being called in the

Re: [PATCH v6] staging: typec: handle vendor defined part and modify drp toggling flow

2018-03-05 Thread 李書帆
Hi, 2018-03-05 22:49 GMT+08:00 Guenter Roeck : > On 03/04/2018 08:16 PM, ShuFan Lee wrote: >> >> From: ShuFan Lee >> >> Handle vendor defined behavior in tcpci_init, tcpci_set_vconn, >> tcpci_start_drp_toggling >> and export tcpci_irq. More operations

Re: [PATCH v6] staging: typec: handle vendor defined part and modify drp toggling flow

2018-03-05 Thread Guenter Roeck
On 03/04/2018 08:16 PM, ShuFan Lee wrote: From: ShuFan Lee Handle vendor defined behavior in tcpci_init, tcpci_set_vconn, tcpci_start_drp_toggling and export tcpci_irq. More operations can be extended in tcpci_data if needed. According to TCPCI specification, 4.4.5.2

Re: Fwd: Re: Bug 198731 "USB devices not seen with newest kernel"

2018-03-05 Thread Mathias Nyman
On 26.02.2018 16:05, Oliver Neukum wrote: Am Dienstag, den 13.02.2018, 13:56 -0800 schrieb The Real Bev: I went back to the distribution kernel for 64-bit 14.2 slackware -- 4.14.18. During boot, dmesg displays the following errors: [   15.850711] xhci_hcd :09:00.0: not ready 4195ms after

Re: [RFC PATCH] cdc-acm: do not drop data from fast devices

2018-03-05 Thread Oliver Neukum
On Mon, 2018-03-05 at 10:55 +0100, Romain Izard wrote: > The TTY buffer is 4096 bytes large, throttling when there are only 128 > free bytes left, and unthrottling when there are only 128 bytes available. > But the TTY buffer is filled from an intermediate flip buffer that > contains up to 64 KiB

[PATCH] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Bin Liu
From: Merlijn Wajer Without pm_runtime_{get,put}_sync calls in place, reading vbus status via /sys causes the following error: Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 pgd = b333e822 [fa0ab060] *pgd=48011452(bad) [] (musb_default_readb) from

[PATCH] musb fixes for v4.16-rc5

2018-03-05 Thread Bin Liu
Hi Greg, Here is only musb patch for v4.16-rc5, which fixes the clk gating problem when read a sysfs entry. Please let me know if any change is needed. Regards, -Bin. --- Merlijn Wajer (1): usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers drivers/usb/musb/musb_core.c

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Bin Liu
On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: > * Merlijn Wajer [180227 22:29]: > > Without pm_runtime_{get,put}_sync calls in place, reading > > vbus status via /sys causes the following error: > > > > Unhandled fault: external abort on non-linefetch

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Ivaylo Dimitrov
Hi, On 5.03.2018 19:38, Bin Liu wrote: On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: * Merlijn Wajer [180227 22:29]: Without pm_runtime_{get,put}_sync calls in place, reading vbus status via /sys causes the following error: Unhandled fault: external

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

2018-03-05 Thread Eric Dumazet
On Mon, 2018-03-05 at 12:46 +0100, Oliver Neukum wrote: > On Mon, 2018-03-05 at 08:45 +0100, Marek Szyprowski wrote: > > Hi Oliver, > > > > On 2018-02-27 17:07, Oliver Neukum wrote: > > > Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > > > > On Tue, 2018-02-27 at 07:09 -0800,

Re: howto debug xhci driver?

2018-03-05 Thread Bin Liu
On Mon, Mar 05, 2018 at 10:16:49AM +0200, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > > I am relatively new to xhci and its driver. I am trying to get a xhci > > driver runtime log to understand how it handles usb transactions, but I > > don't get much information with

Re: usb: musb: "(null)" in sysfs mode file after disabling a gadget (and at other times, system hangs)

2018-03-05 Thread Bin Liu
Merlijn, On Fri, Mar 02, 2018 at 05:54:39PM +0100, Pali Rohár wrote: > On Friday 02 March 2018 17:47:52 Merlijn Wajer wrote: > > >> I would expect it to state "b_idle" instead of "(null)". > > > > > > Actually, I'd like to see (null) whenever a gadget driver is not loaded, > > > which indicates

Re: High CPU load produced by USB (DW2)

2018-03-05 Thread Marek Vasut
On 02/20/2018 06:51 AM, Minas Harutyunyan wrote: [...] Is there a way to reduce that or is that the absolute minimum in HS mode? >>> We already discussed, in this email thread earlier, why SOF interrupts >>> required and unmasked. >>> Only in case when connected device with CTRL+BLK EP's

Re: usb: musb: "(null)" in sysfs mode file after disabling a gadget (and at other times, system hangs)

2018-03-05 Thread Merlijn Wajer
Hi Bin, On 05/03/18 20:28, Bin Liu wrote: > The musb udc driver sets the state to b_idle without checking a > gadget driver, this should be cleaned up. I have add this in my backlog. > But if this issue doesn't bother you much right now, I will make the > action low priority and address it later

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Bin Liu
On Mon, Mar 05, 2018 at 08:35:10PM +0200, Ivaylo Dimitrov wrote: > Hi, > > On 5.03.2018 19:38, Bin Liu wrote: > >On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: > >>* Merlijn Wajer [180227 22:29]: > >>>Without pm_runtime_{get,put}_sync calls in place, reading

[PATCH net] net: usbnet: fix potential deadlock on 32bit hosts

2018-03-05 Thread Eric Dumazet
From: Eric Dumazet Marek reported a LOCKDEP issue occurring on 32bit host, that we tracked down to the fact that usbnet could either run from soft or hard irqs. This patch adds u64_stats_update_begin_irqsave() and u64_stats_update_end_irqrestore() helpers to solve this

Re: [PATCH] usb: host: xhci-rcar: add support for r8a77965

2018-03-05 Thread Rob Herring
On Tue, Feb 27, 2018 at 05:15:20PM +0900, Yoshihiro Shimoda wrote: > This patch adds support for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + > drivers/usb/host/xhci-rcar.c

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

2018-03-05 Thread Rob Herring
On Tue, Feb 27, 2018 at 08:11:29AM +0100, Andrzej Hajda wrote: > These bindings allow to describe most known standard USB connectors > and it should be possible to extend it if necessary. > USB connectors, beside USB can be used to route other protocols, > for example UART, Audio, MHL. In such

Re: [PATCH 1/2] usb: renesas_usbhs: add binding for r8a77965

2018-03-05 Thread Rob Herring
On Tue, Feb 27, 2018 at 05:16:02PM +0900, Yoshihiro Shimoda wrote: > This patch adds binding for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 2/2] usb: gadget: udc: renesas_usb3: add binging for r8a77965

2018-03-05 Thread Rob Herring
On Tue, Feb 27, 2018 at 05:16:03PM +0900, Yoshihiro Shimoda wrote: > This patch adds binding for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > 1 file changed, 1 insertion(+)

[PATCH 1/1] usb: host: xhci: do not return error status for URB

2018-03-05 Thread Peter Chen
Current XHCI implementation does not consider completion interrupt for SETUP packet standalone, so it will show warning message and return error status for URB. In fact, it can support it. In this commit, we change warning message as debug message and set status as zero for URB. Support

Re: [PATH 0/4] usbip: make vhci_hcd.* objects independent of vhci_hcd.0

2018-03-05 Thread Shuah Khan
On 03/05/2018 02:00 AM, Salvador Fandiño wrote: > On 02/21/2018 01:35 AM, Shuah Khan wrote: >> Hi Salvador, >> >> On 01/30/2018 01:36 AM, Salvador Fandino wrote: >>> Let me start by explaining the problem that have motivated me to write >>> this patches: >>> >>> I work on the QVD, a virtual

[PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

2018-03-05 Thread ShuFan Lee
From: ShuFan Lee Handle vendor defined behavior in tcpci_init, tcpci_set_vconn, tcpci_start_drp_toggling and export tcpci_irq. More operations can be extended in tcpci_data if needed. According to TCPCI specification, 4.4.5.2 ROLE_CONTROL, TCPC shall not start DRP

Re: [PATCHv2] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-05 Thread Rob Herring
On Wed, Feb 28, 2018 at 07:50:57PM -0800, Tony Lindgren wrote: > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > It is used on some Motorola Mapphone series of phones and tablets such > as Droid 4. > > The MDM6600 is hardwired to the first OHCI port in the Droid 4 case,

Donation For Charity Work

2018-03-05 Thread Friedrich And Ann Mayrhofer
-- Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Ann Mayrhofer. -- To unsubscribe from this

Re: [PATCH v4 1/2] dt-bindings: usb: ehci: add optional external vbus supply property

2018-03-05 Thread Rob Herring
On Thu, Mar 01, 2018 at 10:51:38AM +0100, Amelie Delaunay wrote: > On some boards, especially when vbus supply requires large current, > and the charge pump on the PHY isn't enough, an external vbus power switch > per port may be used. > Add portN_vbus-supply property to usb-ehci bindings. As the

Re: High CPU load produced by USB (DW2)

2018-03-05 Thread Minas Harutyunyan
Hi, On 3/5/2018 11:14 PM, Marek Vasut wrote: > On 02/20/2018 06:51 AM, Minas Harutyunyan wrote: > [...] > Is there a way to reduce that or is that the absolute minimum in HS mode? > We already discussed, in this email thread earlier, why SOF interrupts required and unmasked.