Re: [PATCH] USB: OHCI: Fix NULL dereference in HCDs using HCD_LOCAL_MEM

On Fri, 9 Mar 2018, Fredrik Noring wrote: > Scatter-gather needs to be disabled when using dma_declare_coherent_memory > and HCD_LOCAL_MEM. Andrea Righi made the equivalent fix for EHCI drivers > in commit 4307a28eb01284 "USB: EHCI: fix NULL pointer dererence in HCDs > that use HCD_LOCAL_MEM". >

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, Roger Quadros writes: >> When we set up the DWC3_DEPCMD_ENDTRANSFER command in >> dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC, >> then there will no endpoint command complete interrupts I think. >> >> cmd |= DWC3_DEPCMD_CMDIOC; >

[PATCH] usb: typec: Separate the definitions for data and power roles

USB Type-C specification v1.2 separated the power and data roles more clearly. Dual-Role-Data term was introduced, and the meaning of DRP was changed from "Dual-Role-Port" to "Dual-Role-Power". In order to allow the port drivers to describe the capabilities of the ports more clearly according to

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

Hi, On 27/02/18 09:11, Andrzej Hajda wrote: > These bindings allow to describe most known standard USB connectors > and it should be possible to extend it if necessary. > USB connectors, beside USB can be used to route other protocols, > for example UART, Audio, MHL. In such case every device

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

On 09/03/18 08:36, Thierry Reding wrote: > On Thu, Mar 08, 2018 at 09:31:07PM +, Jon Hunter wrote: >> >> On 01/03/18 14:18, Mathias Nyman wrote: >>> On 14.02.2018 18:34, Jon Hunter wrote: Add runtime PM support to the Tegra XHCI driver and move the function calls to enable/disable

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

On 09/03/18 09:13, Mathias Nyman wrote: > On 09.03.2018 10:36, Thierry Reding wrote: >> On Thu, Mar 08, 2018 at 09:31:07PM +, Jon Hunter wrote: >>> >>> On 01/03/18 14:18, Mathias Nyman wrote: On 14.02.2018 18:34, Jon Hunter wrote: > Add runtime PM support to the Tegra XHCI driver and

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, Roger Quadros writes: >>> This is what the v3.10 databook says >>> >>> "When issuing an End Transfer command, software must set the CmdIOC >>> bit (field 8) so that an Endpoint Command Complete event is generated >>> after the transfer ends. This is necessary to synchronize

Re: [PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

On Wed, Jul 19, 2017 at 05:59:08PM +0200, Philipp Zabel wrote: > From: Vivek Gautam > > Make use of of_reset_control_array_get_exclusive() to manage > an array of reset controllers available with the device. > > Cc: Jon Hunter > Cc: Thierry

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

Hi, Roger Quadros writes: > Hi, > > On 08/03/18 18:49, Brian Norris wrote: >> Hi, >> >> On Thu, Mar 08, 2018 at 12:43:40PM +0200, Felipe Balbi wrote: >>> William Wu writes: The dwc3_core_init() gets the PHYs and initializes the PHYs with the

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

On 09.03.2018 10:36, Thierry Reding wrote: On Thu, Mar 08, 2018 at 09:31:07PM +, Jon Hunter wrote: On 01/03/18 14:18, Mathias Nyman wrote: On 14.02.2018 18:34, Jon Hunter wrote: Add runtime PM support to the Tegra XHCI driver and move the function calls to enable/disable the clocks,

Re: [PATCH v4 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

Benjamin Herrenschmidt writes: > The Aspeed BMC SoCs support a "virtual hub" function. It provides some > HW support for a top-level USB2 hub behind which sit 5 gadget "ports". > > This driver adds support for the full functionality, emulating the > hub standard

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

Hi Chanwoo, On 08.03.2018 02:52, Chanwoo Choi wrote: > Hi Andrzej, Archit, > > On 2018년 03월 07일 20:13, Andrzej Hajda wrote: >> Hi Chanwoo, Archit, >> >> On 07.03.2018 05:48, Chanwoo Choi wrote: >>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote: Hi Rob and Andrzej, On 2018년 03월 06일

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

Hi! > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > It is used on some Motorola Mapphone series of phones and tablets such > as Droid 4. ... > So it seems that MDM6600 is currently not yet idling even with it's > radio turned off, but that's something that is beyond

Re: [PATCH 11/11] usb: dwc2: Enable LPM

Hi, Grigor Tovmasyan writes: > From: John Youn > > Set 'lpm_capable' flag in the gadget structure so > indicating that LPM is supported. > > Signed-off-by: Sevak Arakelyan > Signed-off-by: Grigor Tovmasyan

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

Hi, Masahiro Yamada writes: > +static void dwc3u_reset_init(struct dwc3u_priv *priv) > +{ > + dwc3u_maskwrite(priv, RESET_CTL, LINK_RESET, 0); > + usleep_range(1000, 2000); > + dwc3u_maskwrite(priv, RESET_CTL, LINK_RESET, LINK_RESET);

Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

Stefan Wahren writes: >> Stefan Wahren hat am 12. Februar 2018 um 21:20 >> geschrieben: >> >> >> We better print an error in case probing of dwc2 fails on >> setting the DMA coherent mask. >> >> Signed-off-by: Stefan Wahren

Re: [PATCH 2/3] usb: xhci: tegra: Add runtime PM support

On Thu, Mar 08, 2018 at 09:31:07PM +, Jon Hunter wrote: > > On 01/03/18 14:18, Mathias Nyman wrote: > > On 14.02.2018 18:34, Jon Hunter wrote: > >> Add runtime PM support to the Tegra XHCI driver and move the function > >> calls to enable/disable the clocks, regulators and PHY into the

RE: [PATCH 4.16 REGRESSION fix] Revert "typec: tcpm: Only request matching pdos"

Hi, > -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Heikki Krogerus > Sent: 2018年3月6日 20:33 > To: Hans de Goede > Cc: Greg Kroah-Hartman ; Guenter Roeck >

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

Hi, On 08/03/18 18:49, Brian Norris wrote: > Hi, > > On Thu, Mar 08, 2018 at 12:43:40PM +0200, Felipe Balbi wrote: >> William Wu writes: >>> The dwc3_core_init() gets the PHYs and initializes the PHYs with >>> the usb_phy_init() and phy_init() functions before

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Grigor Tovmasyan writes: > From: Vardan Mikayelyan > > These are wrapper functions which are calling device or host > enter/exit hibernation functions. > > Signed-off-by: Vardan Mikayelyan > Signed-off-by: John Youn

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

On 05/03/18 13:27, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> void dwc3_gadget_exit(struct dwc3 *dwc) >> { >> + int epnum; >> + unsigned long flags; >> + >> + spin_lock_irqsave(>lock, flags); >> +

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

On 09/03/18 11:23, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > > > When we set up the DWC3_DEPCMD_ENDTRANSFER command in dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC, then there will no endpoint command complete interrupts I

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

On 09/03/18 11:26, Roger Quadros wrote: > On 09/03/18 11:23, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >> >> >> > When we set up the DWC3_DEPCMD_ENDTRANSFER command in > dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC, > then there

Without US_FL_NEEDS_CAP16 read_capacity_10 is forced despite of the device capability and HDD size

Hi all I am discussing about an issue I get with my Orico USBtoSATA 5 bays enclosure The issue is that every 5 minutes the BTRFS perform a revalidate action that will fill the dmesg with this log: [ 98.917660] sd 0:0:0:1: [sdb] Very big device. Trying to use READ CAPACITY(16). [ 99.057592] sd

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, Roger Quadros writes: >>> When we set up the DWC3_DEPCMD_ENDTRANSFER command in >>> dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC, >>> then there will no endpoint command complete interrupts I think. >>> >>> cmd |= DWC3_DEPCMD_CMDIOC; >> >> I remember

Re: [PATCH 3/4] usb: host: xhci-plat: revert "usb: host: xhci-plat: enable clk in resume timing"

On Fri, Mar 09, 2018 at 01:48:37AM +, Yoshihiro Shimoda wrote: > Hi Greg, > > > From: Greg KH, Sent: Friday, March 9, 2018 2:06 AM > > > > On Thu, Mar 08, 2018 at 05:17:16PM +0200, Mathias Nyman wrote: > > > From: Yoshihiro Shimoda > > > > > > This patch

Re: [PATCH 4/4] xhci: Fix front USB ports on ASUS PRIME B350M-A

On Fri, Mar 09, 2018 at 11:29:20AM +0800, Kai Heng Feng wrote: > Hi, > > > On Mar 9, 2018, at 1:06 AM, Greg KH wrote: > > > > On Thu, Mar 08, 2018 at 05:17:17PM +0200, Mathias Nyman wrote: > > > From: Kai-Heng Feng > > > > > > When a

Re: [PATCH] usb: typec: Separate the definitions for data and power roles

On Fri, Mar 09, 2018 at 02:09:18PM +0300, Heikki Krogerus wrote: > USB Type-C specification v1.2 separated the power and data > roles more clearly. Dual-Role-Data term was introduced, and > the meaning of DRP was changed from "Dual-Role-Port" to > "Dual-Role-Power". > > In order to allow the port

Re: [PATCH 11/11] usb: dwc2: Enable LPM

Hi John, Could you please add your Signed-off to this patch? On 3/9/2018 12:06 PM, Felipe Balbi wrote: > Hi, > > Grigor Tovmasyan writes: >> From: John Youn >> >> Set 'lpm_capable' flag in the gadget structure so >> indicating that LPM is

Re: [PATCH] usb: musb: Fix external abort in musb_remove

On Thu, Mar 08, 2018 at 11:17:48PM +0100, Merlijn Wajer wrote: > Hi, > > On 08/03/18 22:15, Bin Liu wrote: > > > please add patch version numbers in the subject when necessary. This > > helps cross-referencing. > > Will do. I naively assumed that the first patch would implicitly be > number 1.

Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430

Hi, On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote: > This fixes an oops on unbind / module unload (on the musb omap2430 > platform). > > musb_remove function now calls musb_platform_exit before disabling > runtime pm. > > Signed-off-by: Merlijn Wajer

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Hi Balbi, Seems like your testing/next was changed. I will rebese and send them again. On 3/9/2018 1:07 PM, Felipe Balbi wrote: > Grigor Tovmasyan writes: > >> From: Vardan Mikayelyan >> >> These are wrapper functions which are calling

Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()

Hi Balbi, This patch didn't apply, because you missing 01/14 and 02/14 commits from this patch seria. Please apply following patches and try again. [PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down [PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params On

[PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

In the following test we get stuck by sleeping forever in _dwc3_set_mode() after which dual-role switching doesn't work. On dra7-evm's dual-role port, - Load g_zero gadget driver and enumerate to host - suspend to mem - disconnect USB cable to host and connect otg cable with Pen drive in it. -

Re: [balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

Hi Balbi, I saw you applied "e9c07984979d usb: dwc2: Force mode optimizations" patch to your testing/next. Please re-apply this commit. On 2/15/2018 6:37 PM, Grigor Tovmasyan wrote: > Hi Balbi > > On 2/15/2018 17:34, Felipe Balbi wrote: >> Hi, >> >> kbuild test robot

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

* Pavel Machek [180309 09:45]: > Hi! > > > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > > It is used on some Motorola Mapphone series of phones and tablets such > > as Droid 4. > ... > > So it seems that MDM6600 is currently not yet idling even with

[RFC PATCH v2 3/3] usb: typec: tcpm: Support for Alternate Modes

This adds more complete handling of VDMs and registration of partner alternate modes, and introduces callbacks for alternate mode operations. Only DFP role is supported for now. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/tcpm.c | 133

[RFC PATCH v2 2/3] usb: typec: Bus type for alternate modes

Introducing a simple bus for the alternate modes. Bus allows binding drivers to the discovered alternate modes the partners support. Signed-off-by: Heikki Krogerus --- Documentation/ABI/obsolete/sysfs-class-typec | 48 +++

[RFC PATCH v2 1/3] usb: typec: Register a device for every mode

Before a device was created for every discovered SVID, but this will create a device for every discovered mode of every SVID. The idea is to make it easier to create mode specific drivers once a bus for the alternate mode is added. Signed-off-by: Heikki Krogerus

[RFC PATCH v2 0/3] usb: typec: Support for Alternate Modes

Hi guys, This is second version of my proposal for more complete USB Type-C Alternate Mode support. The original proposal can be read from here: https://www.spinics.net/lists/linux-usb/msg161098.html These patches now depend on series from Hans where he is introducing mux handling support for

Re: [PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

On Tue, Mar 06, 2018 at 09:50:32AM +0800, ShuFan Lee wrote: > From: ShuFan Lee > > Handle vendor defined behavior in tcpci_init, tcpci_set_vconn, > tcpci_start_drp_toggling > and export tcpci_irq. More operations can be extended in tcpci_data if needed. > According to

Re: [PATCH] usb: typec: Separate the definitions for data and power roles

On Fri, Mar 09, 2018 at 02:09:18PM +0300, Heikki Krogerus wrote: > USB Type-C specification v1.2 separated the power and data > roles more clearly. Dual-Role-Data term was introduced, and > the meaning of DRP was changed from "Dual-Role-Port" to > "Dual-Role-Power". > > In order to allow the port

Re: [PATCH v6 01/12] drivers: base: Unified device connection lookup

On Fri, Mar 02, 2018 at 11:20:46AM +0100, Hans de Goede wrote: > From: Heikki Krogerus > > Several frameworks - clk, gpio, phy, pmw, etc. - maintain > lookup tables for describing connections and provide custom > API for handling them. This introduces a single

Re: [PATCH v2] usb: core: introduce per-port over-current counters

On Tue, Feb 20, 2018 at 12:50:33PM +0100, Richard Leitner wrote: > From: Richard Leitner > > For some userspace applications information on the number of > over-current conditions at specific USB hub ports is relevant. > > In our case we have a series of USB

Re: [PATCH v1 11/14] USB: host: sl811: Re-use DEFINE_SHOW_ATTRIBUTE() macro

On Wed, Feb 14, 2018 at 06:08:27PM +0200, Andy Shevchenko wrote: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Signed-off-by: Andy Shevchenko > --- > drivers/usb/host/sl811-hcd.c | 17

[PATCH] USB: OHCI: Fix NULL dereference in HCDs using HCD_LOCAL_MEM

Scatter-gather needs to be disabled when using dma_declare_coherent_memory and HCD_LOCAL_MEM. Andrea Righi made the equivalent fix for EHCI drivers in commit 4307a28eb01284 "USB: EHCI: fix NULL pointer dererence in HCDs that use HCD_LOCAL_MEM". The following NULL pointer WARN_ON_ONCE triggered

Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS

On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. > > The source PPS supply is represented using the Power Supply framework to > provide > access and control APIs for dealing

Re: Without US_FL_NEEDS_CAP16 read_capacity_10 is forced despite of the device capability and HDD size

On Fri, 9 Mar 2018, Menion wrote: > Hi all > I am discussing about an issue I get with my Orico USBtoSATA 5 bays enclosure > The issue is that every 5 minutes the BTRFS perform a revalidate > action that will fill the dmesg with this log: > > [ 98.917660] sd 0:0:0:1: [sdb] Very big device.

Re: Without US_FL_NEEDS_CAP16 read_capacity_10 is forced despite of the device capability and HDD size

Yeah I am in touch with scsi mantainers I have already suggested to lower it to KERN_DEBUG, not really pushed it, but they have said that from their perspective, this is a sub-optimal read_capacity path taken, that shall be logged Also, since this flag is named "try_rc_10_first" I have also