From: Fabio Estevam
Include , so that the following errors are fixed:
drivers/usb/host/imx21-hcd.c:1929:20: error: expected declaration specifiers or
'...' before string constant
drivers/usb/host/imx21-hcd.c:1930:15: error: expected declaration specifiers or
'...' be
Hi Greg,
On Mon, Dec 10, 2012 at 4:16 PM, Greg KH wrote:
> What tree needs this fixed, 3.7-rc8? Or is this showing up in
> linux-next and can wait for 3.8-rc1?
Just tried it on top of tree linus' tree and the problem is also there.
Thanks,
Fabio Estevam
--
To unsubscribe fro
Hi Greg,
On Tue, Dec 18, 2012 at 12:43 AM, Greg KH wrote:
> On Tue, Dec 18, 2012 at 12:01:35AM -0200, Fabio Estevam wrote:
>> Hi,
>>
>> Booting a 3.7 kernel on a mx6qsabrelite board via NFS and using an
>> asix USB/Ethernet adapter and then I try to transfer a 10MB fil
efine USBMODE_SDIS(1<<3) /* Stream disable */
, which is at a different bit position from the i.MX6 Reference Manual:
4 SDIS Stream Disable Mode. (0 - Inactive [default]; 1 - Active)
Also interested to know more details at to why disabling stream mode
make thi
On Thu, Dec 20, 2012 at 8:20 AM, Fabio Estevam wrote:
> Hi Peter,
>
> On Thu, Dec 20, 2012 at 2:39 AM, Peter Chen wrote:
>
>> Please to see if the Stream mode disable (bit4, usbmode) is set or not?
>> If it is not, please try below patch
>>
>> diff --git a/d
On Thu, Dec 20, 2012 at 8:20 AM, Fabio Estevam wrote:
> Excellent! Your suggestion made scp work with mx6 on 3.7.
>
> I assume that this "fix" or workaround would need a better place, right?
>
> Should this fix go into the chipidea host driver instead?
Also, w
On Thu, Dec 20, 2012 at 8:45 AM, Fabio Estevam wrote:
> Would this be the correct fix?
>
> --- a/include/linux/usb/chipidea.h
> +++ b/include/linux/usb/chipidea.h
> @@ -18,7 +18,7 @@ struct ci13xxx_platform_data {
> #define CI13XXX_REGS_SHARED
Hi Peter,
On Fri, Dec 21, 2012 at 12:22 AM, Peter Chen wrote:
> Current chipidea driver only considers disable stream mode at device
> mode, in fact, it may be related to below chipidea bug, and needs
> to consider all usb modes.
>
> STAR 9000378958
> Title: Non-Double Word Aligned Buffer Addres
. hw_write() is now used by
ci_role_start(), so I re-ordered so that hw_write comes first in the
code and compiler does not complain.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kerne
From: Fabio Estevam
When running a scp transfer using a USB/Ethernet adapter the following crash
happens:
$ scp test.tar.gz fabio@192.168.1.100:/home/fabio
fabio@192.168.1.100's password:
test.tar.gz 0%0 0.0KB/s --:-- ETA
[ cut
From: Fabio Estevam
When running a scp transfer using a USB/Ethernet adapter the following crash
happens:
$ scp test.tar.gz fabio@192.168.1.100:/home/fabio
fabio@192.168.1.100's password:
test.tar.gz 0%0 0.0KB/s --:-- ETA
[ cut
Hi Peter,
On Sat, Dec 22, 2012 at 9:24 AM, Fabio Estevam wrote:
> From: Fabio Estevam
>
> When running a scp transfer using a USB/Ethernet adapter the following crash
> happens:
>
> $ scp test.tar.gz fabio@192.168.1.100:/home/fabio
> fabio@192.168.1.100'
Hi Alexander,
On Wed, Nov 28, 2012 at 12:52 AM, Peter Chen wrote:
> I have tested it at i.mx6q sabrelite board, it works good.
>
> I have pushed your commit to my git, please cc me
> your coming chipidea patches, thanks.
>
> Alex, please add:
>
> Reviewed-by: Peter Chen
> Tested-by: Peter Chen
fore string constant
>
> by including
>
> Signed-off-by: Felipe Balbi
I have already sent this fix:
http://www.spinics.net/lists/linux-usb/msg75850.html
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a m
On Thu, Jan 17, 2013 at 9:25 AM, Lothar Waßmann
wrote:
> The equivalent of !cpu_is_mx51() would be
> strcmp(pdev->id_entry->name, "imx-udc-mx51") (without the '!') meaning
> id_entry->name is different from "imx-udc-mx51".
Yes, agree.
strcmp(pdev->id_entry->name, "imx-udc-mx51") is also better
From: Fabio Estevam
According to Documentation/CodingStyle:
"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
"
, so do as suggested to improve readability.
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/udc.c | 2
From: Fabio Estevam
No need to split the dma_pool_zalloc() line into two as it can
perfectly fit into a single line.
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/udc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb
From: Fabio Estevam
We can make the code simpler by using dma_pool_zalloc() instead
of calling dma_pool_zalloc() and then a memset().
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/udc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/chipidea
From: Fabio Estevam
According to Documentation/CodingStyle:
"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
"
, so do as suggested to improve readability.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
d
From: Fabio Estevam
No need to split the dma_pool_zalloc() line in two lines as it can
perfectly fit into a single one.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Add a missing 'line' in the commit log.
drivers/usb/chipidea/udc.c | 3 +--
1 file changed, 1 insertion(+), 2
From: Fabio Estevam
We can make the code simpler by using dma_pool_zalloc() instead
of calling dma_pool_alloc() followed by memset().
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Fix a typo in commit log (Sergei)
drivers/usb/chipidea/udc.c | 6 ++
1 file changed, 2 insertions
Hi Sergei,
On Fri, Sep 9, 2016 at 9:47 AM, Sergei Shtylyov
wrote:
>> We can make the code simpler by using dma_pool_zalloc() instead
>> of calling dma_pool_zalloc() and then a memset().
>
>
>dma_pool_alloc().
Thanks, fixed in v2.
--
To unsubscribe from this list: send the line "unsubscribe
On Mon, Dec 7, 2015 at 11:37 PM, Peter Chen wrote:
> Add dt-binding documentation for generic onboard USB HUB.
>
> Signed-off-by: Peter Chen
> ---
> .../bindings/usb/generic-onboard-hub.txt | 28
> ++
> 1 file changed, 28 insertions(+)
> create mode 100644
> Docu
Hi Peter,
On Mon, Dec 14, 2015 at 5:26 AM, Peter Chen wrote:
> Hi all,
>
> There is a known issue that the USB code can't handle USB HUB's
> external pins well, in that case, it may cause some onboard
> USB HUBs can't work since their PHY's clock or reset pin needs to
> operate.
>
> The user rep
On Tue, Dec 15, 2015 at 4:28 AM, Peter Chen wrote:
> Thanks, Fabio.
>
> I am afraid I forget to set gpio as output, would you please apply
> below patch against my original ones:
Same error happens with these changes applied.
Here are more details: if I run a pure 4.3.2 then I do see the USB
st
Hi Maciej,
On Tue, Dec 15, 2015 at 6:19 PM, Maciej S. Szmigiero
wrote:
> Can we now use this change for repairing the USB support on UDOO board?
>
> This seems to work fine if not 100% correct:
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -122,7 +1
Hi Peter,
On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen wrote:
> Thanks, Fabio, but I am curious how things like that? The USBOH3 clock
> is not opened, the usb driver will hang when it tries to access
> registers. If this clock is always on, then, why the system will
> hang later?
I found the is
usb1-port1: cannot reset (err = -32)
usb usb1-port1: cannot reset (err = -32)
usb usb1-port1: Cannot enable. Maybe the USB cable is bad?
Passing CI_HDRC_SUPPORTS_RUNTIME_PM flag fixes the problem.
Tested on a mx28evk and also on a mx28 custom board.
Signed-off-by: Fabio Estevam
---
drivers/usb
6aa33221 ("usb: phy: mxs: Add VF610 USB PHY support")
shows the same error messages in the commit log, but trying the same
approach of adding the MXS_PHY_NEED_IP_FIX flag does not help on mx28.
Any suggestions?
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send the line "un
Hi Peter,
On Wed, Dec 23, 2015 at 7:49 AM, Peter Chen wrote:
> Fabio, there is a bug for imx28 usb low power mode, and we have no
> good way to implement
> workaround using current USB PHY framework, would you please test by
> add "usbcore.autosuspend = -1"
> at bootargs (no CI_HDRC_SUPPORTS_RUN
hub.
> Is i.MX23 affected, too?
As far as I know mx23 olinuxino maxi has a USB hub and the issue is
not present there.
Maybe Peter can confirm.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger
From: Fabio Estevam
MXS_PHY_ABNORMAL_IN_SUSPEND and MXS_PHY_SENDING_SOF_TOO_FAST flags
are never used, so let's get rid of them.
Reported-by: Stefan Wahren
Signed-off-by: Fabio Estevam
---
drivers/usb/phy/phy-mxs-usb.c | 31 +++
1 file changed, 3 inser
On Tue, Dec 29, 2015 at 6:15 AM, Peter Chen wrote:
> I prefer to keep it, and it let us know the existing issues although
> we have not implemented workaround for them. In future, we may have
> solutions for how to implement them.
Ok, what about adding the recommendation below?
--- a/drivers/us
n't know that the issue comes really from the mx28 instead of the
> hub.
It seems there are other users that reported this same issue at
community.freescale.com.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
From: Fabio Estevam
On a mx28 board with a USB hub the following error is observed:
hub 1-1:1.0: USB hub found
hub 1-1:1.0: 2 ports detected
usb 1-1: USB disconnect, device number 2
usb usb1-port1: cannot reset (err = -32)
usb usb1-port1: cannot reset (err = -32)
usb usb1-port1: cannot reset
ces/usb1/power/wakeup
$ echo enabled > /sys/bus/usb/devices/1-1/power/wakeup
- Put the system in suspend
$ echo mem > /sys/power/state
- Clicking in the mouse button does not wakeup the system.
Any ideas?
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe
On Wed, Feb 3, 2016 at 1:21 PM, Fabio Estevam wrote:
> Hi Peter,
>
> I am running imx6sl-evk with linux-next 20160203 and I am trying to
> make it wake up via a USB mouse click.
>
> These are the steps I am doing:
>
> - Insert the USB mouse in the USB host port:
>
&
On Wed, Feb 3, 2016 at 1:21 PM, Fabio Estevam wrote:
> Hi Peter,
>
> I am running imx6sl-evk with linux-next 20160203 and I am trying to
> make it wake up via a USB mouse click.
>
> These are the steps I am doing:
>
> - Insert the USB mouse in the USB host port:
>
&
00.usb/power/wakeup
/sys/devices/soc0/soc/210.aips-bus/2184200.usb/ci_hdrc.1/usb1/1-1/power/wakeup
/sys/devices/soc0/soc/210.aips-bus/2184200.usb/ci_hdrc.1/usb1/power/wakeup
/sys/devices/soc0/soc/210.aips-bus/2184200.usb/ci_hdrc.1/power/wakeup
Regards,
Fabio Estevam
--
To unsubscribe fro
On Wed, Feb 3, 2016 at 2:58 PM, Alan Stern wrote:
> On Wed, 3 Feb 2016, Fabio Estevam wrote:
>
>> Hi Alan,
>>
>> On Wed, Feb 3, 2016 at 2:29 PM, Alan Stern wrote:
>>
>> > It seems likely that this script does exactly the same thing that you
>> > di
From: Fabio Estevam
On a mx28 board with a USB hub the following error is observed:
hub 1-1:1.0: USB hub found
hub 1-1:1.0: 2 ports detected
usb 1-1: USB disconnect, device number 2
usb usb1-port1: cannot reset (err = -32)
usb usb1-port1: cannot reset (err = -32)
usb usb1-port1: cannot reset
Hi Felipe,
On Fri, Feb 19, 2016 at 10:05 AM, Felipe Balbi wrote:
> how about detecting that you're running on mx23/mx28 and returning
> -EBUSY on your runtime_idle implementation ? You already have the basics
> done for it. Care to test below and tell me whether it helps ?
Thanks for the sugges
On Fri, Feb 19, 2016 at 11:33 AM, Felipe Balbi wrote:
> alright, in which sense doesn't it help ? Which platform did you use ?
USB devices are not recognized with your patch applied on a mx28 board
with an on-board USB hub and if I remove 'usbcore.autosuspend=-1' from
the kernel command line.
>
On Fri, Feb 19, 2016 at 12:13 PM, Felipe Balbi wrote:
> h, okay. So you have another problem, actually. Seems like ci_hdrc
> just shouldn't call your phy->suspend(), or your phy->suspend()
> shouldn't do anything. How about below?
>
> @@ -370,6 +370,9 @@ static int mxs_phy_suspend(struct usb_
Hi Peter,
On Sun, Feb 21, 2016 at 10:59 PM, Peter Chen wrote:
> Fabio, Felipe is correct. The mx23 and mx28 should NOT call mxs phy's
> suspend API
> since the runtime suspend is not enabled for mx23 and mx28 at chipidea driver.
> Would you please check if CI_HDRC_SUPPORTS_RUNTIME_PM is set wron
On Tue, Feb 23, 2016 at 4:47 PM, Fabio Estevam wrote:
> Hi Peter,
>
> On Sun, Feb 21, 2016 at 10:59 PM, Peter Chen wrote:
>
>> Fabio, Felipe is correct. The mx23 and mx28 should NOT call mxs phy's
>> suspend API
>> since the runtime suspend is not enabled for m
On Tue, Feb 23, 2016 at 10:20 PM, Peter Chen wrote:
> Oh, you said it is called before.
>
> http://www.spinics.net/lists/linux-usb/msg136714.html
Yes, I have enabled runtime pm previously. Sorry for the confusion.
> If you make sure the neither .runtime_suspend at chipidea driver
> nor mxs_phy_
On Tue, Feb 23, 2016 at 11:44 PM, Peter Chen wrote:
> Just plug in an external USB HUB at i.mx28 evk host port without pass
> ''usbcore.autosuspend=-1' at bootargs to see if it works.
Well, the board I have is based on mx28 and has a USB hub onboard. It
does not work without ''usbcore.autosuspen
Hi Felipe,
On Wed, Feb 24, 2016 at 7:47 AM, Felipe Balbi wrote:
> Then what DOES get called ? If we don't reach runtime_pm of the PHY, we
> must reach runtime_pm of chipidea. In that case, detect _there_ if
> you're running on one of the known broken ones and return -EBUSY or
> something like th
On Wed, Feb 24, 2016 at 8:32 AM, Felipe Balbi wrote:
> Then that's the problem. You should _always_ implement your runtime_pm
> callbacks otherwise driver model will assume you don't need to do
> ANYTHING for runtime pm and runtime suspend you unconditionally.
>
> As a test, try setting the flag
On Wed, Feb 24, 2016 at 8:48 AM, Fabio Estevam wrote:
> and this is the result:
I missed to post the first print. Here is the complete log:
[2.375588] usbcore: registered new interface driver usb-storage
[2.405944] ** Calling ci_hdrc_imx_runtime_suspend
[2.412
On Wed, Feb 24, 2016 at 10:29 AM, Felipe Balbi wrote:
>> [2.814449] usb 1-1: new high-speed USB device number 2 using ci_hdrc
>> [2.857129] fec 800f.ethernet eth0: Freescale FEC PHY driver
>> [SMSC LAN8710/LAN8720] (mii_bus:phy_addr=800f.etherne:00, irq)
>> [2.993879] hub 1-1:
On Wed, Feb 24, 2016 at 10:20 PM, Peter Chen wrote:
> Would you get any chances to test i.mx28 evk with an external HUB?
> I just would like to know it is not a HUB issue which can't be
> suspended.
Just connected an external USB hub on a mx28evk and did not see any issue.
--
To unsubscribe from
#x27;usbcore.autosuspend=-1' in the
kernel command line?
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 1, 2016 at 11:55 AM, Joshua Clayton
wrote:
> Thanks a million, Fabio!
>
> 'usbcore.autosuspend=-1' quiets the errors.
>
> ~joshua
>
> P.S. I guess this technically is a bug in chipidea usb.
> I'll give it a quick once over, though I am not very familiar
> with USB core or the CI drive
From: Fabio Estevam
clk_prepare_enable() may fail, so we should better check its return
value and propagate it in the case of failure.
Signed-off-by: Fabio Estevam
---
drivers/usb/phy/phy-generic.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy
On Wed, Aug 31, 2016 at 1:28 PM, Sudip Mukherjee
wrote:
> Use proper error code instead of using -1 on failure to allocate
> memory. We may use the error code later in the caller.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/hid/usbhid/usbkbd.c | 10 +-
> 1 file changed, 5 insertio
o now they had
> to specify these two properties in the machine.dts which still takes
> precedence by just overwriting the defaults added here.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb"
Hi Martin,
On Tue, Feb 21, 2017 at 1:06 PM, Martin Fuzzey wrote:
> Hi,
>
> I ran into a problem of "choppy" audio when using a USB codec on a i.MX53
> (with the chipidea driver)
> The problem occurs on 4.4.47 but not on an old 3.19
> It also does not occur on the latest 4.10.
>
> The codec is :
On Sun, Apr 2, 2017 at 3:00 PM, Leif Neland wrote:
> There is a patch
>
> https://github.com/karlp/ch341-linux/blob/master/0001-usb-serial-ch341-Add-parity-support.patch
>
> which enables parity selection for the ch341 USB-RS485 adapter.
>
> From: Karl Palsson
> Date: Tue, 18 Mar 2014 23:33:27 +0
From: Fabio Estevam
Remove the following sparse warning:
drivers/usb/chipidea/ci13xxx_imx.h:22:25: error: dubious one-bit signed bitfield
drivers/usb/chipidea/ci13xxx_imx.h:22:25: error: dubious one-bit signed bitfield
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/ci13xxx_imx.h
From: Fabio Estevam
Staticize usbmisc_imx6q_drv_init/exit() to fix the following sparse warnings:
drivers/usb/chipidea/usbmisc_imx6q.c:147:12: warning: symbol
'usbmisc_imx6q_drv_init' was not declared. Should it be static?
drivers/usb/chipidea/usbmisc_imx6q.c:153:13: warni
From: Fabio Estevam
Since commit c0304996b (USB: ehci-mxc: remove Efika MX-specific CHRGVBUS hack)
there is no need to include , so remove it.
Signed-off-by: Fabio Estevam
---
drivers/usb/host/ehci-mxc.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/host/ehci-mxc.c b
From: Fabio Estevam
Rather than reporting that the controller is about to be initialized, it is more
useful to indicate a succesful probe instead.
Signed-off-by: Fabio Estevam
---
drivers/usb/host/ehci-mxc.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb
From: Fabio Estevam
Since commit c0304996b (USB: ehci-mxc: remove Efika MX-specific CHRGVBUS hack)
there is no need to include , so remove it.
Signed-off-by: Fabio Estevam
Acked-by: Alan Stern
---
Changes since v1:
- Added Alan's ack
drivers/usb/host/ehci-mxc.c |4
1 file ch
From: Fabio Estevam
It is not very useful to indicate the the driver is about to be probed.
Quoting Alan Stern [1]:
"Plenty of drivers don't include any message like this at all. You
might as well get rid of it entirely."
Remove such dev_info().
[1] http://marc.info
re any pending patch to fix it.
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 27, 2013 at 11:53 AM, Fabio Estevam wrote:
> Hi,
>
> I noticed that USB host is no longer functional on mx28evk running 3.8
> kernel. It worked well until 3.7.9:
Ok, I managed to get USB host working now.
commit 09f6ffde2e (USB: EHCI: fix build error by making ChipIdea h
Hi Steffen,
On Fri, Mar 1, 2013 at 12:39 PM, Steffen Trumtrar
wrote:
> This series for imx28:
>
> Tested-by: Steffen Trumtrar
May I see your imx28-evk.dts with USB udc support, please?
Thanks,
Fabio Estevan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
th
From: Fabio Estevam
Use 'unsigned int' for indexes, in order to fix the following build warnings
with W=1 option:
drivers/usb/core/usb.c: In function 'usb_find_alt_setting':
drivers/usb/core/usb.c:89:16: warning: comparison between signed and unsigned
integer express
From: Fabio Estevam
Building a kernel for imx_v4_v5_defconfig with CONFIG_USB_ULPI disabled, results
in the following error:
arch/arm/mach-imx/built-in.o: In function 'pca100_init':
platform-mx2-emma.c:(.init.text+0x6788): undefined reference to
'otg_ulpi_create'
Hi Igor,
On Wed, Mar 20, 2013 at 11:14 AM, Igor Grinberg wrote:
> On 03/20/13 15:35, Fabio Estevam wrote:
>> From: Fabio Estevam
>>
>> Building a kernel for imx_v4_v5_defconfig with CONFIG_USB_ULPI disabled,
>> results
>> in the following error:
>>
>&
On Mon, Jun 25, 2012 at 11:37 PM, Shawn Guo wrote:
> On Mon, Jun 25, 2012 at 01:18:22PM -0300, Fabio Estevam wrote:
>> Any suggestions as to how to make the driver work on mx23?
>>
> I won't be able to test it on my imx23-evk board, because the board
> design is somehow
related to this hack in FSL kernel?
http://opensource.freescale.com/git?p=imx/linux-2.6-imx.git;a=commitdiff;h=c44dc00d2aecfcbf30336180f5ecd6a3a633545d
What would be the proper way to handle HOSTDISCONDETECT so that it can
work for mx23 as well?
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, including mx23, and would like to get some feedback
from the FSL guys in Cc.
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e reset and speed negotiation period.
3. Do not set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during host suspend/resume sequence."
and the same is not present on mx28 reference manual.
How can we make sure we are not violating the point 2 above?
Thanks,
Fabio Estevam
--
To unsubscribe from this lis
On 8/14/12, Chen Peter-B29397 wrote:
> HW_USBPHY_CTRL.ENHOSTDISCONDETECT should be set after bus reset is
> finished.
I agree. How do we guarantee that ENHOSTDISCONDETECT is set after bus reset?
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe li
From: Fabio Estevam
Differently from mx28 and mx6q, the mx23 SoC has the following description
about ENHOSTDISCONDETECT bit in its Reference Manual:
"Due to a on chip issue (Errata #2791), software must pay attention to when
to assert the ENHOSTDISCONDETECT bit in HW_USBPHY_CTRL regist
ork on your first suggestion was that you
only commented out ENHOSTDISCONDETECT from mxs_phy_on_connect and
still kept it inside mxs_phy_on_disconnect.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...
On Tue, Aug 21, 2012 at 1:04 AM, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Differently from mx28 and mx6q, the mx23 SoC has the following description
> about ENHOSTDISCONDETECT bit in its Reference Manual:
>
> "Due to a on chip issue (Errata #2791), software must pay
connection
processing from completing and not setting it prevents disconnect from being
detected. No delay is needed for clearing of ENHOSTDISCONDETECT.
Successfully tested on mx23-olinuxino (micro, mini and maxi variants) and
mx28evk.
Signed-off-by: Mike Thompson
Signed-off-by: Fabio Estevam
-off-by: Fabio Estevam
---
drivers/usb/otg/mxs-phy.c | 57 -
1 file changed, 51 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c
index 8188380..93a48ce 100644
--- a/drivers/usb/otg/mxs-phy.c
+++ b/drivers
connection
processing from completing and not setting it prevents disconnect from being
detected. No delay is needed for clearing of ENHOSTDISCONDETECT.
Successfully tested on mx23-olinuxino (micro, mini and maxi variants) and
mx28evk.
Signed-off-by: Mike Thompson
Signed-off-by: Fabio Estevam
tdiscondetect_work,
>> + mxs_phy_enhostdiscondetect_delay);
>> + schedule_delayed_work(&mxs_phy->enhostdiscondetect_work,
>> + msecs_to_jiffies(MXY_PHY_ENHOSTDISCONDETECT_DELAY));
>
> Isn't this mx23 specific?
Checked with Pet
connection
processing from completing and not setting it prevents disconnect from being
detected. No delay is needed for clearing of ENHOSTDISCONDETECT.
Successfully tested on mx23-olinuxino (micro, mini and maxi variants) and
mx28evk.
Signed-off-by: Mike Thompson
Signed-off-by: Fabio Estevam
Hi Felipe,
On Thu, Sep 6, 2012 at 11:30 AM, Felipe Balbi wrote:
> I need a final version for this series or it won't make it into v3.7
I sent a v2 for this last week:
http://www.spinics.net/lists/linux-usb/msg69955.html
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send
Hi Felipe,
On Thu, Aug 30, 2012 at 6:26 PM, Fabio Estevam wrote:
> From: Mike Thompson
>
> Currently mx23 fails to enumerate a USB device:
>
> [ 1.30] hub 1-0:1.0: unable to enumerate USB device on port 1
> [ 1.52] hub 1-0:1.0: unable to enumerate USB device on port 1
reported)
- Insert the USB thumb again (connection is not detected)
Fix this problem by accessing the usb_phy structure using the private data
instead of accessing a local structure.
Tested on a mx28evk board.
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/ci13xxx_imx.c | 9 -
1 file
On Mon, Jun 24, 2013 at 10:51 AM, Marek Vasut wrote:
> Fabio, can you possibly test on MX23EVK please?
I never used USB gadget with chipidea driver.
Could you please explain what are the changes I need to do in the dts
file (I want to try on mx28evk first) and defconfig in order to be
able to t
On Tue, Jun 25, 2013 at 11:23 AM, Fabio Estevam wrote:
> On Mon, Jun 24, 2013 at 10:51 AM, Marek Vasut wrote:
>
>> Fabio, can you possibly test on MX23EVK please?
>
> I never used USB gadget with chipidea driver.
>
> Could you please explain what are the changes I need to
truncated
to unsigned type [-Woverflow]
drivers/usb/chipidea/core.c:243:3: warning: large integer implicitly truncated
to unsigned type [-Woverflow]
drivers/usb/chipidea/core.c:246:3: warning: large integer implicitly truncated
to unsigned type [-Woverflow]
Reported-by: Felipe Balbi
Signed-off
On Fri, Jun 28, 2013 at 10:04 AM, Chen Peter-B29397
wrote:
>
>
>> >
>> > Just measure the voltage of your otg vbus pin.
>>
>> Ok, I see it's 2.25 volts after I disconnect the microB-A thing . I
>> should see
>> 0.8V constantly with nothing connected on the port?
>>
>
> You should see the voltage o
From: Fabio Estevam
stmp_reset_block() may fail, so let's check its return value and propagate it in
the case of error.
Signed-off-by: Fabio Estevam
---
drivers/usb/phy/phy-mxs-usb.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/phy/ph
Hi Julius,
On Wed, Jul 10, 2013 at 2:42 PM, Julius Werner wrote:
> Hi Felipe,
>
> This is intended to pull down a reset signal line, not to switch power
> to the device. I could implement that with the regulator framework
> too, but I think that would just be confusing and harder to understand
>
Hi Alexander,
On Thu, Jul 11, 2013 at 3:27 AM, Peter Chen wrote:
> This patchset adds tested otg id switch function and
> vbus connect and disconnect detection for chipidea driver.
> And fix kinds of bugs found at chipidea drivers after enabling
> id and vbus detection.
>
> This patch is fully te
On Mon, Jul 22, 2013 at 8:49 PM, Tomasz Figa wrote:
> dev_dbg(&dev->dev, "s3c2410_start_hc:\n");
>
> - clk_enable(usb_clk);
> + clk_prepare_enable(usb_clk);
clk_prepare_enable may fail, so you would better check its return value.
--
To unsubscribe from this list: send the li
application uses
Please try it on a 3.10.2 kernel and let us know the result.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ll you need to do is to add the USB nodes in
device tree. You can refer to this commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/imx53-qsb.dts?id=502d26a26ad745b7b65f7f0e4518eab7aa79a3ee
Regards,
Fabio Estevam
--
To unsubscribe from this list: send th
From: Fabio Estevam
'res' is not used anywhere, so let's get rid of it.
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/ci_hdrc_imx.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 1
port on mx53qsb board is functional.
Signed-off-by: Fabio Estevam
---
drivers/usb/chipidea/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index a5df24c..a5b3774 100644
--- a/drivers/usb/chipidea/core.c
1 - 100 of 367 matches
Mail list logo
