RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-22 Thread Jun Li
ck-us.net; a.ha...@samsung.com; > cw00.c...@samsung.com; shufan_...@richtek.com; Peter Chen > <peter.c...@nxp.com>; gso...@gmail.com; devicet...@vger.kernel.org; > linux-usb@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v5 05/14] usb: typec: add

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-21 Thread Heikki Krogerus
l.org; > > linux-usb@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > > Subject: Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port > > power > > and data config > > > > On Thu, May 17, 2018 at 02:05:41PM +, Jun Li wrote: > > &g

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
a.ha...@samsung.com; > cw00.c...@samsung.com; shufan_...@richtek.com; Peter Chen > <peter.c...@nxp.com>; gso...@gmail.com; devicet...@vger.kernel.org; > linux-usb@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v5 05/14] usb: typec: add API to get t

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Heikki Krogerus
On Thu, May 17, 2018 at 02:05:41PM +, Jun Li wrote: > Hi Heikki, > > > > I reread this patch and tried to see it more in the context of the > > > other patches and the existing code. The naming of the existing string > > > tables doesn't help in getting this right, however I have a proposal:

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi Heikki, > > I reread this patch and tried to see it more in the context of the > > other patches and the existing code. The naming of the existing string > > tables doesn't help in getting this right, however I have a proposal: > > > > typec_find_port_power_role() to get to

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi Mats > I reread this patch and tried to see it more in the context of the other > patches > and the existing code. The naming of the existing string tables doesn't help > in > getting this right, however I have a proposal: > > typec_find_port_power_role() to get to TYPEC_PORT_SRC/SNK/DRP >

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
t; a.ha...@samsung.com; cw00.c...@samsung.com; shufan_...@richtek.com; > Peter Chen <peter.c...@nxp.com>; gso...@gmail.com; > devicet...@vger.kernel.org; linux-usb@vger.kernel.org; dl-linux-imx > <linux-...@nxp.com> > Subject: Re: [PATCH v5 05/14] usb: typec: add API to get ty

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi Mats, > > Uhm, typing too fast again, I am. A better name would be just > typec_find_role(). > What I mean is that the function could be used for any situation when > someone wants to map a string to a TYPEC_{SOURCE,SINK} constant so it is > unnecessary to limit its usage to just preferred

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Heikki Krogerus
ernel.org; > >>>> gre...@linuxfoundation.org; > >>>> heikki.kroge...@linux.intel.com; li...@roeck-us.net > >>>> Cc: a.ha...@samsung.com; cw00.c...@samsung.com; > >>>> shufan_...@richtek.com; Peter Chen <peter.c...@nxp.com>; >

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-16 Thread Mats Karrman
Cc: a.ha...@samsung.com; cw00.c...@samsung.com; >>>> shufan_...@richtek.com; Peter Chen <peter.c...@nxp.com>; >>>> gso...@gmail.com; devicet...@vger.kernel.org; linux-usb@vger.kernel.org; >>>> dl-linux-imx <linux-...@nxp.com> >>>> Subject:

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-16 Thread Heikki Krogerus
...@nxp.com>; > >> gso...@gmail.com; devicet...@vger.kernel.org; linux-usb@vger.kernel.org; > >> dl-linux-imx <linux-...@nxp.com> > >> Subject: Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port > >> power > >> and

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-15 Thread Mats Karrman
...@linux.intel.com; li...@roeck-us.net >> Cc: a.ha...@samsung.com; cw00.c...@samsung.com; >> shufan_...@richtek.com; Peter Chen <peter.c...@nxp.com>; >> gso...@gmail.com; devicet...@vger.kernel.org; linux-usb@vger.kernel.org; >> dl-linux-imx <linux-...@nxp.com> &

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-14 Thread Jun Li
m; cw00.c...@samsung.com; > shufan_...@richtek.com; Peter Chen <peter.c...@nxp.com>; > gso...@gmail.com; devicet...@vger.kernel.org; linux-usb@vger.kernel.org; > dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port > powe

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-11 Thread Mats Karrman
Hi Li Jun, On 2018-05-03 02:24, Li Jun wrote: This patch adds 3 APIs to get the typec port power and data type, and preferred power role by its name string. Signed-off-by: Li Jun --- drivers/usb/typec/class.c | 52 +++

[PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-02 Thread Li Jun
This patch adds 3 APIs to get the typec port power and data type, and preferred power role by its name string. Signed-off-by: Li Jun --- drivers/usb/typec/class.c | 52 +++ include/linux/usb/typec.h | 3 +++ 2 files changed, 55