RE: [PATCH v3 05/12] usb: typec: add API to get sink and source config

2018-03-19 Thread Jun Li
li...@roeck-us.net; yue...@google.com; > shufan_...@richtek.com; o_leve...@orange.fr; linux-usb@vger.kernel.org; > dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v3 05/12] usb: typec: add API to get sink and source > config > > Hi, > > On 2018-03-13 10:34,

RE: [PATCH v3 05/12] usb: typec: add API to get sink and source config

2018-03-19 Thread Jun Li
net; > yue...@google.com; shufan_...@richtek.com; o_leve...@orange.fr; > linux-usb@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v3 05/12] usb: typec: add API to get sink and source > config > > Hi, > > A small nitpick. The subject lines se

RE: [PATCH v3 05/12] usb: typec: add API to get sink and source config

2018-03-19 Thread Jun Li
rg; a.ha...@samsung.com; li...@roeck-us.net; > yue...@google.com; shufan_...@richtek.com; o_leve...@orange.fr; > linux-usb@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v3 05/12] usb: typec: add API to get sink and source > config > > On

Re: [PATCH v3 05/12] usb: typec: add API to get sink and source config

2018-03-15 Thread Mats Karrman
Hi, On 2018-03-13 10:34, Li Jun wrote: This patch add 2 APIs to get sink and source power config from firmware description in case the port supports PD. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 47 +++

Re: [PATCH v3 05/12] usb: typec: add API to get sink and source config

2018-03-15 Thread Heikki Krogerus
Hi, A small nitpick. The subject lines seem to be a little bit inconsistent in this series. This patch for example does not mention tcpm at all in its subject or even commit message, even though it only modifies tcpm.c. Please change the subject lines of all the patches in this series mainly

Re: [PATCH v3 05/12] usb: typec: add API to get sink and source config

2018-03-15 Thread Heikki Krogerus
On Tue, Mar 13, 2018 at 05:34:31PM +0800, Li Jun wrote: > This patch add 2 APIs to get sink and source power config from firmware > description in case the port supports PD. > > Signed-off-by: Li Jun > --- > drivers/usb/typec/tcpm.c | 47