Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

2018-08-28 Thread Doug Anderson
Hi, On Tue, Aug 28, 2018 at 11:04 AM, Terin Stock wrote: >> It would also be good to document what device you were plugging in >> that you were having problems with and what system you were running >> on. That would help someone else if they ever wanted to modify the >> same area of code and

Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

2018-08-28 Thread Terin Stock
Thanks Alan and Doug for your feedback. They've both been extremely helpful in understanding what you're looking for in messages. A few responses below. > I think your commit will be more compelling with additional data. As > Allen says it looks like you're not actually changing the delay. You

Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

2018-08-28 Thread Doug Anderson
Hi, On Sat, Aug 25, 2018 at 8:45 PM, Terin Stock wrote: > Upon upgrading a Raspberry Pi 3B-based project from vanilla 4.14, > attempts to mount a floppy disk in a generic USB floppy drive would hang > until the floppy drive was removed from the system. > > Tracing shows that during mounting the

Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

2018-08-26 Thread Alan Stern
On Sat, 25 Aug 2018, Terin Stock wrote: > Upon upgrading a Raspberry Pi 3B-based project from vanilla 4.14, > attempts to mount a floppy disk in a generic USB floppy drive would hang > until the floppy drive was removed from the system. > > Tracing shows that during mounting the drive produces a