Re: [PATCH v2] usb: misc: legousbtower: Fix buffers on stack

2017-04-26 Thread Greg Kroah-Hartman 
On Tue, Apr 25, 2017 at 10:28:42PM +0300, Maksim Salau wrote:
> On Tue, 25 Apr 2017 20:04:24 +0200
> Greg Kroah-Hartman  wrote:
> 
> > On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote:
> > > Allocate buffers on HEAP instead of STACK for local structures
> > > that are to be received using usb_control_msg().
> > > 
> > > Signed-off-by: Maksim Salau 
> > > Tested-by: Alfredo Rafael Vicente Boix 
> > > Cc: sta...@vger.kernel.org  
> > 
> > This patch does not apply to usb-next, what did you make it against?
> > 
> > Can you rebase it and resend?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> 
> I've created the patch against linux-stable v4.10.12. I've checked history 
> of the driver and it turns out that the patch conflicts with 
> 9b181166f17534a82b4b628b13e524a893715dfc
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/legousbtower.c?h=usb-next=9b181166f17534a82b4b628b13e524a893715dfc
> 
> There are no conflicting changes, but context has changed.
> I'll rebase and resend shortly.
> 
> The same patch can't be used for stable and for usb-next anymore. Is there
> any chance to backport the fix for stable?

Yes, we can backport it, I'll mark it for stable and do the backport
when it hits Linus's tree after 4.12-rc1 is out.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: misc: legousbtower: Fix buffers on stack

2017-04-25 Thread Maksim Salau 
On Tue, 25 Apr 2017 20:04:24 +0200
Greg Kroah-Hartman  wrote:

> On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote:
> > Allocate buffers on HEAP instead of STACK for local structures
> > that are to be received using usb_control_msg().
> > 
> > Signed-off-by: Maksim Salau 
> > Tested-by: Alfredo Rafael Vicente Boix 
> > Cc: sta...@vger.kernel.org  
> 
> This patch does not apply to usb-next, what did you make it against?
> 
> Can you rebase it and resend?
> 
> thanks,
> 
> greg k-h

Hi Greg,

I've created the patch against linux-stable v4.10.12. I've checked history 
of the driver and it turns out that the patch conflicts with 
9b181166f17534a82b4b628b13e524a893715dfc

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/legousbtower.c?h=usb-next=9b181166f17534a82b4b628b13e524a893715dfc

There are no conflicting changes, but context has changed.
I'll rebase and resend shortly.

The same patch can't be used for stable and for usb-next anymore. Is there
any chance to backport the fix for stable?

Regards,
Maksim.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: misc: legousbtower: Fix buffers on stack

2017-04-25 Thread Greg Kroah-Hartman 
On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote:
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().
> 
> Signed-off-by: Maksim Salau 
> Tested-by: Alfredo Rafael Vicente Boix 
> Cc: sta...@vger.kernel.org

This patch does not apply to usb-next, what did you make it against?

Can you rebase it and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html