Re: [PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume
Hi, Sandeep Singh writes: > On 8/4/2017 4:44 PM, Felipe Balbi wrote: >> >> Hi, >> >> Sandeep Singh writes: >>> From: Sandeep Singh >>> >>> Certain HP keyboards would keep inputting a character automatically which >>> is the wake-up key after S3 resume >>> >>> On some AMD platforms USB host fails to respond (by holding resume-K) to >>> USB device (an HP keyboard) resume request within 1ms (TURSM) and ensures >>> that resume is signaled for at least 20 ms (TDRSMDN), which is defined in >>> USB 2.0 spec. The result is that the keyboard is out of function. >>> >>> In SNPS USB design, the host responds to the resume request only after >>> system gets back to S0 and the host gets to functional after the internal >>> HW restore operation that is more than 1 second after the initial resume >>> request from the USB device. >>> >>> As a workaround for specific keyboard ID(HP Keyboards), applying port reset >>> after resume when the keyboard is plugged in. >>> >>> Signed-off-by: Sandeep Singh >>> Signed-off-by: Shyam Sundar S K >>> cc: Nehal Shah >> >> seems correct now: >> >> Reviewed-by: Felipe Balbi >> > > Greg, Any feedback on this patch.? Mathias is the xHCI maintainer. He just came back from vacations, give him some time ;-) -- balbi signature.asc Description: PGP signature
Re: [PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume
On 8/4/2017 4:44 PM, Felipe Balbi wrote: > > Hi, > > Sandeep Singh writes: >> From: Sandeep Singh >> >> Certain HP keyboards would keep inputting a character automatically which >> is the wake-up key after S3 resume >> >> On some AMD platforms USB host fails to respond (by holding resume-K) to >> USB device (an HP keyboard) resume request within 1ms (TURSM) and ensures >> that resume is signaled for at least 20 ms (TDRSMDN), which is defined in >> USB 2.0 spec. The result is that the keyboard is out of function. >> >> In SNPS USB design, the host responds to the resume request only after >> system gets back to S0 and the host gets to functional after the internal >> HW restore operation that is more than 1 second after the initial resume >> request from the USB device. >> >> As a workaround for specific keyboard ID(HP Keyboards), applying port reset >> after resume when the keyboard is plugged in. >> >> Signed-off-by: Sandeep Singh >> Signed-off-by: Shyam Sundar S K >> cc: Nehal Shah > > seems correct now: > > Reviewed-by: Felipe Balbi > Greg, Any feedback on this patch.? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume
Hi, Sandeep Singh writes: > From: Sandeep Singh > > Certain HP keyboards would keep inputting a character automatically which > is the wake-up key after S3 resume > > On some AMD platforms USB host fails to respond (by holding resume-K) to > USB device (an HP keyboard) resume request within 1ms (TURSM) and ensures > that resume is signaled for at least 20 ms (TDRSMDN), which is defined in > USB 2.0 spec. The result is that the keyboard is out of function. > > In SNPS USB design, the host responds to the resume request only after > system gets back to S0 and the host gets to functional after the internal > HW restore operation that is more than 1 second after the initial resume > request from the USB device. > > As a workaround for specific keyboard ID(HP Keyboards), applying port reset > after resume when the keyboard is plugged in. > > Signed-off-by: Sandeep Singh > Signed-off-by: Shyam Sundar S K > cc: Nehal Shah seems correct now: Reviewed-by: Felipe Balbi -- balbi signature.asc Description: PGP signature
