Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 04:32, nick xerofo...@gmail.com wrote: I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other locking related to this driver. So do you say it's not executed in an

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Michael Büsch
On Fri, 28 Nov 2014 22:32:30 -0500 nick xerofo...@gmail.com wrote: I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other locking related to this driver. From the current docs: *

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 09:56, Michael Büsch m...@bues.ch wrote: On Fri, 28 Nov 2014 22:32:30 -0500 nick xerofo...@gmail.com wrote: I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other

Re: [PATCH] mac80211: enable TPC through mac80211 stack

2014-11-29 Thread Lorenzo Bianconi
On Fri, 2014-11-28 at 16:02 +0100, Lorenzo Bianconi wrote: I just need to notify lower driver (ath9k in my case) to setup TPC registers in order to take into account TX power configured in frame descriptors. For that purpose I added tpc_enabled flags in ieee80211_bss_conf and in

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Larry Finger
On 11/29/2014 12:09 PM, nick wrote: Sorry about that, next time I will be more careful. One other thing would be to change the initial part of the subject. Yes, the device is in drivers/net/wireless/, but it is much more common to not include those in patches that are sent to Linville. I

Re: Non Explained TODOs in halbtcoutsrc.c

2014-11-29 Thread Larry Finger
On 11/29/2014 05:34 PM, nick wrote: Greetings Larry, After reading the code around the TODOS, I can't understand you reasoning for them in this file as they seem to unneeded as the logic for the switch statement with them seems to be fine. If there are reasons for them in this file, it would