Re: rtl8192ee (Thinkpad T440s)

2015-02-04 Thread Larry Finger
7;uname -r' is a lot more helpful that what version of Ubuntu you are using. Sorry; I'll be more specific going forward. Current kernel I'm using is 3.19.0-rc7-next-20150204. The included driver did not work: cut here --

Re: rtl8192ee (Thinkpad T440s)

2015-02-04 Thread Larry Finger
On 02/05/2015 12:56 AM, Ken D'Ambrosio wrote: Feb 5 01:51:19 minasithil kernel: [ 3141.801171] rtl8192ee :03:00.0: Refused to change power state, currently in D3 Above is the serious problem. The wifi device is not powering on. Sometimes this can be caused by some state left by Windows. D

How to increase wifi A-MDU with lots of streaming peers?

2015-02-04 Thread Ben Greear
Suppose one has an AP that is trying to support 40 or so clients all streaming video, using http gets to get around 2 seconds worth of data at a time. The AP's NIC is ath10k, stations are a mix of /n and /ac. User has control of streaming server and AP, but not clients. I think from wifi transpo

Re: rtl8192ee (Thinkpad T440s)

2015-02-04 Thread Ken D'Ambrosio
version of Ubuntu you are using. Sorry; I'll be more specific going forward. Current kernel I'm using is 3.19.0-rc7-next-20150204. The included driver did not work: cut here -- Feb 5 01:05:21 minasithil Netwo

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Michal Kazior
On 4 February 2015 at 22:11, Eric Dumazet wrote: > I do not see how a TSO patch could hurt a flow not using TSO/GSO. > > This makes no sense. > > ath10k tx completions being batched/deferred to a tasklet might increase > probability to hit this condition in tcp_wfree() : > > /* If this sof

[PATCH 3/7] ath9k: Add new MCI states

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan Several new MCI states have to handled, add them to the list. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/ar9003_mci.h | 30 - 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/

[PATCH 4/7] ath9k: Check MCI PowerSave state

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan The power save state of MCI has to be disabled when enabling WoW sleep, check this properly. ar9003_mci_state() doesn't handle MCI_STATE_GET_WLAN_PS_STATE right now, but this will be done later when proper support for MCI/PS is added. Signed-off-by: Sujith Manoharan ---

[PATCH 6/7] ath9k: Clear additional WoW events

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan The events for patterns 8..15 need to be cleared on wakeup. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 5 - drivers/net/wireless/ath/ath9k/reg_wow.h| 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 2/7] ath9k: Set keep awake timer

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan When MCI is enabled and WoW sleep is enabled, make sure that the RTC keep awake timer is set with the required value. This is also required when the AR_WA is programmed. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 6 ++ 1 file ch

[PATCH 5/7] ath9k: Handle additional patterns on wakeup

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan Handle the user-configured patterns in the range 8..15 when waking up and update wow_status correctly. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 16 drivers/net/wireless/ath/ath9k/reg_wow.h| 8 +++- 2 file

[PATCH 7/7] ath9k: Restart TSF2 timers on wakeup

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan When coming out of WoW sleep, check and restart timers based on TSF2. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/ar9003_wow.c b/drivers/net/wir

[PATCH 1/7] ath9k: Fix descriptors for keep-alive frame

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan Along with AR9462, AR9565 also has an extra field in the TX descriptor which needs to be zeroed out for the keep alive frame. This makes the earlier REG_WRITE redundant, so it can be removed. Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/ath9k/ar9003_wow.c

[PATCH 0/7] ath9k patches

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan ath9k patches for -next. Sujith Manoharan (7): ath9k: Fix descriptors for keep-alive frame ath9k: Set keep awake timer ath9k: Add new MCI states ath9k: Check MCI PowerSave state ath9k: Handle additional patterns on wakeup ath9k: Clear additional WoW events at

[PATCH 07/10] mac80211: restructure per-rate throughput calculation into function

2015-02-04 Thread Thomas Huehn
This patch moves Minstrels and Minstrel-HTs per-rate throughput calculation (EWMA(thr)) into a dedicated function to be called. Therefore the variable "unsigned int cur_tp" within struct "minstrel_rate_stats" becomes obsolete. and is removed to free up its space. Signed-off-by: Thomas Huehn ---

[PATCH 08/10] mac80211: add max. lossless throughput per rate to rc_stats

2015-02-04 Thread Thomas Huehn
This patch adds the new statistic "maximum possible lossless throughput" to Minstrels and Minstrel-HTs rc_stats (in debugfs). This enables comprehensive comparison between current per-rate throughput and max. achievable per-rate throughput. Signed-off-by: Thomas Huehn --- net/mac80211/rc80211_mi

[PATCH 02/10] mac80211: enhance readability of Minstrel-HTs rc_stats output

2015-02-04 Thread Thomas Huehn
This patch restructures the rc_stats debugfs table of Minstrel-HT in order to achieve better human readability. A new layout of the statistics and a new header is added. In addition to the old layout there are two new columns of information added: "idx" - representing the rate index of each rate

[PATCH 04/10] mac80211: add new Minstrel-HT statistic output via csv

2015-02-04 Thread Thomas Huehn
This patch adds a new debugfs file "rc_stats_csv" to output Minstrel-HTs statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn Signed-off-by: Stefan Venz --- net/mac80211/rc80211_minstrel_ht.h | 1 + net/mac80211/rc80211_minstrel_ht_debugfs.c | 145 +

[PATCH 03/10] mac80211: add new Minstrel statistic output via csv

2015-02-04 Thread Thomas Huehn
This patch adds a new debugfs file "rc_stats_csv" to output Minstrels statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn Signed-off-by: Stefan Venz --- net/mac80211/rc80211_minstrel.h| 6 +- net/mac80211/rc80211_minstrel_debugfs.c| 95 +

[PATCH 06/10] mac80211: improve Minstrel variable & function naming

2015-02-04 Thread Thomas Huehn
This patch ensures a consistent usage of variable names for type "minstrel_rate_stats" to be used as "mrs" and from type minstrel_rate as "mr" across both Minstrel & Minstrel-HT. In addition some variable and function names got changed to more meaningful ones. Signed-off-by: Thomas Huehn --- net

[PATCH 09/10] mac80211: reduce calculation costs of EWMA

2015-02-04 Thread Thomas Huehn
This patch reduces the calculation costs of the EWMA macro from "2x multiplication and 1 addition" down to "1x multiplication and 2 additions". This slightly improves performance depending on the CPU architecture. Signed-off-by: Thomas Huehn --- net/mac80211/rc80211_minstrel.h | 7 ++- 1 fil

[PATCH 01/10] mac80211: enhance readability of Minstrels rc_stats output

2015-02-04 Thread Thomas Huehn
This patch restructures the rc_stats debugfs table of Minstrel in order to achieve better human readability. A new layout of the statistics and a new header is added. In addition to the old layout there are two new columns of information added: "idx" - representing the rate index of each rate in

[PATCH 05/10] mac80211: unify Minstrel & Minstrel-HTs calculation of rate statistics

2015-02-04 Thread Thomas Huehn
This patch unifies the calculation of Minstrels and Minstrel-HTs per-rate statistic. The new common function minstrel_calc_rate_stats() is called when a statistic update is performed. Signed-off-by: Thomas Huehn --- net/mac80211/rc80211_minstrel.c| 44 --

[PATCH 10/10] mac80211: add standard deviation to Minstrels throughput statistic

2015-02-04 Thread Thomas Huehn
This patch adds the statistical descriptor "standard deviation" to better describe the current properties of Minstrel and Minstrel-HTs success probability distribution. The standard deviation (SD) is calculated as exponential weighted moving standard deviation (EWMSD) and its current value is added

[PATCH 0/10] Improve Minstrels & Minstrel-HTs common code base & statistics

2015-02-04 Thread Thomas Huehn
This patch series adds several improvements to the readability, the output format of rc_stats and the calculated statistics of Minstrel and Minstrel-HT. Variable names got more consistent and functions got unified between both rate control algorithms. Greetings Thomas [PATCH 01/10] mac80211: en

Re: pull-request: mac80211-next 2015-02-03

2015-02-04 Thread David Miller
From: Johannes Berg Date: Tue, 03 Feb 2015 14:51:43 +0100 > Here's a last pull request for net-next - I hope it can still make it, > we fixed a fairly large number of issues. Also there's a bunch of new > ciphers, but see the details below. > > Let me know if there's any problem. Pulled, thanks

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Eric Dumazet
I do not see how a TSO patch could hurt a flow not using TSO/GSO. This makes no sense. ath10k tx completions being batched/deferred to a tasklet might increase probability to hit this condition in tcp_wfree() : /* If this softirq is serviced by ksoftirqd, we are likely under stress.

about bitrate information

2015-02-04 Thread Arend van Spriel
Hi Johannes, Just a quick question about the bitrate info shown with 'iw link'. I assume the MCS info reported is the MCS related to the bitrate number so the current/last MCS used and not some maximum MCS. Regards, Arend -- To unsubscribe from this list: send the line "unsubscribe linux-wire

[PATCH] net: brcm80211: Delete unnecessary checks before two function calls

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 20:28:49 +0100 The functions brcmu_pkt_buf_free_skb() and usb_free_urb() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. Signed-off-by: Markus Elfring --- drivers/net/wireless/brcm80211/brc

[PATCH] HostAP: Delete an unnecessary check before the function call "kfree"

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 20:06:39 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/

[PATCH] orinoco: Delete an unnecessary check before the function call "kfree"

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 19:53:11 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/

[PATCH] ath10k: Delete unnecessary checks before the function call "release_firmware"

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 19:30:23 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- d

[PATCH] ath9k: Delete an unnecessary check before the function call "relay_close"

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 18:48:28 +0100 The relay_close() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- driver

[PATCH 2/2] CW1200: Less function calls in cw1200_load_firmware_cw1200() after error detection

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 17:28:41 +0100 The functions kfree() and release_firmware() were called in a few cases by the cw1200_load_firmware_cw1200() function during error handling even if the passed variables contained still a null pointer. Corresponding implementation details

[PATCH 1/2] CW1200: Delete an unnecessary check before the function call "release_firmware"

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 16:32:15 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- d

[PATCH 0/2] CW1200: Deletion of an unnecessary check

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 4 Feb 2015 17:31:00 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete an unnecessary check before the function call "release_firmware" Less function calls in cw1200_loa

Re: broken URLs of iwlwifi firmware tarballs

2015-02-04 Thread Emmanuel Grumbach
> On Wed, 2015-02-04 at 13:06 +0100, Vladimír Čunát wrote: >> On 02/03/2015 09:46 AM, Johannes Berg wrote: >> > I've fixed that now. >> >> Thanks! >> >> For future reference, is it the case that fetching from (c)git is the >> preferred way of distributing the firmware? (preferred by you, i.e.p >> *

Re: [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-02-04 Thread Ben Greear
On 02/04/2015 12:37 AM, Kalle Valo wrote: gree...@candelatech.com writes: From: Ben Greear In case firmware fails to start the scan, then complete the start condition and clean up so that driver does not block on timeout. Signed-off-by: Ben Greear These patches are now in the pending bran

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Eric Dumazet
On Wed, 2015-02-04 at 05:16 -0800, Eric Dumazet wrote: > OK guys > > Using a mlx4 testbed I can reproduce the problem by pushing coalescing > settings and disabling SG (thus disabling GSO) > > ethtool -K eth0 sg off > Actual changes: > scatter-gather: off > tx-scatter-gather: off > generic-

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Eric Dumazet
OK guys Using a mlx4 testbed I can reproduce the problem by pushing coalescing settings and disabling SG (thus disabling GSO) ethtool -K eth0 sg off Actual changes: scatter-gather: off tx-scatter-gather: off generic-segmentation-offload: off [requested on] ethtool -C eth0 tx-usecs 1024 t

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Johannes Berg
On Wed, 2015-02-04 at 13:53 +0100, Michal Kazior wrote: > The hardware itself seems to be capable. The firmware is a problem > though. I'm also not sure if mac80211 can handle this as is. No 802.11 > driver seems to support SG except wil6210 which uses cfg80211 and > netdevs directly. mac80211 ca

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Michal Kazior
On 4 February 2015 at 13:38, Eric Dumazet wrote: > On Wed, 2015-02-04 at 13:22 +0100, Michal Kazior wrote: >> On 4 February 2015 at 12:57, Eric Dumazet wrote: > >> >> > To disable gso you would have to use : >> > >> > ethtool -K wlan1 gso off >> >> Oh, thanks! This works. However I can't turn it

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Eric Dumazet
On Wed, 2015-02-04 at 13:22 +0100, Michal Kazior wrote: > On 4 February 2015 at 12:57, Eric Dumazet wrote: > > > To disable gso you would have to use : > > > > ethtool -K wlan1 gso off > > Oh, thanks! This works. However I can't turn it on: > > ; ethtool -K wlan1 gso on > Could not change any

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Michal Kazior
On 4 February 2015 at 12:57, Eric Dumazet wrote: > On Wed, 2015-02-04 at 12:35 +0100, Michal Kazior wrote: > >> > (Or maybe wifi drivers should start to use skb->xmit_more as a signal to >> > end aggregation) >> >> This could work if your firmware/device supports this kind of thing. >> To my unde

Re: broken URLs of iwlwifi firmware tarballs

2015-02-04 Thread Johannes Berg
On Wed, 2015-02-04 at 13:06 +0100, Vladimír Čunát wrote: > On 02/03/2015 09:46 AM, Johannes Berg wrote: > > I've fixed that now. > > Thanks! > > For future reference, is it the case that fetching from (c)git is the > preferred way of distributing the firmware? (preferred by you, i.e. > *.kernel

Re: broken URLs of iwlwifi firmware tarballs

2015-02-04 Thread Vladimír Čunát
On 02/03/2015 09:46 AM, Johannes Berg wrote: I've fixed that now. Thanks! For future reference, is it the case that fetching from (c)git is the preferred way of distributing the firmware? (preferred by you, i.e. *.kernel.org) Vladimir smime.p7s Description: S/MIME Cryptographic Signat

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Eric Dumazet
On Wed, 2015-02-04 at 12:35 +0100, Michal Kazior wrote: > > (Or maybe wifi drivers should start to use skb->xmit_more as a signal to > > end aggregation) > > This could work if your firmware/device supports this kind of thing. > To my understanding ath10k firmware doesn't. This is a pure softwa

Re: Throughput regression with `tcp: refine TSO autosizing`

2015-02-04 Thread Michal Kazior
On 3 February 2015 at 15:27, Eric Dumazet wrote: > On Tue, 2015-02-03 at 12:50 +0100, Michal Kazior wrote: [...] >> IOW: >> - stretch acks / TSO defer don't seem to help much (when compared to >> throughput results from yesterday) >> - GRO helps >> - disabling A-MSDU on sender helps >> - net/m

oops in pwq_activate_delayed_work+0x1f/0x3f

2015-02-04 Thread Janusz Dziedzic
Hello, 3.19rc3 and 3.19rc5 - I am not 100% sure, but didn't see this on 3.17? In 2 cases last log I see is: "cancelling AP probe due to a received beacon" Any idea what could be a problem here? [ 1654.833647] wlan1: cancelling AP probe due to a received beacon [ 1654.840062] BUG: unable to handle

Re: [PATCH] ath10k: add TxBF support

2015-02-04 Thread Kalle Valo
Michal Kazior writes: > If firmware advertises support for TxBF then the > driver has to instruct the firmware accordingly > during runtime. Without this patch connecting to > an AP with beamformer support would yield abysmal > Rx performance. > > This has been tested with wmi-tlv and qca6174 > w

Re: [PATCH 0/4] ath10k: implement fw stats for wmi-tlv

2015-02-04 Thread Kalle Valo
Michal Kazior writes: > There are some slight differences in fw stats > (sic) in wmi-tlv. > > Firmware has changed the querying scheme and no > longer requires the ping-pong to get all stats. > The patchset doesn't change this behaviour so with > wmi-tlv it's possible to see the following > warni

Re: [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly.

2015-02-04 Thread Kalle Valo
gree...@candelatech.com writes: > From: Ben Greear > > In case firmware fails to start the scan, then complete > the start condition and clean up so that driver does not > block on timeout. > > Signed-off-by: Ben Greear These patches are now in the pending branch. 86f50c71b224 ath10k: scan sho

Re: [PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging.

2015-02-04 Thread Kalle Valo
gree...@candelatech.com writes: > From: Ben Greear > > A bit of general cleanup to make debug messages more useful. > > Signed-off-by: Ben Greear [...] > - ath10k_warn(ar, "failed to synchronise monitor vdev %i: %d\n", > + ath10k_warn(ar, "failed to synchronize monitor

[PATCH 1/3] wireless: orinoco: orinoco_plx use msecs_to_jiffies for conversion

2015-02-04 Thread Nicholas Mc Guire
This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire --- Converting milliseconds to jiffies by "val * HZ / 1000" is technically ok but msecs_to_jiffies(val) is the cleaner solution and handle

[PATCH 3/3] wireless: orinoco: orinoco_tmd use msecs_to_jiffies for conversion

2015-02-04 Thread Nicholas Mc Guire
This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire --- Converting milliseconds to jiffies by "val * HZ / 1000" is technically ok but msecs_to_jiffies(val) is the cleaner solution and handle

[PATCH 2/3] wireless: orinoco: orinoco_pci use msecs_to_jiffies for conversion

2015-02-04 Thread Nicholas Mc Guire
This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire --- Converting milliseconds to jiffies by "val * HZ / 1000" is technically ok but msecs_to_jiffies(val) is the cleaner solution and handle