On 19 August 2015 at 13:23, Kalle Valo kv...@qca.qualcomm.com wrote:
Michal Kazior michal.kaz...@tieto.com writes:
Kernel would complain about leaving a held lock
after going back to userspace and would
subsequently deadlock.
Fixes: e04cafbc38c7 (ath10k: fix peer limit enforcement)
On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote:
On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote:
This patch allows setting all options in the module's debug region
options file 'wilc_debug_region'. This functionality allows the user
to enable logging from all
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and the
last one will have 65420.
Change-Id:
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
---
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
Kalle Valo kv...@codeaurora.org writes:
here's one more pull request for 4.3. More info in the signed tag below.
This time I had to merge mac80211-next.git due to some iwlwifi
dependencies and apparently that broke git-request-pull's diffstat
again, it was showing changes which were not
On 08/19/2015 08:51 AM, Adrien Schildknecht wrote:
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
---
Has this ID been tested with the Netgear device?
Larry
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1
The function returns 1 when DMA mapping fails. The
driver would return bogus values and could
possibly confuse itself if DMA failed.
Fixes: 767d34fc67af (ath10k: remove DMA mapping wrappers)
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Michal Kazior michal.kaz...@tieto.com
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
The segmentation is done completely in software. The
driver creates several MPDUs out of a single large send.
Each MPDU is a newly allocated SKB.
A page is allocated to create the headers that need to be
duplicated (SNAP / IP / TCP).
The segmentation is done completely in software. The
driver creates several MPDUs out of a single large send.
Each MPDU is a newly allocated SKB.
A page is allocated to create the headers that need to be
duplicated (SNAP / IP / TCP). The WiFi header is in the
header of the newly created SKBs.
We enable TSO to get a lot of data at once to build A-MSDUs.
Our hardware doesn't have (yet) TCP CSUM offload, so we do
it manually. TSO won't be enabled on hardware that don't
support CSUM offload in release code, computing TCP CSUM
in the driver is just a way to start coding the flows.
This is
Now that we can get a big chunk of data from the network
stack, we can create an A-MSDU out of it. The purpose is to
get a throughput improvement since sending one single A-MSDU
is more efficient than sending several MSDUs at least under
ideal link conditions.
type=feature
Change-Id:
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
We could have enabled A-MSDU based on xmit-more, but the
rationale of using LSO is that when using pfifo-fast,
the Qdisc gets one packet and dequeues is straight away
which limits the possibility to get a lot of packets at
once. (Am
Michal Kazior michal.kaz...@tieto.com writes:
Kernel would complain about leaving a held lock
after going back to userspace and would
subsequently deadlock.
Fixes: e04cafbc38c7 (ath10k: fix peer limit enforcement)
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Michal
Manikanta Pubbisetty c_mpu...@qti.qualcomm.com writes:
Currently fw stats printing in ath10k is common to all firmware
versions. Eventually we end up printing the stats which are not
intended to be printed. For example, we might print stats of 10.2.4
in 10.2, additional stats will have the
Standard Chartered Bank Dubai Main Branch,
Al Fardan Gebäude, Al Mankhool Road,
P.O. Box 999, Dubai,
Vereinigte Arabische Emirate
Sehr geehrte Kunden,
Telegrafische Überweisung HINWEIS.
Wir sind hiermit offiziell informieren Sie über Ihre Fondstelegrafische
Überweisung durch unsere Bank,
On Fri, 2015-08-14 at 14:39 -0700, Allan Matthew wrote:
Anyone have any thoughts on this?
Is it possible with channel context enabled somehow?
I don't think it's possible - per-packet configuration would have to be
basically instantaneous (cannot sleep etc.) and setting the channel is
On Wed, 2015-08-19 at 07:17 -0700, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
The segmentation is done completely in software. The
driver creates several MPDUs out of a single large send.
Each MPDU is a newly allocated SKB.
A page is allocated to
On 08/19/2015 10:33 AM, Adrien Schildknecht wrote:
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
Cc: Stable sta...@vger.kernel.org
---
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
1 file changed, 1
On Wed, Aug 19, 2015 at 06:00:12PM +0530, Chandra Gorentla wrote:
On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote:
On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote:
This patch allows setting all options in the module's debug region
options file
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
Cc: Stable sta...@vger.kernel.org
---
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 08/19/2015 08:51 AM, Adrien Schildknecht wrote:
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
Add a Cc: Stable sta...@vger.kernel.org line here. That way the new ID will
be available with older kernels.
On Wed, 2015-08-19 at 17:00 +, Grumbach, Emmanuel wrote:
On 08/19/2015 07:08 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote:
I'll look at it.
I was almost starting to implement that but then I thought with another
(good?) reason to use LSO.
On 16 August 2015 at 08:55, Arend van Spriel ar...@broadcom.com wrote:
From: Hante Meuleman meule...@broadcom.com
Host platforms such as routers supported by OpenWRT can
support NVRAM reading directly from internal NVRAM store.
With this patch the nvram load routines will fall back to
this
On 08/19/2015 07:08 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote:
I'll look at it.
I was almost starting to implement that but then I thought with another
(good?) reason to use LSO. LSO gives me the guarantee that the packet is
directed to one peer,
On Wed, 2015-08-19 at 17:56 +, Grumbach, Emmanuel wrote:
So I feel that making net/core/tso.c more complicated just because of
our craziness seems an overkill to me.
I'll try a bit harder to see how I can use net/core/tso.c, but I have to
say I am pessimistic.
net/core/tso.c is WIP,
On Wed, 2015-08-19 at 10:44 -0700, Ben Greear wrote:
At least with ath9k, it is possible to send HT20 frames
when the radio has other vifs on the same radio sending HT40 frames,
for instance.
(And rate-ctrl will do the same thing even for an 'ht40' vif).
Yes, but that's pure rate control.
On 08/19/2015 05:18 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
The segmentation is done completely in software. The
driver creates several MPDUs out of a single large send.
Each MPDU is a newly allocated SKB.
A page is allocated to create the headers
On Wed, 2015-08-19 at 09:37 -0700, Allan Matthew wrote:
It seems like the functionality for this (maybe not the monitor mode)
must be available in order to support the multiple 802.11p channels
in the 5.8ghz band.
Not sure - I haven't looked at WAVE/11p in a long time, but the code we
have
Thank you Johannes,
It seems like the functionality for this (maybe not the monitor mode)
must be available in order to support the multiple 802.11p channels in
the 5.8ghz band.
It sounds like what you are proposing is to create a non-monitor vif,
select its channel, bitrate, bandwidth and then
On Wed, 2015-08-19 at 12:50 -0700, Allan Matthew wrote:
Regarding the AP clients, could the AP send a power save or sleep
notification telling clients its going away for awhile, then come
back after the specified time?
No, the protocol has no such provision for the AP.
[also, please try to
I have a commercial AP that is using a CM9 ath5k radio (evidently, I could be
wrong)
and it has the ability to do a constant transmit of raw noise (RF probe shows
noise, but a monitor-port sniffer does not see any frames from the CM9).
I don't know the low-level details of how it is doing this,
Hello.
On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and
On 08/19/2015 05:24 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
Regarding the AP clients, could the AP send a power save or sleep
notification telling clients its going away for awhile, then come back
after the specified time?
On Wed, Aug 19, 2015 at 12:41 PM, Johannes Berg
johan...@sipsolutions.net wrote:
On Wed, 2015-08-19 at 12:00 -0700, Allan Matthew
On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
Hm.. how would net/core/tso.c avoid this?
Because a driver using these helpers keep around the original LSO packet
and frees it normally at TX completion time.
I can't see anything related to truesize there.
Note that this work
Hi,
On 08/19/2015 10:10 PM, Sergei Shtylyov wrote:
Hello.
On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all
On 08/19/2015 10:12 PM, Grumbach, Emmanuel wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and the
last
On Wed, Aug 19, 2015 at 12:53 PM, Johannes Berg
johan...@sipsolutions.net wrote:
No, the protocol has no such provision for the AP.
[also, please try to format your emails more readable, instead of just
tacking on something on the top]
johannes
Understood, thanks for the help. Apologies
Hello Lorenzo Bianconi,
Hi Dan,
The patch b119ad6e726c: mac80211: add rate mask logic for vht rates
from Aug 6, 2015, leads to the following static checker warning:
net/mac80211/cfg.c:2520 ieee80211_set_bitrate_mask()
error: buffer overflow
On Wed, 2015-08-19 at 12:00 -0700, Allan Matthew wrote:
I operate an AP on one channel that talks to some set of devices.
On another channel (maybe just different BW) I use packet injection
to send data to and from a separate device.
The bitrate to the 2nd device (on the 2nd channel) is
On 08/19/2015 06:38 PM, Rafał Miłecki wrote:
On 16 August 2015 at 08:55, Arend van Spriel ar...@broadcom.com wrote:
From: Hante Meuleman meule...@broadcom.com
Host platforms such as routers supported by OpenWRT can
support NVRAM reading directly from internal NVRAM store.
With this patch the
On 08/19/2015 11:21 PM, Arend van Spriel wrote:
subject changed to v2. So let's go over your beef.
On 07/11/2015 07:09 PM, Rafał Miłecki wrote:
On 10 July 2015 at 20:31, Arend van Spriel ar...@broadcom.com wrote:
@@ -146,7 +147,7 @@ brcmf_nvram_handle_value(struct nvram_parser *nvp)
On 12 August 2015 at 10:58, Arend van Spriel ar...@broadcom.com wrote:
You did a warm reboot of the device, right? There seems to be an issue
because on OpenWrt the brcmfmac is not unloaded upon warm reboot, which
makes the device unaccessible. Because on OpenWrt the firmware request is
subject changed to v2. So let's go over your beef.
On 07/11/2015 07:09 PM, Rafał Miłecki wrote:
On 10 July 2015 at 20:31, Arend van Spriel ar...@broadcom.com wrote:
@@ -146,7 +147,7 @@ brcmf_nvram_handle_value(struct nvram_parser *nvp)
u32 cplen;
c = nvp-data[nvp-pos];
-
On 16 August 2015 at 08:55, Arend van Spriel ar...@broadcom.com wrote:
From: Hante Meuleman meule...@broadcom.com
Next generation devices will have firmware which will have more
than 256 flowrings. This patch increases the maximum number of
supported flowrings to 512.
Reviewed-by: Arend Van
Broadcom is working on better reflection of interface combinations. With
upcoming patches we may have 1st combination supporting less interfaces
than others.
To don't run out of addresses check all combinations to find the one
with the greatest max_interfaces value.
Signed-off-by: Rafał Miłecki
On 16 August 2015 at 08:55, Arend van Spriel ar...@broadcom.com wrote:
The interface combination provided by brcmfmac did not truly reflect
the combinations supported by driver and/or firmware.
This is OK in general but may conflict a bit with my recent:
brcmfmac: set wiphy's addresses to
On 08/19/2015 11:49 PM, Rafał Miłecki wrote:
On 16 August 2015 at 08:55, Arend van Spriel ar...@broadcom.com wrote:
The interface combination provided by brcmfmac did not truly reflect
the combinations supported by driver and/or firmware.
This is OK in general but may conflict a bit with my
From: Miaoqing Pan miaoq...@qca.qualcomm.com
When rx stopped, AR_RX_FILTER should be cleared, but in
ath9k_hw_setrxfilter(), ATH9K_RX_FILTER_CONTROL_WRAPPER will always
be set for ar9462/ar9565.
Fix this by moving the code in ath9k_hw_setrxfilter() to
ath_calcrxfilter().
Signed-off-by: Miaoqing
From: Miaoqing Pan miaoq...@qca.qualcomm.com
One stuck issue was found on AP152, the root cause is using wrong
calibration initial function.
Signed-off-by: Miaoqing Pan miaoq...@qca.qualcomm.com
---
drivers/net/wireless/ath/ath9k/ar9003_calib.c | 6 --
1 file changed, 4 insertions(+), 2
Here is the changelog note. This particular improvement does not require
any driver patches as far as I know. I tested this on my 4.0.4+ kernel.
Should be useful for anyone doing sniffing with ath10k.
* Allow monitor mode to receive 'Association Request', block-ack action
frames,
Raja Mani rm...@qti.qualcomm.com writes:
Found incorrect sequence in ath10k_core_stop() where wmi pktlog
disable cmd is passed from ath10k_debug_stop() to firmware
immediately after wmi pdev suspend cmd. Firmware will not accept
any wmi cmd after receiving wmi pdev suspend cmd.
Fix this
Raja Mani rm...@qti.qualcomm.com writes:
10.4 firmware uses dedicated copy engine for pktlog transaction.
Whatever the data received in that dedicated copy engine will
have only pkt log header and followed by pktlog payload (will not
have htc header). In the current design, htc layer callback
Hi Dave,
here's one more pull request for 4.3. More info in the signed tag below.
This time I had to merge mac80211-next.git due to some iwlwifi
dependencies and apparently that broke git-request-pull's diffstat
again, it was showing changes which were not really coming from my tree.
I think
Kernel would complain about leaving a held lock
after going back to userspace and would
subsequently deadlock.
Fixes: e04cafbc38c7 (ath10k: fix peer limit enforcement)
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Michal Kazior michal.kaz...@tieto.com
---
To enable/configure spectral scan parameters in 10.4 firmware, existing
wmi spectral related functions can be reused. Link those functions in
10.4 wmi ops table.
In addition, adjust bin size (only when size is 68 bytes) before reporting
bin samples to user space. The background for this
This patch removes multiple blank lines.
CHECK: Please don't use multiple blank lines
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
This patch replaces WILC_MsgQueueSend with wilc_mq_send to
shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 98 +++
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
This patch removes blank line before a close brace }
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 1 -
1 file changed, 1 deletion(-)
diff --git
This patch replaces WILC_ErrNo with int type.
WILC_ErrNo typedef is also removed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_errorsupport.h | 2 --
drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++--
drivers/staging/wilc1000/wilc_msgqueue.h
This patch remove unnecessary parentheses found by checkpatch.pl
CHECK: Unnecessary parentheses around pHandle-hSem
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch removes kfree NULL check.
WARNING: kfree(NULL) is safe and this check is probably not required.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
This patch changes bool comparison style found by checkpatch.pl
CHECK: Using comparison to true is error prone
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch uses ! operator instead of NULL comparison.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
This patch removes braces for single statement blocks.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
This patch replaces WILC_MsgQueueRecv with wilc_mq_recv
to shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
This patch replaces WILC_MsgQueueDestroy to wilc_mq_destroy to
shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
This patch removes a blank line for open brace {
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 2 --
1 file changed, 2 deletions(-)
diff --git
From: Miaoqing Pan miaoq...@qca.qualcomm.com
When rx stopped, AR_RX_FILTER should be cleared, but in
ath9k_hw_setrxfilter(), ATH9K_RX_FILTER_CONTROL_WRAPPER will always
be set for ar9462/ar9565.
Fix this by moving the code in ath9k_hw_setrxfilter() to
ath_calcrxfilter().
Signed-off-by: Miaoqing
From: Miaoqing Pan miaoq...@qca.qualcomm.com
One stuck issue was found on AP152, the root cause is using wrong
calibration initial function.
Signed-off-by: Miaoqing Pan miaoq...@qca.qualcomm.com
---
drivers/net/wireless/ath/ath9k/ar9003_calib.c | 6 --
1 file changed, 4 insertions(+), 2
Real ID value means the value mapped to an alive NIC handler.
Who is mapping it? It's all within the driver so it is not real
unless there external requirements.
And when the driver transmits and receives some data frame with chipset,
the ID is used to distinguish the data frame's owner.
From: Johannes Berg johannes.b...@intel.com
This reduces code size slightly (at least on x86/64) while also
removing memory consumption by two unsigned long values for each
ath5k device.
Signed-off-by: Johannes Berg johannes.b...@intel.com
---
drivers/net/wireless/ath/ath5k/Kconfig | 1 -
Since there's very little benefit of the out-of-line implementation
(a single byte of .text in one driver as far as I've seen), convert
all drivers to the inline implementation, saving memory, and remove
the out-of-line implementation.
Perhaps the easiest would be for Dave to take all of these
From: Johannes Berg johannes.b...@intel.com
Instead of using the out-of-line EWMA calculation, use DECLARE_EWMA()
to create static inlines. On x86/64 this results in code that's one
byte larger (for me), but reduces struct link_ant and struct link
size by the two unsigned long values that store
From: Johannes Berg johannes.b...@intel.com
Instead of using the out-of-line EWMA calculation, use DECLARE_EWMA()
to create static inlines. On x86/64 this results in no change in code
size for me, but reduces the struct receive_queue size by the two
unsigned long values that store the parameters.
From: Johannes Berg johannes.b...@intel.com
Since all users are now converted to the inline implementation,
remove the out-of-line implementation entirely.
Signed-off-by: Johannes Berg johannes.b...@intel.com
---
include/linux/average.h | 24 ---
lib/Kconfig | 10
Hello Dan.
On 2015년 08월 18일 18:12, Dan Carpenter wrote:
On Tue, Aug 18, 2015 at 12:10:53PM +0900, Johnny Kim wrote:
Hello Dan.
On 2015년 08월 13일 23:49, Dan Carpenter wrote:
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote:
+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler)
+{
+
miaoq...@qti.qualcomm.com wrote:
- if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah))
+ if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah) ||
+ AR_SREV_9561(ah))
priv_ops-init_cal = ar9003_hw_init_cal_pcoem;
else
78 matches
Mail list logo
