[PATCH] staging: rtl8723au: use proper typecast in assignment

2015-12-14 Thread Anatoly Stepanov
This resolves the following Sparse warning: "incorrect type in assignment (different base types)" Signed-off-by: Anatoly Stepanov --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] wcn36xx: handle rx skb allocation failure to avoid system crash

2015-12-14 Thread fengwei.yin
On 2015/12/15 6:47, Julian Calaby wrote: Hi Fengwei, On Mon, Dec 14, 2015 at 9:06 PM, Fengwei Yin wrote: Lawrence reported that git clone could make system crash on a Qualcomm ARM soc based device (DragonBoard, 1G memory without swap) running 64bit Debian. It's

Re: [PATCH v2] wcn36xx: handle rx skb allocation failure to avoid system crash

2015-12-14 Thread Bjorn Andersson
On Mon 14 Dec 02:06 PST 2015, Fengwei Yin wrote: > Lawrence reported that git clone could make system crash on a > Qualcomm ARM soc based device (DragonBoard, 1G memory without > swap) running 64bit Debian. > > It's turned out the crash is related with rx skb allocation > failure. git could

Re: [PATCH v2] wcn36xx: handle rx skb allocation failure to avoid system crash

2015-12-14 Thread fengwei.yin
Hi Bjorn, On 2015/12/15 8:20, Bjorn Andersson wrote: On Mon 14 Dec 02:06 PST 2015, Fengwei Yin wrote: Lawrence reported that git clone could make system crash on a Qualcomm ARM soc based device (DragonBoard, 1G memory without swap) running 64bit Debian. It's turned out the crash is related

Re: [PATCH] ath10k: allow Mesh Point to install peer security key

2015-12-14 Thread Kalle Valo
Peter Oh writes: > Mesh Point requires peer security key install when running > in secured mode since it's a type of peer links, otherwise peer > link will be removed due to key install failure. > > MFP feature set is required to run Mesh in secured mode and > QCA988X

Re: [PATCH 000/182] Rid struct gpio_chip from container_of() usage

2015-12-14 Thread Johan Hovold
On Wed, Dec 09, 2015 at 03:46:00PM +0100, Linus Walleij wrote: > On Wed, Dec 9, 2015 at 2:44 PM, Russell King - ARM Linux > wrote: > > On Wed, Dec 09, 2015 at 02:08:35PM +0100, Linus Walleij wrote: > >> Because we want to have a proper userspace ABI for GPIO chips, > >>

[PATCH 01/14] mwifiex: change ap and station interface limits

2015-12-14 Thread Amitkumar Karwar
From: Shengzhen Li ap/station interface limit has been changed to allow creating maximum 3 interfaces. Signed-off-by: Shengzhen Li Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 8 +++- 1 file

[PATCH 13/14] mwifiex: use world for unidentified region code

2015-12-14 Thread Amitkumar Karwar
It's better to use world if region code from EEPROM is unidentied instead of forcing it to FCC Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 11/14] mwifiex: fix wake on disconnect feature

2015-12-14 Thread Amitkumar Karwar
From: chunfan chen Default gpio and gap is downloaded to firmware while configuring host sleep for wake on disconnect. We may have gpio and gap modified by user. This patch fixes the problem. Signed-off-by: chunfan chen Signed-off-by: Amitkumar Karwar

Re: [PATCH 00/14] mwifiex fixes

2015-12-14 Thread Johannes Berg
On Mon, 2015-12-14 at 04:15 -0800, Amitkumar Karwar wrote: > These patches include few fixes for mwifiex and add a > debugfs file for chip reset. > A lot of these "fixes" look like new firmware features to me (e.g. interface limits, sms4 cipher, pattern length). First of all - is that really

Re: iwlwifi A-MSDU tx

2015-12-14 Thread Emmanuel Grumbach
On Sat, Dec 12, 2015 at 10:54 PM, Emmanuel Grumbach wrote: > On Fri, Dec 11, 2015 at 10:02 PM, Stefan Sperling wrote: >> Hi Emmanuel, >> >> Thanks a bunch, this worked out quite well for me. >> I got what I was aiming for out of this already but I still

[PATCH 14/14] mwifiex: fix WPA connection problem

2015-12-14 Thread Amitkumar Karwar
From: chunfan chen Device fails to connect to some AP's configured in WPA security mode. Currently IE buffer parsing logic in driver expects WPA IE to be present at the beginning of IE buffer. Otherwise connection is failed with 'incompatible network setting' error. This

[PATCH 10/14] mwifiex: fix AMPDU not setup on TDLS link problem

2015-12-14 Thread Amitkumar Karwar
Sometimes AP sends TDLS setup response as AMSDU packet. As driver doesn't parse it and update peer station's 11n capability in this case, AMPDU doesn't get setup. This patch calls mwifiex_process_tdls_action_frame() in AMSDU Rx path to fix the problem. Signed-off-by: Amitkumar Karwar

[PATCH 12/14] mwifiex: update region_code_index array

2015-12-14 Thread Amitkumar Karwar
This array contains list of supported region codes. It is changed to make it aligned with region code to country mapping table in driver. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +- drivers/net/wireless/marvell/mwifiex/main.h | 2

[PATCH 02/14] mwifiex: multiple bss support

2015-12-14 Thread Amitkumar Karwar
From: Shengzhen Li This patch fixes issues observed while starting 3 different bss simultaneously, eg, 2 AP + 1 STA or 3 AP Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 20

[PATCH 04/14] mwifiex: fix bug for wildcard-prefix wowlan pattern

2015-12-14 Thread Amitkumar Karwar
From: Xinming Hu Wildcard prefix bytes are ignored while downloading packet pattern to firmware. As packet offset is not adjusted accordingly firmware end up matching the pattern at wrong offset. The packet offset is corrected in this patch. Signed-off-by: Xinming Hu

[PATCH 09/14] mwifiex: add debugfs file for testing reset of card

2015-12-14 Thread Amitkumar Karwar
This provides an option for user to power cycle the card. It will be used to change the firmware without actually rebooting the system. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 30 ++ 1 file changed, 30

[PATCH 07/14] mwifiex: suppress "Rx of mgmt packet failed" message

2015-12-14 Thread Amitkumar Karwar
Block ACK action frames are dropped in driver. This error is expected in this case. Let's lower the priority of this message. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/sta_rx.c | 2 +- drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 3 +--

[PATCH 05/14] mwifiex: increase supported wowlan pattern length

2015-12-14 Thread Amitkumar Karwar
From: Xinming Hu Maximum supported wowlan pattern length has been increased from 20 to 40. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/fw.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH 00/14] mwifiex fixes

2015-12-14 Thread Amitkumar Karwar
These patches include few fixes for mwifiex and add a debugfs file for chip reset. Amitkumar Karwar (6): mwifiex: suppress "Rx of mgmt packet failed" message mwifiex: remove redundant timestamp assignment mwifiex: add debugfs file for testing reset of card mwifiex: fix AMPDU not setup on

[PATCH 06/14] mwifiex: abort cac in del_station() handler

2015-12-14 Thread Amitkumar Karwar
From: Xinming Hu When hostapd is killed with Ctrl+C before cac get completed, stop_ap handler will not be called, thus priv->wdev.cac_started flag remains set. Hostapd restart attempt will be failed in this case with device busy error. This patch aborts cac in del_station

[PATCH 08/14] mwifiex: remove redundant timestamp assignment

2015-12-14 Thread Amitkumar Karwar
During AMSDU aggregation, we are already using timestamp value of a first packet being aggregated. This patch removes redundant ktime_get_real() call. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/11n_aggr.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread Emmanuel Grumbach
Hi, I was interested in the checking the A-MSDU implementation only, so I reviewed only that. I am not sure I really followed your implementation though. In iwlwifi I chose the LSO mechanism to implement A-MSDU. I understand that for an AP it makes less sense since you don't really have locally

RE: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread David Lin
> Emmanuel Grumbach [mailto:egrumb...@gmail.com] wrote: > > Hi, > > I was interested in the checking the A-MSDU implementation only, so I > reviewed only that. > > I am not sure I really followed your implementation though. > In iwlwifi I chose the LSO mechanism to implement A-MSDU. I

RE: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread David Lin
> Kalle Valo [mailto:kv...@codeaurora.org] wrote: > > David Lin writes: > > > On November 26, 2015 5:40 PM, Johannes Berg wrote: > >> On Thu, 2015-11-26 at 08:27 +, David Lin wrote: > >> > >> > > > +#ifdef CONFIG_SUPPORT_MFG > >> > > > >> > > This Kconfig variable doesn't

RE: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread David Lin
> Kan Yan writes: > > David Lin writes: > > > +static inline struct sk_buff *mwl_tx_do_amsdu(struct mwl_priv *priv, > > + int desc_num, > > ... > > + amsdu_pkts = (struct sk_buff_head *) > > +

Re: [PATCH 000/182] Rid struct gpio_chip from container_of() usage

2015-12-14 Thread Dmitry Torokhov
On Mon, Dec 14, 2015 at 1:18 AM, Linus Walleij wrote: > On Wed, Dec 9, 2015 at 8:30 PM, Dmitry Torokhov > wrote: >> On Wed, Dec 09, 2015 at 02:08:35PM +0100, Linus Walleij wrote: >>> This removes the use of container_of() constructions from

RE: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread David Lin
> Kalle Valo [mailto:kv...@codeaurora.org] wrote: > > David Lin writes: > > > This patch provides the mwlwifi driver for Marvell 8863, 8864 and 8897 > > chipsets. > > This driver was developed as part of the openwrt.org project to > > support Linksys WRT1900AC and is

SUPPORTS_CLONED_SKBS question

2015-12-14 Thread Janusz Dziedzic
Hello Johannes, During ath9k test we found a performance problem in TCP TX direction. Seems a lot of time we spent in memcpy() and this is because ath9k don't set SUPPORTS_CLONED_SKBS, and next pskb_expand_head() is called for every TCP frame. Base of SUPPORTS_CLONED_SKBS description, we can set

RE: [PATCH 00/14] mwifiex fixes

2015-12-14 Thread Amitkumar Karwar
> From: Johannes Berg [mailto:johan...@sipsolutions.net] > Sent: Monday, December 14, 2015 5:53 PM > To: Amitkumar Karwar; linux-wireless@vger.kernel.org > Cc: Cathy Luo; Nishant Sarmukadam > Subject: Re: [PATCH 00/14] mwifiex fixes > > On Mon, 2015-12-14 at 04:15 -0800, Amitkumar Karwar wrote: >

[PATCH] mac80211: avoid ROC during hw restart

2015-12-14 Thread Emmanuel Grumbach
From: Eliad Peller Defer ROC requests during hw restart, as the driver might not be fully configured in this stage (e.g. channel contexts were not added yet) Signed-off-by: Eliad Peller Signed-off-by: Emmanuel Grumbach

[PATCH 7/7] brcmfmac: introduce module parameter to force successful probe

2015-12-14 Thread Arend van Spriel
The module parameter can be used to ensure the probe succeeds thus claiming the device and allowing post-mortem debugging in case of firmware crash. It is only available when select CONFIG_BRCMDBG. Reviewed-by: Hante Meuleman Reviewed-by: Franky (Zhenhui) Lin

[PATCH 6/7] brcmfmac: Move all module parameters to one place

2015-12-14 Thread Arend van Spriel
From: Hante Meuleman Module parameters are defined in several files. Move them in one place and make them device specific or global. This makes it easier to override device specific settings by external data like platform data in the future. Reviewed-by: Arend Van Spriel

[PATCH 3/7] brcmfmac: Add support for scheduled scan mac randomization

2015-12-14 Thread Arend van Spriel
From: Hante Meuleman Scheduled scan be requested to use mac randomization. This patch checks the flags and enables the randomization if desired. Reviewed-by: Arend Van Spriel Reviewed-by: Franky (Zhenhui) Lin Reviewed-by:

[PATCH 2/7] brcmfmac: Add get_station support for IBSS

2015-12-14 Thread Arend van Spriel
From: Hante Meuleman When get_station is requested for IBSS then an error will be printed and no information will be returned. This patch adds IBSS specific get station information function. Reviewed-by: Arend Van Spriel Reviewed-by: Pieter-Paul

[PATCH 5/7] brcmfmac: Fix warn trace on module unload while in ibss mode

2015-12-14 Thread Arend van Spriel
From: Hante Meuleman When the driver is being unloaded a situation can occur where the wirelesss core (cfg80211) wants to remove the ibss, but the state of brcmfmac has already been set to down. When an error is returned in that situation then that will result in a stack

[PATCH 4/7] brcmfmac: obtain feature info using 'cap' firmware command

2015-12-14 Thread Arend van Spriel
Several features in the driver directly map to a firmware feature listed in response of the 'cap' firmware command. For those features this response will be examined instead of attempting individual firmware commands. Reviewed-by: Hante Meuleman Reviewed-by: Franky

[PATCH] mtd: nand: bcm47xxnflash: fix bcm47xxnflash_remove()

2015-12-14 Thread Boris Brezillon
bcm47xxnflash_remove() is supposed to unregister the NAND device previously registered in bcm47xxnflash_probe(), but the current implementation just test for the always NULL ->mtd platform data field (and does not call the right function to unregister it). Kill the useless ->mtd field in struct

[ANN] wireless-regdb: master-2015-12-14

2015-12-14 Thread Seth Forshee
A new release of wireless-regdb (master-2015-12-14) is available at: https://www.kernel.org/pub/software/network/wireless-regdb/wireless-regdb-2015.12.14.tar.gz The short log of changes since the 2015-10-22 release is below. Thanks, Seth --- Anssi Hannula (1): wireless-regdb: Update

Re: [PATCH] mtd: nand: bcm47xxnflash: fix bcm47xxnflash_remove()

2015-12-14 Thread Brian Norris
On Mon, Dec 14, 2015 at 06:14:10PM +0100, Boris Brezillon wrote: > bcm47xxnflash_remove() is supposed to unregister the NAND device previously > registered in bcm47xxnflash_probe(), but the current implementation just > test for the always NULL ->mtd platform data field (and does not call the >

Re: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread Kan Yan
David Lin writes: > +static inline struct sk_buff *mwl_tx_do_amsdu(struct mwl_priv *priv, > + int desc_num, > ... > + amsdu_pkts = (struct sk_buff_head *) > + kmalloc(sizeof(*amsdu_pkts), GFP_KERNEL); > +

[ANNOUNCE] Another round of NetDev 1.1 updates

2015-12-14 Thread Pablo Neira Ayuso
Hi! We would like to share with you another round of incremental updates on accepted sessions in netdev 1.1, the community-driven Linux networking conference held back-to-back with netconf in Sevilla, Spain, February 10-12, 2016. = Keynote = * "Hardware Checksumming: Less is More" (David S.

Re: [PATCH v7] Add new mac80211 driver mwlwifi.

2015-12-14 Thread Kalle Valo
Grant Grundler writes: > Sorry for the late response...just one point below > > On Fri, Nov 20, 2015 at 3:22 AM, Johannes Berg > wrote: > > > +#define MWL_DRV_NAME KBUILD_MODNAME > > +#define MWL_DRV_VERSION       "10.3.0.14" > >

Re: [PATCH] mtd: bcm47xxnflash: really unregister NAND on device removal

2015-12-14 Thread Boris Brezillon
On Tue, 8 Dec 2015 17:04:59 -0800 Brian Norris wrote: > The field bcma_nflash::mtd is never set to be non-zero anywhere, but we > test for it in the removal path. So the MTD is never unregistered. > > Also, we should use nand_release(), not mtd_device_unregister().

Re: [PATCH] mtd: bcm47xxnflash: really unregister NAND on device removal

2015-12-14 Thread Brian Norris
On Mon, Dec 14, 2015 at 06:49:07PM +0100, Boris Brezillon wrote: > On Tue, 8 Dec 2015 17:04:59 -0800 > Brian Norris wrote: > > > The field bcma_nflash::mtd is never set to be non-zero anywhere, but we > > test for it in the removal path. So the MTD is never

Re: [PATCH] mtd: nand: bcm47xxnflash: fix bcm47xxnflash_remove()

2015-12-14 Thread Boris Brezillon
Hi Brian, On Mon, 14 Dec 2015 09:30:11 -0800 Brian Norris wrote: > On Mon, Dec 14, 2015 at 06:14:10PM +0100, Boris Brezillon wrote: > > bcm47xxnflash_remove() is supposed to unregister the NAND device previously > > registered in bcm47xxnflash_probe(), but the

[PATCH 0/8] Fixes for module parameters

2015-12-14 Thread Larry Finger
To: kv...@codeaurora.org Cc: linux-wireless@vger.kernel.org de...@driverdev.osuosl.org Several of the rtlwifi-driver family have errors in the handling of module parameters. These 8 patches for the -next repo contain fixes. Signed-off-by: Larry Finger Larry

[PATCH 7/8] rtlwifi: rtl8192ce: Fix handling of module parameters

2015-12-14 Thread Larry Finger
The module parameter for software encryption was never transferred to the location used by the driver. Signed-off-by: Larry Finger Cc: Stable --- drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 4/8] rtlwifi: rtl8188ee: Fix module parameter initialization

2015-12-14 Thread Larry Finger
In this driver, parameters disable_watchdog and sw_crypto are never copied into the locations used in the main code. While modifying the parameter handling, the copying of parameter msi_support is moved to be with the rest. Signed-off-by: Larry Finger Cc: Stable

[PATCH 5/8] rtlwifi: rtl8192de: Fix incorrect module parameter descriptions

2015-12-14 Thread Larry Finger
Two of the module parameters are listed with incorrect default values. Signed-off-by: Larry Finger Cc: Stable --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/8] rtlwifi: rtl8723ae: Fix initialization of module parameters

2015-12-14 Thread Larry Finger
This driver has some errors in the handling of module parameters. These include missing initialization for parameters msi_support and disable_watchdog. In addition, neither of these parameters nor sw_crypto are transferred into the locations used by the driver. A final fix is adding parameter msi

[PATCH 1/8] rtlwifi: rtl8723be: Fix module parameter initialization

2015-12-14 Thread Larry Finger
This driver has a number of errors in the module initialization. These include the following: Parameter msi_support is stored in two places - one is removed. Paramters sw_crypto and disable_watchdog were never stored in the final locations, nor were they initialized properly. Signed-off-by:

[PATCH 3/8] rtlwifi: rtl8821ae: Fix errors in parameter initialization

2015-12-14 Thread Larry Finger
This driver failed to copy parameters sw_crypto and disable_watchdog into the locations actually used by the driver. In addition, msi_support was initialized three times and one of them used the wrong variable. The initialization of parameter int_clear was moved so that it is near that of the rest

[PATCH 8/8] rtlwifi: rtl8192cu: Add missing parameter setup

2015-12-14 Thread Larry Finger
This driver fails to copy the module parameter for software encryption to the locations used by the main code. Signed-off-by: Larry Finger Cc: Stable --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 ++ 1 file changed, 2

[PATCH 6/8] rtlwifi: rtl8192se: Fix module parameter initialization

2015-12-14 Thread Larry Finger
Two of the module parameter descriptions show incorrect default values. In addition the value for software encryption is not transferred to the locations used by the driver. Signed-off-by: Larry Finger Cc: Stable ---

Re: iwlwifi - L1 Enabled - LTR Enabled loop

2015-12-14 Thread Johannes Berg
On Mon, 2015-12-14 at 04:00 +, Grumbach, Emmanuel wrote: >  > This is really weird. I don't see how that could be firmware related. > BTW, -10.ucode is fairly old :) we have -16.ucode out there. I guess the question is how we get into this situation to start with? About the only thing I can

Re: [PATCH v2] wcn36xx: handle rx skb allocation failure to avoid system crash

2015-12-14 Thread Julian Calaby
Hi Fengwei, On Mon, Dec 14, 2015 at 9:06 PM, Fengwei Yin wrote: > Lawrence reported that git clone could make system crash on a > Qualcomm ARM soc based device (DragonBoard, 1G memory without > swap) running 64bit Debian. > > It's turned out the crash is related with rx