Re: [PATCH 2/3] mwifiex: using general print function during device intialization

2017-04-04 Thread Xinming Hu
> -Original Message- > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: 2017年4月4日 2:42 > To: Dmitry Torokhov > Cc: Xinming Hu; Linux Wireless; Kalle Valo; Rajat Jain; Amitkumar Karwar; > Cathy > Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 2/3] mwifiex: using general print func

RE: Re: [PATCH 1/3] mwifiex: remove unnecessary wakeup interrupt number sanity check

2017-04-04 Thread Xinming Hu
Hi Brain, > -Original Message- > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: 2017年4月4日 2:34 > To: Dmitry Torokhov > Cc: Xinming Hu; Linux Wireless; Kalle Valo; Rajat Jain; Amitkumar Karwar; > Cathy > Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 1/3] mwifiex: remove unneces

RE: [EXT] Re: [PATCH 1/3] mwifiex: remove unnecessary wakeup interrupt number sanity check

2017-04-04 Thread Xinming Hu
Hi Dmitry, > -Original Message- > From: Dmitry Torokhov [mailto:d...@chromium.org] > Sent: 2017年4月1日 6:37 > To: Xinming Hu > Cc: Linux Wireless; Kalle Valo; Brian Norris; Rajat Jain; Amitkumar Karwar; > Cathy Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 1/3] mwifiex: remove unnecessary wake

Re: pull-request: wireless-drivers-next 2017-04-03

2017-04-04 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Tue, 04 Apr 2017 20:48:35 +0300 > >> David Miller writes: >> >>> From: Kalle Valo >>> Date: Mon, 03 Apr 2017 14:26:10 +0300 >>> here few really small fixes. I'm hoping this to be the last pull request for 4.11. Please let me

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Tobin C. Harding
On Tue, Apr 04, 2017 at 11:31:14PM +0200, Arend Van Spriel wrote: > >> On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > >>> "Tobin C. Harding" writes: > >>> > Except one: do you know off the top of your head of a canonical > implementation of a softmac wi-fi driver. > >>> > >>> I'll su

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-04-04 Thread Larry Finger
On 04/04/2017 04:53 PM, Hans de Goede wrote: Hi, On 04/04/2017 11:38 PM, Arend Van Spriel wrote: On 4-4-2017 20:53, Hans de Goede wrote: Hi, On 04/04/2017 08:31 PM, Larry Finger wrote: On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-04-04 Thread Hans de Goede
Hi, On 04/04/2017 11:38 PM, Arend Van Spriel wrote: On 4-4-2017 20:53, Hans de Goede wrote: Hi, On 04/04/2017 08:31 PM, Larry Finger wrote: On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux users, such as on Atom systems (Intel Compute

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-04-04 Thread Arend Van Spriel
On 4-4-2017 20:53, Hans de Goede wrote: > Hi, > > On 04/04/2017 08:31 PM, Larry Finger wrote: >> On 03/29/2017 12:47 PM, Hans de Goede wrote: >>> The rtl8723bs is found on quite a few systems used by Linux users, >>> such as on Atom systems (Intel Computestick and various other >>> Atom based de

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Arend Van Spriel
On 3-4-2017 23:39, Tobin C. Harding wrote: > On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: >> seems we are missing out again? > > Sorry, I don't understand what this comment means? My bad. I had to reset my email account in thunderbird and now it needs to learn anew what is

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-04-04 Thread Larry Finger
On 04/04/2017 01:53 PM, Hans de Goede wrote: Hi, On 04/04/2017 08:31 PM, Larry Finger wrote: On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux users, such as on Atom systems (Intel Computestick and various other Atom based devices) and on

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-04-04 Thread Hans de Goede
Hi, On 04/04/2017 08:31 PM, Larry Finger wrote: On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux users, such as on Atom systems (Intel Computestick and various other Atom based devices) and on many (budget) ARM boards such as the CHIP. Th

Re: pull-request: wireless-drivers-next 2017-04-03

2017-04-04 Thread David Miller
From: Kalle Valo Date: Tue, 04 Apr 2017 20:48:35 +0300 > David Miller writes: > >> From: Kalle Valo >> Date: Mon, 03 Apr 2017 14:26:10 +0300 >> >>> here few really small fixes. I'm hoping this to be the last pull request >>> for 4.11. >>> >>> Please let me if there are any problems. >> >> Pul

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-04-04 Thread Larry Finger
On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux users, such as on Atom systems (Intel Computestick and various other Atom based devices) and on many (budget) ARM boards such as the CHIP. The plan moving forward with this is for the new cle

Re: pull-request: wireless-drivers-next 2017-04-03

2017-04-04 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Mon, 03 Apr 2017 14:26:10 +0300 > >> here few really small fixes. I'm hoping this to be the last pull request >> for 4.11. >> >> Please let me if there are any problems. > > Pulled, thanks. > > But I will warn you, you say fixes, but your Subject

Re: pull-request: wireless-drivers-next 2017-04-03

2017-04-04 Thread David Miller
From: Kalle Valo Date: Mon, 03 Apr 2017 14:26:10 +0300 > here few really small fixes. I'm hoping this to be the last pull request > for 4.11. > > Please let me if there are any problems. Pulled, thanks. But I will warn you, you say fixes, but your Subject line and GIT tag says "-next" so I pul

[PATCH 11/13] rtlwifi: btcoex: 23b 2ant: turn off ps and tdma mechanism when in concurrent mode

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang When wifi is in concurrent mode, we can not distinguish if it is the real PS or just a fake one by sending null data, so we turn it off in case of miracast scenario. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc:

[PATCH 10/13] rtlwifi: btcoex: 23b 2ant: let bt transmit when hw initialisation done

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang During hw initialisation, wifi may be ready after bt has already been ready, which causes bt to act abnormally. To avoid this, set GNT_BT to high during hw init. Signed-off-by: Yan-Hsuan Chuang Cc: Stable Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- ..

[PATCH 08/13] rtlwifi: btcoex: 23b 2ant: workaround for bt a2dp and hid

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang For a2dp and hid, we need extra process to avoid voice degradation Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 2 ++ 1 file

[PATCH 12/13] rtlwifi: btcoex: 23b 2ant: turn off antenna when rssi is too high/low

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang For 2-antenna combo card, the signal of the neighbor antenna could be over noise level and cause be severe interference. So we monitor the rssi and turn off one of the antennas when the other is transmitting and the rssi level is beyond a threshold. Signed-off-by: Yan-Hsua

[PATCH 06/13] rtlwifi: btcoex: 23b 2ant: add pnp notidy to avoid LPS/IPS mismatch

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang When driver is going to sleep, it does not leave LPS/IPS, thus the BTCoex may have mismatch when driver wakes up. To avoid that, BTCoex needs to clear the IPS/LPS state when it receives a pnp notify, then it can properly set up the hw when driver wakes up. Signed-off-by: Y

[PATCH 13/13] rtlwifi: btcoex: 23b 2ant: set coex table when wifi is linking

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang When wifi is under linking process, those packets are important. Mark them as high priority to protect the linking process Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- .../realtek/rtlwifi/btco

[PATCH 05/13] rtlwifi: btcoex: 23b 2ant: fix PTA unstable problem when hw init

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang In the hardware initialisation stage, the PTA circuits may be unstable, so we reset it after 6 secs to fix the problem. Signed-off-by: Yan-Hsuan Chuang Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c| 41

[PATCH 09/13] rtlwifi: btcoex: 23b 2ant: tell fw if external or internal switch is used

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang Some chips use an external antenna switch, but fw may not realize it. Here we tell fw exactly that which type of switch we are using. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- .../wireless/

[PATCH 07/13] rtlwifi: btcoex: 23b 2ant: check more cases when bt is queuing

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang If bt is queing, we need to set the packet priority properly. Originally we only consider if wifi was connected or not, but now we also consider if bt is under abnormal scan or wifi is scanning, roaming or linking, and set the coex table. Signed-off-by: Yan-Hsuan Chuang S

[PATCH 03/13] rtlwifi: btcoex: 23b 2ant: detect ap num and set GNT_BT properly

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang If ap num < 10, let wifi and bt transmit simultaneously, otherwise set wifi into standy when bt is transmitting Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- .../wireless/realtek/rtlwifi/btcoex

[PATCH 02/13] rtlwifi: btcoex: 23b 2ant: rename tdma_adj_type to ps_tdma_du_adj_type

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang The variable is for PS tdma duration adjust, so rename it to clearly to specify its usage. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c| 30

[PATCH 01/13] rtlwifi: btcoex: 23b 2ant: check PS state before setting tdma duration

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang For time division multiple access, the wifi and bt take turns to transmit, but we need to let AP know that wifi is under standby mode by sending null data to "pretend" entering power saving state using lps rpwm. But, the fw does not know if it is the actual power saving mo

[PATCH 04/13] rtlwifi: btcoex: 23b 2ant: more cases for adjusting tdma duration

2017-04-04 Thread Larry Finger
From: Yan-Hsuan Chuang These cases are for the btcoex to tune the performance Signed-off-by: Yan-Hsuan Chuang Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c| 766 + 1 file changed, 766 insertions(+) diff -

[PATCH] ath10k: Fix compile time sanity check for CE4 buffer size

2017-04-04 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan In 'ath10k_ce_alloc_pipe' the compile time sanity check to ensure that there is sufficient buffers in CE4 for HTT Tx MSDU descriptors, but this did not take into account of the case with 'peer flow control' enabled, fix this. Cc: Michal Kazior Signed-off-by: Moham

[PATCH 00/13] rtlwifi: btcoex: More improvements to Bluetooth Coexistence for 23b

2017-04-04 Thread Larry Finger
This set of patches, which should be applied after the 12 patches submitted with cover title "rtlwifi: btcoex: Improve Bluetooth coexistence", offers more updates to driver btcoex for the RTL8723BE device. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu

Re: [PATCH v2 1/5] NFC: st21nfca: Fix obvious typo when check error code

2017-04-04 Thread Andy Shevchenko
On Tue, 2017-03-07 at 12:25 +0200, Andy Shevchenko wrote: > We return -ENODEV if ACPI provides a GPIO resource. Looks really > wrong. > If it has even been tested? Samuel, Christophe, anything I have to address? > > Signed-off-by: Andy Shevchenko > --- >  drivers/nfc/st21nfca/i2c.c | 4 ++-- >  

Re: [PATCH v3 1/5] NFC: pn544: Get rid of platform data

2017-04-04 Thread Andy Shevchenko
On Tue, 2017-03-28 at 12:36 +0300, Andy Shevchenko wrote: > Legacy platform data must go away. We are on the safe side here since > there are no users of it in the kernel. > > If anyone by any odd reason needs it the GPIO lookup tables and > built-in device properties at your service. > Samuel,

RE: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

2017-04-04 Thread Reshetova, Elena
> Elena Reshetova writes: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > > > Signed-off-by: Ele

Re: [PATCH 1/2] Documentation/sphinx: kerneldoc: add "unused-functions"

2017-04-04 Thread Jani Nikula
On Mon, 03 Apr 2017, Johannes Berg wrote: > On Fri, 2017-03-31 at 15:54 +0300, Jani Nikula wrote: >> >> I'm sure the parameter name could be improved to capture what you >> mean better; alas I don't have a suggestion. > > Yes, that's a fair point - perhaps "functions-not-linked" or something > li