Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id

2017-05-17 Thread Kalle Valo
Tom Gaudasiński writes: > Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device > contains a Ralink RT3071L, registers as vendor Accton/Arcadyan. > > Signed-off-by: Tom Gaudasinski The prefix should be "rt2x00:". >

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

2017-05-17 Thread Bjorn Andersson
On Wed 17 May 06:14 PDT 2017, Johannes Berg wrote: > On Thu, 2017-05-04 at 13:13 +, Kalle Valo wrote: > > > > > > This code intentionally checked if TX status was requested, and > > > > if not then it doesn't go to the effort of building it. > > > > > > > > > > What I'm finding puzzling is

Re: [net-realtek-btcoexist] question about identical code for different branches

2017-05-17 Thread Larry Finger
On 05/17/2017 04:52 PM, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1362263 I ran into the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1000: 1000void exhalbtc_set_ant_num(struct rtl_priv *rtlpriv, u8 type, u8

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Bjorn Andersson
On Wed 17 May 05:53 PDT 2017, Pali Roh?r wrote: > On Wednesday 17 May 2017 14:06:06 Johannes Berg wrote: > > On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > > > Now for N900 case there is a similar scenario > > > > > alhtough it has additional requirement to go to user-space due

[net-realtek-btcoexist] question about identical code for different branches

2017-05-17 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1362263 I ran into the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1000: 1000void exhalbtc_set_ant_num(struct rtl_priv *rtlpriv, u8 type, u8 ant_num) 1001{ 1002if (BT_COEX_ANT_TYPE_PG ==

Re: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

2017-05-17 Thread Michael Büsch
On Wed, 17 May 2017 18:22:49 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 May 2017 18:12:16 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by

[PATCH] staging: wilc1000: Delete an error message for a failed memory allocation in Handle_Key()

2017-05-17 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 17 May 2017 22:26:07 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Bastian Bittorf
* Johannes Berg [17.05.2017 20:18]: > On Wed, 2017-05-17 at 12:08 +0200, Bastian Bittorf wrote: > > * Ben Greear [17.05.2017 11:51]: [...] > > > kernels, but when testing on 4.9 overnight, I notice that 'iw > > > events' is not showing any

[PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

2017-05-17 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 17 May 2017 18:12:16 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Ben Greear
On 05/17/2017 06:30 AM, Johannes Berg wrote: On Wed, 2017-05-17 at 12:08 +0200, Bastian Bittorf wrote: * Ben Greear [17.05.2017 11:51]: I have been keeping an 'iw events' program running with a perl script gathering its output and post-processing it. This has been

[PATCH v2 03/10] rt2x00: convert rt2x00_rf_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00_rf_read() to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \

[PATCH v2 02/10] rt2x00: convert rt2800_rfcsr_read return type

2017-05-17 Thread Arnd Bergmann
With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high stack usage (with a private patch set I have to turn on this warning, which I intend to get into the next kernel release): wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_bw_filter_calibration':

[PATCH v2 10/10] rt2x00: convert rt2x00_desc_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00_desc_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i

[PATCH v2 05/10] rt2x00: convert rt2x00usb_register_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00usb_register_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i

[PATCH v2 08/10] rt2x00: convert rt2x00_eeprom_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00_eeprom_read() to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:=

[PATCH v2 01/10] rt2x00: change function pointers for register accessors

2017-05-17 Thread Arnd Bergmann
This prepares the driver for changing all the 'read' register accessors to return the value instead of passing it by reference. Since a lot of them are used in callbacks, this takes care of the callbacks first, adding a couple of helpers that will be removed again one at a time. Signed-off-by:

[PATCH v2 04/10] rt2x00: convert rt2x00mmio_register_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2x00mmio_register_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(rt2x00mmio_register_read(.*, .*\), &\(.*\));:\2 = \1);:' \ -i

[PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-17 Thread Arnd Bergmann
I've managed to split up my long patch into a series of reasonble steps now. The first two are required to fix a regression from commit 41977e86c984 ("rt2x00: add support for MT7620"), the rest are just cleanups to have a consistent state across all the register access functions. Arnd

[PATCH v2 06/10] rt2x00: convert rt2800_register_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2800_register_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(rt2800_register_read(.*, .*\), &\(.*\));:\2 = \1);:' \

[PATCH v2 09/10] rt2x00: convert rt2800_eeprom_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change rt2800_eeprom_read to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\3 = \1);:'

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 2:17 PM, Tom Psyborg wrote: > > > On 16 May 2017 at 16:31, Jes Sorensen wrote: >> >> >> True - if the automatic conversion works without automatic intervention, I >> am less worried about it. Personally I would still

[PATCH v2 07/10] rt2x00: convert rt2*_bbp_read return type

2017-05-17 Thread Arnd Bergmann
This is a semi-automated conversion to change *_bbp_read() to return the register contents instead of passing them by value, resulting in much better object code. The majority of the patch was done using: sed -i 's:\(\(.*, .*\), &\(.*\));:\2 = \1);:' \ -i

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

2017-05-17 Thread Johannes Berg
Hi, I think this looks really good. One thing though: > Another change is the > addition of the flag ATTR_WANT_1X_4WAY_HS that user-space has to pass > in CONNECT request. Some drivers may need to be aware before the PMK > is programmed through SET_PMK request. I wonder how we really should do

Re: [PATCH v3] mac80211: Dynamically set CoDel parameters per station

2017-05-17 Thread Johannes Berg
On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote: > CoDel can be too aggressive if a station sends at a very low rate, > leading reduced throughput. This gets worse the more stations are > present, as each station gets more bursty the longer the round-robin > scheduling between

Re: [PATCH v2] mac80211: mesh - always do every discovery retry

2017-05-17 Thread Johannes Berg
On Wed, 2017-03-29 at 18:33 +0800, Chun-Yeow Yeoh wrote: > I would suggest the following modification of commit messages and > code. Let me know whether this is fine. > > - > I would suggest the following edition to the commit message: > > Instead of stopping path discovery when a path

Re: nl80211 vendor commands on upstream drivers

2017-05-17 Thread Johannes Berg
On Fri, 2017-05-12 at 16:51 +0300, Kalle Valo wrote: > > But this does not mean that the gates are open for all possible hacks > via vendor commands, we still want to have generic nl80211 interface > for all normal functionality. Just to give some examples of something > which is NOT acceptable:

Re: iw reg get since iw-4.x

2017-05-17 Thread Johannes Berg
On Fri, 2017-05-12 at 17:11 +0300, Sergey Naumov wrote: > Hi All. > > I see that since iw-4.x "iw reg get" reports multiple region > information - per-phy and global. Moreover, per-phy information could > be marked as "self-managed". That's also dependent on the kernel. > Could somebody clarify

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 12:08 +0200, Bastian Bittorf wrote: > * Ben Greear [17.05.2017 11:51]: > > I have been keeping an 'iw events' program running with a perl > > script gathering its > > output and post-processing it.  This has been working for several > > years on 4.7

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 15:21 +0200, Pali Rohár wrote: > On Wednesday 17 May 2017 15:04:50 Johannes Berg wrote: > > On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > > > > > In fact, why should the *driver* care either? IOW - why should > > > > "request_firmware_prefer_user()" even exist? >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Pali Rohár
On Wednesday 17 May 2017 15:04:50 Johannes Berg wrote: > On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > > > In fact, why should the *driver* care either? IOW - why should > > > "request_firmware_prefer_user()" even exist? > > > > There are default/example NVS data, which are stored in

Re: when to use wdev_lock()

2017-05-17 Thread Johannes Berg
Hi Arend, Sorry for the long delay. > I bumped into use of wdev_lock() again with 802.1X 4-way-hs offload  > stuff. So for .set_pmk() and .del_pmk() it takes wdev_lock(). Is > there a  rule of thumb when this lock is needed. What is it > protecting in general  and in the case of pmk

Re: [PATCH v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets

2017-05-17 Thread Johannes Berg
Good job :) Let's merge this - the tiny fixes for things I found can come later. Some (mostly trivial) comments: * I'm surprised you don't support WEP - nice :) * I don't think returning -EFAULT from qtnf_add_virtual_intf is a good idea - perhaps better propagate the error or use -EIO? *

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Wed, 2017-05-17 at 14:53 +0200, Pali Rohár wrote: > > In fact, why should the *driver* care either? IOW - why should > > "request_firmware_prefer_user()" even exist? > > There are default/example NVS data, which are stored in /lib/firmware > and installed by linux-firmware package. [...] Oh,

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Pali Rohár
On Wednesday 17 May 2017 14:06:06 Johannes Berg wrote: > On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > > Now for N900 case there is a similar scenario > > > > alhtough it has additional requirement to go to user-space due to > > > > need to use a proprietary library to obtain

Re: [PATCH v2] mac80211: strictly check mesh address extension mode

2017-05-17 Thread Johannes Berg
On Sun, 2017-05-14 at 21:41 -0700, Rajkumar Manoharan wrote: > Mesh forwarding path checks for address extension mode to fetch > appropriate proxied address and MPP address. Existing condition > that looks for 6 address format is not strict enough so that > frames with improper values are

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Johannes Berg
On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > Now for N900 case there is a similar scenario > > > alhtough it has additional requirement to go to user-space due to > > > need to use a proprietary library to obtain the NVS calibration > > > data. My thought: Why should

[PATCH] rt2800usb: Add Epson wireless adapter device-id

2017-05-17 Thread Tom Gaudasiński
Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device contains a Ralink RT3071L, registers as vendor Accton/Arcadyan. Signed-off-by: Tom Gaudasinski --- linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c.orig 2017-05-17 19:49:44.893895819

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-17 Thread Bastian Bittorf
* Ben Greear [17.05.2017 11:51]: > I have been keeping an 'iw events' program running with a perl script > gathering its > output and post-processing it. This has been working for several years on > 4.7 and earlier > kernels, but when testing on 4.9 overnight, I notice

Re: [PATCH] [ath10k] go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-17 Thread Sven Eckelmann
On Montag, 1. Mai 2017 14:43:27 CEST Adrian Chadd wrote: > This reverts b057886524be060021e3cfad0ba8458c850330cd in 2015 > which converted this allocation from dma_map_coherent() to > kzalloc() / dma_map_single(). > > The current problem manifests when using later model NICs with larger >

git repo with Redpine changes

2017-05-17 Thread Alexey Brodkin
Hello Amitkumar, Prameela, I was lucky enough to get hold of RS9113 Evaluation Kit and now I'm trying to get it working with my board via USB and SDIO interfaces but seeing issues here and there:  1) In case of SDIO I see this on interface up with vanilla 4.11.1 kernel:

VERIFICA

2017-05-17 Thread ZIMBRA
L'aggiornamento dell'account è in corso, fa parte di esso oggi per un perfetto funzionamento dei conti. CLICCA SULLA LINK SEGUENTE E AGGIORNARE IL TUO CONTO IMMEDIATAMENTE. http://bibankie.tripod.com ZIMBRA WEBMASTER