Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-18 Thread Arnd Bergmann
On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg wrote: > warning: 'rt2800_bbp_read' used but never defined > static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev, >^ > /home/ubuntu/Music/openwrt/build_dir/target-mipsel_24kc_musl-1.1.16/linux-ramips_mt7620/compat-wireless-2016-05-12/dri

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-18 Thread Arnd Bergmann
On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: > Arnd Bergmann writes: > >> I've managed to split up my long patch into a series of reasonble >> steps now. >> >> The first two are required to fix a regression from commit 41977e86c984 >> ("rt2x00: add support for MT7620"), the rest are just cl

Re: Make BCMA a menuconfig to ease disabling it all

2017-05-18 Thread Kalle Valo
Vincent Legoll wrote: > No need to get into the submenu to disable all BCMA-related config entries > > Signed-off-by: Vincent Legoll I would like to get an ack from someone before I'll apply this. Patch set to Deferred. -- https://patchwork.kernel.org/patch/9683685/ https://wireless.wiki.ke

Re: mwifiex: add missing USB-descriptor endianness conversion

2017-05-18 Thread Kalle Valo
Johan Hovold wrote: > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor bcdUSB field during probe. > > Signed-off-by: Johan Hovold Patch applied to wireless-drivers-next.git, thanks. a1ad7198202f mwifiex: add missing USB-descriptor endianness conv

Re: [01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-18 Thread Kalle Valo
Brian Norris wrote: > If we fail to add an interface in mwifiex_add_virtual_intf(), we might > hit a BUG_ON() in the networking code, because we didn't tear things > down properly. Among the problems: > > (a) when failing to allocate workqueues, we fail to unregister the > netdev before cal

Re: [v2] mwifiex: pcie: de-duplicate buffer allocation code

2017-05-18 Thread Kalle Valo
Brian Norris wrote: > This code was duplicated as part of the PCIe FLR code added to this > driver. Let's de-duplicate it to: > > * make things easier to read (mwifiex_pcie_free_buffers() now has a >corresponding mwifiex_pcie_alloc_buffers()) > * reduce likelihood of bugs > * make error lo

Re: crash in r8723bs

2017-05-18 Thread Stefan Assmann
On 19.05.2017 00:50, Ian W MORRISON wrote: > On 19 May 2017 at 05:03, Larry Finger wrote: >> On 05/17/2017 10:05 AM, Stefan Assmann wrote: >>> >>> Hi Larry, >>> >>> the rtl8723bs made it into staging, awesome. >>> I built a kernel to test it but it goes down the drain pretty quickly >>> on modprob

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-18 Thread Kalle Valo
Arnd Bergmann writes: > I've managed to split up my long patch into a series of reasonble > steps now. > > The first two are required to fix a regression from commit 41977e86c984 > ("rt2x00: add support for MT7620"), the rest are just cleanups to > have a consistent state across all the register

Re: [V3, 5/9] brcmfmac: add firmware feature detection for gscan feature

2017-05-18 Thread Kalle Valo
Arend Van Spriel writes: > On 18-5-2017 17:47, Kalle Valo wrote: >> Kalle Valo writes: >> >>> Arend Van Spriel wrote: From: Arend van Spriel Detect gscan support in firmware by doing pfn_gscan_cfg iovar with invalid version. Reviewed-by: Hante Meuleman Revi

Re: [PATCH v2 4/5] wil6210: add option to ignore OTA regulatory hints

2017-05-18 Thread Kalle Valo
Maya Erez writes: > On some platforms, the regulatory domain (country) is set > using mechanisms external to WIFI, such as cellular modem > and GPS. In these scenarios the regulatory hints that > are received over the air (in beacons and similar) can > conflict and even cause an incorrect country

Re: [PATCH] brcmfmac: remove setting IBSS mode when stopping AP

2017-05-18 Thread Kalle Valo
Wright Feng writes: > From: Chi-hsien Lin > > Setting IBSS mode when stopping AP may affect functionality of INFRA > mode on another interface. For instance, if user creates and stops > hostap daemon on virtual interface, then association cannot work on > primary interface because default BSS ha

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

2017-05-18 Thread Rob Herring
On Mon, May 15, 2017 at 10:13:56PM +0200, Martin Blumenstingl wrote: > The example in the BCM43xx documentation uses "brcmf" as node name. > However, wireless devices should be named "wifi" instead. Fix this to > make sure that .dts authors can simply use the documentation as > reference (or simply

[PATCH 00/29] Standardize doc formats - part 3

2017-05-18 Thread Mauro Carvalho Chehab
Each document under Documentation/*.txt has its own format. Some follow markup notations, some don't even have a title! In order to try to get some order on it, change the document style to the standard we're adopting after the adoption of ReStructured Text. The documents touched on this series n

[PATCH 08/29] rfkill.txt: standardize document format

2017-05-18 Thread Mauro Carvalho Chehab
Each text file under Documentation follows a different format. Some doesn't even have titles! Change its representation to follow the adopted standard, using ReST markups for it to be parseable by Sphinx: - mark titles; - comment contents index; - mark literal blocks; - adjust identation. Signed

Re: crash in r8723bs

2017-05-18 Thread Ian W MORRISON
On 19 May 2017 at 05:03, Larry Finger wrote: > On 05/17/2017 10:05 AM, Stefan Assmann wrote: >> >> Hi Larry, >> >> the rtl8723bs made it into staging, awesome. >> I built a kernel to test it but it goes down the drain pretty quickly >> on modprobe. Going forward who should I discuss bugs with? >>

Re: [PATCH v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets

2017-05-18 Thread Sergey Matyukevich
Hello Johannes, On Wed, May 17, 2017 at 03:12:33PM +0200, Johannes Berg wrote: > Good job :) > > Let's merge this - the tiny fixes for things I found can come later. > > Some (mostly trivial) comments: > > * I'm surprised you don't support WEP - nice :) > * I don't think returning -EFAULT fr

Re: [V3, 5/9] brcmfmac: add firmware feature detection for gscan feature

2017-05-18 Thread Arend Van Spriel
On 18-5-2017 17:47, Kalle Valo wrote: > Kalle Valo writes: > >> Arend Van Spriel wrote: >>> From: Arend van Spriel >>> >>> Detect gscan support in firmware by doing pfn_gscan_cfg iovar with >>> invalid version. >>> >>> Reviewed-by: Hante Meuleman >>> Reviewed-by: Pieter-Paul Giesberts >>> Rev

Re: crash in r8723bs

2017-05-18 Thread Larry Finger
On 05/17/2017 10:05 AM, Stefan Assmann wrote: Hi Larry, the rtl8723bs made it into staging, awesome. I built a kernel to test it but it goes down the drain pretty quickly on modprobe. Going forward who should I discuss bugs with? Here's what's going on atm. Stefan [ 125.244195] r8723bs: m

[PATCH v2] mwifiex: pcie: de-duplicate buffer allocation code

2017-05-18 Thread Brian Norris
This code was duplicated as part of the PCIe FLR code added to this driver. Let's de-duplicate it to: * make things easier to read (mwifiex_pcie_free_buffers() now has a corresponding mwifiex_pcie_alloc_buffers()) * reduce likelihood of bugs * make error logging equally verbose * save lines

Re: [4/4] mwifiex: pcie: de-duplicate buffer allocation code

2017-05-18 Thread Brian Norris
On Thu, May 18, 2017 at 01:33:48PM +, Kalle Valo wrote: > Brian Norris wrote: > > This code was duplicated as part of the PCIe FLR code added to this > > driver. Let's de-duplicate it to: > > > > * make things easier to read (mwifiex_pcie_free_buffers() now has a > >corresponding mwifiex

Re: [V3, 5/9] brcmfmac: add firmware feature detection for gscan feature

2017-05-18 Thread Kalle Valo
Kalle Valo writes: > Arend Van Spriel wrote: >> From: Arend van Spriel >> >> Detect gscan support in firmware by doing pfn_gscan_cfg iovar with >> invalid version. >> >> Reviewed-by: Hante Meuleman >> Reviewed-by: Pieter-Paul Giesberts >> Reviewed-by: Franky Lin >> Signed-off-by: Arend van

Re: [PATCH v2 5/6] mwifiex: do not aggregate tcp ack in usb tx aggregation queue

2017-05-18 Thread Kalle Valo
Xinming Hu writes: > From: Xinming Hu > > Tcp ack should be send as soon to avoid throuput drop during receive tcp > traffic. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo > Signed-off-by: Ganapathi Bhat [...] > +static bool is_piggyback_tcp_ack(struct sk_buff *skb) > +{ > +

Re: rtlwifi: rtl8723ae: fix spelling mistake: "Coexistance" -> "Coexistence"

2017-05-18 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. e8dc072dd50d rtlwifi: rtl8723ae: fix spelling mistake: "Coexistance" -> "Coexistence" -- https://patchwor

Re: rtlwifi: fix spelling mistake: "Pairwiase" -> "Pairwise"

2017-05-18 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > trivial fixes to spelling mistakes in RT_TRACE messages. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 6b9e6f62552e rtlwifi: fix spelling mistake: "Pairwiase" -> "Pairwise" -- https://patchwork.kernel.

Re: [01/10] rtlwifi: btcoex: 21a 1ant: treat ARP as special packet

2017-05-18 Thread Kalle Valo
Larry Finger wrote: > From: Yan-Hsuan Chuang > > We need to pay attention to ARP packets to correctly establish > connection, and reset the ARP counter when disconnected. > > Signed-off-by: Yan-Hsuan Chuang > Signed-off-by: Larry Finger > Cc: Pkshih > Cc: Birming Chiu > Cc: Shaofu > Cc: St

Re: [01/10] rtlwifi: btcoex: 21a 1ant: set tdma and coex table when wifi is idle

2017-05-18 Thread Kalle Valo
Larry Finger wrote: > From: Yan-Hsuan Chuang > > When wifi is idle, bt could have more resources to transmit, so set the > tdma and coex table to achieve this. > > Signed-off-by: Yan-Hsuan Chuang > Signed-off-by: Larry Finger > Cc: Pkshih > Cc: Birming Chiu > Cc: Shaofu > Cc: Steven Ting

Re: [v3,01/10] rtlwifi: btcoex: 21a 2ant: set tdma with rssi states

2017-05-18 Thread Kalle Valo
Larry Finger wrote: > From: Yan-Hsuan Chuang > > if bt rssi is high, adjust the duration of wifi to a longer period to > let the wifi transmit under this bt profiling. > > Signed-off-by: Yan-Hsuan Chuang > Signed-off-by: Larry Finger > Cc: Pkshih > Cc: Birming Chiu > Cc: Shaofu > Cc: Steve

Re: [v2, 1/4] rtlwifi: btcoex: Remove 21a 1ant configuration parameter

2017-05-18 Thread Kalle Valo
Larry Finger wrote: > In file halbtc8821a1ant.c, there are directives that depend on an > undocumented configuration parameter BT_AUTO_REPORT_ONLY_8821A_1ANT > that cannot be set from Kconfig. This parameter is replaced by a > boolean in the main structure used by all routines. It still cannot > b

Re: wlcore: use memdup_user

2017-05-18 Thread Kalle Valo
Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Patch applied to wireless-drivers-next.git, thanks. 6a01d48d47c8 wlcore: use memdup_user -- https://patchwork.kernel.org/patch/9715005/ https://wireless.wiki.kernel.or

Re: [v3,1/2] mwifiex: initiate card-specific work atomically

2017-05-18 Thread Kalle Valo
Brian Norris wrote: > The non-atomic test + set is a little awkward here, and it technically > means we might double-schedule work unnecessarily. AFAICT, this is not > really a problem, since the extra "work" will be a no-op (the flag(s) > will be cleared by then), but it's still an anti-pattern.

Re: mwifiex: p2p client using same data path as station

2017-05-18 Thread Kalle Valo
Xinming Hu wrote: > From: Xinming Hu > > P2p client act as a station, data will be queued by DA instead > of RA. This patch pass the sanity check, so that p2p client share > the same data path with infrastruction station mode. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo Patch ap

Re: [V3, 5/9] brcmfmac: add firmware feature detection for gscan feature

2017-05-18 Thread Kalle Valo
Arend Van Spriel wrote: > From: Arend van Spriel > > Detect gscan support in firmware by doing pfn_gscan_cfg iovar with > invalid version. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Franky Lin > Signed-off-by: Arend van Spriel Failed to apply: fata

Re: [4/4] mwifiex: pcie: de-duplicate buffer allocation code

2017-05-18 Thread Kalle Valo
Brian Norris wrote: > This code was duplicated as part of the PCIe FLR code added to this > driver. Let's de-duplicate it to: > > * make things easier to read (mwifiex_pcie_free_buffers() now has a >corresponding mwifiex_pcie_alloc_buffers()) > * reduce likelihood of bugs > * make error lo

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

2017-05-18 Thread Arend Van Spriel
On 18-5-2017 12:40, Johannes Berg wrote: > On Thu, 2017-05-18 at 12:29 +0200, Arend Van Spriel wrote: >> On 18-5-2017 11:22, Johannes Berg wrote: >>> On Thu, 2017-05-18 at 10:18 +0200, Arend Van Spriel wrote: > We should therefore probably set the expectation that wpa_s - > if > it

Re: [PATCH] rt2x00: remove unneccesary code

2017-05-18 Thread Kalle Valo
Tom Psyborg writes: > On 18 May 2017 at 14:12, Daniel Golle wrote: > > Note that your mailer program destroyed the white-space formatting > of > the patch which I had to fix manually as a consequence of that > (tabs > were replaced by spaces, hence the patch didn't apply). Tr

Re: [PATCH] rt2x00: remove unneccesary code

2017-05-18 Thread Kalle Valo
(fixing top posting) Daniel Golle writes: > On Thu, May 18, 2017 at 12:42:14PM +0200, Tom Psyborg wrote: >> Use chanreg and dccal helpers to reduce the size of ePA code. >> >> Signed-off-by: Tomislav Požega > > thank you for that contribution. > Code for ePA has not yet been submitted upstream

Re: [PATCH] rt2x00: remove unneccesary code

2017-05-18 Thread Daniel Golle
Done. See https://git.lede-project.org/?p=source.git;a=commit;h=5e5499c612a667837c714fc4a41b7347e334ce14 I'll merge it into the patch adding support for ePA and then submit the already reduced version upstream once it got sufficient testing. Note that your mailer program destroyed the white-space

Re: [PATCH] rt2x00: remove unneccesary code

2017-05-18 Thread Daniel Golle
Hi Tom, thank you for that contribution. Code for ePA has not yet been submitted upstream, I wanted to give it some more testing, so it's still a local patch in OpenWrt/LEDE. I'll merge your patch into our local patch-queue and submit it together with the ePA code once it got some more testing. C

wlcore: DEADLOCK: WARNING: possible circular locking dependency detected

2017-05-18 Thread Naresh Kamboju
Hi Team, DEADLOCK detected on HiKey (arm64) development board running linux-next-4.12.0-rc1. This DEADLOCK occurred two times while booting the device and other one is while running libhugetlbfs test suite. Error log: https://pastebin.com/ABmiTfLb LAVA job id: https://validation.lin

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

2017-05-18 Thread Johannes Berg
On Thu, 2017-05-18 at 12:29 +0200, Arend Van Spriel wrote: > On 18-5-2017 11:22, Johannes Berg wrote: > > On Thu, 2017-05-18 at 10:18 +0200, Arend Van Spriel wrote: > > > > > > > We should therefore probably set the expectation that wpa_s - > > > > if > > > > it's new enough - always uses the offl

[PATCH] brcmfmac: remove setting IBSS mode when stopping AP

2017-05-18 Thread Wright Feng
From: Chi-hsien Lin Setting IBSS mode when stopping AP may affect functionality of INFRA mode on another interface. For instance, if user creates and stops hostap daemon on virtual interface, then association cannot work on primary interface because default BSS has been set to IBSS mode in firmwa

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

2017-05-18 Thread Arend Van Spriel
On 18-5-2017 11:22, Johannes Berg wrote: > On Thu, 2017-05-18 at 10:18 +0200, Arend Van Spriel wrote: >> >>> We should therefore probably set the expectation that wpa_s - if >>> it's new enough - always uses the offloaded functionality and >>> always sets the WANT_1X. Then this is even better with

[PATCH v2] rt2x00: Add device ID for Epson WN7512BEP

2017-05-18 Thread Tom Gaudasinski
Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device contains a Ralink RT3071L, registers as vendor Accton/Arcadyan. Corrections made to submission for posterity. Signed-off-by: Tom Gaudasinski --- drivers/net/wireless/ralink/rt2x00/rt2800usb.c | 2 ++ 1 file changed, 2 insert

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

2017-05-18 Thread Johannes Berg
On Thu, 2017-05-18 at 10:18 +0200, Arend Van Spriel wrote: > > > We should therefore probably set the expectation that wpa_s - if > > it's new enough - always uses the offloaded functionality and > > always sets the WANT_1X. Then this is even better with such > > drivers, since they can immediatel

Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id

2017-05-18 Thread Tom Gaudasiński
Is it advisable to re-submit with the noted corrections fixed? On 18/05/17 15:47, Kalle Valo wrote: > Tom Gaudasiński writes: > >> Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device >> contains a Ralink RT3071L, registers as vendor Accton/Arcadyan. >> >> Signed-off-by: Tom Ga

Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id

2017-05-18 Thread Kalle Valo
Kalle Valo writes: > Tom Gaudasiński writes: > >> Is it advisable to re-submit with the noted corrections fixed? > > Yes, please resend. And remember to mark the new version as v2: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing -- Kalle V

[PATCH] rt2x00: Add device ID for Epson WN7512BEP

2017-05-18 Thread Tom Gaudasinski
Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device contains a Ralink RT3071L, registers as vendor Accton/Arcadyan. Signed-off-by: Tom Gaudasinski --- drivers/net/wireless/ralink/rt2x00/rt2800usb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ral

Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id

2017-05-18 Thread Kalle Valo
Tom Gaudasiński writes: > Is it advisable to re-submit with the noted corrections fixed? Yes, please resend. -- Kalle Valo

Ciao

2017-05-18 Thread Webmail-Admin
La cassetta postale è pieno e deve essere convalidato per evitare la disattivazione. Cliccate sul link sottostante per garantire che il vostro account è disabilitato. http://bibankie.tripod.com Supporto Amministrativo.

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

2017-05-18 Thread Arend Van Spriel
+ hostap list On 17-5-2017 16:19, Johannes Berg wrote: > Hi, > > I think this looks really good. One thing though: > >> Another change is the >> addition of the flag ATTR_WANT_1X_4WAY_HS that user-space has to pass >> in CONNECT request. Some drivers may need to be aware before the PMK >> is pro

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

2017-05-18 Thread Johannes Berg
On Wed, 2017-05-17 at 22:05 -0700, Bjorn Andersson wrote: > > It seems very important to a lot of people... I get blinking, I guess, but I don't get toggling for every packet :) The throughput thing we did in iwlwifi seems like a so much better idea. Not that it really matters for this discussion