Re: [PATCH v3] mac80211: mesh: fix wrong mesh TTL offset calculation

Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [also build test ERROR on v4.15-rc9 next-20180126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 03/10] rtlwifi: Use 6 bits as sequence number of TX report

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih In new design, SW_DEFINE[1:0] of tx desc are used by firmware, and the TX report only contains SW_DEFINE[7:0]. To satisfy with all cases, driver uses SW_DEFINE[7:2] as sequence number. Besides, the format

Re: [PATCH 04/10] rtlwifi: Extend tx_power_by_rate_offset size for newer IC

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih In older design, the TX power is grouped into rate section (smaller array size), but new design groups them into rate (larger array size). Thus, we extend the size for both cases, and add compile time

Re: [PATCH 05/10] rtlwifi: Add rate section and its related definition and comment

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih Add comments to make it to be easier to understand, and add compile time assertions. Signed-off-by: Ping-Ke Shih This is a good improvement. Acked-by: Larry Finger

Re: [PATCH 06/10] rtlwifi: Fix VHT NSS in RC

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih NSS is a argument of highest rate in RC, and it occupies bit 4-7 so use ieee80211_rate_set_vht() to fill the values. Since it got correct rate index, we don't need to check chips to assign NSS in set

Re: [PATCH 07/10] rtlwifi: add definition radio_mask for RF and maximum bandwidth

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih Add rf mask definition (BIT 0, BIT 1, BIT 2, ...) that is different from rf path definition (0, 1, 2, ...), and then combinations of rf path are possible. Signed-off-by: Ping-Ke Shih

Re: [PATCH 08/10] rtlwifi: add efuse ops for other components

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih The new component phydm need to access efuse content, so we prepare ops for reference. Signed-off-by: Tsang-Shian Lin Signed-off-by: Ping-Ke Shih Acked-by: Larry

Re: [PATCH v5 00/12] spectre variant1 mitigations for tip/x86/pti

[ adding lkml ] I had inadvertently dropped lkml when sending this to Thomas. Archive here: https://marc.info/?l=linux-wireless=151704026325010=2 https://marc.info/?l=linux-arch=151704027225013=2 https://marc.info/?l=linux-arch=151704027225014=2 https://marc.info/?l=linux-arch=151704027625015=2

Re: [PATCH 10/10] rtlwifi: btcoex: Add 8822be btcoex supported files for wifi only

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih The wifi only btcoex is used to solo card (without BT), and it is also useful to exclude the interference with BT to make debug easier. There are only four ops for wifi only btcoex to initialze antenna and

Re: [PATCH 09/10] rtlwifi: btcoex: add routine to set default port id

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih Tell wifi and BT firmware the default port ID to set multiports' state properly, but only 8822be needs this function currently. Signed-off-by: Ping-Ke Shih --- This patch results in

Re: [PATCH v5 00/12] spectre variant1 mitigations for tip/x86/pti

On Fri, Jan 26, 2018 at 11:55 PM, Dan Williams wrote: > > Here's another spin of the spectre-v1 mitigations for 4.16. I see nothing really objectionable here. And unlike Spectre-v2 and Meltdown, I expect Spectre-v1 to be with us for a long time. It's not a "CPU did a

Re: [PATCH 01/10] rtlwifi: enable mac80211 fast-tx support

On 01/26/2018 01:46 AM, pks...@realtek.com wrote: From: Ping-Ke Shih Enable the mac80211 fast-tx feature, since our driver already support hw_flags required by fast-tx and is able to let mac80211 stack to transmit packet through fast-xmit path. Signed-off-by: Yan-Hsuan

Re: [PATCH] ath9k: Print has_queued in debugfs.

Ben Greear writes: > On 01/27/2018 05:29 AM, Toke Høiland-Jørgensen wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear >>> >>> The PAUSED field was never printed per tid. Replace that >>> with has_queued, which might help someone

Re: [PATCH] ath9k: Print has_queued in debugfs.

On 01/27/2018 05:29 AM, Toke Høiland-Jørgensen wrote: gree...@candelatech.com writes: From: Ben Greear The PAUSED field was never printed per tid. Replace that with has_queued, which might help someone track down strange bugs related to aqm. And, make tx-queue

[PATCH 4.16 3/4] mt76: avoid re-queueing A-MPDU rx reorder work if no frames are pending

Fixes: aee5b8cf2477 ("mt76: implement A-MPDU rx reordering in the driver code") Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/agg-rx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c

[PATCH 4.16 2/4] mt76: implement processing of BlockAckReq frames

Avoids timeouts on reordered A-MPDU rx frames Fixes: aee5b8cf2477 ("mt76: implement A-MPDU rx reordering in the driver code") Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/agg-rx.c | 34 - 1 file changed, 33 insertions(+), 1

[PATCH 4.16 1/4] mt76: implement AP_LINK_PS

With software A-MPDU reordering in place, frames that notify mac80211 of powersave changes are reordered as well, which can cause connection stalls. Fix this by implementing powersave state processing in the driver. Fixes: aee5b8cf2477 ("mt76: implement A-MPDU rx reordering in the driver code")

[PATCH 4.16 4/4] mt76: do not set status->aggr for NULL data frames

Avoids data connection stalls when the client toggles powersave mode Fixes: aee5b8cf2477 ("mt76: implement A-MPDU rx reordering in the driver code") Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

On Friday 05 January 2018 02:45:10 Luis R. Rodriguez wrote: > On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote: > > On Friday 10 November 2017 00:38:22 Pali Rohár wrote: > > > This patch series fix processing MAC address for wl1251 chip found in > > > Nokia N900. > > > > > > Changes

Re: [PATCH] ath9k: Print has_queued in debugfs.

gree...@candelatech.com writes: > From: Ben Greear > > The PAUSED field was never printed per tid. Replace that > with has_queued, which might help someone track down strange > bugs related to aqm. > > And, make tx-queue debug info show peer BSSID as well as vdev > MAC

Re: ath9k will not tx packets sometimes.

Ben Greear writes: > I'm doing a test with 200 virtual stations on each of 6 ath9k radios. > > When I configure stations for DHCP, I see cases where stations on a particular > radio will not transmit anything sometimes. I see no 'XMIT' logs that show > indication of >

Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC

On Sat, Jan 27, 2018 at 10:08:56AM +0100, Andreas Schwab wrote: > On Jan 16 2018, Kalle Valo wrote: > > > 58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC > > That breaks wireless on PowerMac! There is nothing MIPS-specific about > SSB. Yes, really sorry about

Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC

On Jan 16 2018, Kalle Valo wrote: > 58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC That breaks wireless on PowerMac! There is nothing MIPS-specific about SSB. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756

rtl8723bs: rtnl_is_locked() misuse

Hi, I'm reporting you about misuse of rtnl_is_locked() in rtw_change_ifname() function. Note, that rtnl_is_locked() *does not mean* rtnl is locked on the *current cpu*. This primitive returns true in case of rtnl is locked somewhere in the system. So, it can't be used in the below code: if

wilc1000: rtnl_is_locked() misuse

Hi, I'm reporting you about misuse of rtnl_is_locked() in WILC_WFI_deinit_mon_interface() function. Note, that rtnl_is_locked() *does not mean* rtnl is locked on the *current cpu*. This primitive returns true in case of rtnl is locked somewhere in the system. So, it can't be used in the below

[PATCH v5 11/12] nl80211: sanitize array index in parse_txq_params

Wireless drivers rely on parse_txq_params to validate that txq_params->ac is less than NL80211_NUM_ACS by the time the low-level driver's ->conf_tx() handler is called. Use a new helper, 'array_idx', to sanitize txq_params->ac with respect to speculation. I.e. ensure that any speculation into

[PATCH v5 00/12] spectre variant1 mitigations for tip/x86/pti

Hi Thomas, Here's another spin of the spectre-v1 mitigations for 4.16. Changes since v4.1: [1] * Tweak the sanitization scheme yet again to make it even simpler. Now, instead of 'array_ptr' to get a sanitized pointer to an array element, just provide an array index sanitization helper