Re: [RESEND] rsi: Remove stack VLA usage

Added Konstantin in case he is in charge of administering patchwork.kernel.org? On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees Cook wrote: > On Tue, Mar 13, 2018 at 7:11 PM, Tobin C. Harding wrote: > > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: > >> On Tue,

Re: [RESEND] rsi: Remove stack VLA usage

On Tue, Mar 13, 2018 at 7:11 PM, Tobin C. Harding wrote: > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: >> On Tue, Mar 13, 2018 at 10:17 PM, tcharding wrote: >> > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> >> tcharding

Re: [RESEND] rsi: Remove stack VLA usage

On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: > On Tue, Mar 13, 2018 at 10:17 PM, tcharding wrote: > > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: > >> tcharding wrote: > > I'm pretty much sure it depends on the original email

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

On Sun, Mar 11, 2018 at 12:12 AM, Kees Cook wrote: > > The problem is that it's not a "constant expression", so the compiler > frontend still yells about it under -Wvla. I would characterize this > mainly as a fix for "accidental VLA" or "misdetected VLA" or something >

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

> I don't think the difference between C and C++ const pointer > conversions I mean I don't think the difference between them was intended.

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

No, it's undefined behavior to write to a const variable. The `static` and `const` on the variable both change the code generation in the real world as permitted / encouraged by the standard. It's placed in read-only memory. Trying to write to it will break. It's not "implemented defined" to write

[RFC v5 4/9] cfg80211: Support all iftypes in autodisconnect_wk

Currently autodisconnect_wk assumes that only interface types of P2P_CLIENT and STATION use conn_owner_nlportid. Change this so all interface types are supported. Signed-off-by: Denis Kenzior --- net/wireless/sme.c | 43 --- 1 file

[RFC v5 3/9] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute

Signed-off-by: Denis Kenzior --- include/net/cfg80211.h | 3 +++ include/uapi/linux/nl80211.h | 14 +- net/wireless/nl80211.c | 13 + 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/include/net/cfg80211.h

[RFC v5 5/9] nl80211: Add SOCKET_OWNER support to JOIN_IBSS

Signed-off-by: Denis Kenzior --- include/uapi/linux/nl80211.h | 2 ++ net/wireless/ibss.c | 1 + net/wireless/nl80211.c | 6 ++ 3 files changed, 9 insertions(+) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index

[RFC v5 6/9] nl80211: Add SOCKET_OWNER support to JOIN_MESH

Signed-off-by: Denis Kenzior --- include/uapi/linux/nl80211.h | 2 ++ net/wireless/mesh.c | 1 + net/wireless/nl80211.c | 10 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h

[RFC v5 8/9] mac80211: Add support for tx_control_port

Signed-off-by: Denis Kenzior --- net/mac80211/cfg.c | 1 + net/mac80211/ieee80211_i.h | 3 +++ net/mac80211/tx.c | 46 ++ 3 files changed, 50 insertions(+) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c

[RFC v5 9/9] mac80211: Send control port frames over nl80211

If userspace requested control port frames to go over 80211, then do so. The control packets are intercepted just prior to delivery of the packet to the underlying network device. Pre-authentication type frames (protocol: 0x88c7) are also forwarded over nl80211. Signed-off-by: Denis Kenzior

[RFC v5 2/9] nl80211: Implement TX of control port frames

This commit implements the TX side of NL80211_CMD_CONTROL_PORT_FRAME. Userspace provides the raw EAPoL frame using NL80211_ATTR_FRAME. Userspace should also provide the destination address and the protocol type to use when sending the frame. This is used to implement TX of Pre-authentication

[RFC v5 7/9] nl80211: Add SOCKET_OWNER support to START_AP

Signed-off-by: Denis Kenzior --- include/uapi/linux/nl80211.h | 2 ++ net/wireless/ap.c| 1 + net/wireless/nl80211.c | 4 3 files changed, 7 insertions(+) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index

[RFC v5 0/9] EAPoL over NL80211

This patchset adds support for running 802.11 authentication mechanisms (e.g. 802.1X, 4-Way Handshake, etc) over NL80211 instead of putting them onto the network device. This has the advantage of fixing several long-standing race conditions that result from userspace operating on multiple

[RFC v5 1/9] nl80211: Add CMD_CONTROL_PORT_FRAME API

This commit also adds cfg80211_rx_control_port function. This is used to generate a CMD_CONTROL_PORT_FRAME event out to userspace. The conn_owner_nlportid is used as the unicast destination. This means that userspace must specify NL80211_ATTR_SOCKET_OWNER flag if control port over nl80211

Re: [RESEND] rsi: Remove stack VLA usage

On Tue, Mar 13, 2018 at 10:17 PM, tcharding wrote: > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> tcharding wrote: I'm pretty much sure it depends on the original email headers, like above ^^^ — no name. Perhaps git config on your side should be

Re: [2/3] mwifiex: support sysfs initiated device coredump

On 3/13/2018 9:19 PM, Marcel Holtmann wrote: Hi Arend, Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver callback. As there is no longer a need to

Re: [PATCH] brcmfmac: Add support for getting nvram contents from EFI variables

On 3/12/2018 10:45 AM, Hans de Goede wrote: Hi, On 12-03-18 09:55, Arend van Spriel wrote: On 3/11/2018 10:47 PM, Hans de Goede wrote: Various models Asus laptops with a SDIO attached brcmfmac wifi chip, store the nvram contents in a special EFI variable. This commit adds support for getting

Re: [2/3] mwifiex: support sysfs initiated device coredump

Hi Arend, > Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > it is possible to initiate a device coredump from user-space. This > patch adds support for it adding the .coredump() driver callback. > As there is no longer a need to initiate it through debugfs

Re: [RESEND] rsi: Remove stack VLA usage

On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: > tcharding wrote: > > > The kernel would like to have all stack VLA usage removed[1]. rsi uses > > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > > is defined using a magic number. We can

Re: [RESEND PATCH] rsi: Remove stack VLA usage

On Sun, Mar 11, 2018 at 09:06:10PM -0500, Larry Finger wrote: > On 03/11/2018 08:43 PM, Tobin C. Harding wrote: > >The kernel would like to have all stack VLA usage removed[1]. rsi uses > >a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > >is defined using a magic number.

Re: [2/3] mwifiex: support sysfs initiated device coredump

On 3/13/2018 2:10 PM, Kalle Valo wrote: Arend van Spriel writes: On 3/12/2018 10:41 AM, Kalle Valo wrote: Arend Van Spriel wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a

Re: Support on vendor id and device id

+ Greg, +wilc1000 maintainers On 3/1/2018 11:10 AM, Harsha Rao wrote: On Wed, Feb 28, 2018 at 3:08 PM, Arend van Spriel wrote: On 2/28/2018 12:14 AM, Harsha Rao wrote: My suspicion is that your device, is fundamentally a wilc1000 and that the existing wilc1000

Re: [PATCH 08/10] rsi: device disconnect changes

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > Below changes are done: > 1. When HCI detach is called, making bt_adapter null and checking > for this variable where ever required. > 2. In USB case, one extra register write is added

Re: [PATCH 09/10] rsi: tx improvements

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > Changes done to improve TX path: > 1. Max number of frames to aggregate is increased to 8 > 2. Bootup parameters updated. > 3. registering 5g band is done only when device supports > 4.

Re: [1/3] Revert "mwifiex: fix incorrect ht capability problem"

Ganapathi Bhat wrote: > This reverts commit bcc920e8f08336cbbdcdba7c4449c27137e6b4b9. > > Drivers gets hardware info and updates ht_cap field of > wiphy->bands during initialization. Once updated during init, > ht_cap must not be modified as it reflects the capability >

Re: mwifiex: correct antenna number with high bits reserved

Xinming Hu wrote: > High bits of antenna number are reserved in hardware spec, > using low 4 bits represent supported antenna. > > Signed-off-by: Cathy Luo > Signed-off-by: Xinming Hu Patch applied to wireless-drivers-next.git, thanks.

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to

Re: net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

Randy Dunlap wrote: > From: Randy Dunlap > > Lots of the wireless driver vendor Kconfig symol help text says > "questions about cards." (2 spaces between "about" and "cards") > > Besides dropping one of those spaces, it also needs some other word

Re: [v3] ssb: use put_device() if device_register fail

Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav Patch applied to

Re: [v2] bcma: Prevent build of PCI host features in module

Matt Redfearn wrote: > Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in > a build error due to use of symbols not exported from vmlinux: > > ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! > ERROR: "register_pci_controller"

Re: [PATCH] firmware: add a function to load optional firmware v2

"Luis R. Rodriguez" writes: > On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: >> "Luis R. Rodriguez" writes: >> >> >> +/** >> >> + * request_firmware_optional: - request for an optional fw module >> >> + * @firmware_p: pointer to firmware image

Re: [1/3] rsi: improve RX handling in SDIO interface

Amitkumar Karwar wrote: > From: Prameela Rani Garnepudi > > Currently, RX packets are handled in interrupt context in SDIO > interface. To improve the efficiency of processing RX packets, > RX thread and RX skb queues are introduced. > When the

Re: [PATCH] firmware: add a function to load optional firmware v2

On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > >> +/** > >> + * request_firmware_optional: - request for an optional fw module > >> + * @firmware_p: pointer to firmware image > >> + * @name: name of firmware file > >> + * @device:

Re: [v9,1/8] rsi: add rx control block to handle rx packets in USB

Amitkumar Karwar wrote: > From: Prameela Rani Garnepudi > > Rx bluetooth endpoint shall be added in further patches. Rx control > block is introduced here to handle Rx packets properly. Separate > function is written to initialize the RX control

Re: [PATCH] firmware: add a function to load optional firmware v2

On Tue, Mar 13, 2018 at 03:39:23PM +0200, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > > On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: > >> On 3/11/2018 5:05 PM, Andres Rodriguez wrote: > >> > > Your patch series then should also have the driver

Re: mt7601u: let mac80211 validate rx CCMP PN

Lorenzo Bianconi wrote: > Apparently the hardware does not perform CCMP PN validation so > let mac80211 take care of possible replay attacks in sw. > Moreover indicate ICV and MIC had been stripped setting corresponding > bits in ieee80211_rx_status. > The fix has

Re: mt7601u: simplify mt7601u_mcu_msg_alloc signature

Lorenzo Bianconi wrote: > Remove mt7601u_dev parameter from mt7601u_mcu_msg_alloc signature since > dev pointer is never used in routine body > > Signed-off-by: Lorenzo Bianconi > Acked-by: Jakub Kicinski Patch applied

Re: mt76x2: remove unnecessary len variable in mt76x2_eeprom_load()

Lorenzo Bianconi wrote: > Substitute unnecessary len variable in mt76x2_eeprom_load() with > MT7662_EEPROM_SIZE macro since len is used just to store eeprom > default size. > > Signed-off-by: Lorenzo Bianconi Patch applied to

Re: mt7601u: remove a warning in mt7601u_efuse_physical_size_check()

Lorenzo Bianconi wrote: > Fix the following sparse warning in mt7601u_efuse_physical_size_check: > - drivers/net/wireless/mediatek/mt7601u/eeprom.c:77:27: warning: > Variable length array is used > > Signed-off-by: Lorenzo Bianconi >

Re: [1/3] mt76: initialize available_antennas_{tx,rx} info

Lorenzo Bianconi wrote: > Initialize available_antennas related info in wiphy data structure > according to antenna_mask field; antenna_mask info is initialized > in device specific code and will be used in mac80211 {set,get}_antenna > callbacks > > Signed-off-by:

Re: [PATCH 10/10] rsi: drop RX broadcast/multicast packets with invalid PN

Amitkumar Karwar writes: > From: Siva Rebbagondla > > This patch adds a check to drop received broadcast/multicast frames if > PN is invalid (i.e. not greater than last PN). bc_mc_pn > variable added for each interface > >

Re: [PATCH 06/10] rsi: add module parameter rsi_reg

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > For few regulatory customizations, we are taking rsi_reg > as module parameter. Why? > +static u16 rsi_reg = RSI_REG_DEF; > +module_param(rsi_reg, ushort, 0444); >

Re: [PATCH 05/10] rsi: roaming enhancements

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > To support roaming below changes are done: > * Station notify frame is send to firmware after sending assoc > request. This will avoid dropping of first EAPOL frame due to > delay in

Re: [PATCH 01/10] rsi: add support for hardware scan offload

Kalle Valo writes: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> With the current approach of scanning, roaming delays >> are observed. Firmware has support for back ground scanning. >> To get this

Re: [PATCH 01/10] rsi: add support for hardware scan offload

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > With the current approach of scanning, roaming delays > are observed. Firmware has support for back ground scanning. > To get this advantage, mac80211 hardware scan is implemented. > In

Re: [PATCH 1/3] rsi: improve RX handling in SDIO interface

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > Currently, RX packets are handled in interrupt context in SDIO > interface. To improve the efficiency of processing RX packets, > RX thread and RX skb queues are introduced. > When the

Re: [PATCH 1/2] cfg80211: Add support to enable or disable btcoex

Arend van Spriel writes: > + Marcel > > On 3/2/2018 6:14 AM, Kalle Valo wrote: >> Arend van Spriel writes: >> >>> On 3/1/2018 6:59 PM, Tamizh chelvam wrote: From: Tamizh chelvam This patch

Re: [PATCH] firmware: add a function to load optional firmware v2

"Luis R. Rodriguez" writes: > On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: >> On 3/11/2018 5:05 PM, Andres Rodriguez wrote: >> > > Your patch series then should also have the driver callers who you >> > > want to modify to use this new API. Collect from

Re: [PATCH] firmware: add a function to load optional firmware v2

Arend van Spriel writes: > On 3/11/2018 5:05 PM, Andres Rodriguez wrote: >>> Your patch series then should also have the driver callers who you >>> want to modify to use this new API. Collect from the 802.11 folks the >>> other drivers which I think they wanted

Re: [PATCH] firmware: add a function to load optional firmware v2

"Luis R. Rodriguez" writes: >> +/** >> + * request_firmware_optional: - request for an optional fw module >> + * @firmware_p: pointer to firmware image >> + * @name: name of firmware file >> + * @device: device for which firmware is being loaded >> + * >> + * This function is

Re: [2/3] mwifiex: support sysfs initiated device coredump

Arend van Spriel writes: > On 3/12/2018 10:41 AM, Kalle Valo wrote: >> Arend Van Spriel wrote: >> >>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") >>> it is possible to initiate a device coredump from

RE: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

From: Daniel Micay > Sent: 10 March 2018 23:45 > > > Just wondering. Is this actually a VLA. FFT_NUM_SAMPLES was static const so > > not really going to show a lot of variation. This array will always have the > > same size on the stack. > > The issue is that unlike in C++, a `static const`

[PATCH] staging: wilc1000: use kmemdup to replace kmalloc/memcpy

From: HariPrasath Elango kmalloc followed by memcpy can be replaced by kmemdup.Also added the related error handling part Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/host_interface.c | 10 +++--- 1 file

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

On Tue, 13 Mar 2018 10:58:16 +0100 Greg Kroah-Hartman wrote: > On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > > > Reviewed-by: Ajay Singh > > > > On Mon, 12 Mar 2018 15:09:03 +0530 > >

[PATCH] staging: wilc1000: remove unwanted braces and correct code alignment

From: HariPrasath Elango Remove the unwated brace and corrected the code block alignment accordingly Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/host_interface.c | 25 - 1 file changed, 12

[PATCH] staging: wilc1000: replace switch statement by simple if condition

From: HariPrasath Elango In this case,there is only a single switch case statement.So replacing by a simple if condition. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +--- 1 file

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > Reviewed-by: Ajay Singh > > On Mon, 12 Mar 2018 15:09:03 +0530 > wrote: > > > From: HariPrasath Elango > > > > Please avoid use of 'From'

[PATCH] staging: wilc1000: destroy initialized mutex object

From: HariPrasath Elango A mutex object that is initialized but not destroyed.This patch destroys the mutex object Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 + 1 file changed, 1

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 3/13/2018 8:20 AM, Felix Fietkau wrote: [resent with fixed typo in linux-wireless address] On 2018-02-27 11:08, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network

Re: [PATCH] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

On Tue, 13 Mar 2018 11:50:48 +0530 wrote: > From: HariPrasath Elango > > Kmalloc followed by memcpy can be replaced by kmemdup. > > Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh

Re: [PATCH] staging: wilc1000: Destroy mutex object in deinitialization

On Mon, 12 Mar 2018 18:49:49 +0530 wrote: > From: HariPrasath Elango > > Destroy the mutex object that is initialized in wlan_init_locks() > > Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh

Re: [PATCH] staging: wilc1000: Fix code block alignment

On Mon, 12 Mar 2018 18:30:44 +0530 wrote: > From: HariPrasath Elango > > Fix the code alignment for a block of code to adhere to coding > guidelines > > Signed-off-by: HariPrasath Elango Reviewed-by:

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

Reviewed-by: Ajay Singh On Mon, 12 Mar 2018 15:09:03 +0530 wrote: > From: HariPrasath Elango > Please avoid use of 'From' tag specially when there is only one 'Signed-off-by' tag and its same. > Use the

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

[resent with fixed typo in linux-wireless address] On 2018-02-27 11:08, Rafał Miłecki wrote: > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > FullMAC WiFi chipset. > > > First of all OpenWrt/LEDE uses bridge interface for LAN network with: > 1)

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 03/13/2018 12:01 AM, Stephen Hemminger wrote: On Mon, 12 Mar 2018 23:42:48 +0100 Rafał Miłecki wrote: 2) Blame bridge + mcast-to-ucast + hairpin for 802.11f incompatibility If we agree that 802.11f support in FullMAC firmware is acceptable, then we have to make sure

[PATCH] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

From: HariPrasath Elango Kmalloc followed by memcpy can be replaced by kmemdup. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git