> -Original Message-
> From: Johannes Berg [mailto:johan...@sipsolutions.net]
> Sent: Monday, October 08, 2018 10:00 PM
> To: Tony Chuang; kv...@codeaurora.org
> Cc: larry.fin...@lwfinger.net; Pkshih; Andy Huang; sgrus...@redhat.com;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC
On 10/08/2018 07:57 AM, Johannes Berg wrote:
> On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote:
>>
>> +static void clear_shadow_scan(struct wilc_priv *priv)
>> +{
>> +int i;
>> +
>> +for (i = 0; i < priv->scanned_cnt; i++) {
>> +kfree(priv->scanned_shadow[i].ies);
>> +
> -Original Message-
> From: Johannes Berg [mailto:johan...@sipsolutions.net]
> Sent: Monday, October 08, 2018 9:29 PM
> To: Tony Chuang; kv...@codeaurora.org
> Cc: larry.fin...@lwfinger.net; Pkshih; Andy Huang; sgrus...@redhat.com;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v3
When powering down a SDIO connected card during suspend, make sure to call
into the generic lbs_suspend() function before pulling the plug. This will
make sure the card is successfully deregistered from the system to avoid
communication to the card starving out.
Fixes: 7444a8092906 ("libertas:
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > index 99e0a91a2f99..d18942e54048 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > @@ -734,8
On 10/08/2018 12:38 AM, Kalle Valo wrote:
> Ajay Singh writes:
>
>> On Sat, 6 Oct 2018 15:45:41 +0300
>> Kalle Valo wrote:
>>
>>> Ajay Singh writes:
>>>
This patch set contains the driver files from
'driver/staging/wilc1000'. Renamed the driver from 'wilc1000' to
'wilc' to
On 2018-10-08 14:40, Lorenzo Bianconi wrote:
> Fix restore value configured in 0x2124 register in
> mt76x0_phy_recalibrate_after_assoc routine.
>
> Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> Signed-off-by: Lorenzo Bianconi
> ---
> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
> 1
clang warns about the misuse of enums:
reg.c:246:26: warning: implicit conversion from enumeration type 'enum
command_identify_by' to different enumeration type 'enum id_input'
[-Wenum-conversion]
err = handle_cmd(state, CIB_NONE, 2, dump_args);
~~^~~~
On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote:
>
> +#define NO_ENCRYPT 0
> +#define ENCRYPT_ENABLED BIT(0)
> +#define WEP BIT(1)
> +#define WEP_EXTENDED BIT(2)
> +#define WPA BIT(3)
> +#define WPA2 BIT(4)
>
On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote:
>
> +static struct net_device *wilc_wfi_mon; /* global monitor netdev */
There might not exist platforms with multiple devices (yet), but it's
really bad practice to do this anyway.
> +static u8 srcadd[6];
> +static u8 bssid[6];
> +
>
On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote:
> Moved '/driver/staging/wilc1000/linux_wlan.c' to
> 'drivers/net/wireless/microchip/wilc/'.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/net/wireless/microchip/wilc/linux_wlan.c | 1161
> ++
> 1 file changed, 1161
> +#define WILC_TX_ERR_NO_BUF (-2)
Hmm? what's wrong with just e.g. -ENOBUFS? If it doesn't go to userspace
it doesn't matter, and if it does you can't use this anyway? This would
be -ENOENT which is a bad idea.
> +
> +/
> + *
> + * Wlan
> + *currbyte = (u32)0 & DRV_HANDLER_MASK;
You do this a few times, not sure what it's supposed to achieve?
> + if (param->flag & RETRY_LONG) {
> + u16 limit = param->long_retry_limit;
> +
> + if (limit > 0 && limit < 256) {
> +
On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote:
> +#include
you include it
> +#include "coreconfigurator.h"
> +
> +#define IDLE_MODE0x00
> +#define AP_MODE 0x01
> +#define STATION_MODE 0x02
> +#define GO_MODE 0x03
> +#define CLIENT_MODE 0x04
> +#define
> +static inline u16 get_beacon_period(u8 *data)
> +{
> + u16 bcn_per;
> +
> + bcn_per = data[0];
> + bcn_per |= (data[1] << 8);
> +
> + return bcn_per;
> +}
Remove and use get_unaligned_le16().
> +static inline u32 get_beacon_timestamp_lo(u8 *data)
> +{
> + u32 time_stamp
On Wed, 2018-10-03 at 19:20 +0800, yhchu...@realtek.com wrote:
If you use bitmaps for the security CAM index tracking,
this:
> +u32 rtw_sec_installed_cam_num(struct rtw_sec_desc *sec)
> +{
> + u32 cnt = 0;
> + int i;
> +
> + for (i = 0; i < sec->total_cam_num; i++)
> +
On Wed, 2018-10-03 at 19:20 +0800, yhchu...@realtek.com wrote:
>
> +static int rtw_ops_config(struct ieee80211_hw *hw, u32 changed)
> +{
> + struct rtw_dev *rtwdev = hw->priv;
> + int ret = 0;
> +
> + mutex_lock(>mutex);
> +
> + if (changed & IEEE80211_CONF_CHANGE_IDLE) {
> +
On Wed, 2018-10-03 at 19:20 +0800, yhchu...@realtek.com wrote:
>
> +config RTW88_CORE
> + tristate
> + depends on RTW88
> +
> +config RTW88_PCI
> + tristate
> + depends on RTW88_CORE && PCI
Those "depends on" lines are misleading, I don't think select honours
that?
> +++
On Wed, 2018-10-03 at 19:20 +0800, yhchu...@realtek.com wrote:
>
> + do {
> + cnt--;
> + value = rtw_read8(rtwdev, offset);
> + value &= cmd->mask;
> + if (value == (cmd->value & cmd->mask))
> + return 0;
> + if
> > This patch adds support for QSR1000/QSR2000 family of chipsets
> > to qtnfmac_pcie platform driver.
> >
> > QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2,
> > 4x4/2x4/2x2 chips, including single and dual band devices.
> > Depending on specific chip model and firmware in use,
On Wed, 2018-10-03 at 19:20 +0800, yhchu...@realtek.com wrote:
>
> +static struct dentry *debugfs_topdir;
> +
> +void rtw_debugfs_init(struct rtw_dev *rtwdev)
> +{
> + debugfs_topdir = debugfs_create_dir("rtw88", NULL);
You really can't do this, all hell will break lose if you ever plug two
On Wed, Oct 3, 2018 at 3:54 AM Luca Coelho wrote:
>
> Hi,
>
> We have updated all the firmwares we currently support.
>
> Please pull or let me know if there are any issues.
>
> Cheers,
> Luca.
>
>
> The following changes since commit 7c81f23ad903f72e87e2102d8f52408305c0f7a2:
>
>
Fix restore value configured in 0x2124 register in
mt76x0_phy_recalibrate_after_assoc routine.
Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
On 2018-10-08 13:22, Stanislaw Gruszka wrote:
> dma.h is not used any longer.
>
> Signed-off-by: Stanislaw Gruszka
Merged, thanks.
- Felix
On 2018-10-08 13:22, Stanislaw Gruszka wrote:
> Reserve enough room for USB skb, so we don not need to check
> the room every time we send frame.
>
> Signed-off-by: Stanislaw Gruszka
Merged, thanks.
- Felix
On 2018-10-07 11:57, Lorenzo Bianconi wrote:
> Enable client mode in mt76x0e driver registering the device to the mac80211
> layer. Moreover add missing mac80211 callbacks in mt76x0e_ops data structure.
> Sta mode has been tested connecting to a 802.11ac AP on 5GHz band
>
Merged, thanks.
- Felix
On 2018-10-07 11:51, Lorenzo Bianconi wrote:
> Report via ethtool fw_ver and build_ver members of mt76x02_fw_header
> data structure similarly to what is reported in the syslog
>
> Signed-off-by: Lorenzo Bianconi
Merged, thanks.
- Felix
On 2018-10-07 11:45, Lorenzo Bianconi wrote:
> Use mt76x02_dev data structure as reference in mt76x02 code
> instead of mt76_dev one
Merged, thanks.
- Felix
On 2018-10-07 11:37, Lorenzo Bianconi wrote:
> Fix typo in bank check in mt76x0_rf_csr_{wr,rr} routines.
> This issue has never been hit since mt76x0_rf_csr_{wr,rr}
> are actually used just by pci code
>
> Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> Signed-off-by: Lorenzo Bianconi
Merged,
Fixes a rare corner case where a BlockAckReq might get the wrong
sequence number.
Signed-off-by: Felix Fietkau
---
drivers/net/wireless/mediatek/mt76/tx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/tx.c
Sergey Matyukevich writes:
> This patch adds support for QSR1000/QSR2000 family of chipsets
> to qtnfmac_pcie platform driver.
>
> QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2,
> 4x4/2x4/2x2 chips, including single and dual band devices.
> Depending on specific chip model and
Reserve enough room for USB skb, so we don not need to check
the room every time we send frame.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 5 -
drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c | 17 +
dma.h is not used any longer.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/dma.h | 126
1 file changed, 126 deletions(-)
delete mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/dma.h
diff --git
From: Igor Mitsyanko
Single PCIe driver can identify hardware type by reading CHIP ID at
probe time and invoking a correct initialization sequence.
Signed-off-by: Igor Mitsyanko
---
drivers/net/wireless/quantenna/qtnfmac/Kconfig | 8 +-
drivers/net/wireless/quantenna/qtnfmac/Makefile
Hello Kalle and all,
Here is the next update for qtnfmac driver. This patch set adds
support for the previous generation of Quantenna wireless cards,
namely QSR1000/QSR2000 family of devices.
The summary of changes is as follows:
- the last bits of pcie layer unification work:
-- extract
Fix checkpatch warning: use preferred 'help' option in Kconfig.
Signed-off-by: Sergey Matyukevich
---
drivers/net/wireless/quantenna/Kconfig | 2 +-
drivers/net/wireless/quantenna/qtnfmac/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove redundant information from Pearl platform headers.
Signed-off-by: Sergey Matyukevich
---
.../quantenna/qtnfmac/pcie/pearl_pcie_ipc.h| 5 -
.../quantenna/qtnfmac/pcie/pearl_pcie_regs.h | 228 +
2 files changed, 3 insertions(+), 230 deletions(-)
diff
Change pcie bus layer licensing information to SPDX format.
Signed-off-by: Sergey Matyukevich
---
.../net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c| 17 ++---
.../wireless/quantenna/qtnfmac/pcie/pearl_pcie_ipc.h| 17 ++---
This patch adds support for QSR1000/QSR2000 family of chipsets
to qtnfmac_pcie platform driver.
QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2,
4x4/2x4/2x2 chips, including single and dual band devices.
Depending on specific chip model and firmware in use, either
STA or both STA and
> -Original Message-
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Thursday, October 04, 2018 10:37 PM
> To: Tony Chuang
> Cc: kv...@codeaurora.org; larry.fin...@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v3 09/12] rtw88: chip
> -Original Message-
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Monday, October 08, 2018 5:19 PM
> To: Kalle Valo
> Cc: Tony Chuang; larry.fin...@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v2 04/12] rtw88: trx files
>
> On
On Fri, Oct 05, 2018 at 12:07:06PM +, Tony Chuang wrote:
> > > +static void rtw_pci_dma_check(struct rtw_dev *rtwdev,
> > > + struct rtw_pci_rx_ring *rx_ring,
> > > + u32 idx)
> > > +{
> > > + struct rtw_chip_info *chip = rtwdev->chip;
> > > + struct
On Fri, Oct 05, 2018 at 09:20:01AM +, Tony Chuang wrote:
> > > + rcu_read_lock();
> > > +
> > > + bssid = get_hdr_bssid(hdr);
> > > + rtwvif = get_hdr_vif(rtwdev, hdr);
> > > + vif = rtwvif ? rtwvif->vif : NULL;
> > > + pkt_stat->vif = vif;
> > > + if
On Sat, Oct 06, 2018 at 03:32:11PM +0300, Kalle Valo wrote:
> Tony Chuang writes:
>
> >> > +pkt_info->bmc = bmc;
> >> > +pkt_info->sec_type = sec_type;
> >> > +pkt_info->tx_pkt_size = skb->len;
> >> > +pkt_info->offset = chip->tx_pkt_desc_sz;
> >> > +
> Lorenzo,
>
Hi Johannes,
> It would help - also for patchwork tracking - if you could thread your
> patch series properly.
>
> FWIW, that should be the default in git send-email, so I think you need
> to either update your version or change its configuration. Unless you
> weren't using
On Fri, Oct 05, 2018 at 09:19:31AM +, Tony Chuang wrote:
> > On Wed, Oct 03, 2018 at 04:02:22PM +0800, yhchu...@realtek.com wrote:
> > > +void rtw_fw_do_iqk(struct rtw_dev *rtwdev, struct rtw_iqk_para *para)
> > > +{
> > > + u8 h2c_pkt[H2C_PKT_SIZE] = {0};
> >
> > Not sure if '= {0}' work as
> -Original Message-
> From: Kalle Valo [mailto:kv...@codeaurora.org]
> Sent: Saturday, October 06, 2018 8:29 PM
> To: Tony Chuang
> Cc: Stanislaw Gruszka; larry.fin...@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v2 03/12] rtw88: hci files
>
>
Lorenzo,
It would help - also for patchwork tracking - if you could thread your
patch series properly.
FWIW, that should be the default in git send-email, so I think you need
to either update your version or change its configuration. Unless you
weren't using --compose option and sent the 0/N
> -Original Message-
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Thursday, October 04, 2018 7:43 PM
> To: Tony Chuang
> Cc: kv...@codeaurora.org; larry.fin...@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v2 02/12] rtw88: core
From: Johannes Berg
We want to call iwl_mvm_inactivity_check() from here in the
next patch, so need to move the code down to be able to.
Fix a minor checkpatch complaint while at it.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/sta.c |
From: Johannes Berg
We don't really need this state: instead of having an inactive
state where we can awaken zombie queues again if needed, just
keep them in their normal state unless a new queue is actually
needed and there's no other way of getting one.
We do this here by making the
From: Johannes Berg
We set the queue to this state, only to pretty much immediately
move it out of it again. However, we can't even hit any of the
code that checks if the queue is reconfiguring, because all of
this happens under mvm->mutex and we hold the all the way from
marking the queue as
From: Ayala Beker
Fast balance scan is similar to SCAN_TYPE_MILD, but this scan is
fragmented and has shorter out of operating channel time,
and therefore better match low latency scenarios.
Signed-off-by: Ayala Beker
Signed-off-by: Luca Coelho
---
From: Sara Sharon
Split TX tracing to be per TB. This is needed now that
AMSDUs can be sent and skb can be larger than trace
limit.
Signed-off-by: Sara Sharon
Signed-off-by: Luca Coelho
---
.../intel/iwlwifi/iwl-devtrace-data.h | 30 ---
From: Johannes Berg
There's no need to have a hw refcount if we just mark the
command queue with a (fake) TID; at that point, the refcount
becomes equivalent to the hweight() of the TID bitmap.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
From: Johannes Berg
None of these functions really need to be separate, they're all
only used in sta.c, move them there and make them static.
Fix a small typo in related code while at it.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
From: Sara Sharon
When we TX AMSDU, we shouldn't pad the packet. In the past,
we were building AMSDU only in transport layer, and gen2
functions are built based on this. However, now that op mode
may build AMSDUs, we need to take care of padding also in
gen2 "non-pcie-amsdu" path.
From: Sara Sharon
In the past, we needed to program the keys when entering D3. This was
since we replaced the image. However, now that there is a single
image, this is no longer needed. Note that RSC is sent separately in
a new command. This solves issues with newer devices that support PN
From: Johannes Berg
Make this a named struct rather than an anonymous one,
we'll want to refer to it by name later.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 24 +++-
1 file changed, 13 insertions(+), 11
From: Johannes Berg
We currently reconfigure the queues after the inactivity check,
but only in one of the two callers. This might leave queues in
a state where the TID owner is wrong, if called when reserving
a queue for a new station.
Clean this up and do the reconfiguration inside the
From: Johannes Berg
There's no need to build a bitmap first and then iterate,
just do the iteration with the right locking directly.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 32 +---
1 file changed, 15
From: Johannes Berg
If TVQM is used we skip over this, move the code into a new
function to get rid of the label.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 64 ++--
1 file changed, 33 insertions(+), 31
From: Johannes Berg
Instead of iterating all the queues after having potentially
changed some queue configurations, rechecking if that was done,
mark the ones that do need a TID change explicitly in a bitmap
and use that to send the change to the firmware.
While at it, also rename
From: Shahar S Matityahu
Move the rt status checking to the start of the resume flow in order
to avoid sending D0I3_END_CMD to the FW. Also, collect dump if an
assert was encountered.
Signed-off-by: Shahar S Matityahu
Signed-off-by: Luca Coelho
---
From: Shahar S Matityahu
Debug data dump is not working in flows that stop the device is used
in their error handling. During these flows the op mode mutex is
locked until the device stops. Because of that, any assert generated
from the firmware can be handled only after the device already
From: Johannes Berg
This function is only used in the file where it's declared,
so just make it static.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 6 +++---
drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 4
2 files changed,
From: Ayala Beker
Currently in case of DCM with P2P GO where BSS DTIM interval < 220 msec
the fw fails to allocate events for the P2P GO dtim due to long passive
scan events.
Fix this by requesting all scans in this scenario to be fragmented with
fast balance scan time settings. The only
From: Luca Coelho
Hi,
Here's the seventh set of patches intended for v4.20. It's the usual
development, the majority of the changes are cleanups in the queue
lifetime management code by Johannes, and also some improvements,
debugging and bugfixes again.
The changes are:
* Support for a new
> -Original Message-
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Thursday, October 04, 2018 10:23 PM
> To: Tony Chuang
> Cc: kv...@codeaurora.org; larry.fin...@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v3 08/12] rtw88:
Ajay Singh writes:
> On Sat, 6 Oct 2018 15:45:41 +0300
> Kalle Valo wrote:
>
>> Ajay Singh writes:
>>
>> > This patch set contains the driver files from
>> > 'driver/staging/wilc1000'. Renamed the driver from 'wilc1000' to
>> > 'wilc' to have generic name, as the same driver will be used by
70 matches
Mail list logo
