Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-31 Thread Daniel Lenski
On Tue, May 31, 2016 at 8:04 AM, Jes Sorensen wrote: > Given your follow-on discoveries, do you still want me to apply the poll > timeout patch, or should we wait until we nail down the reset code issue > first? No, I don't think the timeout patch is worth appying. I

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-23 Thread Daniel Lenski
On Mon, May 23, 2016 at 12:24 PM, Jes Sorensen wrote: > Interesting, so if I understand you correctly, if you run > rtl8xxxu_power_off() once, the driver comes up correctly? Right. If rtl8xxxu_init_device() fails, I simply call rtl8xxxu_power_off(), and then

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-20 Thread Daniel Lenski
On Fri, May 20, 2016 at 7:08 AM, Jes Sorensen <jes.soren...@redhat.com> wrote: > > Daniel Lenski <dlen...@gmail.com> writes: > > Unfortunately, I ran into a case today where even 5000 loops was not > > enough after a cold boot. 5000 loops meant about 1.5 seco

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-20 Thread Daniel Lenski
On Fri, May 20, 2016 at 1:50 PM, Daniel Lenski <dlen...@gmail.com> wrote: > Am I understanding your idea correctly? To put a loop around the 8051 > reset and the firmware polling loop, with a delay between failure and retry? That was some sloppy pseudo-code by me... here's what I

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-20 Thread Daniel Lenski
Jes Sorensen writes: > > Unfortunately, I ran into a case today where even 5000 loops was not > > enough after a cold boot. 5000 loops meant about 1.5 second delay > > between finishing the firmware checksum poll, while waiting for the > > firmware to start. It now

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

2016-05-19 Thread Daniel Lenski
You're welcome, and thanks for writing this great driver. It really makes a huge difference for stability of the Yoga 13 wifi! Unfortunately, I ran into a case today where even 5000 loops was not enough after a cold boot. 5000 loops meant about 1.5 second delay between finishing the firmware

Re: [PATCH 1/2] rtl8xxxu: Increase default polling timeout for firmware startup

2016-05-17 Thread Daniel Lenski
On Tue, May 17, 2016 at 8:35 PM, Jes Sorensen wrote: > Dan Lenski writes: >> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h >> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h >> index f2a1bac..39c6ce7 100644 >> ---

Re: [PATCH] Make firmware startup polling timeout configurable, and increase default

2016-05-17 Thread Daniel Lenski
Jes Sorensen writes: > > Dan Lenski writes: > > > > This issue seems to occur because RTL8XXXU_FIRMWARE_POLL_MAX (1000) is > > too short, and the MCU fails to start up as quickly as expected. > > > > With a longer value (5000), the driver starts up

rtl8xxxu: "Firmware failed to start" caused by too-short polling timeout

2016-05-17 Thread Daniel Lenski
Hi, I submitted a small patch for the r8723au driver a few months, and quickly abandoned that driver once Jes Sorensen pointed out his rtl8xxxu wireless driver which supports the same RTL8723AU chipset and is part of the mainline

Re: [PATCH] enable setting MAC address for r8723au

2015-12-24 Thread Daniel Lenski
On Wed, Dec 23, 2015 at 3:18 AM, Jes Sorensen <jes.soren...@redhat.com> wrote: > Daniel Lenski <dlen...@gmail.com> writes: >> On Mon, Dec 21, 2015 at 9:53 AM, Larry Finger <larry.fin...@lwfinger.net> >> wrote: >>> On 12/20/2015 08:28 PM, Dan Lenski wrote:

Re: [PATCH] enable setting MAC address for r8723au

2015-12-21 Thread Daniel Lenski
On Mon, Dec 21, 2015 at 9:53 AM, Larry Finger wrote: > On 12/20/2015 08:28 PM, Dan Lenski wrote: >> >> Signed-off-by: Dan Lenski > > > The commit message should be in this patch rather than in the non-patch > previous mail. If this patch were to be