Re: [PATCH 00/29] staging: wilc1000: avoid deferring of cfg80211 operation callback

On Sun, Dec 02, 2018 at 06:02:13PM +, ajay.kat...@microchip.com wrote: > 6 files changed, 755 insertions(+), 2012 deletions(-) Nice code removal, patch series all now applied. greg k-h

Re: [PATCH v4 1/3] staging: wilc1000: validate cfg parameters before scheduling the work

On Thu, Nov 08, 2018 at 09:50:25PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > From: Adham Abozaeid Twice? Something went wrong on your side, for all of these patches :( Please fix up and resend. thanks, greg k-h

Re: [PATCH v3 2/4] staging: wilc1000: validate cfg parameters before scheduling the work

On Tue, Nov 06, 2018 at 12:01:18AM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > Validate cfg parameters after being called by cfg80211 in set_wiphy_params > before scheduling the work executed in handle_cfg_param > > Signed-off-by: Adham Abozaeid > --- >

Re: [PATCH v2] staging: wilc1000: update wilc1000 driver maintainer ids

On Wed, Nov 07, 2018 at 05:05:01AM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > We would like to update the maintainer email id's for wilc1000 driver. > > Signed-off-by: Aditya Shankar > Signed-off-by: Ganesh Krishna > Signed-off-by: Adham Abozaeid > Signed-off-by: Ajay

Re: [PATCH v2 1/4] staging: wilc1000: remove unused flags in handle_cfg_param()

On Tue, Oct 30, 2018 at 04:22:55AM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > handle_cfg_param() receives a bit map that describes what to be changed. > Some of these bits flags aren't referred to from elsewhere and can be > removed. > > Signed-off-by: Adham Abozaeid

Re: [PATCH] staging: wilc1000: update wilc1000 driver maintainer ids

On Tue, Oct 30, 2018 at 05:53:40AM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > We would like to update the maintainer email id's for wilc1000 driver. > > Signed-off-by: Ajay Singh > Signed-off-by: Adham Abozaeid It would be good to get the current maintainer's signed off

Re: [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation"

On Thu, Sep 06, 2018 at 02:36:22PM -0700, Brian Norris wrote: > Hi Greg / stable maintainer(s), > > IIUC, this commit is a good candidate for -stable. I just hit the bug on > 4.14, because of new vendor firmware that noticed the mismatched length > (an internal "assert"), but it seems like this

Re: [PATCH 00/24] staging: wilc1000: avoid use of static and global variable

On Tue, Aug 14, 2018 at 12:19:52PM +0530, Ajay Singh wrote: > This patch set mainly contains changes to avoid the use of static > and global variables. Also contains few patch to avoid the checkpatch > warning arise due to code refactor. I'm dropping this whole series from my review queue as I

Re: [PATCH 23/24] staging: wilc1000: move 'wilc_connecting' static variable to 'wilc_vif' struct

On Tue, Aug 14, 2018 at 12:20:15PM +0530, Ajay Singh wrote: > --- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h > +++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h > @@ -151,6 +151,7 @@ struct wilc_vif { > struct timer_list periodic_rssi; > struct rf_info periodic_stat; >

Re: feedback on mainlining wilc1000 staging driver

On Thu, Aug 16, 2018 at 01:52:43AM +0530, Ajay Singh wrote: > Hi Greg, > > We all are working on submitting and reviewing patches for wilc1000 in > staging driver for quite some time. > > We would like to have feedback on the next steps to bring wilc1000 > driver closer to move into the

Re: [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type

On Sun, Aug 12, 2018 at 05:18:29PM +0530, Ajay Singh wrote: > Hi Greg, > > On Sun, 12 Aug 2018 13:29:30 +0200 > Greg KH wrote: > > > On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote: > > > Refactor code by removing array of 'wilc_debugfs_info_t' type

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

On Sun, Aug 12, 2018 at 05:48:52PM +0530, Ajay Singh wrote: > Hi Greg, > > On Sun, 12 Aug 2018 13:35:55 +0200 > Greg KH wrote: > > > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > > > wilc_debug.o object file is included for both SDIO and SPI module.

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >

Re: [PATCH 4/5] staging: wilc1000: change permission to 0600 in debugfs_create_file() call

On Sun, Aug 12, 2018 at 10:17:44AM +0530, Ajay Singh wrote: > Cleanup patch to use more restrictive access permission for debugfs > file. Why? What is the harm in writing to a value that is never used? :) thanks, greg k-h

Re: [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type

On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote: > Refactor code by removing array of 'wilc_debugfs_info_t' type and use > single variable to store 'wilc_debugfs_info_t' struct value. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_debugfs.c | 26

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

On Sun, Aug 12, 2018 at 04:52:04PM +0530, Ajay Singh wrote: > Hi Greg, > > On Sun, 12 Aug 2018 08:42:50 +0200 > Greg KH wrote: > > > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > > > wilc_debug.o object file is included for both SDIO and SPI module.

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

On Thu, Aug 09, 2018 at 03:51:55PM +0300, Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 02:13:24PM +0200, Greg KH wrote: > > On Thu, Aug 09, 2018 at 01:43:58PM +0300, Dan Carpenter wrote: > > > On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > > > >

Re: [PATCH v2] staging: wilc1000: fix undefined reference to `__this_module' compilation error

On Thu, Aug 09, 2018 at 04:59:39PM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >

Re: [PATCH] staging: wilc1000: fix undefined reference to `__this_module' compilation error

On Thu, Aug 09, 2018 at 01:43:58PM +0300, Dan Carpenter wrote: > On Thu, Aug 09, 2018 at 01:08:38PM +0300, Dan Carpenter wrote: > > On Thu, Aug 09, 2018 at 12:13:06PM +0530, Ajay Singh wrote: > > > wilc_dir = debugfs_create_dir("wilc_wifi", NULL); > > > - for (i = 0; i <

Re: [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range

On Fri, Aug 03, 2018 at 01:58:51PM +0530, Ajay Singh wrote: > Hi Greg, > > On Thu, 2 Aug 2018 09:34:15 +0200 > Greg KH wrote: > > > On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote: > > > Cleanup patch to avoid the below checkpatch reported iss

Re: [PATCH] staging: wilc1000: fix compilation warning for ARCH PowerPC

On Thu, Aug 02, 2018 at 04:57:02PM +0530, Ajay Singh wrote: > Fix below warning reported for PowerPC arch compilation > > include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing > argument 1 of '__swab32s' makes pointer from integer without a cast > [-Wint-conversion] > > Fixes:

Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > Cleanup patch to fix below checkpatch reported issue: > > Macro argument 'id' may be better as '(id)' to avoid precedence issues > > Also updated the TODO file to remove the below item > 'rework comments and function headers(also

Re: [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range

On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote: > Cleanup patch to avoid the below checkpatch reported issue. > > "usleep_range is preferred over udelay; see > Documentation/timers/timers-howto.txt". > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 2 +-

Re: [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file

On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote: > Cleanup patch to remove the unnecessary copyright information in > the file, as it already has SPDX License Identifier. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_debugfs.c | 10 -- >

Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Mon, Jun 18, 2018 at 04:11:51PM +0300, Kalle Valo wrote: > Greg KH writes: > > > On Mon, Jun 18, 2018 at 10:29:43AM +0300, Kalle Valo wrote: > >> Greg KH writes: > >> > >> > On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote: > >

Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Mon, Jun 18, 2018 at 10:29:43AM +0300, Kalle Valo wrote: > Greg KH writes: > > > On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote: > >> The BIT macro uses unsigned long which some architectures handle as 32 bit > >> and therefore might cause macro

Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote: > The BIT macro uses unsigned long which some architectures handle as 32 bit > and therefore might cause macro's shift to overflow when used on a value > equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards). > > Since

Re: [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Thu, Jun 14, 2018 at 01:13:37PM +0300, Omer Efrat wrote: > Since 'filled' member in station_info changed to u64, BIT_ULL macro > should be used with NL80211_STA_INFO_* attribute types instead of BIT. > > The BIT macro uses unsigned long type which some architectures handle as 32bit > and this

Re: [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Thu, Jun 14, 2018 at 01:09:34PM +0200, Johannes Berg wrote: > On Thu, 2018-06-14 at 13:13 +0300, Omer Efrat wrote: > > Since 'filled' member in station_info changed to u64, BIT_ULL macro > > should be used with NL80211_STA_INFO_* attribute types instead of BIT. > > > > The BIT macro uses

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

On Fri, May 18, 2018 at 10:56:25AM +0200, Arend van Spriel wrote: > On 5/17/2018 6:46 PM, Greg KH wrote: > > On Thu, May 17, 2018 at 06:40:04PM +0200, Greg KH wrote: > > > Adding the network and NFC developers as this really is a NFC driver > > > bug, not a USB core i

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

On Thu, May 17, 2018 at 06:40:04PM +0200, Greg KH wrote: > Adding the network and NFC developers as this really is a NFC driver > bug, not a USB core issue... > > On Thu, May 17, 2018 at 04:12:17PM +0200, Greg KH wrote: > > On Thu, May 17, 2018 at 02:10:57PM +0100, Carlos M

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

Adding the network and NFC developers as this really is a NFC driver bug, not a USB core issue... On Thu, May 17, 2018 at 04:12:17PM +0200, Greg KH wrote: > On Thu, May 17, 2018 at 02:10:57PM +0100, Carlos Manuel Santos wrote: > > Hello. > > I'm having troubles with this NFC card r

Re: WARNING in kernfs_add_one

On Sat, May 05, 2018 at 10:43:45AM -0700, Eric Dumazet wrote: > > > On 05/05/2018 09:40 AM, Greg KH wrote: > > On Sat, May 05, 2018 at 08:47:02AM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >

Re: [PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On Mon, Apr 30, 2018 at 11:56:25AM +0530, Sriram R wrote: > ath10k has a replay detection issue which was fixed in v4.14 and we would > like to get this security fix also to linux-stable-4.4.But for that it > depends on 3 mac80211 patches so the below mac80211 commits needs to be > picked first in

Re: [PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call

On Wed, May 02, 2018 at 08:59:28PM +0300, Andy Shevchenko wrote: > On Wed, 2018-05-02 at 23:19 +0530, Amit Pundir wrote: > > > - dev_dbg(dev, "%s\n", __func__); > > + dev_dbg(dev, "\n"); > > If one enables function tracer this will be redundant completely. Yes those kinds of "trace" debug

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On Tue, May 01, 2018 at 05:44:19AM +0530, Sriram R wrote: > On 2018-05-01 05:14, Sriram R wrote: > > On 2018-05-01 00:39, Greg KH wrote: > > > On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote: > > > > Rx data frames notified t

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified

Re: [PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On Mon, Apr 30, 2018 at 11:56:25AM +0530, Sriram R wrote: > ath10k has a replay detection issue which was fixed in v4.14 and we would > like to get this security fix also to linux-stable-4.4.But for that it > depends on 3 mac80211 patches so the below mac80211 commits needs to be > picked first in

Re: [PATCH v2 01/21] staging: wilc1000: replace crc7_byte() with inline macro CRC7_BYTE

On Wed, Apr 25, 2018 at 10:48:06PM +0530, Ajay Singh wrote: > Replace the function call for crc7_byte() with macro CRC7_BYTE. > crc7_byte() was called in close while(), so replaced it with macro to > avoid extra functional call depth. > > Signed-off-by: Ajay Singh >

Re: [PATCH 1/2] firmware: some documentation fixes

On Wed, Apr 25, 2018 at 12:25:39PM -0400, Andres Rodriguez wrote: > Including: > - Fixup outdated kernel-doc paths > - Slightly too short title underline > - Some typos > > Signed-off-by: Andres Rodriguez > --- > > Hey Greg, > > Here is the patch rebased on

Re: [PATCH 2/2] usb: typec: fix formatting errors that cause build breakage

On Wed, Apr 25, 2018 at 12:25:40PM -0400, Andres Rodriguez wrote: > The ASCII art illustration should be marked as a preformatted text > block. Otherwise the build will fail when attempting to parse it. > > Fixes: bdecb33af34f ( "usb: typec: API for controlling USB ..." ) > Signed-off-by: Andres

Re: [PATCH 1/9] firmware: some documentation fixes

On Wed, Apr 25, 2018 at 05:25:26PM +0200, Greg KH wrote: > On Mon, Apr 23, 2018 at 04:11:57PM -0400, Andres Rodriguez wrote: > > Including: > > - Fixup outdated kernel-doc paths > > - Slightly too short title underline > > - Some typos > > > >

Re: [PATCH 1/9] firmware: some documentation fixes

On Mon, Apr 23, 2018 at 04:11:57PM -0400, Andres Rodriguez wrote: > Including: > - Fixup outdated kernel-doc paths > - Slightly too short title underline > - Some typos > > Signed-off-by: Andres Rodriguez > --- > Documentation/driver-api/firmware/request_firmware.rst | 16

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

On Mon, Apr 23, 2018 at 07:31:38PM +0530, Ajay Singh wrote: > On Mon, 23 Apr 2018 15:45:38 +0200 > Greg KH <gre...@linuxfoundation.org> wrote: > > > On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > > > This patch series is based on top of > > >

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > This patch series is based on top of > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > malloc memory properly" and its not applied yet.[1] I don't have that patch set in my queue. So please resend all outstanding

Re: [RESEND][PATCH 4/4] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

On Wed, Apr 18, 2018 at 03:35:04PM +0530, Amit Pundir wrote: > From: Suren Baghdasaryan > > Possible buffer overflow when reading next_read_size bytes into > tmp buffer after next_read_size was extracted from a previous packet. > > Signed-off-by: Suren Baghdasaryan

Re: License info

On Tue, Apr 03, 2018 at 09:53:29PM +0200, Xose Vazquez Perez wrote: > Larry Finger wrote: > > > What is your position regarding license information? Should the standard > > GPL-V2 > > boiler plate be replaced with "SPDX-License-Identifier: GPL-2.0" in > > wireless files? > > "GPL-2.0" tag is

Re: [PATCH v2 1/9] staging: wilc1000: remove unused global variables related to p2p

On Mon, Mar 26, 2018 at 05:15:55PM +0530, Ajay Singh wrote: > Cleanup patch to remove the unused global variables defined for p2p. > > Signed-off-by: Ajay Singh > Reviewed-by: Claudiu Beznea > --- >

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > Please let me know, in case I have to rework and resubmit this patch > series to make them into staging branch. You already sent a v2 series for this, right? Why respond to the v1 set? confused, greg k-h

Re: [PATCH v2 2/2] drivers: remove force dma flag from buses

On Wed, Mar 21, 2018 at 04:28:46PM +, Nipun Gupta wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Wednesday, March 21, 2018 15:05 > > To: Nipun Gupta <nipun.gu...@nxp.com> > >

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

On Tue, Mar 20, 2018 at 06:24:09PM +, Luis R. Rodriguez wrote: > On Tue, Mar 20, 2018 at 06:38:01PM +0100, Greg KH wrote: > > On Tue, Mar 20, 2018 at 05:34:09PM +, Luis R. Rodriguez wrote: > > > On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote: > > > >

Re: [PATCH v2 2/2] drivers: remove force dma flag from buses

On Wed, Mar 21, 2018 at 12:25:23PM +0530, Nipun Gupta wrote: > With each bus implementing its own DMA configuration callback, > there is no need for bus to explicitly have force_dma in its > global structure. This patch modifies of_dma_configure API to > accept an input parameter which specifies

Re: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure

On Wed, Mar 21, 2018 at 12:25:22PM +0530, Nipun Gupta wrote: > It's bus specific aspect to map a given device on the bus and > relevant firmware description of its DMA configuration. > So, this change introduces '/dma_configure/' as bus callback > giving flexibility to busses for implementing its

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

On Tue, Mar 20, 2018 at 05:34:09PM +, Luis R. Rodriguez wrote: > On Tue, Mar 20, 2018 at 09:30:55AM +0100, Greg KH wrote: > > On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote: > > > +EXPORT_SYMBOL_GPL(request_firmware_cache); > > > > I know you a

Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.ela...@gmail.com wrote: > From: HariPrasath Elango > > In this case,there is only a single switch case statement.So replacing > by a simple if condition > > Signed-off-by: HariPrasath Elango

Re: [PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

On Sat, Mar 10, 2018 at 06:15:00AM -0800, Luis R. Rodriguez wrote: > Some devices have an optimization in place to enable the firmware to > be retaineed during a system reboot, so after reboot the device can skip > requesting and loading the firmware. This can save up to 1s in load > time. The

Re: [PATCH 5/7] staging: wilc1000: replace switch statement by simple if condition

On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com wrote: > From: HariPrasath Elango > > In this case,there is only a single switch case statement.So replacing > by a simple if condition. > > Signed-off-by: HariPrasath Elango

Re: [PATCH v3 11/20] firmware: enable to force disable the fallback mechanism at run time

On Sat, Mar 10, 2018 at 06:14:52AM -0800, Luis R. Rodriguez wrote: > You currently need four different kernel builds to test the firmware > API fully. By adding a proc knob to force disable the fallback mechanism > completely we are able to reduce the amount of kernels you need built > to test the

Re: [PATCH v3 07/20] firmware: move loading timeout under struct firmware_fallback_config

On Sat, Mar 10, 2018 at 06:14:48AM -0800, Luis R. Rodriguez wrote: > The timeout is a fallback construct, so we can just stuff the > timeout configuration under struct firmware_fallback_config. Why? What does it matter? > While at it, add a few helpers which vets the use of getting or > setting

Re: [PATCH v3 06/20] firmware: use helpers for setting up a temporary cache timeout

On Sat, Mar 10, 2018 at 06:14:47AM -0800, Luis R. Rodriguez wrote: > We only use the timeout for the firmware fallback mechanism > except for trying to set the timeout during the cache setup > for resume/suspend. For those cases, setting the timeout should > be a no-op, so just reflect this in

Re: [PATCH v3 05/20] firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK further

On Sat, Mar 10, 2018 at 06:14:46AM -0800, Luis R. Rodriguez wrote: > All CONFIG_FW_LOADER_USER_HELPER_FALLBACK really is, is just a bool, > initailized at build time. Define it as such. This simplifies the > logic even further, removing now all explicit #ifdefs around the code. > > Acked-by: Kees

Re: [PATCH v3 00/20] firmware: development for v4.17

On Wed, Mar 14, 2018 at 05:44:03PM +, Luis R. Rodriguez wrote: > On Sat, Mar 10, 2018 at 09:16:36AM -0800, Kees Cook wrote: > > On Sat, Mar 10, 2018 at 6:14 AM, Luis R. Rodriguez > > wrote: > > > Greg, > > > > > > Here's a respin of what I have queued up for v4.17 for the

Re: [PATCH 00/12] fix to remove line over 80 chars and few other

On Fri, Feb 16, 2018 at 08:41:37PM +0530, Ajay Singh wrote: > This patch series contains changes to fix line over 80 characters, > too many leading tabs and few other issues reported by checkpatch.pl > script. Please put the proper prefix on your 00/XX patches, that are with your other patches.

Re: [PATCH 4/6] staging: wilc1000: fix line over 80 characters in wilc_spi_init()

On Wed, Feb 14, 2018 at 04:40:13PM +0530, Ajay Singh wrote: > Modified wilc_spi_init() to fix the line over 80 char issues reported > by checkpatch.pl script. > To overcome the checkpatch.pl reported issue modified debug logs and > comments used in wilc_spi_init(). > > Signed-off-by: Ajay Singh

[PATCH] sysfs: turn WARN() into pr_warn()

From: Greg Kroah-Hartman It's not good to crash the machine if panic_on_warn() is set just because someone made a stupid mistake of trying to create a sysfs file with the same name of an existing one. This makes the automated testing tools a lot harder to find the

Re: WARNING in sysfs_warn_dup

On Mon, Jan 22, 2018 at 03:30:12PM +0100, Dmitry Vyukov wrote: > On Mon, Jan 22, 2018 at 3:00 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: > >> On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov &l

Re: WARNING in sysfs_warn_dup

On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov <dvyu...@google.com> wrote: > > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov <dvyu...@google.com> wrote: > >> > >> On Tue,

Re: Google Summer of Code 2018 - Project ideas page for the Linux Foundation online

On Thu, Jan 18, 2018 at 10:59:14AM -0200, Till Kamppeter wrote: > Hi, > > I have set up a page for project ideas for the Linux Foundation's > participation in the Google Summer of Code 2018: > > https://wiki.linuxfoundation.org/gsoc/google-summer-code-2018 > > Please add your ideas to the

Re: [PATCH v2 5/9] staging: wilc1000: removed few unnecessary enums typedef

On Wed, Jan 10, 2018 at 04:42:47PM +0530, Ajay Singh wrote: > This patch removes following N_OPERATING_MODE_T,N_OBSS_DETECTION_T, > N_PROTECTION_TYPE_T,N_SMPS_MODE_T,TX_ABORT_OPTION_T, typedef enum. > Now, these enums are used as anonymous-enums for constants. > > checkpatch.pl warning to not add

Re: [PATCH] staging: wilc1000: removed typedef from enum BSSTYPE_T

On Tue, Jan 09, 2018 at 02:37:42PM +0530, Ajay Singh wrote: > This patch removes typedef from enum BSSTYPE_T and > rename it to bss_types. > > It fixes "WARNING: do not add new typdefs" warning > reported by checkpatch.pl. > > Signed-off-by: ajaysk Hi, This is the

Re: [PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

On Tue, Jan 09, 2018 at 09:40:06AM +0800, Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with usleep_range, > to reduce busy wait. > > Signed-off-by: Jia-Ju Bai >

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: > Hi all, > > When I tried to use devm_ioremap function and review related code, I found > devm_ioremap and devm_ioremap_nocache is almost the same with each other, > except one use ioremap while the other use ioremap_nocache. For all

Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache

On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote: > --- a/lib/devres.c > +++ b/lib/devres.c > @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, > resource_size_t offset, > EXPORT_SYMBOL(devm_ioremap); > > /** > - * devm_ioremap_nocache - Managed ioremap_nocache() >

Re: [PATCH] staging: wilc1000: Fix lines ending with parentheses

On Sat, Dec 16, 2017 at 01:25:19PM +0530, Aditya Shankar wrote: > This patch fixes the "Lines should not end with a '('" > problem reported by checkpatch > > Signed-off-by: Aditya Shankar > --- > drivers/staging/wilc1000/linux_mon.c | 12 ++-- > 1 file

Re: [PATCH v3] rtlwifi:rtl8723ae:add the function name to the printouts

On Fri, Nov 24, 2017 at 05:11:20PM +0530, venkat.prashanth2...@gmail.com wrote: > From: Venkat Prashanth B U > > Prefer and make it generic by using %s and __func__ > to print function name > > Change Log: > > v2: > a. RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,

Re: [PATCH] rtlwifi:rtl8723ae: Fix embedded function names with __func__ Prefer and make it generic by using %s and __func__ to print functions name instead of embedding functions name in print statem

On Mon, Nov 20, 2017 at 06:03:19PM +0530, venkat.prashanth2...@gmail.com wrote: > From: Venkat Prashanth B U > > --- Something when really wrong when you created your patch :( Please always send it to yourself first, and of course, use scripts/checkpatch.pl to

Re: [PATCH] iwlwifi: fix firmware names for 9xxx and a0 series hw

On Tue, Nov 14, 2017 at 01:38:20PM +0200, Luciano Coelho wrote: > On Tue, 2017-11-14 at 13:29 +0200, Thomas Backlund wrote: > > Den 14-11-2017 kl. 12:52, skrev Luca Coelho: > > > On Tue, 2017-11-14 at 12:37 +0200, Thomas Backlund wrote: > > > > iwlwifi 9xxx and a0 series hw contains an extra dash

Re: [PATCH v4.9] nl80211: Define policy for packet pattern attributes

On Wed, Oct 11, 2017 at 10:32:09AM +0200, Johannes Berg wrote: > From: Peng Xu > > Upstream commit ad670233c9e1d5feb365d870e30083ef1b889177. > > Define a policy for packet pattern attributes in order to fix a > potential read over the end of the buffer during

Re: [PATCH] brcmfmac: add length check in brcmf_cfg80211_escan_handler()

On Thu, Oct 12, 2017 at 11:54:12AM +0200, Arend van Spriel wrote: > commit 17df6453d4be17910456e99c5a85025aa1b7a246 upstream. > > Upon handling the firmware notification for scans the length was > checked properly and may result in corrupting kernel heap memory > due to buffer overruns. This fix

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the

Re: [PATCH V2 1/3] brcmfmac: Avoid possible out-of-bounds read

On Tue, Sep 12, 2017 at 10:18:00AM +0200, Arend van Spriel wrote: > + Greg KH > > On 9/12/2017 10:05 AM, Kalle Valo wrote: > > Arend van Spriel <arend.vanspr...@broadcom.com> writes: > > > > > On 9/12/2017 9:47 AM, Kalle Valo wrote: > > > > Arend

Re: [PATCH v2 1/2] wireless: move prism54 out to staging

On Mon, Aug 07, 2017 at 03:30:10PM -0700, Luis R. Rodriguez wrote: > prism54 is deprecated in favor of the p54pci device driver. Although > only *one soul* had reported issues with it long ago Linux most Linux > distributions these days just disable the device driver given the > conflicts with the

Re: New Realtek driver

On Sat, Jul 22, 2017 at 07:51:20AM -0500, Larry Finger wrote: > On 07/21/2017 10:51 PM, Greg KH wrote: > > On Fri, Jul 21, 2017 at 07:36:41PM -0500, Larry Finger wrote: > > > On 07/21/2017 10:08 AM, Greg KH wrote: > > > > On Thu, Jul 20, 2017 at 08:18:

Re: New Realtek driver

On Fri, Jul 21, 2017 at 07:36:41PM -0500, Larry Finger wrote: > On 07/21/2017 10:08 AM, Greg KH wrote: > > On Thu, Jul 20, 2017 at 08:18:13PM -0500, Larry Finger wrote: > > > Kalle and Greg, > > > > > > Once again I find myself in the awkward position of

Re: New Realtek driver

On Thu, Jul 20, 2017 at 08:18:13PM -0500, Larry Finger wrote: > Kalle and Greg, > > Once again I find myself in the awkward position of needing to submit code > to two different trees, i.e. wireless and staging. > > The code in question concerns a new Realtek device, the RTL8822BE. The > device

Re: [PATCH v2 1/1] rtl8188eu: add TL-WN722N v2 support

On Mon, Jul 17, 2017 at 12:03:07PM -0400, Michael Gugino wrote: > From: Michael Gugino > > This patch adds support for USB Device TP-Link TL-WN722N v2. > VendorID: 0x2357, ProductID: 0x010c > > Signed-off-by: Michael Gugino > --- >

Re: [PATCH 1/1] rtl8188eu: add TL-WN722N v2 support

On Mon, Jul 17, 2017 at 11:59:35AM -0400, Michael Gugino wrote: > From: Michael Gugino > > This patch adds support for USB Device TP-Link TL-WN722N v2. > VendorID: 0x2357, ProductID: 0x010c > > Signed-off-by: Michael Gugino > --- >

Re: 'skb' buffer address information leakage

On Tue, Jul 04, 2017 at 01:12:18PM +0800, Dison River wrote: > Hi all: > I'd found several address leaks of "skb" buffer.When i have a > arbitrary address write vulnerability in kernel(enabled kASLR),I can > use skb's address find sk_destruct's address and overwrite it. And > then,invoke

Re: [PATCH v2 5/8] staging: wilc1000: Add new variable for ac queue management

On Mon, Jun 26, 2017 at 05:13:27PM +0530, Aditya Shankar wrote: > This patch adds a new variable in the wilc struct to manage > ac queues. > > Signed-off-by: Aditya Shankar > --- > drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + > 1 file changed, 1

Re: [PATCH v2 3.18-stable] mac80211/wpa: use constant time memory comparison for MACs

On Mon, Jun 19, 2017 at 06:44:06PM +0200, Jason A. Donenfeld wrote: > Otherwise, we enable all sorts of forgeries via timing attack. > > Signed-off-by: Jason A. Donenfeld > Cc: Johannes Berg > Cc: linux-wireless@vger.kernel.org > Cc:

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > Driver ks7010 does not currently have a maintainer. > > Add maintainers entry for ks7010. > > Signed-off-by: Tobin C. Harding > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > Current driver implements the WEXT interface. WEXT is in maintenance > mode, we need to re-write the driver using cfg80211. The current > driver is handy as a reference for the new implementation, we can keep > it in tree for now.

Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

On Sat, May 06, 2017 at 03:47:50AM +1000, Ian W MORRISON wrote: > The following patch was sent to linux-wireless@vger.kernel.org and > various wifi driver developers however I've just realized that I > should have sent it to driverdev-de...@linuxdriverproject.org. It was > reviewed on 01 May with

Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

On Fri, Apr 28, 2017 at 08:50:05AM +1000, Ian W MORRISON wrote: > This patch is to remove the re-positioned call to kfree() in > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise > results in segmentation fault. > > Signed-off-by: Ian W Morrison > --- >

Re: [PATCH 1/2] staging: vt6656: use off stack for out buffer USB transfers.

On Sat, Apr 22, 2017 at 11:14:57AM +0100, Malcolm Priestley wrote: > Since 4.9 mandated USB buffers be heap allocated this causes the driver > to fail. It's really been a requirement since the 2.2 days, it's just that not many people ran USB drivers on the platforms that required it :) thanks,

Re: [PATCH RFC] staging: wilc1000: Refactor handling of HT caps fields

On Tue, Apr 25, 2017 at 10:46:25PM -0600, Jason Litzinger wrote: > The patch with this RFC addresses the following sparse warnings: So are you going to resend this as a non-RFC patch so that I can apply it? :) thanks, greg k-h

Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

On Thu, Apr 27, 2017 at 11:42:38PM +1000, Ian W MORRISON wrote: > Hi, html email is rejected by vger, also please always cc: the driverdev mailing list for staging patches. And finally, I need all patches in a format that I can apply them in (i.e. not as attachments.) Can you fix that up and

Re: [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler

On Thu, Apr 13, 2017 at 08:14:23AM +0530, Aditya Shankar wrote: > On Tue, 11 Apr 2017 19:35:46 +0200 > Greg KH <gre...@linuxfoundation.org> wrote: > > > On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote: > > > Change the config packet format used

Re: [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler

On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote: > Change the config packet format used in handle_set_wfi_drv_handler() > to align the host driver with the new format used in the wilc firmware. > > The change updates the format in which the host driver provides the > firmware with

  1   2   3   4   >