[PATCH 1/5] cfg80211: Parsing of Multiple BSSID information in scanning

2018-12-07 Thread Jouni Malinen
Berg Signed-off-by: Jouni Malinen --- net/wireless/core.h | 1 + net/wireless/scan.c | 504 2 files changed, 466 insertions(+), 39 deletions(-) diff --git a/net/wireless/core.h b/net/wireless/core.h index c5d6f34..d58c56a 100644 --- a/net

[PATCH 2/5] cfg80211: Properly track transmitting and non-transmitting BSS

2018-12-07 Thread Jouni Malinen
From: Sara Sharon When holding data of the non-transmitting BSS, we need to keep the transmitting BSS data on. Otherwise it will be released, and release the non-transmitting BSS with it. Signed-off-by: Sara Sharon Signed-off-by: Johannes Berg Signed-off-by: Jouni Malinen --- net/wireless

[PATCH 4/5] mac80211: Declare support for Multi-BSSID if driver supports it

2018-12-07 Thread Jouni Malinen
From: Sara Sharon Define bits and flags for indicating support of Multi-BSSID feature and indicate support for this if the driver supports it. Signed-off-by: Sara Sharon Signed-off-by: Johannes Berg Signed-off-by: Jouni Malinen --- include/linux/ieee80211.h | 6 ++ include/net/mac80211

[PATCH 5/5] mac80211_hwsim: Declare support for Multi-BSSID

2018-12-07 Thread Jouni Malinen
This can be used to test cfg80211 support for Multi-BSSID scan result parsing. Signed-off-by: Jouni Malinen --- drivers/net/wireless/mac80211_hwsim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 0540834

[PATCH 3/5] cfg80211: Move Multiple BSS info to struct cfg80211_bss to be visible

2018-12-07 Thread Jouni Malinen
From: Sara Sharon Previously the transmitted BSS and the non-trasmitted BSS list were defined in struct cfg80211_internal_bss. Move them to struct cfg80211_bss since mac80211 needs this info. Signed-off-by: Sara Sharon Signed-off-by: Johannes Berg Signed-off-by: Jouni Malinen --- include

Re: [RFC PATCH v2 0/2] Extended Key ID support for linux

2018-12-07 Thread Jouni Malinen
ernel changes are concerned, cfg80211 and mac80211 should support everything that's allowed by the standard, i.e., use of Key IDs 0..3 for GTK. It is up to the user space implementation on the AP side (e.g., hostapd) to select which Key IDs are actually taken into use. -- Jouni MalinenPGP id EFC895FA

[PATCH] cfg80211: Fix busy loop regression in ieee80211_ie_split_ric()

2018-12-05 Thread Jouni Malinen
is currently used only for testing purposes, so this does not cause significant harm for production use cases. Fixes: 2512b1b18d07 ("mac80211: extend ieee80211_ie_split to support EXTENSION") Signed-off-by: Jouni Malinen --- net/wireless/util.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 3/3] mac80211: Extend SAE authentication in infra BSS STA mode

2018-10-10 Thread Jouni Malinen
he new ieee80211_mark_sta_auth() helper function can handle both completion of authentication and updates to the STA entry under the same condition and there is no need to return from the function between those operations. Signed-off-by: Jouni Malinen --- net/mac80211/ieee80211_i.h | 1 + net/mac80211/mlme.c

[PATCH 1/3] mac80211: Helper function for marking STA authenticated

2018-10-10 Thread Jouni Malinen
Authentication exchange can be completed in both TX and RX paths for SAE, so move this common functionality into a helper function to avoid having to implement practically the same operations in two places when extending SAE implementation in the following commits. Signed-off-by: Jouni Malinen

[PATCH 2/3] mac80211: Move ieee80211_mgd_auth() EBUSY check to be before allocation

2018-10-10 Thread Jouni Malinen
be used anyway in the error case. Signed-off-by: Jouni Malinen --- net/mac80211/mlme.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 2d3ec01..1818dbc 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c

[PATCH] nl80211: Add per peer statistics to compute FCS error rate

2018-09-27 Thread Jouni Malinen
without full accuracy can be used, e.g., to trigger a kick-out of a connected client with a bad link in AP mode to force such a client to roam to another AP. Signed-off-by: Ankita Bajaj Signed-off-by: Jouni Malinen --- include/net/cfg80211.h | 7 +++ include/uapi/linux/nl80211.h | 8

Re: SAE authentication frames in client mode

2018-09-20 Thread Jouni Malinen
ion exchange from scratch which is likely sufficient for covering robustness needs with all the link layer retries making it sufficiently unlikely for the Authentication frames to be lost completely. -- Jouni MalinenPGP id EFC895FA

Re: SAE authentication frames in client mode

2018-09-19 Thread Jouni Malinen
ed in the Linux implementation, but this flexibility is not extended to the infrastructure case on purpose. -- Jouni MalinenPGP id EFC895FA

[PATCH] cfg80211: Address some corner cases in scan result channel updating

2018-09-05 Thread Jouni Malinen
the function is trying to achieve to make it easier to understand what happens here and why. Signed-off-by: Jouni Malinen --- net/wireless/scan.c | 58 - 1 file changed, 49 insertions(+), 9 deletions(-) diff --git a/net/wireless/scan.c b/net/wireless

[PATCH] cfg80211: nl80211_update_ft_ies() to validate NL80211_ATTR_IE

2018-08-29 Thread Jouni Malinen
checking that NL80211_ATTR_IE is included. Fixes: 355199e02b83 ("cfg80211: Extend support for IEEE 802.11r Fast BSS Transition") Signed-off-by: Arunk Khandavalli Signed-off-by: Jouni Malinen --- net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless/n

[PATCHv2] cfg80211: Call reg_notifier for self managed hints conditionally

2018-04-26 Thread Jouni Malinen
; Signed-off-by: Jouni Malinen <jo...@codeaurora.org> --- net/wireless/reg.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) v2 - merge the two patches into a single one - instead of modifying reg_only_self_managed_wiphys() use a new

Re: Wi-Fi Disconnection on Suspend for no wowlan triggers

2018-04-05 Thread Jouni Malinen
s. And if the default behavior should be changed, should that behavior change be done in the kernel or user space (wpa_supplicant)? -- Jouni MalinenPGP id EFC895FA

Re: [PATCH v4 1/3] mac80211_hwsim: add permanent mac address option for new radios

2018-03-19 Thread Jouni Malinen
gt; + hw->wiphy->addresses = data->addresses; Why did that ORing of 0x40 got moved to be before the memcpy()? Effectively, that removes the OR operation completely since the following memcpy() overrides the first octets of data->addresses[1].addr. Restoring the order of those two lines seems to fix the behavior. -- Jouni MalinenPGP id EFC895FA

[PATCH 2/2] cfg80211: Modify wiphy registration semantics for self managed hints

2018-03-03 Thread Jouni Malinen
equest. This is needed to allow trusted regulatory domain changes to be processed by the driver. Signed-off-by: Amar Singhal <asing...@codeaurora.org> Signed-off-by: Kiran Kumar Lokere <klok...@codeaurora.org> Signed-off-by: Jouni Malinen <jo...@codeaurora.org> --- net/wireless/re

[PATCH 1/2] cfg80211: Enhance semantics for self-managed hints

2018-03-03 Thread Jouni Malinen
ff-by: Kiran Kumar Lokere <klok...@codeaurora.org> Signed-off-by: Jouni Malinen <jo...@codeaurora.org> --- include/net/regulatory.h | 7 --- net/wireless/reg.c | 14 ++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/include/net/regulatory.h b/

Re: [PATCH v2] ieee80211: Increase the PMK maximum length to 64 bytes

2018-02-10 Thread Jouni Malinen
tised? The limits can be different for each particular use of NL80211_ATTR_PMK (NL80211_CMD_CONNECT, NL80211_CMD_ASSOCIATE, NL80211_START_AP, NL80211_CMD_SET_PMKSA (for FILS), NL80211_CMD_SET_PMKSA (for DPP), NL80211_CMD_SET_PMKSA (for something else), NL80211_CMD_SET_PMK). -- Jouni MalinenPGP id EFC895FA

[PATCH] nl80211: Fix external_auth check for offloaded authentication

2018-02-02 Thread Jouni Malinen
). Fix this by adding back the lost '!'. Fixes: 40cbfa90218b ("cfg80211/nl80211: Optional authentication offload to userspace") Signed-off-by: Srinivas Dasari <dasa...@codeaurora.org> Signed-off-by: Jouni Malinen <jo...@codeaurora.org> --- net/wireless/nl80211.c | 2 +- 1 fil

[PATCH v3 2/3] cfg80211/nl80211: Optional authentication offload to userspace

2018-01-25 Thread Jouni Malinen
P flag in the NL80211_CMD_CONNECT request. Host drivers shall look at this capability to offload the authentication. Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 54 +--

[PATCH v3 1/3] nl80211: Introduce scan flags to emphasize requested scan behavior

2018-01-25 Thread Jouni Malinen
rdware specific. These flags can be used to control the compromise between how long a scan takes, how much power it uses, and high accurate/complete the scan is in finding the BSSs. Signed-off-by: Sunil Dutt <usd...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.co

[PATCH v3 3/3] nl80211: Allow SAE Authentication for NL80211_CMD_CONNECT

2018-01-25 Thread Jouni Malinen
e user space to advertise support to handle offload through NL80211_ATTR_EXTERNAL_AUTH_SUPPORT in NL80211_CMD_CONNECT request. Such drivers should reject the connect request on no offload support from user space. Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off-by: Jouni

[PATCH v2 3/3] nl80211: Introduce scan flags to emphasize requested scan behavior

2017-12-22 Thread Jouni Malinen
rdware specific. These flags can be used to control the compromise between how long a scan takes, how much power it uses, and high accurate/complete the scan is in finding the BSSs. Signed-off-by: Sunil Dutt <usd...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.co

[PATCH v2 2/3] nl80211: Allow SAE Authentication for NL80211_CMD_CONNECT

2017-12-22 Thread Jouni Malinen
From: Srinivas Dasari <dasa...@qti.qualcomm.com> This commit allows SAE Authentication for NL80211_CMD_CONNECT interface, provided this is supported by the host driver. Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcom

[PATCH v2 1/3] cfg80211/nl80211: Optional authentication offload to userspace

2017-12-22 Thread Jouni Malinen
hrough the NL80211_ATTR_EXTERNAL_AUTH_SUPP flag in the NL80211_CMD_CONNECT request. Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 44 include/uapi/li

[PATCH] nl80211: Introduce scan flags to emphasize requested scan behavior

2017-12-13 Thread Jouni Malinen
t <usd...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/uapi/linux/nl80211.h | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index 6dd6939..68fdb95 100644

[PATCH] cfg80211: Scan results to also report the per chain signal strength

2017-12-13 Thread Jouni Malinen
lcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 8 include/uapi/linux/nl80211.h | 3 +++ net/wireless/nl80211.c | 5 + net/wireless/scan.c | 5 + 4 files changed, 21 insertions(+) diff --git a/include/net/cf

[PATCH 2/2] nl80211: Allow SAE Authentication for NL80211_CMD_CONNECT

2017-12-13 Thread Jouni Malinen
From: Srinivas Dasari <dasa...@qti.qualcomm.com> This commit allows SAE Authentication for NL80211_CMD_CONNECT interface, provided this is supported by the host driver. Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcom

[PATCH 1/2] cfg80211/nl80211: Optional authentication offload to userspace

2017-12-13 Thread Jouni Malinen
<dasa...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 40 include/uapi/linux/nl80211.h | 39 net/wireless/nl80211.c | 87 net/wireless/rd

[RFC v2] cfg80211: Implement Multiple BSSID capability in scanning

2017-11-28 Thread Jouni Malinen
m> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/wireless/core.h | 1 + net/wireless/scan.c | 450 ++-- 2 files changed, 437 insertions(+), 14 deletions(-) v2: - address number of comments from Johannes on the first ve

Re: [RFC] cfg80211: Implement Multiple BSSID capability in scanning

2017-11-14 Thread Jouni Malinen
SSIDs. As far as other vendor specific elements are concerned, there could certainly be use cases for using different values for WPA element, Hotspot 2.0 element, MBO/OCE element. -- Jouni MalinenPGP id EFC895FA

Re: ath9k disconnects in 4.13 with reason=4 locally_generated=1

2017-11-03 Thread Jouni Malinen
de paths in mlme.c where disconnection is triggered if the current AP become unreachable. Getting a debug log from mac80211 might help in figuring out what is causing this (there seem to be number of mlme_dbg() calls before most, but not necessarily all, places where WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY is u

[RFC] cfg80211: Implement Multiple BSSID capability in scanning

2017-11-01 Thread Jouni Malinen
m> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/wireless/core.h | 1 + net/wireless/scan.c | 537 ++-- 2 files changed, 526 insertions(+), 12 deletions(-) diff --git a/net/wireless/core.h b/net/wireless/core.h index 35165

[PATCH] nl80211: Define policy for packet pattern attributes

2017-10-06 Thread Jouni Malinen
m> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/wireless/nl80211.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 90e212d..e99671f 100644 --- a/net/wireless/nl80211.c +++ b/net/

Re: [PATCH 1/4] cfg80211: Check if PMKID attribute is of expected size

2017-07-07 Thread Jouni Malinen
milar issues flagged as security issues in various kernel components recently and that has triggered more scrutiny for the kernel interfaces. -- Jouni MalinenPGP id EFC895FA

[PATCH 4/4] cfg80211: Validate frequencies nested in NL80211_ATTR_SCAN_FREQUENCIES

2017-07-06 Thread Jouni Malinen
..@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/wireless/nl80211.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 0a63b95..740d3c1 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/

[PATCH 3/4] cfg80211: Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE

2017-07-06 Thread Jouni Malinen
f data with NL80211_ATTR_LOCAL_MESH_POWER_MODE. Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE to avoid the buffer overread. Fixes: 3b1c5a5307f ("{cfg,nl}80211: mesh power mode primitives and userspace access") Cc: sta...@vger.kernel.org Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off

[PATCH 1/4] cfg80211: Check if PMKID attribute is of expected size

2017-07-06 Thread Jouni Malinen
0211: PMKSA caching support") Cc: sta...@vger.kernel.org Signed-off-by: Srinivas Dasari <dasa...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/wireless/nl80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/wireless/nl8021

Re: [PATCH] mac80211: Validate michael MIC before attempting packet decode.

2017-05-10 Thread Jouni Malinen
may have a bug if you do not see Michael MIC failures reported correctly. Anyway, as Johannes pointed out, this part in mac80211 is in the correct sequence and that cannot be changed since it would completely break TKIP for more or less all software-based cases. -- Jouni Malinen

[PATCH 2/2] cfg80211: Add support for FILS shared key authentication offload

2017-03-30 Thread Jouni Malinen
llatha Kanchanapally <vkanc...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/linux/ieee80211.h| 13 +++ include/net/cfg80211.h | 57 +++- include/uapi/linux/nl80211.h | 86 -- ne

[PATCH 1/2] cfg80211: Use a structure to pass connect response params

2017-03-30 Thread Jouni Malinen
g them as function arguments. Signed-off-by: Vidyullatha Kanchanapally <vkanc...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 91 +++--- net/wireless/core.h| 20 ++- net/wireless/mlme.c| 20 +++

[RFC v2] cfg80211: Add support for FILS shared key authentication offload

2017-03-09 Thread Jouni Malinen
-by: Vidyullatha Kanchanapally <vkanc...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/linux/ieee80211.h| 9 +++ include/net/cfg80211.h | 143 ++--- include/uapi/linux/nl80211.h | 86

[PATCH] mac80211_hwsim: Add channel 169 (5845 MHz)

2017-03-06 Thread Jouni Malinen
This channel is defined in the IEEE 802.11 standard and available in number of countries, so extend the mac80211_hwsim channel list to cover channel 169 to enable additional testing. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- drivers/net/wireless/mac80211_hwsim.c | 1 +

Re: [RFC] mac80211_hwsim: report survey data for scanned channels

2017-03-04 Thread Jouni Malinen
y->channel_time_busy = survey->channel_time/8; .. and "channel_" in these to make this compile. Anyway, with those trivial changes, the hwsim test cases did start looking more interesting, so it would seem reasonable to get this applied. -- Jouni MalinenPGP id EFC895FA

[RFC] cfg80211: Add support for FILS shared key authentication offload

2017-03-03 Thread Jouni Malinen
-by: Vidyullatha Kanchanapally <vkanc...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/linux/ieee80211.h| 9 include/net/cfg80211.h | 115 +++ include/uapi/linux/nl80211.h | 48 +++

Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

2017-02-21 Thread Jouni Malinen
d not assume that WLAN_PMK_LEN definition is the only possible option. -- Jouni MalinenPGP id EFC895FA

[PATCH] mac80211: Allocate a sync skcipher explicitly for FILS AEAD

2017-02-04 Thread Jouni Malinen
with hardware accelerators. This is based on the patch sent out by Ard. Fixes: 39404feee691 ("mac80211: FILS AEAD protection for station mode association frames") Reported-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- ne

[PATCH] mac80211: Fix FILS AEAD protection in Association Request frame

2017-02-04 Thread Jouni Malinen
g> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/mac80211/fils_aead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) If there is still time, it would be nice to get this included in Linux 4.10 since fils_aead.c is being added there. If not, Cc: stable could be ad

[PATCH] wireless-regdb: Remove DFS requirement for India (IN)

2017-01-30 Thread Jouni Malinen
0 MHz band. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- db.txt | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/db.txt b/db.txt index 7964cfb..05108e0 100644 --- a/db.txt +++ b/db.txt @@ -580,11 +580,10 @@ country IL: DFS-ETSI (5150 - 5250 @ 80), (200

[PATCH 4/4] cfg80211: Fix documentation for connect result

2017-01-12 Thread Jouni Malinen
() documentation. Update the function specific comments to note the failure cases and also describe how the special status == -1 case is used in cfg80211_connect_bss() to indicate a connection timeout based on the internal implementation in cfg80211_connect_timeout(). Signed-off-by: Jouni Malinen <

[PATCH v2 3/4] cfg80211: Specify the reason for connect timeout

2017-01-12 Thread Jouni Malinen
ribute NL80211_ATTR_TIMEOUT_REASON (u32). Signed-off-by: Purushottam Kushwaha <pkush...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 18 ++ include/uapi/linux/nl80211.h | 21 + net/wireless/core.h

[PATCH v3 1/4] cfg80211: Add support to randomize TA of Public Action frames

2017-01-12 Thread Jouni Malinen
lcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/uapi/linux/nl80211.h | 6 ++ net/wireless/mlme.c | 21 +++-- 2 files changed, 25 insertions(+), 2 deletions(-) v3: - moved to the beginning of the series since there were no

[PATCH v4 2/4] cfg80211: Add support to sched scan to report better BSSs

2017-01-12 Thread Jouni Malinen
e RSSI (compared to the current BSS) are added to the sched scan to implement this. Signed-off-by: vamsi krishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 36 +--- include/uapi/li

[PATCH 3/3] cfg80211: Specify the reason for connect timeout

2017-01-09 Thread Jouni Malinen
ribute NL80211_ATTR_TIMEOUT_REASON (u32). Signed-off-by: Purushottam Kushwaha <pkush...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 15 +++ include/uapi/linux/nl80211.h | 21 + net/wireless/core.h

[PATCH v2 2/3] cfg80211: Add support to randomize TA of Public Action frames

2017-01-09 Thread Jouni Malinen
lcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/uapi/linux/nl80211.h | 6 ++ net/wireless/mlme.c | 21 +++-- 2 files changed, 25 insertions(+), 2 deletions(-) v2: - remove unnecessary NL80211_ATTR_MGMT_TX_RANDOM_SA and allow addr

[PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs

2017-01-09 Thread Jouni Malinen
e RSSI (compared to the current BSS) are added to the sched scan to implement this. Signed-off-by: vamsi krishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 36 ++-- include/uapi/li

[PATCH] cfg80211: Random local address for Public Action frame exchange

2016-12-20 Thread Jouni Malinen
t used. Signed-off-by: vamsi krishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 6 ++ include/uapi/linux/nl80211.h | 16 net/wireless/mlme.c | 5 - net/wireless/nl80211.c | 14

Re: ath10k firmware sends probes on DFS channels without radar detection

2016-12-15 Thread Jouni Malinen
ve scanning should not be used on DFS channels. That said, unicast Probe Request frame to the current AP while associated could be a reasonable exception. In addition, WPS with PBC depends on Probe Request frames to allow PBC session overlap detection, so there might be sufficient justification t

Re: ath10k firmware sends probes on DFS channels without radar detection

2016-12-14 Thread Jouni Malinen
+ passive = channel->flags & (IEEE80211_CHAN_NO_IR | + IEEE80211_CHAN_RADAR); ch->passive = passive; ch->freq = channel->center_freq; -- Jouni MalinenPGP id EFC895FA

[PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-12-02 Thread Jouni Malinen
e RSSI (compared to the current BSS) are added to the sched scan to implement this. Signed-off-by: vamsi krishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 19 +++ include/uapi/li

[PATCH v2 1/2] nl80211: Use different attrs for BSSID and random MAC addr in scan req

2016-12-02 Thread Jouni Malinen
ith the addition of the second user for the same attribute in commit 818965d39177 ("cfg80211: Allow a scan request for a specific BSSID"). Fixes: 818965d39177 ("cfg80211: Allow a scan request for a specific BSSID") Signed-off-by: Vamsi Krishna <vam...@qti.qualcom

Re: Break-it testing for wifi

2016-11-23 Thread Jouni Malinen
s some more constraints on preventing some testing combinations. > But, if local Linux (and local userspace) itself is the test target, then > hwsim should give some very good > test coverage. Please keep in mind that almost anything that can tested with mac80211_hwsim can also be used with real WLAN hardware when using mac80211-based drivers.. -- Jouni MalinenPGP id EFC895FA

[PATCH 2/2] cfg80211: Add support to sched scan to report better BSSs

2016-11-23 Thread Jouni Malinen
rishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 17 + include/uapi/linux/nl80211.h | 17 + net/wireless/nl80211.c | 32 ++-- 3 files changed, 6

[PATCH v2] cfg80211: Add support to update connection parameters

2016-10-27 Thread Jouni Malinen
e only. Other parameters can be added in future when required. Signed-off-by: vamsi krishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 24 include/uapi/linux/nl80211.h | 7 +++ net/

[PATCH v2 8/9] mac80211: FILS AEAD protection for station mode association frames

2016-10-26 Thread Jouni Malinen
This adds support for encrypting (Re)Association Request frame and decryption (Re)Association Response frame when using FILS in station mode. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/mac80211/Makefile | 1 + net/mac80211/aes_cmac.c| 8 +- net/mac80211/aes_

[PATCH v2 9/9] mac80211: Claim Fast Initial Link Setup (FILS) STA support

2016-10-26 Thread Jouni Malinen
With the previous commits, initial FILS authentication/association support is now functional in mac80211-based drivers for station role (and FILS AP case is covered by user space in hostapd withotu requiring mac80211 changes). Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --

[PATCH v2 5/9] cfg80211: Add Fast Initial Link Setup (FILS) auth algs

2016-10-26 Thread Jouni Malinen
This defines authentication algorithms for FILS (IEEE 802.11ai). Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/linux/ieee80211.h| 3 +++ include/uapi/linux/nl80211.h | 6 ++ net/wireless/nl80211.c | 21 +++-- 3 files changed, 28 inse

[PATCH v2 0/9] cfg80211/mac80211: Fast Initial Link Setup (IEEE 802.11ai)

2016-10-26 Thread Jouni Malinen
only the FILS authentication/association functionality from IEEE 802.11ai, i.e., the other changes like scanning optimizations are not included. v2: Updates to address comments from Johannes Jouni Malinen (9): cfg80211: Rename SAE_DATA to more generic AUTH_DATA mac80211: Allow AUTH_DATA

[PATCH 3/8] cfg80211: Add feature flag for Fast Initial Link Setup (FILS)

2016-10-25 Thread Jouni Malinen
This defines a feature flag that drivers can use to indicate that they support (IEEE 802.11ai) when using user space SME (NL80211_CMD_AUTHENTICATE) in station mode. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/uapi/linux/nl80211.h | 3 +++ 1 file changed, 3 inse

[PATCH 8/8] mac80211: Claim Fast Initial Link Setup (FILS) support

2016-10-25 Thread Jouni Malinen
With the previous commits, initial FILS support is now functional in mac80211-based drivers for both AP and stations roles. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/mac80211/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/main.c b/net/mac80211/

[PATCH 5/8] cfg80211: Add KEK/nonces for FILS association frames

2016-10-25 Thread Jouni Malinen
The new nl80211 attributes can be used to provide KEK and nonces to allow the driver to encrypt and decrypt FILS (Re)Association Request/Response frames in station mode. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/linux/ieee80211.h| 3 +++ include/net/cfg8

[PATCH 7/8] mac80211: FILS AEAD protection for station mode association frames

2016-10-25 Thread Jouni Malinen
This adds support for encrypting (Re)Association Request frame and decryption (Re)Association Response frame when using FILS in station mode. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/mac80211/Makefile | 1 + net/mac80211/aes_cmac.c| 8 +- net/mac80211/aes_

[PATCH 4/8] cfg80211: Add Fast Initial Link Setup (FILS) auth algs

2016-10-25 Thread Jouni Malinen
This defines authentication algorithms for FILS (IEEE 802.11ai). Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/linux/ieee80211.h| 3 +++ include/uapi/linux/nl80211.h | 6 ++ net/wireless/nl80211.c | 21 +++-- 3 files changed, 28 inse

[PATCH 6/8] mac80211: Add FILS auth alg mapping

2016-10-25 Thread Jouni Malinen
Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/mac80211/mlme.c | 12 1 file changed, 12 insertions(+) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index b6222f2..b815f2d 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -2618,6 +2618,9 @@

[PATCH 2/8] mac80211: Allow AUTH_DATA to be used for FILS

2016-10-25 Thread Jouni Malinen
The special SAE case should be limited only for SAE since the more generic AUTH_DATA can now be used with other authentication algorithms as well. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- net/mac80211/mlme.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[PATCH 1/8] cfg80211: Rename SAE_DATA to more generic AUTH_DATA

2016-10-25 Thread Jouni Malinen
having to duplicate that implementation. Rename that attribute to more generic NL80211_ATTR_AUTH_DATA (with backwards compatibility define for NL80211_SAE_DATA). Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 10 +- include/uapi/linux/nl80211.

[PATCH 0/8] cfg80211/mac80211: Fast Initial Link Setup (IEEE 802.11ai)

2016-10-25 Thread Jouni Malinen
only the FILS authentication/association functionality from IEEE 802.11ai, i.e., the other changes like scanning optimizations are not included. Jouni Malinen (8): cfg80211: Rename SAE_DATA to more generic AUTH_DATA mac80211: Allow AUTH_DATA to be used for FILS cfg80211: Add feature flag

Re: [PATCH] cfg80211: add key management offload feature

2016-10-14 Thread Jouni Malinen
d by wpa_supplicant especially in cases where the host is awake anyway. That's why those PTK-related values need to be kept in sync between the driver/firmware and host (wpa_supplicant). -- Jouni MalinenPGP id EFC895FA

Re: [PATCH] nl80211: add key management offload feature

2016-10-14 Thread Jouni Malinen
b/src/rsn_supp/wpa_ft.c > > @@ -37,6 +37,10 @@ int wpa_derive_ptk_ft(struct wpa_sm *sm, const unsigned > > char *src_addr, > > + wpa_sm_set_key(sm, WPA_ALG_PMK_R0, NULL, 0, 1, NULL, > > + 0, sm->pmk_r0, PMK_LEN); > > + wpa_sm_set_key(sm, WPA_ALG_PMK_R0_NAME, NULL, 0, 1, NULL, > > + 0, sm->pmk_r0_name, WPA_PMK_NAME_LEN); This looks quite bad. I don't think I can really support two separate nl80211 commands to set a PMK-R0 and the matching PMK-R0-Name, i.e., this should really be a single (atomic) operation. -- Jouni MalinenPGP id EFC895FA

[PATCH] cfg80211: Add support to update connection parameters

2016-10-13 Thread Jouni Malinen
e only. Other parameters can be added in future when required. Signed-off-by: vamsi krishna <vam...@qti.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 22 ++ include/uapi/linux/nl80211.h | 7 +++ n

Re: [PATCH 6/6] cfg80211: reduce connect key caching struct size

2016-09-28 Thread Jouni Malinen
9-28 20:36:15.644646 START wext_pmf 2/6 qemu-system-x86_64: 9pfs:virtfs_reset: One or more uncluncked fids found during reset qemu-system-x86_64: 9pfs:virtfs_reset: One or more uncluncked fids found during reset KERNEL CRASHED! -- Jouni MalinenPGP id EFC895FA

[PATCH] hostap: Mark the Host AP driver obsolete

2016-09-27 Thread Jouni Malinen
something without being quickly noticed due to lack of testing. In addition, remove the old mailing list that does not work anymore and point the web-page to a more accurate URL. Signed-off-by: Jouni Malinen <j...@w1.fi> --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

[PATCH] cfg80211: Add HT and VHT information in start_ap

2016-08-15 Thread Jouni Malinen
From: Peng Xu <p...@qca.qualcomm.com> Add HT and VHT information in struct cfg80211_ap_settings when starting ap so that driver does not need to parse IE to obtain the information. Signed-off-by: Peng Xu <p...@qca.qualcomm.com> Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.co

Re: [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler

2016-07-22 Thread Jouni Malinen
p key handshake has completed with each associated STA. It is that last operation that needs set_default_mgmt_key() to allow this rekeying to work correctly. If you update the TX Key ID on add_key(), you'll risk sending out frames that some of the associated STAs do not yet hav

Re: [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler

2016-07-21 Thread Jouni Malinen
d will configure two different IGTKs with different Key IDs and change the TX key on the AP once all associated STAs have the new key. If the driver does not support updating the TX key index, either the old or the new STAs associated after rekeying will not have the correct key. -- Jouni Malinen

Re: [PATCH] mac80211_hwsim: Added vendor echo command

2016-06-25 Thread Jouni Malinen
a new subcommand/attribute to be assigned and once that gets applied to the hostap.git master branch, the values have been assigned and can be used for whatever purpose they were assigned, e.g., in mac80211_hwsim. More details on how to make such a hostap.git contribut

Re: [PATCH] mac80211_hwsim: Added vendor echo command

2016-06-24 Thread Jouni Malinen
e, a value that have already been assigned for a completely different purpose. -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@v

Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-21 Thread Jouni Malinen
On Tue, Jun 21, 2016 at 03:16:22PM +0900, Masashi Honma wrote: > On 2016年06月21日 06:25, Jouni Malinen wrote: > > What about RX side? > > Previously, MGTK and IGTK was identical key. > Now new wpa_supplicant can provide correct IGTK. > I have tested with new IGTK, RX

Re: [PATCH v2] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-21 Thread Jouni Malinen
cipher) { > case WLAN_CIPHER_SUITE_WEP40: > case WLAN_CIPHER_SUITE_WEP104: This looks completely separate item and I don't see why we would even delete that empty line.. In any case, it should probably not be in this patch. -- Jouni Malinen

Re: [PATCH] ath9k: Support 4.9Ghz channels on AR9580 adapter.

2016-06-21 Thread Jouni Malinen
? And if so, what are those use cases? Or is this only for some public safety cases? And if so, for which regulatory domains? To be frank, I really don't see how this would be even close to a state that should be accepted into the upstream tree. -- Jouni Malinen

Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-20 Thread Jouni Malinen
On Mon, Jun 20, 2016 at 09:51:28AM +0900, Masashi Honma wrote: > On 2016年06月18日 18:11, Jouni Malinen wrote: > Yes. This patch breaks backward compatibility. > I do not have smart idea to avoid also. > I will create new define like this. > CONFIG_MAC80211_MESH_GROUP_ADDRESSED_PRIVAC

[PATCH] mac80211: Fix mesh estab_plinks counting in STA removal case

2016-06-19 Thread Jouni Malinen
for capability to accept additional peers. Signed-off-by: Jouni Malinen <j...@w1.fi> --- net/mac80211/mesh.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c index 21b1fdf..6a1603b 100644 --- a/net/mac80211/mesh.c +++ b/net/ma

Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames

2016-06-18 Thread Jouni Malinen
SS to get updated to the fixed versions. > diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c > +static bool debug_noinline > +ieee80211_is_group_privacy_action(struct ieee80211_hdr *hdr) And this helper should likely be in some more generic locatio

[PATCH] cfg80211: Allow cfg80211_connect_result() errors to be distinguished

2016-05-30 Thread Jouni Malinen
compatibility, NL80211_STATUS_CODE with the value WLAN_STATUS_UNSPECIFIED_FAILURE is still indicated in the event in such a case. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 54 ++-- include/uapi/linux/nl80211.

Re: [PATCH v2] ath10k: remove VHT capabilities from 2.4GHz

2016-04-27 Thread Jouni Malinen
80211 next to the places where we handle the matching standard VHT elements in the 5 GHz band. -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] cfg80211: Improve Connect/Associate command documentation

2016-04-06 Thread Jouni Malinen
. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 26 +++--- include/uapi/linux/nl80211.h | 16 +--- 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index b

[PATCH 1/2] cfg80211: Add option to specify previous BSSID for Connect command

2016-03-29 Thread Jouni Malinen
to reassociate within an ESS without having to disconnect and associate with the AP. Signed-off-by: Jouni Malinen <jo...@qca.qualcomm.com> --- include/net/cfg80211.h | 2 ++ net/wireless/nl80211.c | 4 net/wireless/trace.h | 6 -- 3 files changed, 10 insertions(+), 2 deletions(-) diff

  1   2   3   >