Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

On Mon, Apr 30, 2018 at 8:10 AM, Pkshih wrote: > > > > -Original Message- > > From: Barry Day [mailto:brise...@gmail.com] > > Sent: Saturday, April 28, 2018 6:42 AM > > To: Pkshih > > Cc: Kalle Valo; larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org > >

Re: ath10k: controlling TX aggregation

On Sun, May 21, 2017 at 8:36 PM, Ben Greear <gree...@candelatech.com> wrote: > > > On 05/20/2017 09:21 AM, Krishna Chaitanya wrote: >> >> On Mon, May 15, 2017 at 3:02 PM, Krishna Chaitanya >> <chaitanya.m...@gmail.com> wrote: >>> >&

Re: ath10k: controlling TX aggregation

On Mon, May 15, 2017 at 3:02 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Fri, May 12, 2017 at 8:15 PM, Ben Greear <gree...@candelatech.com> wrote: >> What chipset, and what firmware version? >> >> Thanks, >> Ben > > Hi Ben, > >

Re: ath10k: controlling TX aggregation

rs-next) > On 05/12/2017 07:43 AM, Krishna Chaitanya wrote: >> >> Hi, >> >> I am doing some comparative tests, wanted to configure common >> settings btw all STA's. wanted to limit agg_size to 24 in ath10k with >> the below command. >> >> echo

ath10k: controlling TX aggregation

Hi, I am doing some comparative tests, wanted to configure common settings btw all STA's. wanted to limit agg_size to 24 in ath10k with the below command. echo "3 24" > /sys/kernel/debug/ieee80211/phy0/ath10k/htt_max_amsdu_ampdu The ADDBA request still has 64 and when i run iperf it is

Re: Formatting of db.txt

On Tue, Mar 28, 2017 at 10:41 PM, Matthew Stanger wrote: > Hi, > > I'm trying to set antenna gain in the db.txt following the > documentation from: > https://wireless.wiki.kernel.org/en/developers/regulatory/processing_rules > > If I copy the example exactly show in

Re: bcmdhd: Strange Power Save messages

regular STA > interface that could trigger the Null Frame (which includes the exit > from PS Mode). However, I would expect to see some management frames > in the air before/after the Null Packet (e.g.: a Probe request in case > of a scheduled scan). But in my case the trigger for

Re: bcmdhd: Strange Power Save messages

On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel wrote: > > > On 29-09-16 13:32, Gucea Doru wrote: >> On Tue, Sep 27, 2016 at 12:03 PM, Gucea Doru wrote: >>> What is the decision triggering the exit from the PS mode immediately >>> after the

Re: [RFD] mac80211: Handling local operating class in (E)CSA

On Mon, Jul 25, 2016 at 12:56 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > > Hi, > > Some AP's use local operating class in (E)CSA IE's. Currently > mac80211 fails the parsing of those IE's and results in a > disconnection. > > What is the best way to a

[RFD] mac80211: Handling local operating class in (E)CSA

Hi, Some AP's use local operating class in (E)CSA IE's. Currently mac80211 fails the parsing of those IE's and results in a disconnection. What is the best way to add support for local operating classes? a) Maintaining a per country operating class table in cfg80211 b) Embed operating class

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 22, 2016 at 7:02 PM, Ben Greear <gree...@candelatech.com> wrote: > > > On 07/22/2016 05:21 AM, Krishna Chaitanya wrote: >> >> On Fri, Jul 22, 2016 at 5:29 PM, Manoharan, Rajkumar >> <rmano...@qti.qualcomm.com> wrote: >>> >>> [...

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 22, 2016 at 5:29 PM, Manoharan, Rajkumar wrote: > [...] >> >> Thanks Raj, with this fix the rates are 0-7, if i disable then i am >> >> seeing 0-9, so its >> >> working. >> >> >> >> But i am seeing a weird issues, the moment i give bitrates command, >> >>

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 8, 2016 at 9:07 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > > On Fri, Jul 8, 2016 at 8:57 PM, Krishna Chaitanya > <chaitanya.m...@gmail.com> wrote: > > On Fri, Jul 8, 2016 at 6:29 PM, Manoharan, Rajkumar > > <rmano...@qti.qualco

Re: ath10k + iw set bitrates is causing FW crash

issue. Right after connecting i see that packets are encrypted but once it unset/set "bitrates" plain packets are seen in sniffer. BTW, i am not rebooting for each driver update, just re-inserting the module, do i need to do a reboot for each driver change?

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 8, 2016 at 9:17 PM, Ben Greear <gree...@candelatech.com> wrote: > On 07/08/2016 08:44 AM, Krishna Chaitanya wrote: >> >> On Fri, Jul 8, 2016 at 9:12 PM, Ben Greear <gree...@candelatech.com> >> wrote: >>> >>> On 07/08/2016 08:39 AM, Kr

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 8, 2016 at 9:12 PM, Ben Greear <gree...@candelatech.com> wrote: > On 07/08/2016 08:39 AM, Krishna Chaitanya wrote: > >> Also can you please tell me how to make ath10k use minstrel rc, its needed >> for comparative purposes? Is disable HW_RATE_CONTROL enough

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 8, 2016 at 9:07 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Fri, Jul 8, 2016 at 8:57 PM, Krishna Chaitanya > <chaitanya.m...@gmail.com> wrote: >> On Fri, Jul 8, 2016 at 6:29 PM, Manoharan, Rajkumar >> <rmano...@qti.qualcomm.com>

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 8, 2016 at 8:57 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Fri, Jul 8, 2016 at 6:29 PM, Manoharan, Rajkumar > <rmano...@qti.qualcomm.com> wrote: >> I think security failures are due to peer unmap & map upon reassoc. Can you >> p

Re: ath10k + iw set bitrates is causing FW crash

On Fri, Jul 8, 2016 at 3:39 PM, Manoharan, Rajkumar wrote: >>> I am using ath10k driver with qca988x hw2.0 and trying to limit it to use >>> VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). >>> >>> But the command it causing a FW crash, if it disable HW_HAS_RATE_CONTROL

Re: ath10k + iw set bitrates is causing FW crash

On Thu, Jul 7, 2016 at 10:19 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > Hi, > > I am using ath10k driver with qca988x hw2.0 and trying to limit it to use > VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). > > But the command it causing a FW crash, if it dis

ath10k + iw set bitrates is causing FW crash

Hi, I am using ath10k driver with qca988x hw2.0 and trying to limit it to use VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). But the command it causing a FW crash, if it disable HW_HAS_RATE_CONTROL no crash is observed but it still uses MCS9. tree: wireless-drivers-next:

Re: [PATCH] mac80211: minstrel: Enable STBC and LDPC for VHT Rates

On Wed, Jun 29, 2016 at 1:50 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Wed, Jun 29, 2016 at 1:41 PM, Karl Beldan <karl.bel...@gmail.com> wrote: >> On Mon, Jun 27, 2016 at 9:53 AM, Chaitanya TK <chaitanya.m...@gmail.com> >> wrote: >>

Re: [PATCH] mac80211: minstrel: Enable STBC and LDPC for VHT Rates

On Wed, Jun 29, 2016 at 1:52 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Wed, Jun 29, 2016 at 1:50 PM, Krishna Chaitanya > <chaitanya.m...@gmail.com> wrote: >> On Wed, Jun 29, 2016 at 1:41 PM, Karl Beldan <karl.bel...@gmail.com> wrote: >&

Re: [PATCH] mac80211: minstrel: Enable STBC and LDPC for VHT Rates

On Wed, Jun 29, 2016 at 1:50 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Wed, Jun 29, 2016 at 1:41 PM, Karl Beldan <karl.bel...@gmail.com> wrote: >> On Mon, Jun 27, 2016 at 9:53 AM, Chaitanya TK <chaitanya.m...@gmail.com> >> wrote: >>

Re: [PATCH] mac80211: minstrel: Enable STBC and LDPC for VHT Rates

On Wed, Jun 29, 2016 at 1:41 PM, Karl Beldan wrote: > On Mon, Jun 27, 2016 at 9:53 AM, Chaitanya TK > wrote: >> >> From: Chaitanya T K >> >> If peer support reception of STBC and LDPC, enable them for better >>

Re: [PATCH] mac80211: ensure info->control.vif is set for queued pkts.

On Tue, Jun 28, 2016 at 8:20 PM, Ben Greear wrote: > On 06/28/2016 07:00 AM, Johannes Berg wrote: >> >> On Wed, 2016-06-15 at 11:24 -0700, gree...@candelatech.com wrote: >>> >>> From: Ben Greear >>> >>> When driving ath10k with a modified pktgen,

STBC and LDPC for VHT

Hi, What is the background for disabling STBC and LDPC for VHT rates? The below comment is cryptic :-). /* TODO tx_flags for vht - ATM the RC API is not fine-grained enough */ Can we just enable these now? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body

Re: iw reg overwritten after connecting to AP

On Fri, Jun 3, 2016 at 2:02 AM, Belisko Marek <marek.beli...@gmail.com> wrote: > > Hi Krishna, > > On Thu, Jun 2, 2016 at 10:21 PM, Krishna Chaitanya > <chaitanya.m...@gmail.com> wrote: > > On Thu, Jun 2, 2016 at 7:34 PM, Belisko Marek <marek.beli...@gm

Re: iw reg overwritten after connecting to AP

On Thu, Jun 2, 2016 at 7:34 PM, Belisko Marek wrote: > > Hello, > > I'm using kernel 4.1 with option CONFIG_CFG80211_INTERNAL_REGDB > enabled. I have set one country in db.txt which during startup I set > via 'iw reg set XX'. When connected to some AP which sends country

Re: dynamic ps + offchannel mgmt_tx + HW RoC

On Wed, May 4, 2016 at 1:33 AM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Wed, 2016-05-04 at 01:20 +0530, Krishna Chaitanya wrote: >> On Wed, May 4, 2016 at 1:05 AM, Johannes Berg <johannes@sipsolutions. >> net> wrote: >> > >> > Ther

Re: dynamic ps + offchannel mgmt_tx + HW RoC

On Wed, May 4, 2016 at 1:05 AM, Johannes Berg wrote: > There is, btw, perhaps a different way - just fix the damn stuff. > > Requires moving everything into ifmgd rather than local, and then > perhaps if only a single managed interface exists mirroring its state > into

Re: dynamic ps + offchannel mgmt_tx + HW RoC

On Tue, May 3, 2016 at 9:31 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Tue, 2016-05-03 at 20:02 +0530, Krishna Chaitanya wrote: > >> > i don't see any issues in the powersave w.r.t driver. Isn't it a >> > valid case? you meant implementing dynamic

Re: dynamic ps + offchannel mgmt_tx + HW RoC

On Tue, May 3, 2016 at 7:46 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Tue, May 3, 2016 at 6:44 PM, Johannes Berg <johan...@sipsolutions.net> > wrote: >> On Tue, 2016-05-03 at 18:23 +0530, Krishna Chaitanya wrote: >>> Hi, >>> >>>

Re: dynamic ps + offchannel mgmt_tx + HW RoC

On Tue, May 3, 2016 at 6:44 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Tue, 2016-05-03 at 18:23 +0530, Krishna Chaitanya wrote: >> Hi, >> >> When the HW is in PS and Dynamic PS is enabled we are dropping >> all the offchannel frames. Sequence

dynamic ps + offchannel mgmt_tx + HW RoC

Hi, When the HW is in PS and Dynamic PS is enabled we are dropping all the offchannel frames. Sequence is as below if hw is in PS: stop_queues reason=PS, queue dynamic_ps_disable_work send Offchannel mgmt_tx drop the packet because offchanel + stop_reasons[q] !=0 How should we handle this? SW

Re: [PATCH v2] ath10k: remove VHT capabilities from 2.4GHz

On Wed, Apr 27, 2016 at 2:46 PM, Jouni Malinen <j...@w1.fi> wrote: > On Wed, Apr 27, 2016 at 12:13:46PM +0530, Krishna Chaitanya wrote: >> On Wed, Apr 27, 2016 at 1:40 AM, Ben Greear <gree...@candelatech.com> wrote: >> > On 04/26/2016 01:07 PM, Krishna Chaitanya wrote

Re: [PATCH v2] ath10k: remove VHT capabilities from 2.4GHz

On Wed, Apr 27, 2016 at 1:40 AM, Ben Greear <gree...@candelatech.com> wrote: > On 04/26/2016 01:07 PM, Krishna Chaitanya wrote: >> >> On Tue, Apr 26, 2016 at 5:33 PM, Valo, Kalle <kv...@qca.qualcomm.com> >> wrote: >>> >>> Johannes Berg <johan

Re: [PATCH v2] ath10k: remove VHT capabilities from 2.4GHz

On Tue, Apr 26, 2016 at 5:33 PM, Valo, Kalle wrote: > Johannes Berg writes: > >> On Thu, 2016-04-21 at 08:15 -0700, Ben Greear wrote: >> >>> The thing is, it actually works just fine with the patch I posted >>> to fix mac80211, and at any rate,

[RFC] Sampling Holes in Minstrel when VHT is enabled

Hi, With the current design, occasionally we are seeing issues where minstrel sends 3x3 rates for our 2x2 chip. IMHO, couple of things can cause this 1) update_caps doesn't take local HW capabilities in to account 2) While calculating sample_idx, we use MCS_GROUP_RATES which can cause a

Re: Intel 7260 AC only using 802.11n not AC

On Tue, Apr 26, 2016 at 4:20 PM, Kalle Valo wrote: > > Radu P writes: > > > iw list|grep -i VHT <- still nothing > > Maybe your iw is too old? I didn't see anything either (using stock iw > from Ubuntu 14.04) but then I upgraded to the latest one from git

Re: Debug prints mac80211 drivers

On Sat, Apr 23, 2016 at 1:53 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Sat, Apr 23, 2016 at 1:35 PM, Joe Perches <j...@perches.com> wrote: >> On Sat, 2016-04-23 at 13:11 +0530, Krishna Chaitanya wrote: >>> On Sat, Apr 23, 2016 at 3:48 AM, Joe Pe

Re: Debug prints mac80211 drivers

On Sat, Apr 23, 2016 at 1:35 PM, Joe Perches <j...@perches.com> wrote: > On Sat, 2016-04-23 at 13:11 +0530, Krishna Chaitanya wrote: >> On Sat, Apr 23, 2016 at 3:48 AM, Joe Perches <j...@perches.com> wrote: >> > >> > On Sat, 2016-04-23 at 02:32 +0530, Krishn

Re: Debug prints mac80211 drivers

On Sat, Apr 23, 2016 at 3:48 AM, Joe Perches <j...@perches.com> wrote: > On Sat, 2016-04-23 at 02:32 +0530, Krishna Chaitanya wrote: >> On Sat, Apr 23, 2016 at 12:59 AM, Joe Perches <j...@perches.com> wrote: >> > >> > >> > On Fri, 20

Re: Debug prints mac80211 drivers

On Sat, Apr 23, 2016 at 12:59 AM, Joe Perches <j...@perches.com> wrote: > > On Fri, 2016-04-22 at 17:51 +0530, Krishna Chaitanya wrote: > > What is the recommended method for adding > > debug prints in mac80211 based drivers. > > > > 1) -DDEBUG + pr_debug =

Debug prints mac80211 drivers

Hi, What is the recommended method for adding debug prints in mac80211 based drivers. 1) -DDEBUG + pr_debug ==> used by mac80211, brcm80211 2) -DDEBUG + dev_dbg ==> zd1201 3) dev_printk(KERN_DEBUG) ==> used by iwlwifi 4) printk(KERN_DEBUG) ==> Just to complete the list. -- Thanks, Regards,

Re: General VHT rate-ctrl question

On Wed, Apr 13, 2016 at 10:31 PM, Dave Taht wrote: > > On Wed, Apr 13, 2016 at 6:18 AM, Ben Greear wrote: > > > > > > On 04/13/2016 01:01 AM, Johannes Berg wrote: > >> > >> On Tue, 2016-04-12 at 16:48 -0700, Ben Greear wrote: > >>> > >>> If a station

Re: RFC: Handling DL only traffic when already in Powersave

On Fri, Apr 8, 2016 at 1:37 AM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Thu, 2016-04-07 at 18:31 +0530, Krishna Chaitanya wrote: >> Hi, >> >> When using HW_PS and running Downlink only traffic like UDP-RX, >> mac80211 has the mechanism to

RFC: Handling DL only traffic when already in Powersave

Hi, When using HW_PS and running Downlink only traffic like UDP-RX, mac80211 has the mechanism to not to enter power-save (postpone the dynamic ps timer). But if we are already in power-save it continues to stay in PS and retrieves the frames, for large traffic this is not acceptable. The

Re: ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins

On Wed, Feb 17, 2016 at 10:02 AM, Avery Pennarun wrote: > > On Tue, Feb 16, 2016 at 5:05 PM, Johannes Berg > wrote: > > On Tue, 2016-02-16 at 16:28 -0500, Avery Pennarun wrote: > >> Changing default_agg_timeout to zero (as it is on most non-ath9k >

Re: [RFC v4] mac80211: add A-MSDU tx support

On Mon, Feb 8, 2016 at 2:56 PM, Emmanuel Grumbach wrote: > On Mon, Feb 8, 2016 at 10:38 AM, Felix Fietkau wrote: >> Requires software tx queueing support. frag_list support (for zero-copy) >> is optional. >> >> Signed-off-by: Felix Fietkau

Re: [RFC v4] mac80211: add A-MSDU tx support

On Mon, Feb 8, 2016 at 3:56 PM, Emmanuel Grumbach <egrumb...@gmail.com> wrote: > On Mon, Feb 8, 2016 at 11:54 AM, Krishna Chaitanya > <chaitanya.m...@gmail.com> wrote: >> On Mon, Feb 8, 2016 at 2:56 PM, Emmanuel Grumbach <egrumb...@gmail.com> >> wrote: >&g

Re: [RFC v4] mac80211: add A-MSDU tx support

On Mon, Feb 8, 2016 at 4:34 PM, Felix Fietkau <n...@openwrt.org> wrote: > On 2016-02-08 10:54, Krishna Chaitanya wrote: >> On Mon, Feb 8, 2016 at 2:56 PM, Emmanuel Grumbach <egrumb...@gmail.com> >> wrote: >>> On Mon, Feb 8, 2016 at 10:38 AM, Felix Fietkau <

Re: mac80211_hwsim + iperf + netns

On Thu, Feb 4, 2016 at 5:57 PM, Krishna Chaitanya <chaitanya.m...@gmail.com> wrote: > On Thu, Feb 4, 2016 at 5:23 PM, Michal Kazior <michal.kaz...@tieto.com> wrote: >> On 4 February 2016 at 12:49, Krishna Chaitanya <chaitanya.m...@gmail.com> >> wrote: >>&

Re: mac80211_hwsim + iperf + netns

On Thu, Feb 4, 2016 at 5:02 PM, Michal Kazior <michal.kaz...@tieto.com> wrote: > On 4 February 2016 at 12:22, Krishna Chaitanya <chaitanya.m...@gmail.com> > wrote: >> Hi All, >> >> I am trying to run some iperf tests using mac80211_hwsim b/w AP and STA. >

Re: mac80211_hwsim + iperf + netns

On Thu, Feb 4, 2016 at 5:23 PM, Michal Kazior <michal.kaz...@tieto.com> wrote: > On 4 February 2016 at 12:49, Krishna Chaitanya <chaitanya.m...@gmail.com> > wrote: >> On Thu, Feb 4, 2016 at 5:02 PM, Michal Kazior <michal.kaz...@tieto.com> >> wrote: >

Re: mac80211_hwsim + iperf + netns

On Thu, Feb 4, 2016 at 5:49 PM, Johannes Berg wrote: > On Thu, 2016-02-04 at 12:32 +0100, Michal Kazior wrote: >> >> ip netns add ns1 >> ip netns exec ns1 bash # get the PID in the session and don't close >> it >> iw phy phyX set netns $pid_of_that_shell >> > > If

Re: mac80211_hwsim + iperf + netns

On Thu, Feb 4, 2016 at 6:05 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Thu, 2016-02-04 at 17:58 +0530, Krishna Chaitanya wrote: >> On Thu, Feb 4, 2016 at 5:49 PM, Johannes Berg <johannes@sipsolutions. >> net> wrote: >> > On Thu, 2016-02-04

mac80211_hwsim + iperf + netns

Hi All, I am trying to run some iperf tests using mac80211_hwsim b/w AP and STA. Even after tweaking the routing table, the packets are still not going through mac80211_hwsim instead they are just looping back. After a quick search i found that we should use different network namespaces. Can

Re: mac80211_hwsim + iperf + netns

On Thu, Feb 4, 2016 at 6:21 PM, Michal Kazior <michal.kaz...@tieto.com> wrote: > On 4 February 2016 at 13:46, Krishna Chaitanya <chaitanya.m...@gmail.com> > wrote: >> On Thu, Feb 4, 2016 at 5:57 PM, Krishna Chaitanya >> <chaitanya.m...@gmail.com> wrote: >&g

Re: lost connectivity until "wpa_cli reassociate" is issued

On Thu, Jan 7, 2016 at 9:59 PM, David Mosberger wrote: > > Ben, > > On Thu, Jan 7, 2016 at 9:24 AM, Ben Greear wrote: > > On 01/07/2016 08:19 AM, David Mosberger wrote: > >> > >> We are seeing a curious issue where WLAN connectivity sometimes > >> gets

Re: lost connectivity until "wpa_cli reassociate" is issued

On Thu, Jan 7, 2016 at 10:17 PM, David Mosberger <dav...@egauge.net> wrote: > On Thu, Jan 7, 2016 at 9:32 AM, Krishna Chaitanya > <chaitanya.m...@gmail.com> wrote: > >> Management frames use a different queue (VO) >> from the logs it looks like a data path

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach wrote: > > From: Eyal Shapira > > An AP can send an operating channel width change in a beacon > opmode notification IE as long as there's a change in the nss as > well (See 802.11ac-2013 section

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote: >> >> > If the rate control algorithm doesn't look at sta->sta.rx_nss then >> > that's their bug. >> &g

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach wrote: > index 7a76ce6..f4a5287 100644 > --- a/net/mac80211/ht.c > +++ b/net/mac80211/ht.c > @@ -230,6 +230,11 @@ bool ieee80211_ht_cap_ie_to_sta_ht_cap(struct > ieee80211_sub_if_data *sdata, > /* set Rx

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

On Tue, Dec 8, 2015 at 9:28 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Tue, 2015-12-08 at 21:25 +0530, Krishna Chaitanya wrote: >> On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg <johannes@sipsolutions. >> net> wrote: >> > On Tue, 2015-12-08 at

Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon

On Tue, Dec 8, 2015 at 9:12 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Tue, 2015-12-08 at 21:08 +0530, Krishna Chaitanya wrote: >> >> > void ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data >> > *sdata, >> >

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

On Wed, Dec 9, 2015 at 12:52 AM, Grumbach, Emmanuel <emmanuel.grumb...@intel.com> wrote: > > > On 12/08/2015 09:11 PM, Krishna Chaitanya wrote: >> >> >> On Dec 9, 2015 12:37 AM, "Grumbach, Emmanuel" >> <emmanuel.grumb...@i

Re: [PATCHv2] offchannel: Cancel the pending_action TX wait, before starting new one.

On Mon, Nov 23, 2015 at 12:45 AM, Jouni Malinen wrote: > > On Mon, Nov 02, 2015 at 08:40:28PM +0530, Chaitanya T K wrote: > > From: tkc > > > > Before the tx_status is received for the action frame, if we > > get another request, we respond to that by

Re: [PATCHv2] offchannel: Cancel the pending_action TX wait, before starting new one.

On Mon, Nov 2, 2015 at 8:40 PM, Chaitanya T K wrote: > From: tkc > > Before the tx_status is received for the action frame, if we > get another request, we respond to that by freeing the memory > for pending_action_tx, but we don't cancel the

Re: Undocumented Sleep Requirements for ieee80211_ops

On Fri, Oct 30, 2015 at 3:07 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Thu, 2015-10-29 at 12:16 +0530, Krishna Chaitanya wrote: >> Hi, >> >> From the documentation:(mac80211.h) For the ieee80211_ops >> (un)assign_vif_chanctx, there is no mention

Undocumented Sleep Requirements for ieee80211_ops

Hi, >From the documentation:(mac80211.h) For the ieee80211_ops (un)assign_vif_chanctx, there is no mention of explicit sleep requirements (allowed/disallwoed) for the callback. >From a quick glance at the code calling the OP, looks like we can sleep (mutexes are used). So how should we handle

Re: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index c8ba2e7..a758eb84 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c @@ -97,7 +97,8 @@ static void

Re: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

On Tue, Jul 28, 2015 at 10:42 PM, Grumbach, Emmanuel emmanuel.grumb...@intel.com wrote: On 07/28/2015 02:35 PM, Grumbach, Emmanuel wrote: On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index

Re: AP + P2P_GO multichan tests with intel7260 as a P2P_CLIENT - direct probe issue

On Thu, Jul 2, 2015 at 12:57 PM, Johannes Berg johan...@sipsolutions.net wrote: On Sat, 2015-06-27 at 23:49 +0200, Janusz Dziedzic wrote: I just check the mac80211/cfg80211 code, and I am not sure this direct probe could work correctly. Function ieee80211_rx_mgmt_probe_resp() is interesting.

Re: AP + P2P_GO multichan tests with intel7260 as a P2P_CLIENT - direct probe issue

On Thu, Jul 2, 2015 at 5:08 PM, Johannes Berg johan...@sipsolutions.net wrote: On Thu, 2015-07-02 at 14:32 +0530, Krishna Chaitanya wrote: We have also found another issue with direct probe. Some of the AP's are not setting sequence number in the probe responses so in case of a retry

Re: AP + P2P_GO multichan tests with intel7260 as a P2P_CLIENT - direct probe issue

On Thu, Jul 2, 2015 at 5:09 PM, Johannes Berg johan...@sipsolutions.net wrote: On Thu, 2015-07-02 at 11:44 +0200, Janusz Dziedzic wrote: The issue above can probably easily fixed by doing the BSS update after the direct probe responded though, no? Like this:

Re: AP + P2P_GO multichan tests with intel7260 as a P2P_CLIENT - direct probe issue

On Thu, Jul 2, 2015 at 5:31 PM, Johannes Berg johan...@sipsolutions.net wrote: On Thu, 2015-07-02 at 17:20 +0530, Krishna Chaitanya wrote: On Thu, Jul 2, 2015 at 5:09 PM, Johannes Berg johan...@sipsolutions.net wrote: On Thu, 2015-07-02 at 11:44 +0200, Janusz Dziedzic wrote: The issue

Re: AP + P2P_GO multichan tests with intel7260 as a P2P_CLIENT - direct probe issue

On Tue, Jun 23, 2015 at 5:25 PM, Peer, Ilan ilan.p...@intel.com wrote: I suspect this is because of P2P_GO NoA? Who should care about this direct probes tx when GO is not present? In case we didn't send direct probes - there is no problem and TC works correctly Interesting :)

Re: AP + P2P_GO multichan tests with intel7260 as a P2P_CLIENT - direct probe issue

On Tue, Jun 23, 2015 at 4:41 PM, Peer, Ilan ilan.p...@intel.com wrote: -Original Message- From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- ow...@vger.kernel.org] On Behalf Of Janusz Dziedzic Sent: Tuesday, June 23, 2015 11:51 To: linux-wireless@vger.kernel.org Cc:

Re: [PATCH 1/3] ath9k: handle RoC abort correctly

On Mon, Jun 22, 2015 at 5:13 PM, Janusz Dziedzic janusz.dzied...@tieto.com wrote: In case we will get ROC abort we should not call ieee80211_remain_on_channel_expired(). In other case I hit such warning on MIPS and p2p negotiation failed (tested with use_chanctx=1). ath: phy0: Starting RoC

Re: [PATCH 1/3] ath9k: handle RoC abort correctly

On Mon, Jun 22, 2015 at 6:32 PM, Michal Kazior michal.kaz...@tieto.com wrote: On 22 June 2015 at 13:56, Krishna Chaitanya chaitanya.m...@gmail.com wrote: On Mon, Jun 22, 2015 at 5:13 PM, Janusz Dziedzic janusz.dzied...@tieto.com wrote: In case we will get ROC abort we should not call

Re: [PATCH V3] mac80211: wowlan: suspend: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Wed, Jun 17, 2015 at 5:07 PM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2015-06-17 at 17:05 +0530, Krishna Chaitanya wrote: Then again, you're talking about WoWLAN, but then ... In wowlan, we simply call drv_resume and only if it fails then we will go through full resume

Re: [PATCH V3] mac80211: wowlan: suspend: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Wed, Jun 17, 2015 at 4:31 PM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2015-06-17 at 15:52 +0530, Krishna Chaitanya wrote: I still don't like it. I also don't believe that what you're writing is actually true. The only problem I can see is that it leads to higher power

Re: [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer.

On Wed, Jun 17, 2015 at 2:38 PM, Johannes Berg johan...@sipsolutions.net wrote: On Fri, 2015-06-12 at 02:34 +0530, Chaitanya T K wrote: In case of Dynamic SMPS enable RTS/CTS for all rates. Applied. I really think you should drop the . at the end of the subject though :) Oh..will drop it. Is

Re: [PATCH V3] mac80211: wowlan: suspend: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Wed, Jun 17, 2015 at 2:17 PM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2015-06-10 at 19:12 +0530, Chaitanya T K wrote: From: Chaitanya T K chaitanya.m...@gmail.com Background: When wowlan is enabled, the chipset stays in low power state maintaining the connection as per the

Re: Question on beacon-miss offloading.

On Fri, Jun 12, 2015 at 6:59 PM, Ben Greear gree...@candelatech.com wrote: On 06/11/2015 11:03 PM, Michal Kazior wrote: On 12 June 2015 at 01:38, Ben Greear gree...@candelatech.com wrote: On 06/11/2015 02:07 PM, Ben Greear wrote: In my ath10k CT firmware, I am disabling the beacon-miss

Re: [PATCH V2] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Wed, Jun 10, 2015 at 1:40 AM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-06-02 at 03:02 +0530, Krishna Chaitanya wrote: This isn't what your patch is actually doing though. You need to mention WoWLAN at the very least in your commit log; Yes, WoWLAN is enabled in our

Re: mac80211 modification

On Mon, Jun 8, 2015 at 10:40 PM, Alexis Green agr...@cococorp.com wrote: You should build mac80211 as module instead of built-in driver and make modules instead of full make. This way you'll be just rebuilding mac80211.ko instead of the whole thing. On Mon, Jun 8, 2015 at 2:39 AM, Duy Tai

Re: [PATCH V2] mac80211: Minstrel HT: Handle all SMPS states of the peer STA.

On Wed, Jun 3, 2015 at 12:07 AM, Chaitanya T K chaitanya.m...@gmail.com wrote: From: Chaitanya Tata chaitanya.m...@gmail.com In case of Dynamic SMPS enable RTS/CTS for all rates. In case of Static SMPS mark the Nss 1 rates as not supported. Signed-off-by: Chaitanya T K

Re: [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss1.

On Tue, Jun 2, 2015 at 3:10 AM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-06-02 at 03:03 +0530, Krishna Chaitanya wrote: This patch is *ancient*, before we actually used patchwork properly ... Ok, so you want me to send a V2 with the indentation fixed? (or) shall i wait

Re: [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss1.

On Thu, Jan 30, 2014 at 11:48 PM, Krishna Chaitanya chaitanya.m...@gmail.com wrote: On Thu, Jan 23, 2014 at 2:57 AM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2014-01-22 at 12:27 +0530, Chaitanya T K wrote: + if (sta-smps_mode == IEEE80211_SMPS_DYNAMIC

Re: cfg80211: Beacon hints for DFS channels

On Thu, Mar 19, 2015 at 1:37 PM, Krishna Chaitanya chaitanya.m...@gmail.com wrote: Hi, In the Regulatory and DFS wiki it is mentioned that beacon hints are not processed for DFS channels. But i could not find the related piece of code which does this. So in DFS channels can we process

Re: [PATCH V2] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Tue, Jun 2, 2015 at 2:06 AM, Johannes Berg johan...@sipsolutions.net wrote: On Mon, 2015-06-01 at 22:44 +0530, Chaitanya T K wrote: From: Chaitanya T K chaitanya.m...@gmail.com If suspended during TX in progress, there can be race where the driver is put of of power-save due to TX and

Re: [PATCH v2] cfg80211: Don't re-use the skb for larger NL messages.

On Sun, May 31, 2015 at 4:12 PM, Johannes Berg johan...@sipsolutions.net wrote: On Sun, 2015-05-31 at 15:31 +0530, Krishna Chaitanya wrote: In our case the data size is 411KB, and each message carries around 3072 bytes, so total messages would be 138. The first message we get, we retrieve

Re: [PATCH v2] cfg80211: Don't re-use the skb for larger NL messages.

On Sun, May 31, 2015 at 12:28 PM, Arend van Spriel aspr...@gmail.com wrote: On 31-05-15 01:28, Chaitanya T K wrote: cfg80211 reuses the skb before asking for a fresh on from genl framework, this works efficiently for smaller messages but NLM_F_DUMP is normally used to transport larger data

Re: [PATCH] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Sun, May 31, 2015 at 3:52 PM, Chaitanya T K chaitanya.m...@gmail.com wrote: From: Chaitanya T K chaitanya.m...@gmail.com If we receive suspend after TX path has executed dynamic ps disable work, the driver will be in ACTIVE state during suspend and even after it resumes. As before

Re: [PATCH v2] cfg80211: Don't re-use the skb for larger NL messages.

On Sun, May 31, 2015 at 2:01 PM, Johannes Berg johan...@sipsolutions.net wrote: On Sun, 2015-05-31 at 04:58 +0530, Chaitanya T K wrote: cfg80211 reuses the skb before asking for a fresh on from genl framework, this works efficiently for smaller messages but NLM_F_DUMP is normally used to

Re: [PATCH v2] cfg80211: Don't re-use the skb for larger NL messages.

On Sun, May 31, 2015 at 4:51 PM, Johannes Berg johan...@sipsolutions.net wrote: On Sun, 2015-05-31 at 16:47 +0530, Krishna Chaitanya wrote: Note # of messages as you say is actually irrelevant - you should look Well with 138 messages the function and each message 3072 bytes calls b/w

Re: Not able to set u-apsd for P2P client

On Fri, May 8, 2015 at 8:16 PM, Krishna Chaitanya chaitanya.m...@gmail.com wrote: Hi, We are having trouble making the uapsd working in p2p client case. Is this broken? or is there a way to configure the uapsd for p2p client case? case a) p2p client with p2p_no_group_iface=1 When trying

Re: [PATCH] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.

On Wed, May 20, 2015 at 7:11 PM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-05-19 at 13:53 +0530, Krishna Chaitanya wrote: I'm not sure I get it - we always transmit a frame after resume. Let me explain the sequence of events: tx_frame: dynamic_ps_disable_work

  1   2   >