Re: [PATCH 2/2] mwifiex: fix unaligned read in mwifiex_config_scan()

2016-08-16 Thread Petri Gynther
On Fri, Aug 12, 2016 at 8:00 PM, Petri Gynther wrote: > $ iwconfig mlan0 essid MySSID > [ 36.93] Path: /sbin/iwconfig > [ 36.93] CPU: 0 PID: 203 Comm: iwconfig Not tainted 4.7.0 #2 > [ 36.94] task: 866f83a0 ti: 866a6000 task.ti: 866a6000 > [ 36.94] > [E

Re: [PATCH 1/2] etherdevice: add is_zero_ether_addr_unaligned()

2016-08-12 Thread Petri Gynther
On Fri, Aug 12, 2016 at 9:11 PM, Joe Perches wrote: > On Fri, 2016-08-12 at 19:59 -0700, Petri Gynther wrote: >> Add a generic routine to test if possibly unaligned to u16 >> Ethernet address is a zero address. > [] >> diff --git a/include/linux/etherdevice.h b/inc

Re: [PATCH] Modify is_zero_ether_addr() to handle byte-aligned addresses

2016-08-12 Thread Petri Gynther
On Fri, Aug 12, 2016 at 8:26 PM, David Miller wrote: > From: Petri Gynther > Date: Fri, 12 Aug 2016 17:15:30 -0700 > >> Root cause: >> mwifiex driver calls is_zero_ether_addr() against byte-aligned address: > > MAC addresses really must be 16-bit aligned to be used

[PATCH 2/2] mwifiex: fix unaligned read in mwifiex_config_scan()

2016-08-12 Thread Petri Gynther
nal patch: [PATCH] Modify is_zero_ether_addr() to handle byte-aligned addresses Per Joe's suggestion -- instead of modifying is_zero_ether_addr() -- add is_zero_ether_addr_unaligned() and use it where needed. Cc: Kalle Valo Cc: David S. Miller Cc: Joe Perches Cc: Amitkumar Karwar Signed

[PATCH 1/2] etherdevice: add is_zero_ether_addr_unaligned()

2016-08-12 Thread Petri Gynther
is_zero_ether_addr() to handle byte-aligned addresses Per Joe's suggestion -- instead of modifying is_zero_ether_addr() -- add is_zero_ether_addr_unaligned() and use it where needed. Cc: Kalle Valo Cc: David S. Miller Cc: Joe Perches Cc: Amitkumar Karwar Signed-off-by: Petri Gynther --- include/

Re: [PATCH] Modify is_zero_ether_addr() to handle byte-aligned addresses

2016-08-12 Thread Petri Gynther
Hi Joe, On Fri, Aug 12, 2016 at 5:28 PM, Joe Perches wrote: > On Fri, 2016-08-12 at 17:15 -0700, Petri Gynther wrote: >> $ iwconfig mlan0 essid MySSID >> [ 36.93] Path: /sbin/iwconfig >> [ 36.93] CPU: 0 PID: 203 Comm: iwconfig Not tainted 4.7.0 #2 >> [ 3

[PATCH] Modify is_zero_ether_addr() to handle byte-aligned addresses

2016-08-12 Thread Petri Gynther
Cc: Joe Perches Cc: Amitkumar Karwar Signed-off-by: Petri Gynther --- include/linux/etherdevice.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h index 37ff4a6..0cfd243 100644 --- a/include/linux/etherdevice.h ++