[PATCH 06/11] rt2800: warn if doing VCO recalibration for unknow RF chip

Since we reset TX_PIN_CFG register, we have to finish recalibration. Warn if this is not possible. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH 04/11] rt2800: set MAX_PSDU len according to remote STAs capabilities

can not set bigger value to speed up communication with some stations and do not break communication with slow stations. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800.h|2 + drivers/net/wireless/ralink/rt2x00/rt2800lib

[PATCH 05/11] rt2800: rename adjust_freq_offset function

We have different modes of adjusting freq offset on different chips. Call current adjustment similarly like vendor driver - mode1 . Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16 1 files changed, 8 inse

Re: [PATCH] iwlegacy: make il3945_mac_ops __ro_after_init

ohannes Berg <johannes.b...@intel.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

[PATCH v2 4/9] rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE

We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on rt2800_init_registers() for USB devices. For PCI devices we will use HW default setting, which is 2, so patch does not change behaviour on PCI devices. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wi

[PATCH v2 7/9] rt2800: use RTS/CTS protection instead of CTS-to-self

Change default to RTS/CTS protection. This has a cost of transmitting one more control frame (RTS) however protect us from traffic from hidden node. On station mode will use CTS-to-self if AP will configure that for the network. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- d

[PATCH v2 6/9] rt2800: correct TX_SW_CFG1 for 5592

Those TX_SW_CFG1 values are used in vendor driver. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drive

[PATCH v2 2/9] rt2800usb: do not wipe out USB_DMA_CFG settings

We should not reset USB_DMA_CFG on rt2800usb_init_registers() as this function is called indirectly from rt2800_enable_radio(). If we do so, we wipe out USB_DMA_CFG settings from rt2800usb_enable_radio(). Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/

[PATCH v2 0/9] rt2800: random fixes

Random fixes mostly related to HT performance. v1 -> v2: - drop patch "rt2800: make ba_size depend on ampdu_factor" - fix changelog for patch "rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE" Stanislaw Gruszka (9): rt2800: correctly report MCS TX par

[PATCH v2 3/9] rt2800: OFDM rates are mandatory

Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index aab59f6..f

[PATCH v2 9/9] rt2800: disable CCK rates on HT

Sending frames in CCK rates on HT can cause performance problems. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wi

[PATCH v2 8/9] rt2800: tune *_PROT_CFG parameters

Use RTS/CTS protection for TXOP on all rates modes as default and disable CCK rates (this cause performance problems). Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16 1 file changed, 8 insertions(+), 8 del

[PATCH v2 5/9] rt2800: correct AUTO_RSP_CFG

Initialize AUTO_RSP_CFG register to similar value as vendor driver does. Do not set BAC_ACK_POLICY based on short preamble setting, those are unrelated. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 ++ 1 file chan

Re: [PATCH] rt2x00: Fix incorrect usage of CONFIG_RT2X00_LIB_USB

n > of pending work. Changing the #ifdef to #if IS_ENABLED() to fix it. > > Signed-off-by: Vishal Thanki <vishaltha...@gmail.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

On Wed, Nov 16, 2016 at 09:07:00AM +0100, Mathias Kresin wrote: > Here are the results of the requested tests. Please keep in mind, I'm not in > a lab environment: > > LEDE head > connect > action 0 sta 9c:f3:87:bc:AA:BB tid 6 buf_size 64 ampdu_factor 3 > action 2 sta 9c:f3:87:bc:AA:BB

[PATCH v2 04/10] rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE

We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on rt2800_init_registers() for USB devices. For PCI devices we will use HW default setting, which is 2, so patch does not change behaviour on PCI devices. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- v1 -> v2 Change

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

On Wed, Nov 02, 2016 at 03:11:00PM +0100, Stanislaw Gruszka wrote: > We can calculate BA window size (max number of pending frames not > yet block acked) of remote station using Maximum A-MPDU length factor > for that station. > > Signed-off-by: Stanislaw Gruszka <sgrus...@

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

On Mon, Nov 14, 2016 at 09:45:36AM +0100, Stanislaw Gruszka wrote: > Could you check below patch and see if it helps? If it does not, > could you printk sta->ht_cap.ampdu_density and ba_size values > and provide them here. Actually please print parameters from below patch. I think ba

Re: Problems with mwifiex_pcie firmware activation

On Thu, Aug 25, 2016 at 05:06:26PM +0200, Stanislaw Gruszka wrote: > On Fri, Aug 12, 2016 at 10:13:43AM +0200, Stanislaw Gruszka wrote: > > On Fri, Aug 12, 2016 at 07:17:38AM +, Amitkumar Karwar wrote: > > > The problem looks strange. The patch just splits > > &

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

Hi On Mon, Nov 14, 2016 at 08:41:57PM +1100, Julian Calaby wrote: > > - rt2x00_set_field32(, MAX_LEN_CFG_MAX_PSDU, 1); > > + rt2x00_set_field32(, MAX_LEN_CFG_MAX_PSDU, 3; > > You're missing a closing parenthesis, so it isn't going to work unless > it's added back in.

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

On Sat, Nov 05, 2016 at 01:56:58PM +0100, Mathias Kresin wrote: > 02.11.2016 15:11, Stanislaw Gruszka: > > > >-sta_priv = sta_to_rt2x00_sta(sta); > >+txdesc->u.ht.mpdu_density = sta->ht_cap.ampdu_density; > > t

Re: [PATCH 04/10] rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE

On Sat, Nov 05, 2016 at 01:55:14PM +0100, Mathias Kresin wrote: > 02.11.2016 15:10, Stanislaw Gruszka: > >We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on > >rt2800_init_registers(). > > > >Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> >

[PATCH 10/10] rt2800: disable CCK rates on HT

Sending frames in CCK rates on HT can cause performance problems. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800li

[PATCH 06/10] rt2800: correct AUTO_RSP_CFG

Initialize AUTO_RSP_CFG register to similar value as vendor driver does. Do not set BAC_ACK_POLICY based on short preamble setting, those are unrelated. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |6 ++ 1 files chan

[PATCH 07/10] rt2800: correct TX_SW_CFG1 for 5592

Those TX_SW_CFG1 values are used in vendor driver. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/d

[PATCH 04/10] rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE

We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on rt2800_init_registers(). Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/

[PATCH 08/10] rt2800: use RTS/CTS protection instead of CTS-to-self

Change default to RTS/CTS protection. This has a cost of transmitting one more control frame (RTS) however protect us from traffic from hidden node. On station mode will use CTS-to-self if AP will configure that for the network. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- d

[PATCH 09/10] rt2800: tune *_PROT_CFG parameters

Use RTS/CTS protection for TXOP on all rates modes as default and disable CCK rates (this cause performance problems). Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16 1 files changed, 8 insertions(+), 8 del

[PATCH 00/10] rt2800: random fixes

Random fixes mostly related to HT performance. Stanislaw Gruszka (10): rt2800: correctly report MCS TX parameters rt2800usb: do not wipe out USB_DMA_CFG settings rt2800: OFDM rates are mandatory rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE rt2800: make ba_size depend

[PATCH 01/10] rt2800: correctly report MCS TX parameters

We should only set IEEE80211_HT_MCS_TX_RX_DIF when TX and RX MCS sets are not equal, i.e. when number of tx streams is different than number of RX streams. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 23 +---

[PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

We can calculate BA window size (max number of pending frames not yet block acked) of remote station using Maximum A-MPDU length factor for that station. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 15 ++- 1

[PATCH 02/10] rt2800usb: do not wipe out USB_DMA_CFG settings

We should not reset USB_DMA_CFG on rt2800usb_init_registers() as this function is called indirectly from rt2800_enable_radio(). If we do so, we wipe out USB_DMA_CFG settings from rt2800usb_enable_radio(). Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/

Re: "silent" TL-WDN4200 (RT593 usb) devices

Hi On Tue, Nov 01, 2016 at 10:33:14AM +0100, Jonas Gorski wrote: > I have a bunch of rt5393 based TL-WDN4200 devices of which only one is > working as expected, and the rest fail to tx with rt2800-usb, using > latest master of lede (but also older verions). They are working fine > with the

Re: [PATCH 08/26] iwlegacy: constify local structures

igned-off-by: Julia Lawall <julia.law...@lip6.fr> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

Re: [PATCH v2] rt2x00: add support for mac addr from device tree

nasty issues. > > Allow to override the MAC in the EEPROM with (a known good) one set in > the device tree to bypass the issue. > > Signed-off-by: Mathias Kresin <d...@kresin.me> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

[PATCH 0/3] mwifiex: FW downloading debug printing improvements

3 small patches that make FW downloading prints more informative Stanislaw Gruszka (3): mwifiex: make "PCI-E is not the winner" print more informative mwifiex: print status of FW ready event mwifiex: do not print dot when downloading FW drivers/net/wireless/marvell/mwifiex/

[PATCH 1/3] mwifiex: make "PCI-E is not the winner" print more informative

Printing ret and adapter->winner do not provide any useful information as those are always 0 at point where the massage is printed. Print value read from reg->fw_status register instead. Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3

[PATCH 2/3] mwifiex: print status of FW ready event

For debugging purpose print content of reg->fw_status register and other variables values when waiting for firmware ready event. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drivers/net/wireless/marvell/mwifiex/pcie.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] rt2x00: add support for mac addr from device tree

On Thu, Aug 25, 2016 at 05:03:06PM +0200, Mathias Kresin wrote: > 2016-08-25 15:19 GMT+02:00 Stanislaw Gruszka <sgrus...@redhat.com>: > > On Thu, Aug 25, 2016 at 01:12:22PM +0200, Mathias Kresin wrote: > >> 2016-08-25 11:33 GMT+02:00 Stanislaw Gruszka <sgrus...@redhat.

[PATCH 3/3] mwifiex: do not print dot when downloading FW

Printing about 3000 lines like this [ 20.691850] mwifiex_pcie :02:00.0: . [ 20.693466] mwifiex_pcie :02:00.0: . is not useful. If FW downloading will be interrupted, we will get proper error message about that. Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> --- drive

Re: [PATCH] rt2x00: add support for mac addr from device tree

On Thu, Aug 25, 2016 at 01:12:22PM +0200, Mathias Kresin wrote: > 2016-08-25 11:33 GMT+02:00 Stanislaw Gruszka <sgrus...@redhat.com>: > > > > On Thu, Aug 25, 2016 at 10:19:22AM +0200, Mathias Kresin wrote: > > > The EEPROM used on some CPEs has for every device the

Re: [PATCH] rt2x00: add support for mac addr from device tree

On Thu, Aug 25, 2016 at 10:19:22AM +0200, Mathias Kresin wrote: > The EEPROM used on some CPEs has for every device the same generic > ralink mac in EEPROM and needs to be overridden. I don't know what is CPE, but even if I would know that, I most likely sill will not understand that description.

Re: Problems with mwifiex_pcie firmware activation

On Fri, Aug 12, 2016 at 07:17:38AM +, Amitkumar Karwar wrote: > The problem looks strange. The patch just splits mwifiex_check_fw_status() > and increases poll count. It should not have any side-effects. > Our code used to check winner status before this patch also. Ok, I misread the patch.

Re: [PATCH] rt2x00usb: Fix error return code

0usb: Use usb anchor to manage URB") > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to m

Re: Problems with mwifiex_pcie firmware activation

Hi On Thu, Aug 11, 2016 at 10:21:58AM +, Amitkumar Karwar wrote: > > -Original Message- > > From: Stanislaw Gruszka [mailto:sgrus...@redhat.com] > > Sent: Thursday, August 11, 2016 2:31 PM > > To: Amitkumar Karwar > > Cc: Nishant Sarmukadam; linux-wirele

Re: Problems with mwifiex_pcie firmware activation

On Thu, Jun 23, 2016 at 02:09:52PM +0200, Stanislaw Gruszka wrote: > On Thu, Jun 16, 2016 at 01:53:15PM +0200, Stanislaw Gruszka wrote: > > On Wed, Jun 15, 2016 at 01:47:53PM +, Amitkumar Karwar wrote: > > > Could you please share complete dmesg log for failure and succe

Re: [RFC] ath10k: silence firmware file probing warnings

On Fri, Jul 22, 2016 at 10:38:24AM +0200, Arend Van Spriel wrote: > + Luis > > On 21-7-2016 13:51, Stanislaw Gruszka wrote: > > (cc: firmware and brcmfmac maintainers) > > > > On Thu, Jul 21, 2016 at 06:23:11AM -0400, Prarit Bhargava wrote: > >> > &g

Re: [RFC] ath10k: silence firmware file probing warnings

(cc: firmware and brcmfmac maintainers) On Thu, Jul 21, 2016 at 06:23:11AM -0400, Prarit Bhargava wrote: > > > On 07/21/2016 04:05 AM, Stanislaw Gruszka wrote: > > On Thu, Jul 21, 2016 at 10:36:42AM +0300, Emmanuel Grumbach wrote: > >> On Thu, Jul 21, 2016 at 10:09 AM,

Re: [RFC] ath10k: silence firmware file probing warnings

On Thu, Jul 21, 2016 at 10:36:42AM +0300, Emmanuel Grumbach wrote: > On Thu, Jul 21, 2016 at 10:09 AM, Stanislaw Gruszka <sgrus...@redhat.com> > wrote: > > On Tue, Jul 19, 2016 at 03:00:37PM +0200, Michal Kazior wrote: > >> Firmware files are versioned to prevent

Re: [RFC] ath10k: silence firmware file probing warnings

On Tue, Jul 19, 2016 at 03:00:37PM +0200, Michal Kazior wrote: > Firmware files are versioned to prevent older > driver instances to load unsupported firmware > blobs. This is reflected with a fallback logic > which attempts to load several firmware files. > > This however produced a lot of

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > > If I understad correctly this error happen 100% of the time, not only during > > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > I guess that works, but it seems wrong to me. Usually, registration > should happen only upon INIT, and yes, at that time the firmware is not > ready to provide the information yet. > > > > As can be seen in the current code

Re: Problems with mwifiex_pcie firmware activation

On Thu, Jun 16, 2016 at 01:53:15PM +0200, Stanislaw Gruszka wrote: > On Wed, Jun 15, 2016 at 01:47:53PM +, Amitkumar Karwar wrote: > > Could you please share complete dmesg log for failure and successful cases? > > Dmesg from failure case is in attachment. I loose access to

Re: Problems with mwifiex_pcie firmware activation

Hi On Wed, Jun 15, 2016 at 01:47:53PM +, Amitkumar Karwar wrote: > Could you please share complete dmesg log for failure and successful cases? Dmesg from failure case is in attachment. I loose access to system where device initalize, I'll provide missed dmesg when I get back the access. >

Re: Problems with mwifiex_pcie firmware activation

On Tue, Jun 14, 2016 at 05:12:50PM +0300, Kalle Valo wrote: > Stanislaw Gruszka <sgrus...@redhat.com> writes: > > > Hence looks like forcing firmware upload somehow changed device, now it > > is capable to initialize. On my second system device is on pristine state

Re: [PATCH] iwlegacy: avoid warning about missing braces

> This adds a set of curly braces to avoid the warning. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to major

Re: [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled

ff-by: Chun-Yeow Yeoh <yeohchuny...@gmail.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rt2800usb: enable MFP if hw crypt is disabled

On Wed, Apr 20, 2016 at 02:59:32PM +0800, Chun-Yeow Yeoh wrote: > If rt2800usb is loaded with nohwcrypt=1, mac80211 takes > care of the crypto with software encryption/decryption > and thus, MFP can be used. > > Tested for secured mesh using ath9k_htc and ath9k. > > Signed-off-by: Chun-Yeow Yeoh

Re: [PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up()

s truly correct - however > it looks right and I stand by my analysis. > > Could someone else please review this? Looks ok. Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6] rt2x00usb: Use usb anchor to manage URB

B disconnect. > Managing the URBs with anchor will make sure that all > the URBs are handled gracefully before device gets > disconnected. > > Signed-off-by: Vishal Thanki <vishaltha...@gmail.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this

Re: [PATCH v3] rt2x00usb: Use usb anchor to manage URB

On Fri, Mar 18, 2016 at 09:30:36AM +0100, Vishal Thanki wrote: > @@ -734,6 +744,8 @@ void rt2x00usb_uninitialize(struct rt2x00_dev *rt2x00dev) > { > struct data_queue *queue; > > + usb_kill_anchored_urbs(rt2x00dev->anchor); As already pointed in different email this is not good place

Re: [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init()

On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote: > From: Markus Elfring > > Rename a jump label according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > [Rewrote commit title] >

Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

On Thu, Mar 17, 2016 at 10:53:18AM +0100, Vishal Thanki wrote: > > usb_anchor structure should be embedded in rt2x00_dev structure, > > otherwise you can kill urb's from other rt2x00 devices, when > > disconnecting another one. > > > > rt2x00_dev structure does not contain any bus specific data

Re: [PATCH v2] rt2x00usb: Use usb anchor to manage URB

On Thu, Mar 17, 2016 at 12:55:59PM +0100, Vishal Thanki wrote: > @@ -840,6 +857,8 @@ void rt2x00usb_disconnect(struct usb_interface *usb_intf) > struct ieee80211_hw *hw = usb_get_intfdata(usb_intf); > struct rt2x00_dev *rt2x00dev = hw->priv; > > +

Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

l_dealloc_bcast_stations in the error handling code of > __il4965_up to fix this problem. > > This patch has been tested in real device, and it actually fixes the bug. Could the call trace from the bug be provided ? > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Ack

Re: [PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up()

On Fri, Mar 18, 2016 at 01:29:11PM +1100, Julian Calaby wrote: > In some of the non-success return paths, the memory allocated by > iwl4965_sta_alloc_lq() in iwl4965_alloc_bcast_station() is not freed. > > In particular: > - if the card isn't ready after il4965_prepare_card_hw() > - if the card

Re: [PATCH v2] rt2x00usb: Use usb anchor to manage URB

On Thu, Mar 17, 2016 at 04:26:22PM +0100, Vishal Thanki wrote: > On Thu, Mar 17, 2016 at 03:56:43PM +0100, Stanislaw Gruszka wrote: > > On Thu, Mar 17, 2016 at 12:55:59PM +0100, Vishal Thanki wrote: > > > @@ -840,6 +857,8 @@ void rt2x00usb_disconnect(struct usb_interfac

Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

Hi On Wed, Mar 16, 2016 at 06:28:51PM +0100, Vishal Thanki wrote: > +struct rt2x00usb_anchors { > + struct usb_anchor async_urb; > + struct usb_anchor tx_submitted; > + struct usb_anchor rx_submitted; > +}; I don't think we need 3 different usb_anchor's, one should be enough. >

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: > > @@ -1001,6 +1002,9 @@ struct rt2x00_dev { > > /* Extra TX headroom required for alignment purposes. */ > unsigned int extra_tx_headroom; > + > + struct usb_anchor *anchor; > + void

Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB

On Sat, Mar 19, 2016 at 09:21:52AM +0100, Vishal Thanki wrote: > On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka <sgrus...@redhat.com> > wrote: > > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote: > >> > >> @@ -1001,6 +1002,9 @@ struct rt2x

Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up

On Fri, Mar 18, 2016 at 10:12:34PM +1100, Julian Calaby wrote: > I don't think you're right. Looking closely at the code, > il->num_stations gets incremented in il_prep_station() which is called > unconditionally from il4965_alloc_bcast_station(). > > So I think this and the following patch are

Re: New firmware for RT2870

On Wed, Mar 09, 2016 at 02:22:45PM -0600, Larry Finger wrote: > In https://bugzilla.kernel.org/show_bug.cgi?id=114151, the OP reports > improved stability and performance for an RT5370 using a newer firmware that > came with the driver CD. The logs show this to be version 0.36, whereas the >

Re: rt2x00queue: rt2800usb: NULL pointer crash while during USB disconnect

Hi, On Tue, Mar 01, 2016 at 11:36:13AM +0100, Vishal Thanki wrote: > I observed a NULL pointer access crash during my testing on a custom AM33xx > based board with RT5572 USB wifi module. The kernel log is attached with > the mail. With initial debugging, I think that the USB disconnect > event

Re: [PATCH] rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

On Tue, Feb 23, 2016 at 11:09:22PM +0800, Anthony Wong wrote: > Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong <anthony.w...@ubuntu.com> > Cc: sta...@vger.kernel.org Acked-by: Stanislaw Gruszka

Re: [PATCH 1/3] net-iwlegacy: Refactoring for il_eeprom_init()

fr...@users.sourceforge.net> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

his in the only file > that shows the behavior, by marking the il_adjust_beacon_interval > function as noinline, which convinces gcc to use the unoptimized > do_div() all the time. I don't think this is good way to "fix" the issue, but also have nothing against to this pa

Re: [patch] iwlegacy: cleanup end of il_send_add_sta()

.carpen...@oracle.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch] rt2x00: type bug in _rt2500usb_register_read()

x%.8x\n", u32); > > We end up copying uninitialized data to the user which is bogus and an > information leak. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> > --- > Not tested. Perhaps we should just rem

Re: rt2x00: Firmware loading vs. udev rules

Hi On Tue, Sep 29, 2015 at 06:38:19PM +0200, Pascal Huerst wrote: > on rt2x00 devices, firmware gets loaded in: > > int rt2x00lib_start(struct rt2x00_dev *rt2x00dev) > > which is called, when we start the interface by: > > ifconfig wlan0 up > > I need to lower tx power of the device and

Re: [PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb

and EEPROM_CALIBRATE_OFFSET. Change the EEPROM_SIZE to 0x6e in order to retrieve all the fields. Tested with a rt2570 device. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Acked-by: Stanislaw Gruszka sgrus...@redhat.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] rt2800: fix assigning same WCID for different stations

On Wed, Jun 10, 2015 at 04:20:37PM +0200, Stanislaw Gruszka wrote: On some hardware reading WCID entries table results getting 0xff numbers, no matter of value written there before. This cause assigning the same WCID for different stations and makes not possible to connect to more than one

[PATCH v2] rt2800: fix assigning same WCID for different stations

On some hardware reading WCID entries table results getting 0xff numbers, no matter of value written there before. This cause assigning the same WCID for different stations and makes not possible to connect to more than one station. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- v1 - v2

[PATCH] rt2800: fix assigning same WCID for different stations

On some hardware reading WCID entries table results getting 0xff numbers, no matter of value written there before. This cause assigning the same WCID for different stations and makes not possible to connect to more than one station. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com

[PATCH] rt2x00, MAINTAINERS: remove rt2x00.serialmonkey.com list and web page

rt2x00.serialmonkey.com will be shutdown. Since traffic on rt2x00 mailing list is very low, we can use only linux-wireless list for any rt2x00 related topics. Thanks for Luis Correia, Ivo van Doorn and Mark Wallis for maintaining rt2x00 servers for years! Signed-off-by: Stanislaw Gruszka sgrus

[PATCH] mac80211: docs: fix cannot parse enum error

Patch fixes documentation generation error: Error(./include/net/mac80211.h:331): Cannot parse enum! Error(./include/net/mac80211.h:369): Cannot parse enum! Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- include/net/mac80211.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

Re: [PATCH] iwl4965: Enable checking of format strings

On Tue, Apr 28, 2015 at 07:19:02PM +0300, Kalle Valo wrote: Rasmus Villemoes li...@rasmusvillemoes.dk writes: Since these fmt_* variables are just const char*, and not const char[], gcc (and smatch) doesn't to type checking of the arguments to the printf functions. Since the linker knows

Re: [1/3] rt2x00usb: initialize the read value in case of failure

On Mon, Mar 16, 2015 at 05:41:00PM +0100, Sebastian Andrzej Siewior wrote: * Kalle Valo | 2015-03-16 16:06:52 [+]: Thanks, 3 patches applied to wireless-drivers-next.git: Thanks. Do you guys have any kind of further documentation? Where did There is doc describing MAC registers, it was

Re: [PATCH] rt2x00: use rt2x00queue_flush_queues() instead of implementing the same action

On Sat, Mar 07, 2015 at 08:45:50PM +02iee80211_ops00, Giedrius Statkevičius wrote: Use rt2x00queue_flush_queues() in rt2x00mac_flush() instead of reimplementing the same actions the second time. Also, now it flushes the rx queue aswell which it didn't before and that makes it completely do

Re: Ralink RT5390/RT5370 no longer works on more recent kernels

On Sun, Feb 08, 2015 at 08:06:28PM -0600, Larry Finger wrote: On 02/07/2015 10:54 AM, Simon Raffeiner (SCC) wrote: The second thing to verify is that your configuration contains the line CONFIG_RT2800USB_RT53XX=y. This parameter is marked as depending on EXPERIMENTAL, and I'm not sure that

Re: [PATCH] net: wireless: rt2x00: use helper to check capability/requirement

On Fri, Dec 26, 2014 at 04:19:18PM +0800, Fred Chou wrote: From: Fred Chou fred.chou...@gmail.com Use rt2x00_has_cap_flag macro to check rt2x00dev-cap_flags. Signed-off-by: Fred Chou fred.chou...@gmail.com Acked-by: Stanislaw Gruszka sgrus...@redhat.com -- To unsubscribe from this list

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

On Thu, Dec 04, 2014 at 03:52:52PM +1100, Julian Calaby wrote: On Thu, Dec 4, 2014 at 3:39 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 04, 2014 at 07:07:58AM +0530, Parth Sane wrote: Hi, I'd say I'm midway through with c programming(part of my computer

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

On Thu, Dec 04, 2014 at 09:49:53AM +0100, Oleksij Rempel wrote: So far i know, Felix is working on abgn+ac (MT7662 and MT7612) devices. MT7601STA is (a)bgn. Are there similar regs? All Mediatek/Ralink devices I know have the same MAC registers, but different BBP and RF registers. In mt7601

Re: [PATCH 4/4] Revert rt2x00: Endless loop on hub port power down

On Tue, Dec 02, 2014 at 12:17:57PM +0100, Richard Genoud wrote: It tested this serie but unfortunately, reverting this still caused an infinite loop. (cf https://lkml.org/lkml/2014/4/3/492 to reproduce) It is possible to disable internal hub? It fails here, but perhaps I do not have compiled

[PATCH 1/4] rt2x00: use timeout in rt2x00usb_vendor_request

Use provided timeout value in rt2x00usb_vendor_request() instead of iterating REGISTER_BUSY_COUNT times. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2x00usb.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 3/4] rt2x00: change REGISTER_TIMEOUT

Waiting 500ms for register access is too long, decrease this value to 100ms. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2x00usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.h b/drivers/net

[PATCH 4/4] Revert rt2x00: Endless loop on hub port power down

2ad69ac597619 solves is kinda artificial. Cc: Richard Genoud richard.gen...@gmail.com Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2x00usb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless

[PATCH 2/4] rt2x00: change REGISTER_BUSY_COUNT for USB

Because of delays on USB we do not have to iterate so many times on USB hardware when waiting for H/W register become valid. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2500usb.c | 8 drivers/net/wireless/rt2x00/rt2x00.h| 5 - drivers

Re: [rt2x00-users] [PATCH] rt2800: fix RT5592 TX power settings regression

On Fri, Nov 21, 2014 at 10:39:39AM +0100, Ronald Wahl wrote: For me the patch will work but there is a change for RT3290 and RT5390. On both chipsets BBP 1 was not written before but with this patch it is going to be written now and the value depends on the return of

[PATCH] rt2800: calculate tx power temperature compensation on selected chips

compensation calculation. Reported-and-tested-by: Ronald Wahl ronald.w...@raritan.com Debugged-by: Ronald Wahl ronald.w...@raritan.com Cc: Mike Romberg mike-romb...@comcast.net Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/net/wireless/rt2x00/rt2800lib.c | 45

Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?

On Fri, Nov 14, 2014 at 03:57:40PM +0900, Marcel Holtmann wrote: Hi Luca, I've updated wireless code on RHEL and get complain that now cfg80211 and rfkill modules are loaded on machines that do not have wireless hardware. Modules are auto-loaded because NetworkManager send nl80211

<    2   3   4   5   6   7   8   >