Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-29 Thread Ajay.Kathat
On 10/29/2018 8:26 PM, Kalle Valo wrote: > Ajay Singh writes: > >> On 10/9/2018 4:06 PM, Johannes Berg wrote: >>> On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: >>> >> +typedef void (*wilc_remain_on_chan_expired)(void *, u32); >> +typedef void (*wilc_remain_on_chan_ready)(void *);

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-29 Thread Kalle Valo
Ajay Singh writes: > On 10/9/2018 4:06 PM, Johannes Berg wrote: >> On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: >> > +typedef void (*wilc_remain_on_chan_expired)(void *, u32); > +typedef void (*wilc_remain_on_chan_ready)(void *); >>> I think as per coding style the typedef for

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Adham.Abozaeid
On 10/09/2018 01:02 PM, Johannes Berg wrote: > On Tue, 2018-10-09 at 20:01 +, adham.aboza...@microchip.com wrote: >> >> Do you mean that it can also be used for probing specific networks even if >> they are broadcasting their SSID? > > Yes. > >> I think this might be a possible case if

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 20:01 +, adham.aboza...@microchip.com wrote: > > Do you mean that it can also be used for probing specific networks even if > they are broadcasting their SSID? Yes. > I think this might be a possible case if the user is trying to limit the scan > results to a

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Adham.Abozaeid
On 10/09/2018 12:14 PM, Johannes Berg wrote: > On Tue, 2018-10-09 at 18:36 +, adham.aboza...@microchip.com wrote: >> >> Johannes, is the cfg80211_scan_request.ssid used for something else >> other than specifying the hidden networks that the controller should >> scan for? > > Ahh, now I

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 18:36 +, adham.aboza...@microchip.com wrote: > > Johannes, is the cfg80211_scan_request.ssid used for something else > other than specifying the hidden networks that the controller should > scan for? Ahh, now I understand where you're coming from. Well, it's the SSID

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Adham.Abozaeid
On 10/09/2018 05:18 AM, Ajay Singh wrote: > > On 10/9/2018 5:16 PM, Johannes Berg wrote: >> On Tue, 2018-10-09 at 17:14 +0530, Ajay Singh wrote: >>> On 10/9/2018 4:06 PM, Johannes Berg wrote: On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: >>> +typedef void

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Ajay Singh
On 10/9/2018 5:16 PM, Johannes Berg wrote: > On Tue, 2018-10-09 at 17:14 +0530, Ajay Singh wrote: >> On 10/9/2018 4:06 PM, Johannes Berg wrote: >>> On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: >>> >> +typedef void (*wilc_remain_on_chan_expired)(void *, u32); >> +typedef void

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 17:14 +0530, Ajay Singh wrote: > On 10/9/2018 4:06 PM, Johannes Berg wrote: > > On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: > > > > > > > +typedef void (*wilc_remain_on_chan_expired)(void *, u32); > > > > > +typedef void (*wilc_remain_on_chan_ready)(void *); > > >

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Ajay Singh
On 10/9/2018 4:06 PM, Johannes Berg wrote: > On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: > +typedef void (*wilc_remain_on_chan_expired)(void *, u32); +typedef void (*wilc_remain_on_chan_ready)(void *); >> I think as per coding style the typedef for function pointer are

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: > > > +typedef void (*wilc_remain_on_chan_expired)(void *, u32); > > > +typedef void (*wilc_remain_on_chan_ready)(void *); > I think as per coding style the typedef for function pointer are allowed. True, I guess, but why do you need them? >

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-09 Thread Ajay Singh
On 10/8/2018 7:50 PM, Johannes Berg wrote: > On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote: > >> +#include > you include it > >> +#include "coreconfigurator.h" >> + >> +#define IDLE_MODE 0x00 >> +#define AP_MODE 0x01 >> +#define STATION_MODE0x02 >> +#define GO_MODE

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-08 Thread Johannes Berg
On Wed, 2018-09-26 at 15:55 +0530, Ajay Singh wrote: > +#include you include it > +#include "coreconfigurator.h" > + > +#define IDLE_MODE0x00 > +#define AP_MODE 0x01 > +#define STATION_MODE 0x02 > +#define GO_MODE 0x03 > +#define CLIENT_MODE 0x04 > +#define

[PATCH 03/19] wilc: add host_interface.h

2018-09-26 Thread Ajay Singh
Moved '/driver/staging/wilc1000/host_interface.h' to 'drivers/net/wireless/microchip/wilc/'. Signed-off-by: Ajay Singh --- .../net/wireless/microchip/wilc/host_interface.h | 362 + 1 file changed, 362 insertions(+) create mode 100644