Re: [PATCH 31/34] brcmfmac: Remove func0 from function array

2017-08-19 Thread Ian Molton
On 08/08/17 12:19, Arend van Spriel wrote: >> -sdio_f0_readb((sdiodev)->func[0], (addr), (r)) >> +sdio_f0_readb((sdiodev)->func[1], (addr), (r)) > > There is no reason to keep these any longer as these do not provide any > functionality over the core sdio function unless you consider the

Re: [PATCH 31/34] brcmfmac: Remove func0 from function array

2017-08-08 Thread Arend van Spriel
On 08-08-17 13:27, Ian Molton wrote: > On 08/08/17 12:19, Arend van Spriel wrote: > >>> #define brcmf_sdiod_func0_rb(sdiodev, addr, r) \ >>> - sdio_f0_readb((sdiodev)->func[0], (addr), (r)) >>> + sdio_f0_readb((sdiodev)->func[1], (addr), (r)) >> >> There is no reason to keep these any

Re: [PATCH 31/34] brcmfmac: Remove func0 from function array

2017-08-08 Thread Arend van Spriel
On 26-07-17 22:25, Ian Molton wrote: > Linux doesnt pass you func0 as a function when probing - instead > providing specific access functions to read/write it. > > This prepares for a patch to remove the actual array entry itself. Reviewed-by: Arend van Spriel >

[PATCH 31/34] brcmfmac: Remove func0 from function array

2017-07-26 Thread Ian Molton
Linux doesnt pass you func0 as a function when probing - instead providing specific access functions to read/write it. This prepares for a patch to remove the actual array entry itself. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

[PATCH 31/34] brcmfmac: Remove func0 from function array

2017-07-19 Thread Ian Molton
Linux doesnt pass you func0 as a function when probing - instead providing specific access functions to read/write it. This prepares for a patch to remove the actual array entry itself. Signed-off-by: Ian Molton --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c