Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Lorenzo Bianconi
> On Mon, 2018-12-03 at 21:36 +0200, Toke Høiland-Jørgensen wrote: > > Hi Johannes > > > > I think your email can be basically summed up to: > > > > > [ ... ] but really I think it's a can of worms. > > > > ...right? :) > > Heh, yeah :) > > > I sort of had a feeling it would be, but thank you for s

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Mon, 2018-12-03 at 21:36 +0200, Toke Høiland-Jørgensen wrote: >> Hi Johannes >> >> I think your email can be basically summed up to: >> >> > [ ... ] but really I think it's a can of worms. >> >> ...right? :) > > Heh, yeah :) > >> I sort of had a feeling it would be,

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Johannes Berg
On Mon, 2018-12-03 at 21:36 +0200, Toke Høiland-Jørgensen wrote: > Hi Johannes > > I think your email can be basically summed up to: > > > [ ... ] but really I think it's a can of worms. > > ...right? :) Heh, yeah :) > I sort of had a feeling it would be, but thank you for spelling out in > ex

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Toke Høiland-Jørgensen
Hi Johannes I think your email can be basically summed up to: > [ ... ] but really I think it's a can of worms. ...right? :) I sort of had a feeling it would be, but thank you for spelling out in excruciating detail why that is so. Given this, I think I agree that it's not worth it for now, an

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-12-03 Thread Johannes Berg
Hi Toke, all, Sorry I wasn't around for the discussion, I've been travelling and sick. I'm picking this as an arbitrary point in the discussion to reply to, hope you don't feel bad about that. >> [A-MPDU reordering] > In principle, all of this could be done. But we need to think carefully > abou

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >> >> Lorenzo Bianconi writes: >> >> >> >> >> On Wed, 28 Nov 2018 13:36:26 +0100 >> >> >> Toke Høiland-Jørgensen wrote: >> >> >> > > [...] > >> >> > >> >> > I guess it will be enough to avoid loading a 'non-WiFi' bpf program on >> >> >

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > >> Lorenzo Bianconi writes: > >> > >> >> On Wed, 28 Nov 2018 13:36:26 +0100 > >> >> Toke Høiland-Jørgensen wrote: > >> >> [...] > >> > > >> > I guess it will be enough to avoid loading a 'non-WiFi' bpf program on > >> > a 802.11 netdevice (and vice versa). We

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >> >> On Wed, 28 Nov 2018 13:36:26 +0100 >> >> Toke Høiland-Jørgensen wrote: >> >> >> >> > Lorenzo Bianconi writes: >> >> > >> >> > >> Lorenzo Bianconi writes: >> >> > >> >> >> > >> > This series is intended as a playground to star

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > >> On Wed, 28 Nov 2018 13:36:26 +0100 > >> Toke Høiland-Jørgensen wrote: > >> > >> > Lorenzo Bianconi writes: > >> > > >> > >> Lorenzo Bianconi writes: > >> > >> > >> > >> > This series is intended as a playground to start > >> > >> > experimenting/developi

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Toke Høiland-Jørgensen
Michał Kazior writes: > On Thu, 29 Nov 2018 at 14:00, Lorenzo Bianconi > wrote: > [...] >> > The other direction will probably be more difficult, at least if 802.11 >> > frames need to be built in software. It *might* be possible with the XDP >> > egress hook we are planning (with a suitable set

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Toke Høiland-Jørgensen
Michał Kazior writes: > On Thu, 29 Nov 2018 at 14:31, Toke Høiland-Jørgensen wrote: > [...] >> >> Option#3 is to say, Wifi XDP is so different that we should create a >> >> new (enum) bpf_prog_type. And then still see if we can leverage some >> >> of the same core-code (as long as it doesn't sl

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Michał Kazior
On Thu, 29 Nov 2018 at 14:00, Lorenzo Bianconi wrote: [...] > > The other direction will probably be more difficult, at least if 802.11 > > frames need to be built in software. It *might* be possible with the XDP > > egress hook we are planning (with a suitable set of helpers, the eBPF > > program

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Michał Kazior
On Thu, 29 Nov 2018 at 14:31, Toke Høiland-Jørgensen wrote: [...] > >> Option#3 is to say, Wifi XDP is so different that we should create a > >> new (enum) bpf_prog_type. And then still see if we can leverage some > >> of the same core-code (as long as it doesn't slowdown performance). > >> > > >

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >> > On Nov 28, Toke Høiland-Jørgensen wrote: >> >> Lorenzo Bianconi writes: >> >> >> >> >> Lorenzo Bianconi writes: >> >> >> >> >> >> >> >> > This series is intended as a playground to start >> >> >> >> >> > experimenting/developing

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> On Wed, 28 Nov 2018 13:36:26 +0100 >> Toke Høiland-Jørgensen wrote: >> >> > Lorenzo Bianconi writes: >> > >> > >> Lorenzo Bianconi writes: >> > >> >> > >> > This series is intended as a playground to start >> > >> > experimenting/developing >> > >> > with XDP/

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > > On Nov 28, Toke Høiland-Jørgensen wrote: > >> Lorenzo Bianconi writes: > >> > >> >> Lorenzo Bianconi writes: > >> >> > >> >> >> >> > This series is intended as a playground to start > >> >> >> >> > experimenting/developing > >> >> >> >> > with XDP/eBPF over W

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-29 Thread Lorenzo Bianconi
> On Wed, 28 Nov 2018 13:36:26 +0100 > Toke Høiland-Jørgensen wrote: > > > Lorenzo Bianconi writes: > > > > >> Lorenzo Bianconi writes: > > >> > > >> > This series is intended as a playground to start > > >> > experimenting/developing > > >> > with XDP/eBPF over WiFi and collect ideas/conc

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: > On Nov 28, Toke Høiland-Jørgensen wrote: >> Lorenzo Bianconi writes: >> >> >> Lorenzo Bianconi writes: >> >> >> >> >> >> > This series is intended as a playground to start >> >> >> >> > experimenting/developing >> >> >> >> > with XDP/eBPF over WiFi and collect idea

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Jesper Dangaard Brouer
On Wed, 28 Nov 2018 13:36:26 +0100 Toke Høiland-Jørgensen wrote: > Lorenzo Bianconi writes: > > >> Lorenzo Bianconi writes: > >> > >> > This series is intended as a playground to start experimenting/developing > >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. > >> > Introd

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Lorenzo Bianconi
On Nov 28, Toke Høiland-Jørgensen wrote: > Lorenzo Bianconi writes: > > >> Lorenzo Bianconi writes: > >> > >> >> >> > This series is intended as a playground to start > >> >> >> > experimenting/developing > >> >> >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. > >> >> >> > In

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >> >> >> > This series is intended as a playground to start >> >> >> > experimenting/developing >> >> >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. >> >> >> > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > >> >> > This series is intended as a playground to start > >> >> > experimenting/developing > >> >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. > >> >> > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported > >> >> > actions are:

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> >> > This series is intended as a playground to start >> >> > experimenting/developing >> >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. >> >> > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported >> >> > actions are: >> >> > - XDP

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Toke Høiland-Jørgensen
Michał Kazior writes: > On Wed, 28 Nov 2018 at 13:39, Toke Høiland-Jørgensen > wrote:[...] >> > This is an early stage implementation, at this point I would collect >> > other people opinions/concerns about using bpf/xdp directly on 802.11 >> > frames. >> >> Thanks for looking into this! > > I'

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Lorenzo Bianconi
> >> > This series is intended as a playground to start experimenting/developing > >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. > >> > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported > >> > actions are: > >> > - XDP_PASS > >> > - XDP_ABORTED > >> > - XDP_D

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Michał Kazior
On Wed, 28 Nov 2018 at 13:39, Toke Høiland-Jørgensen wrote:[...] > > This is an early stage implementation, at this point I would collect > > other people opinions/concerns about using bpf/xdp directly on 802.11 > > frames. > > Thanks for looking into this! I'm really hyped up with this especiall

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >> > This series is intended as a playground to start experimenting/developing >> > with XDP/eBPF over WiFi and collect ideas/concerns about it. >> > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported >> > actions are: >

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > > This series is intended as a playground to start experimenting/developing > > with XDP/eBPF over WiFi and collect ideas/concerns about it. > > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported > > actions are: > > - XDP_PASS > > - XDP_ABORTED >

Re: [RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-28 Thread Kalle Valo
Lorenzo Bianconi writes: > This series is intended as a playground to start experimenting/developing > with XDP/eBPF over WiFi and collect ideas/concerns about it. > Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported > actions are: > - XDP_PASS > - XDP_ABORTED > - XDP_DROP > In

[RFC 0/5] add XDP support to mt76x2e/mt76x0e drivers

2018-11-27 Thread Lorenzo Bianconi
This series is intended as a playground to start experimenting/developing with XDP/eBPF over WiFi and collect ideas/concerns about it. Introduce XDP support to mt76x2e/mt76x0e drivers. Currently supported actions are: - XDP_PASS - XDP_ABORTED - XDP_DROP Introduce ndo_bpf mac80211 callback in order