Re: [PATCH 1/1] wireless: mac80211: Avoid using uninitialized stack data

2014-12-12 Thread Johannes Berg
On Wed, 2014-12-10 at 14:14 -0500, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Avoid case where we would access uninitialized stack data if a driver advertises HT support without 40MHz channel support. I've fixed the commit message (it's actually in the check

Re: [PATCH] iw: Fix calculation of maximum supported 802.11n data rate

2014-12-12 Thread Johannes Berg
On Wed, 2014-12-10 at 10:23 +0100, Henning Rogge wrote: Fix typo in calculation, binary AND combination of low byte and high byte is always zero. Obviously - applied, thanks. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH] nl80211: check matches array length before acessing it

2014-12-12 Thread Johannes Berg
On Mon, 2014-12-01 at 11:32 +0200, Luca Coelho wrote: From: Luciano Coelho luciano.coe...@intel.com If the userspace passes a malformed sched scan request (or a net detect wowlan configuration) by adding a NL80211_ATTR_SCHED_SCAN_MATCH attribute without any nested matchsets, a NULL pointer

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Krzysztof Konopko
On 12/12/14 00:53, Larry Finger wrote: On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16

Re: [PATCH] mac80211: update the channel context after channel switch

2014-12-12 Thread Johannes Berg
On Sun, 2014-11-30 at 17:17 +0200, Emmanuel Grumbach wrote: When the channel switch has been made, a vif is now using the channel context which was reserved. When that happens, we need to update the channel context since its parameters may change. I hit a case in which I switched to a 40Mhz

Re: [PATCH 3/4] ath10k: Fix no-ack frame status

2014-12-12 Thread Johannes Berg
On Thu, 2014-12-11 at 12:10 +0200, Kalle Valo wrote: Sujith Manoharan suj...@msujith.org writes: From: Sujith Manoharan c_man...@qca.qualcomm.com Use the new IEEE80211_TX_STAT_NOACK_TRANSMITTED flag to indicate successful transmission of no-ack frames. This fixes multicast frame

[PATCH v2 4/5] ath10k: enable per-vif sta powersave

2014-12-12 Thread Michal Kazior
Per-vif bss_conf.ps should be used to configure powersave. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c

[PATCH v2 0/5] ath10k: a bunch of STA-related fixes

2014-12-12 Thread Michal Kazior
Michal Kazior (5): ath10k: improve 11b coex ath10k: fix STA u-APSD ath10k: prevent invalid ps timeout config ath10k: enable per-vif sta powersave ath10k: advertise p2p dev support drivers/net/wireless/ath/ath10k/core.c | 6 -- drivers/net/wireless/ath/ath10k/mac.c | 127

[PATCH v2 5/5] ath10k: advertise p2p dev support

2014-12-12 Thread Michal Kazior
Firmware doesn't allow precise tx rate control so P2P wasn't entirely spec compliant (it was using CCK rates in some cases). The only way to make sure firmware doesn't use CCK rates is to have a vdev with P2P subtype used for scanning and tx. This can be done via a special dedicated P2P device

[PATCH v2 1/5] ath10k: improve 11b coex

2014-12-12 Thread Michal Kazior
Some firmware revisions need peer phymode to be specified as MODE_11B when associating as station to a 11b AP. Otherwise they can starve other stations. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 13 - 1 file changed, 12

[PATCH v2 2/5] ath10k: fix STA u-APSD

2014-12-12 Thread Michal Kazior
To comply with WMM-PS the device shouldn't wake up with a NullFunc frame pair when tx-ing. Instead PM bit on each tx frame should be used. To make this work correctly firmware needs to be told to use a different STA PS wake threshold when u-APSD is enabled. Signed-off-by: Michal Kazior

[PATCH v2 3/5] ath10k: prevent invalid ps timeout config

2014-12-12 Thread Michal Kazior
Setting 0 ps timeout to firmware yields very poor latency and traffic issues. This is the case when multi-vif is active. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [PATCHv2] mac80211: enable TPC through mac80211 stack

2014-12-12 Thread Johannes Berg
On Mon, 2014-12-01 at 11:30 +0100, Lorenzo Bianconi wrote: Enable/disable per packet Transmit Power Control (TPC) in lower drivers according to TX power settings configured by the user. In particular TPC is enabled if value passed in enum nl80211_tx_power_setting is NL80211_TX_POWER_AUTOMATIC

Re: [PATCH] cfg80211: avoid intersection when applying custom reg

2014-12-12 Thread Johannes Berg
On Sun, 2014-12-07 at 18:03 +0200, Arik Nemtsov wrote: The custom-reg handling function can currently only add flags to a given channel. This results in stale flags being left applied. In some cases a channel was disabled and even the orig_flags were changed to reflect this. Previously the

Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-12 Thread Johannes Berg
On Wed, 2014-12-10 at 00:21 +0200, Vadim Kochan wrote: It allows to identify the wlan kind of device for the user application, Applied, +static struct rtnl_link_ops wireless_link_ops __read_mostly = { + .kind = wlan, +}; but I've made this const. It only needs to be non-const

Re: [PATCH 1/4] mac80211: Move IEEE80211_TX_CTL_PS_RESPONSE

2014-12-12 Thread Johannes Berg
On Wed, 2014-12-10 at 21:26 +0530, Sujith Manoharan wrote: From: Sujith Manoharan c_man...@qca.qualcomm.com Move IEEE80211_TX_CTL_PS_RESPONSE to info-control.flags since this is used only in the TX path (by ath9k). This frees up a bit which can be used for other purposes. Applied. johannes

Re: [PATCH 2/4] mac80211: Fix accounting of multicast frames

2014-12-12 Thread Johannes Berg
On Wed, 2014-12-10 at 21:26 +0530, Sujith Manoharan wrote: From: Sujith Manoharan c_man...@qca.qualcomm.com Since multicast frames are marked as no-ack, using IEEE80211_TX_STAT_ACK to check if they have been successfully transmitted by the driver is incorrect since a driver can choose to

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Dan Carpenter
On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote: On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16

Re: [PATCH] iw: print phy TDLS ch-switch support

2014-12-12 Thread Johannes Berg
Applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH iw v3 0/3] add WoWLAN net-detect trigger

2014-12-12 Thread Johannes Berg
On Fri, 2014-11-28 at 23:05 +0200, Luca Coelho wrote: From: Luciano Coelho luciano.coe...@intel.com A third spin. This one includes parsing of some configuration information related to net-detect (patch 3/3). I haven't send the nl80211 counterpart yet, but it's backwards compatible with

Re: [PATCH v2 4/4] iw: support multiple regdom print

2014-12-12 Thread Johannes Berg
On Mon, 2014-12-01 at 17:53 +0200, Arik Nemtsov wrote: When a phy is given, print only its regdomain. Otherwise, use the newly implement dump functionality to print all regdomains in the system. This breaks on existing kernels. johannes -- To unsubscribe from this list: send the line

Re: New WARNING from mac80211

2014-12-12 Thread Johannes Berg
On Thu, 2014-11-06 at 21:20 +0530, Sujith Manoharan wrote: Sujith Manoharan wrote: I think this is the race described here: https://patchwork.kernel.org/patch/5095061/ I haven't tried any workaround or fix yet, but it looks like this race can be hit fairly often.

Re: [PATCH] iw: Fix calculation of maximum supported 802.11n data rate

2014-12-12 Thread Henning Rogge
Hi, the bug was caught by Coverity (I use parts of the iw code in a different project to talk to nl802.11). Maybe it would be interesting to register the iw project with Coverity. Henning On Fri, Dec 12, 2014 at 12:07 PM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2014-12-10 at

Re: [PATCH] mac80211: add an intermediate software queue implementation

2014-12-12 Thread Johannes Berg
On Wed, 2014-11-19 at 00:14 +0100, Felix Fietkau wrote: + struct txq_info *txq; + atomic_t txq_len[IEEE80211_NUM_ACS]; I think you should consider renaming the latter to txqs_len or so - it doesn't just cover one txq as is be implied by the name now. Otherwise the skb_queue_head also

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Johannes Berg
On Fri, 2014-12-12 at 12:35 +0100, Krzysztof Konopko wrote: I'm _far_ from being a wireless expert but doesn't data coming out of the wire/air have the endianess defined explicitly? And both `AC_param` and `ADDBA_request` come out of air? In general, data in 802.11 frames is little endian.

Re: [PATCH] mac80211: add an intermediate software queue implementation

2014-12-12 Thread Felix Fietkau
On 2014-12-12 14:21, Johannes Berg wrote: On Wed, 2014-11-19 at 00:14 +0100, Felix Fietkau wrote: +struct txq_info *txq; +atomic_t txq_len[IEEE80211_NUM_ACS]; I think you should consider renaming the latter to txqs_len or so - it doesn't just cover one txq as is be implied by the

Re: [PATCH 1/1] wireless: mac80211: Avoid using uninitialized stack data

2014-12-12 Thread Jes Sorensen
Johannes Berg johan...@sipsolutions.net writes: On Wed, 2014-12-10 at 14:14 -0500, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Avoid case where we would access uninitialized stack data if a driver advertises HT support without 40MHz channel support. I've fixed

Re: [PATCHv2] mac80211: enable TPC through mac80211 stack

2014-12-12 Thread Lorenzo Bianconi
On Mon, 2014-12-01 at 11:30 +0100, Lorenzo Bianconi wrote: Enable/disable per packet Transmit Power Control (TPC) in lower drivers according to TX power settings configured by the user. In particular TPC is enabled if value passed in enum nl80211_tx_power_setting is NL80211_TX_POWER_AUTOMATIC

Re: [PATCH] mac80211: add an intermediate software queue implementation

2014-12-12 Thread Felix Fietkau
On 2014-12-12 15:01, Johannes Berg wrote: On Fri, 2014-12-12 at 14:40 +0100, Felix Fietkau wrote: Then again what even sets vif-txq? Shouldn't those be per-AC? Do you really want to mix 'normal' and txq-TX? Are we even using multiple ACs for packets that don't belong to a particular

NetDev 0.1 Attendee clarification [was: Netdev 0.1 Call for Proposals]

2014-12-12 Thread Richard Guy Briggs
On 14/12/02, Richard Guy Briggs wrote: Netdev 0.1 Call for Proposals - Netdev 0.1 (year 0, conference 1) is a community-driven conference geared towards Linux netheads. Linux kernel networking and user space utilization of the interfaces to the Linux kernel

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Larry Finger
On 12/12/2014 06:52 AM, Dan Carpenter wrote: On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote: On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was reported by sparse:

Re: [PATCH v4] mac80211: keep sending peer candidate events while in listen state

2014-12-12 Thread Bob Copeland (m...@bobcopeland.com)
On Fri, Dec 12, 2014 at 12:41:30PM +0100, Johannes Berg wrote: On Fri, 2014-11-21 at 11:24 +, Nishikawa, Kenzoh wrote: Instead of sending peer candidate events just once, send them as long as the peer remains in the LISTEN state in the peering state machine, when userspace is

pull request: bluetooth 2014-12-12

2014-12-12 Thread Johan Hedberg
Hi John, These fixes are intended for 3.19, note that the tree to pull from is bluetooth-next (unlike the subject implies). I'd have normally done a pull request from bluetooth.git, but since these fixes for 3.19 is all we have so far I thought it's simpler if you just pull from our -next tree.

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Jes Sorensen
Larry Finger larry.fin...@lwfinger.net writes: On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: I was hunting particularly for inconsistencies with `sparse` and came across this one. But I dug a bit further and I wonder why the driver is not using standard stuff like the one in

[PATCH] rsi: fix memory leak in rsi_load_ta_instructions()

2014-12-12 Thread Alexey Khoroshilov
Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked. But duplication of firmware data here is useless, so the patch removes kmemdup() at all. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru ---

Re: [PATCH] cfg80211: avoid intersection when applying custom reg

2014-12-12 Thread Luis R. Rodriguez
On Sun, Dec 07, 2014 at 06:03:45PM +0200, Arik Nemtsov wrote: The custom-reg handling function can currently only add flags to a given channel. This results in stale flags being left applied. In some cases a channel was disabled and even the orig_flags were changed to reflect this.

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Krzysztof Konopko
On 12/12/14 17:43, Larry Finger wrote: On 12/12/2014 06:52 AM, Dan Carpenter wrote: On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote: On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Krzysztof Konopko
On 12/12/14 18:12, Jes Sorensen wrote: Krzysztof Konopko k...@konagma.com writes: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16 rtw_wlan_util.c:1544:29:

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Krzysztof Konopko
On 12/12/14 18:35, Larry Finger wrote: On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: On 12/12/14 00:53, Larry Finger wrote: In particular, did you test on big-endian hardware after you made this change? Nope. I don't have any big-endian hardware. I don't even have the wireless card

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Krzysztof Konopko
On 12/12/14 19:52, Jes Sorensen wrote: Larry Finger larry.fin...@lwfinger.net writes: On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: I was hunting particularly for inconsistencies with `sparse` and came across this one. But I dug a bit further and I wonder why the driver is not using

[PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Krzysztof Konopko
Some struct fields in wifi.h are meant to be __le16 but were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16 rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 rtw_wlan_util.c:1546:25: warning: cast to restricted

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Larry Finger
On 12/12/2014 04:50 PM, Krzysztof Konopko wrote: On 12/12/14 18:35, Larry Finger wrote: On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: On 12/12/14 00:53, Larry Finger wrote: In particular, did you test on big-endian hardware after you made this change? Nope. I don't have any big-endian

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

2014-12-12 Thread Joe Perches
On Fri, 2014-12-12 at 23:58 +0100, Krzysztof Konopko wrote: This patch changes the types of the struct fields involved to be little-endian which is what is received over the air and consistent with relevant structs in include/linux/ieee80211.h. [] diff --git