Re: [PATCH RESEND] ath10k: Fix potential Rx ring corruption

2015-01-09 Thread Ben Greear
I added this to my tree (and a bunch more debug stuff to track CE transport-ids), and I've done about 4500 station reconnects over the last 2 hours and no tx-credits hang issue so far. Could be my debugging code or that I'm getting lucky, but I'm hopeful that your patch actually fixed the problem

Re: [PATCH v2] ath10k: fix build error when hwmon is off

2015-01-09 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: kbuild reported a linking error: ERROR: devm_hwmon_device_register_with_groups [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined! Fix it by returning early and letting the compiler to optimise out the function call. Signed-off-by:

Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries

2015-01-09 Thread Arend van Spriel
On 01/09/15 01:34, Sujith Manoharan wrote: Arend van Spriel wrote: So the content of the modified debugfs files looks sane? Yep, as sane as the code populating the debug data. :-) :-D Thanks, Arend Sujith -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the

Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions

2015-01-09 Thread Rickard Strandqvist
2015-01-07 9:58 GMT+01:00 Arend van Spriel ar...@broadcom.com: On 01/07/15 07:29, Julia Lawall wrote: On Wed, 7 Jan 2015, Rickard Strandqvist wrote: 2015-01-05 12:06 GMT+01:00 Arend van Sprielar...@broadcom.com: On 01/05/15 11:49, Kalle Valo wrote: Rickard

Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-09 Thread Arend van Spriel
On 01/09/15 17:54, Simon Wunderlich wrote: Performing spectral scans on 5 GHz channels may result in PHY errors sent by the hardware, even if DFS support is not enabled in the driver (e.g. channel scanning or passive monitoring). In that case channels may falsely get marked as 'unusable'. To fix

[PATCH 0/8] wcn36xx locking and a-mpdu fixes

2015-01-09 Thread Bob Copeland
Hello, These patches have been merged into the wcn36xx github tree but have been collecting dust for some time. I pinged Eugene (CCed) who said I could just go ahead and send them upstream. Rebased and re-tested on an Android target (and newer checkpatch warnings removed). At some point I can

[PATCH 4/8] wcn36xx: don't process 'valid' descriptors

2015-01-09 Thread Bob Copeland
The DMA engine will reset the valid bit after a descriptor is complete; any with the valid bit still set may still be in use by the hardware, so check that before freeing the descriptor. Signed-off-by: Bob Copeland m...@bobcopeland.com --- drivers/net/wireless/ath/wcn36xx/dxe.c |2 ++ 1 file

[PATCH 5/8] wcn36xx: initialize skb_lock

2015-01-09 Thread Bob Copeland
ctl-skb_lock is never initialized, a fact caught by lockdep. Signed-off-by: Bob Copeland m...@bobcopeland.com --- drivers/net/wireless/ath/wcn36xx/dxe.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c index

[PATCH 8/8] wcn36xx: initiate TX BA sessions

2015-01-09 Thread Bob Copeland
Currently, wcn36xx only asks for a TX BA session if it has already established one for RX. Thus, two wcn36xx devices cannot do a-mpdu between themselves since they both wait for the other to go first. Fix this by starting a BA session after a few QoS data frames have been sent to a STA.

[PATCH 1/8] wcn36xx: initialize device defaults on start

2015-01-09 Thread Bob Copeland
Set up default configuration for the device when we call start. The defaults come from dumps from the prima driver for the same hardware. This fixes transmit A-MPDU; previously only one MPDU would be sent per A-MPDU due to missing MAX_MPDUS_IN_AMPDU setting. Signed-off-by: Bob Copeland

[PATCH 3/8] wcn36xx: let device generate qos seq numbers

2015-01-09 Thread Bob Copeland
wcn36xx currently sends an incorrect sequence number into the BA session setup firmware command: it should be saving or updating the ssn in the TX_START ampdu_action callback instead of waiting until TX_OPERATIONAL. However, we can sidestep the issue by letting the hardware generate the sequence

[PATCH 2/8] wcn36xx: use !! when assigning int as a boolean

2015-01-09 Thread Bob Copeland
bd-tx_comp is a single bit in a bitfield, so assigning info-flags IEEE80211_TX_CTL_REQ_TX_STATUS only happens to work because TX_STATUS is defined to BIT(0); if it were any other bit this assignment would fail. Signed-off-by: Bob Copeland m...@bobcopeland.com ---

[PATCH 7/8] wcn36xx: move set_tx_pdu inside set_tx_data/mgmt

2015-01-09 Thread Bob Copeland
The pdu is part of the buffer descriptor, so it makes sense that one function would fill both. Also, passing the whole skb instead of just the header pointer to the set_tx_data function paves the way for using its fields for ampdu setup inside set_tx_data(). Signed-off-by: Bob Copeland

[PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-09 Thread Simon Wunderlich
Performing spectral scans on 5 GHz channels may result in PHY errors sent by the hardware, even if DFS support is not enabled in the driver (e.g. channel scanning or passive monitoring). In that case channels may falsely get marked as 'unusable'. To fix that, only process radar PHY errors when

Re: [PATCH RESEND 2/2] wlcore: align member-assigns in a structure-copy block

2015-01-09 Thread Kalle Valo
Giel van Schijndel m...@mortis.eu writes: This highlights the differences (e.g. the bug fixed in the previous commit). Signed-off-by: Giel van Schijndel m...@mortis.eu --- drivers/net/wireless/ti/wlcore/acx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

pull-request: wireless-drivers 2015-01-09

2015-01-09 Thread Kalle Valo
Hi Dave, here are few more fixes to 3.19. Please let me know if there are any problems. Kalle The following changes since commit 7ce67a38f799d1fb332f672b117efbadedaa5352: net: ethernet: cpsw: fix hangs with interrupts (2015-01-04 22:18:34 -0500) are available in the git repository at:

Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions

2015-01-09 Thread Rickard Strandqvist
Hi All Yes I use sed as Julian said. I have it as part of my git send-email script, until a few week ago, it was enough that I removed the drivers/ and changed all / to : I have now been expanded my sed pipe a lot (tell me if anyone is interested). But a real script to do this would have been

[PATCH RESEND] ath10k: Fix potential Rx ring corruption

2015-01-09 Thread Vasanthakumar Thiagarajan
When replenishing Rx buffers driver updates the address of the buffer and the index of rx buffer in rx ring to the firmware. Change in order by CPU can cause rx ring corruption. Add memory barrier before updating rx buffer index to guarantee the order. This could fix some instances of rx ring

[PATCH 2/2] nfc: NXP PN544 ACPI support

2015-01-09 Thread Robert Dolca
Device id: NXP5440 Pin mapping: - 0 IRQ pin - 1 enable pin - 2 firmware pin Signed-off-by: Robert Dolca robert.do...@intel.com --- drivers/nfc/Kconfig | 1 + drivers/nfc/pn544/i2c.c | 115 ++-- net/nfc/core.c | 1 + 3 files changed,

[PATCH] nl80211: send netdetect configuration info in NL80211_CMD_GET_WOWLAN

2015-01-09 Thread Luca Coelho
From: Luciano Coelho luciano.coe...@intel.com Send the netdetect configuration information in the response to NL8021_CMD_GET_WOWLAN commands. This includes the scan interval, SSIDs to match and frequencies to scan. Additionally, add the NL80211_WOWLAN_TRIG_NET_DETECT with

Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

2015-01-09 Thread Rafał Miłecki
On 9 January 2015 at 15:03, Kalle Valo kv...@codeaurora.org wrote: Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 19:39, Kalle Valo kv...@codeaurora.org wrote: Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 18:55, Kalle Valo kv...@codeaurora.org wrote: Oscar Forner

[PATCH] ath10k: Fix potential Rx ring corruption

2015-01-09 Thread Vasanthakumar Thiagarajan
When replenishing Rx buffers driver updates the address of the buffer and the index of rx buffer in rx ring to the firmware. Change in order by CPU can cause rx ring corruption. Add memory barrier before updating rx buffer index to guarantee the order. This could fix some instances of rx ring

Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

2015-01-09 Thread Kalle Valo
Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 19:39, Kalle Valo kv...@codeaurora.org wrote: Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 18:55, Kalle Valo kv...@codeaurora.org wrote: Oscar Forner Martinez oscar.forner.marti...@gmail.com writes: Two lines with

[PATCH 2/2] mac80211: fix handling TIM IE when stations disconnect

2015-01-09 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com When a station disconnects with frames still pending, we clear the TIM bit, but too late - it's only cleared when the station is already removed from the driver, and thus the driver can get confused (and hwsim will loudly complain.) Fix this by

[PATCH 1/2] mac80211_hwsim: fix PS debugfs file locking

2015-01-09 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com The functions called within the iterators must be called with tasklets disabled, so use atomic iteration like the rest of the code and disable tasklets around the whole operation. Signed-off-by: Johannes Berg johannes.b...@intel.com ---

[RFC 7/8] ath10k: implement tx pause wmi event

2015-01-09 Thread Michal Kazior
New wmi-tlv firmware can ask host to pause certain tx queues. This is used to improve multi-channel performance. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 12 + drivers/net/wireless/ath/ath10k/wmi-tlv.c | 86

[RFC 5/8] ath10k: protect ar-arvifs linking with data_lock

2015-01-09 Thread Michal Kazior
This will make it possible to iterate over interface list while in an atomic context, i.e. tasklet. Caller should still be careful with accessing arvif structures though. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 8 1 file changed,

[RFC 3/8] ath10k: implement chanctx API

2015-01-09 Thread Michal Kazior
The chanctx API will allow ath10k to support multi-channel operation. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/core.c | 1 + drivers/net/wireless/ath/ath10k/core.h | 8 + drivers/net/wireless/ath/ath10k/htt_rx.c | 80 -

[RFC 8/8] ath10k: add proper wmi-tlv combinations

2015-01-09 Thread Michal Kazior
This adds proper wmi-tlv combinations for both single- and multi-channel operation. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 81 ++- 1 file changed, 80 insertions(+), 1 deletion(-) diff --git

[RFC 2/8] ath10k: allow empty ssid vdev config

2015-01-09 Thread Michal Kazior
It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior michal.kaz...@tieto.com ---

[RFC 4/8] ath10k: implement adaptive qcs command

2015-01-09 Thread Michal Kazior
This command is used in latest firmware revisions to control multi-channel scheduler. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/wmi-ops.h | 16 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 30 ++

[RFC 6/8] ath10k: rework tx queue locking

2015-01-09 Thread Michal Kazior
Tx queue locking was very simple until now. Future multi-channel support will require a more flexible and fine grained control. This introduces a per-hw and per-vif (each with a bitmask of reasons) tx queue locking. Signed-off-by: Michal Kazior michal.kaz...@tieto.com ---

[RFC 1/8] ath10k: defer AP self-peer removal wait

2015-01-09 Thread Michal Kazior
Some firmware revisions don't notify host about self-bss-peer removal until after associated vdev is deleted. This fixes AP teardown slowdowns and prevents warnings: ath10k_pci :00:05.0: failed to remove peer for AP vdev 0: -110 ath10k_pci :00:05.0: removing stale peer

[RFC 0/8] ath10k: add multi-channel support

2015-01-09 Thread Michal Kazior
New wmi-tlv firmware and new hardware will support multi-channel operation. This prepares the driver by implementing chanctx, improves tx queue locking and introduces initial interface combinations. I'm posting this as an RFC first because I'd like to get some early feedback (if possible) while

Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

2015-01-09 Thread Kalle Valo
Rafał Miłecki zaj...@gmail.com writes: Rafal, is this the patch I should apply: https://patchwork.kernel.org/patch/5545021/ Please confirm. That's correct. Thanks. I marked it as 'Under Review' in patchwork and will apply in my next commit round. -- Kalle Valo -- To unsubscribe from