RE: [Query] mwifiex: few observations to reduce number of endian conversions

Hi Prasun, > From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Friday, June 17, 2016 6:42 PM > To: Amitkumar Karwar; Nishant Sarmukadam > Cc: Linux Kernel; Linux Next; WiFi Mailing List; Johannes Berg > Subject: [Query] mwifiex: few observations to reduce number of endian > conversions

Re: [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled

On 06/21/2016 02:09 AM, Jacek Anaszewski wrote: > Hi Andrew, > > This patch doesn't apply, please rebase onto recent LED tree. > > On 06/21/2016 12:13 AM, Andrew F. Davis wrote: >> Some systems use 'gpio_led_register_device' to make an in-memory copy of >> their LED device table so the original

Re: [PATCH 0/3] *** Mesh Path Selection Metric Calculation ***

On Mon, Jun 20, 2016 at 04:00:19PM +0300, Maxim Altshul wrote: > 2. Implements the opcode and the mechanism that reports the rates > in TI driver. Does this mean TI driver will support mesh at some point? -- Bob Copeland %% http://bobcopeland.com/ -- To unsubscribe from this list: send the line

[PATCHv3] wlcore: spi: add wl18xx support

Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the

[PATCH] mwifiex: disable MSIx interrupt for 8997 chipset

From: Shengzhen Li Sometimes MSIx interrupts are received out of order on multi-core system. This creates a problem when there is a race between data packet and SLEEP event from firmware. We will disable MSIx interrupt mode to solve the problem and go with MSI mode.

Re: [Query] mwifiex: few observations to reduce number of endian conversions

Hi Amitkumar, On Tue, Jun 21, 2016 at 3:47 PM, Amitkumar Karwar wrote: > I agree with your observations. We'll prepare a cleanup patch to address this. > > Regards, > Amitkumar I have already made some changes. I will send you a patch for this. -- Thanks, Prasun -- To

Re: NL80211_ATTR_PAD question

On Mon, 2016-06-13 at 21:25 +0200, Arend van Spriel wrote: > > On 10-06-16 23:08, Johannes Berg wrote: > > On Fri, 2016-06-10 at 12:47 -0700, Ben Greear wrote: > > > I see this was added sometime recently:  NL80211_ATTR_PAD > > > > > > If another enum member is added, should it replace the PAD

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

On Fri, 2016-06-10 at 11:43 -0700, Ben Greear wrote: > On 03/15/2016 01:20 PM, Johannes Berg wrote: > > On Tue, 2016-03-15 at 09:10 -0700, Ben Greear wrote: > > > > > > The logic I wrote is basically exactly this.  It uses the > > > configured > > > rates to specify which of the hardware's rates

Re: [PATCH] iw: support and enable separate build dir

On Fri, 2016-06-10 at 13:58 +0300, Maxin B. John wrote: > Hi Johannes, > > On Thu, Jun 9, 2016 at 11:25 AM, Johannes Berg > wrote: > > On Wed, 2016-06-01 at 11:40 +0300, maxin.j...@gmail.com wrote: > > > From: "Maxin B. John" > > > > > > Support

[PATCH 2/2] ath6kl: replace semaphore with mutex

It replaces struct semaphore sem with struct mutex mutex Signed-off-by: Chaehyun Lim --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 30 +++--- drivers/net/wireless/ath/ath6kl/core.c | 2 +- drivers/net/wireless/ath/ath6kl/core.h | 2 +-

Re: [PATCH 2/2] ath6kl: replace semaphore with mutex

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc4 next-20160621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chaehyun-Lim/ath10k-remove-unused-linux-semaphore

Re: [PATCH] ath9k: Support 4.9Ghz channels on AR9580 adapter.

Hi Jouni, On Tue, Jun 21, 2016 at 7:41 PM, Jouni Malinen wrote: > On Tue, Jun 21, 2016 at 11:02:20AM +1000, Julian Calaby wrote: >> I've only done this work as I hate to see people's efforts go to >> waste and I feel that there's enough roadblocks in the way of >> actually using this

pull-request: wireless-drivers 2016-06-21

Hi Dave, here is a pull request for 4.7, really small fixes this time, some of them fix important regressions. Please let me know if there are any problems. Kalle The following changes since commit 182fd9eecb287e696c82b30d06c6150d80a49c5b: MAINTAINERS: Add file patterns for wireless device

pull-request: wireless-drivers-next 2016-06-21

Hi Dave, I hope it's ok to send two pull requests the same day, both for net and net-next? This is targeted to 4.8 so it is for net-next. Even though is this the first pull request for 4.8 we actually remove more code than add, thanks to Guenter Roeck's on removing unused "phy_a" support from

Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

On Mon, 2016-06-13 at 23:21 +0200, Pavel Machek wrote: >  > (Actually, "::wifi" is super confusing, I'd expect that to be a led > that blinks when wifi is active.) Agree with that, yeah, that'd be confusing. > Well... "airplane" is quite confusing. I'd we use "rfkill" for > disabling radios, and

Re: [PATCH] ath9k: Support 4.9Ghz channels on AR9580 adapter.

On Tue, Jun 21, 2016 at 11:02:20AM +1000, Julian Calaby wrote: > I've only done this work as I hate to see people's efforts go to > waste and I feel that there's enough roadblocks in the way of > actually using this functionality that casual idiots won't be able > to. Are these really ready to go

[PATCH 1/2] ath10k: remove unused

is not used anymore, so just remove it. Signed-off-by: Chaehyun Lim --- drivers/net/wireless/ath/ath10k/htc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h index cc82718..0c55cd9 100644

Re: [PATCH 3/3] mac80211: mesh: Add support for HW RC implementation

> - if (sta->mesh->fail_avg >= 100) > - return MAX_METRIC; > + /* try to get rate based on HW RC algorithm */ > + rate = drv_get_expected_throughput(local, >sta); This doesn't look correct, since you should use the rate control op if available, to get data from rate

Re: [PATCH] iw: support and enable separate build dir

Hi, On Tue, Jun 21, 2016 at 12:41 PM, Johannes Berg wrote: > On Fri, 2016-06-10 at 13:58 +0300, Maxin B. John wrote: >> Hi Johannes, >> >> On Thu, Jun 9, 2016 at 11:25 AM, Johannes Berg >> wrote: >> > On Wed, 2016-06-01 at 11:40 +0300,

Re: [PATCH] ath9k: Support 4.9Ghz channels on AR9580 adapter.

On 06/21/2016 02:41 AM, Jouni Malinen wrote: On Tue, Jun 21, 2016 at 11:02:20AM +1000, Julian Calaby wrote: I've only done this work as I hate to see people's efforts go to waste and I feel that there's enough roadblocks in the way of actually using this functionality that casual idiots won't

Re: [ath9k-devel] [PATCH] ath9k: Support 4.9Ghz channels on AR9580 adapter.

On Tue, Jun 21, 2016 at 2:41 AM, Jouni Malinen wrote: > On Tue, Jun 21, 2016 at 11:02:20AM +1000, Julian Calaby wrote: >> I've only done this work as I hate to see people's efforts go to >> waste and I feel that there's enough roadblocks in the way of >> actually using this

Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

Very brief review: > +/* */ That seems slightly odd. > + /* bus private data */ > + char bus_priv[0]; You might want to - for future proofing - add some aligned() attribute. Otherwise, if struct mutex doesn't have a size that's a multiple of the pointer size, fields in here will not be

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

On 06/21/2016 02:40 AM, Johannes Berg wrote: On Fri, 2016-06-10 at 11:43 -0700, Ben Greear wrote: On 03/15/2016 01:20 PM, Johannes Berg wrote: On Tue, 2016-03-15 at 09:10 -0700, Ben Greear wrote: The logic I wrote is basically exactly this. It uses the configured rates to specify which of

RE: [PATCH 0/3] *** Mesh Path Selection Metric Calculation ***

Yes, TI driver have added support in our latest release (TI git). http://software-dl.ti.com/ecs/WiLink8/R8_7/exports/release_notes_R8_7.html Patches will be shared with mainline in the near future. Thanks, Yaniv Machani -Original Message- From: Bob Copeland [mailto:m...@bobcopeland.com]

[PATCH] mwifiex: Reduce endian conversion for REG Host Commands

For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS, HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are saved to driver. So, "leX_to_cpu" conversion is required too many times afterwards in driver. This patch reduces the endian: conversion without saving

Re: Bug with: ath10k: enable parsing per station rx duration for 10.4?

On 06/20/2016 10:18 PM, Mohammed Shafi Shajakhan wrote: Hi Ben, thanks for reporting ... On Mon, Jun 20, 2016 at 04:06:52PM -0700, Ben Greear wrote: I'm working on bringing up my hacked up version of 4.7 ath10k and 10.4 firmware, and I think I may have found a regression. [shafi] let me

Re: [PATCH 1/2] ath10k: remove unused

Hello. On 6/21/2016 2:45 PM, Chaehyun Lim wrote: is not used anymore, so just remove it. s/it/#include/? Signed-off-by: Chaehyun Lim [...] diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h index cc82718..0c55cd9

Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands

Hi, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.7-rc4 next-20160621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Prasun-Maiti/mwifiex-Reduce

Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands

Hi, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.7-rc4 next-20160621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Prasun-Maiti/mwifiex-Reduce

Re: Bug with: ath10k: enable parsing per station rx duration for 10.4?

On Tue, Jun 21, 2016 at 07:10:28AM -0700, Ben Greear wrote: > > > On 06/20/2016 10:18 PM, Mohammed Shafi Shajakhan wrote: > >Hi Ben, > > > >thanks for reporting ... > > > >On Mon, Jun 20, 2016 at 04:06:52PM -0700, Ben Greear wrote: > >>I'm working on bringing up my hacked up version of 4.7

Re: [PATCH v2 2/2] staging: wilc1000: Replace kthread with workqueue for host interface

On Monday, June 20, 2016 3:40:19 PM CEST Binoy Jayan wrote: > Deconstruct the kthread / message_queue logic, replacing it with > create_singlethread_workqueue() / queue_work() setup, by adding a > 'struct work_struct' to 'struct host_if_msg'. The current kthread > hostIFthread() is converted to a

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

Hello Kalle, On 06/10/2016 03:54 PM, Kalle Valo wrote: > Javier Martinez Canillas writes: > >>> This patch (2/3) is only for code rearrangement and adds an >>> unnecessary wrapper function. We can simply drop the patch. >> >> Agreed. >> >> Kalle, >> >> Patch 3/3 applies

[PATCH v2] mac80211: Encrypt "Group addressed privacy" action frames

Previously, the action frames to group address was not encrypted. But [1] "Table 8-38 Category values" indicates "Mesh" and "Multihop" category action frames should be encrypted (Group addressed privacy == yes). And the encyption key should be MGTK ([1] 10.13 Group addressed robust management

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

On 21 June 2016 at 18:58, Ismael Luceno wrote: > On 21/Jun/2016 07:45, Rafał Miłecki wrote: >> On 21 June 2016 at 02:18, Ismael Luceno wrote: >> > @@ -56,6 +57,8 @@ >> > >> > /* USB Device IDs */ >> > #define BRCM_USB_43143_DEVICE_ID 0xbd1e >> >

Re: [PATCH v2] mac80211: Encrypt "Group addressed privacy" action frames

On Tue, Jun 21, 2016 at 03:23:39PM +0900, Masashi Honma wrote: > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h > +static inline bool ieee80211_is_group_privacy_action(struct ieee80211_hdr > *hdr) This is somewhat problematic since no indication of the frame length is passed

Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands

Hi, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.7-rc4 next-20160621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Prasun-Maiti/mwifiex-Reduce

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

On 21/Jun/2016 07:45, Rafał Miłecki wrote: > On 21 June 2016 at 02:18, Ismael Luceno wrote: > > @@ -56,6 +57,8 @@ > > > > /* USB Device IDs */ > > #define BRCM_USB_43143_DEVICE_ID 0xbd1e > > +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \ > > +

Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames

On Tue, Jun 21, 2016 at 03:16:22PM +0900, Masashi Honma wrote: > On 2016年06月21日 06:25, Jouni Malinen wrote: > > What about RX side? > > Previously, MGTK and IGTK was identical key. > Now new wpa_supplicant can provide correct IGTK. > I have tested with new IGTK, RX side can work without >

Re: Troubleshooting mwl8k driver issue

On Mon, Jun 20, 2016 at 07:36:30PM -0500, David Gilman wrote: > > Nothing in here seems particularly bad. So whatever the problem is, > > I don't think it can be diagnosed from these messages alone. > > > > I went back to the email thread, and it seems that the problem is that > > you're trying

Re: [PATCH] mac80211: Fix mesh estab_plinks counting in STA removal case

On Tue, Jun 21, 2016 at 09:09:10PM +0200, Johannes Berg wrote: > > >    */ > > - changed = mesh_accept_plinks_update(sdata); > > + if (sdata->u.mesh.user_mpm && > > + sta->mesh->plink_state == NL80211_PLINK_ESTAB) > > + changed |= mesh_plink_dec_estab_count(sdata); > > +

Re: [PATCH] mac80211: Fix mesh estab_plinks counting in STA removal case

On Tue, Jun 21, 2016 at 06:26:02PM -0400, Bob Copeland wrote: > Looks further buggy, so perhaps this untested patch would work, i.e. (still) > @@ -370,13 +372,19 @@ u32 mesh_plink_deactivate(struct sta_info *sta) > >

Re: [PATCH] mac80211: Fix mesh estab_plinks counting in STA removal case

>    */ > - changed = mesh_accept_plinks_update(sdata); > + if (sdata->u.mesh.user_mpm && > + sta->mesh->plink_state == NL80211_PLINK_ESTAB) > + changed |= mesh_plink_dec_estab_count(sdata); > + changed |= mesh_accept_plinks_update(sdata); >   if

Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames

> We actually cover (2) for some cases by "accident" since > ieee80211_rx_h_decrypt() assigns rx->key to rx->sta->gtk[i] if one is > available. I'm not completely sure this is correct since it applies > to management frame as well, but that's the way commit >

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

On 21-06-16 02:18, Ismael Luceno wrote: > Signed-off-by: Ismael Luceno A bit more description would be nice. I am actually wondering why you would be adding this. If I am not mistaken the AE1200 can not be handled by brcmfmac. Otherwise I am interested in a kernel log showing

[PATCH V2 2/2] ath6kl: replace semaphore with mutex

It replaces struct semaphore sem with struct mutex mutex Reported-by: kbuild test robot Signed-off-by: Chaehyun Lim --- V2: fix build failure reported by kbuild test robot drivers/net/wireless/ath/ath6kl/cfg80211.c | 30 +++---

Re: [PATCHv3] wlcore: spi: add wl18xx support

On Tue, Jun 21, 2016 at 12:02:06PM +, Reizer, Eyal wrote: > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is high. > - Use

Re: [PATCH 0/3] *** Mesh Path Selection Metric Calculation ***

Peter Oh writes: > where is 2/3 ? You can find the patches from patchwork: https://patchwork.kernel.org/patch/9187367/ https://patchwork.kernel.org/patch/9187361/ https://patchwork.kernel.org/patch/9187355/ -- Kalle Valo -- To unsubscribe from this list: send the line

Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames

On 2016年06月21日 06:25, Jouni Malinen wrote: Do we really want that? Sorry, I mis-understood your previous massage. I have thought you required backward compatibility. Ok, I will remove backward compatibility code. > What about RX side? Previously, MGTK and IGTK was identical key. Now new

Re: [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled

Hi Andrew, This patch doesn't apply, please rebase onto recent LED tree. On 06/21/2016 12:13 AM, Andrew F. Davis wrote: Some systems use 'gpio_led_register_device' to make an in-memory copy of their LED device table so the original can be removed as .init.rodata. When the LED subsystem is not