[PATCH 2/5] rsi: Added rx filter frame

2016-11-14 Thread Prameela Rani Garnepudi
Filtering the rx frames in firmware after connection in station mode avoids the overhead of processing un-necessary frames. Hence rx filter frame is added which can be configured to device at suitable times. Signed-off-by: Prameela Rani Garnepudi ---

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

2016-11-14 Thread Arend Van Spriel
On 28-10-2016 22:41, Arend Van Spriel wrote: > On 28-10-2016 18:15, Gianfranco Costamagna wrote: >> (resending from my debian.org mail address, to avoid spam filtering) >> >> Hi Broadcom developers and linux wireless list. >> >> We found a possible issue in the cfg80211 implementation of the

[PATCH 5/5] rsi: Added support for 802.11d

2016-11-14 Thread Prameela Rani Garnepudi
Transmit power value in a channel are determined based on the dfs region in firmware. To support regulatory rules dfs region should be configured to device during set channel request. Also antenna gain values are taken from the mac80211 channel parameters. Signed-off-by: Prameela Rani Garnepudi

[PATCH v3 1/3] mwifiex: Allow mwifiex early access to device structure

2016-11-14 Thread Amitkumar Karwar
From: Rajat Jain Today all the interface drivers (usb/pcie/sdio) assign the adapter->dev in the register_dev() callback, although they have this piece of info well before hand. This patch makes the device structure available for mwifiex right at the beginning, so that it can

[PATCH v3 3/3] mwifiex: Enable WoWLAN for both sdio and pcie

2016-11-14 Thread Amitkumar Karwar
From: Rajat Jain Commit ce4f6f0c353b ("mwifiex: add platform specific wakeup interrupt support") added WoWLAN feature only for sdio. This patch moves that code to the common module so that all the interface drivers can use it for free. It enables pcie and sdio for its use

[PATCH v3 2/3] mwifiex: Introduce mwifiex_probe_of() to parse common properties

2016-11-14 Thread Amitkumar Karwar
From: Rajat Jain Introduce function mwifiex_probe_of() to parse common properties. Interface drivers get to decide whether or not the device tree node was a valid one (depending on the compatible property), Lets fill "adapter->dt_node" in mwifiex_add_card(). The function

RE: [PATCH v2 2/3] mwifiex: Introduce mwifiex_probe_of() to parse common properties

2016-11-14 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Saturday, November 12, 2016 2:20 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com; dmitry.torok...@gmail.com > Subject: Re: [PATCH v2 2/3] mwifiex: Introduce

RE: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-11-14 Thread Stam, Michel [FINT]
Dear List, After 2 weeks of Ferry Huberts and me trying to resolve this issue, this is the result: The problem can be mitigated by resetting the chip and immediately replumbing the encryption keys. I wrote a patch for this, which unfortunately this seems to suffer from some locking issues,

[PATCH] ath10k: fix null deref on wmi-tlv when trying spectral scan

2016-11-14 Thread Michal Kazior
WMI ops wrappers did not properly check for null function pointers for spectral scan. This caused null dereference crash with WMI-TLV based firmware which doesn't implement spectral scan. The crash could be triggered with: ip link set dev wlan0 up echo background >

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

2016-11-14 Thread Jes Sorensen
Barry Day writes: > The rtl8192e and rtl8723 fail to reconnect to an AP after being > disconnected. Ths patch fixes that without affecting the rtl8192cu. > I don't have a rtl8723 to test but it has been tested on a rtl8192eu. > After going through the orginal realtek code for

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

2016-11-14 Thread Stanislaw Gruszka
On Wed, Nov 02, 2016 at 03:11:00PM +0100, Stanislaw Gruszka wrote: > We can calculate BA window size (max number of pending frames not > yet block acked) of remote station using Maximum A-MPDU length factor > for that station. > > Signed-off-by: Stanislaw Gruszka Kalle,

Re: [RFC] change mac80211_hwsim tx_rates to ieee80211_tx_rate

2016-11-14 Thread Benjamin Beichler
> I agree with that, but there exist also other code in hwsim, which is >> tightly coupled with the mac80211 API, as e.g., the usage of >> IEEE80211_TX_MAX_RATES, which already broke older versions of >> wmediumd or similar implementations. Maybe a review regarding such >> things would be good to

Re: [RFC] change mac80211_hwsim tx_rates to ieee80211_tx_rate

2016-11-14 Thread Johannes Berg
> Mhh, I thought also some atheros drivers implement hardware multirate > retry changes, which maps to this struct. Only one rate per frame > would introduce a extreme additional communication overhead, which > will make testing with standard wmediumd impractical. I think we need > to keep such a

[PATCH 3/5] rsi: Added support for configuring tx power

2016-11-14 Thread Prameela Rani Garnepudi
TX power can be configured from iwconfig, iw or from mac80211 when regulatory changes are done. Hence support for configuring tx power to device is added. This can be done by sending RADIO_PARAMS_UPDATE command frame to device with upated tx power value. Signed-off-by: Prameela Rani Garnepudi

[PATCH 4/5] rsi: Added support for antenna selection

2016-11-14 Thread Prameela Rani Garnepudi
RSI 9113 device supports single antenna for tx and rx. Support for using external is added. This can be configured from user space using iw. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 78 +

RE: [bug report] iwlwifi: mvm: use dev_coredumpsg()

2016-11-14 Thread Erenfeld, Aviya
Thanks, Right, we already have a pending fix for that one. Aviya -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Monday, November 14, 2016 13:21 To: Erenfeld, Aviya Cc: linux-wireless@vger.kernel.org Subject: [bug report]

Re: [RFC] change mac80211_hwsim tx_rates to ieee80211_tx_rate

2016-11-14 Thread Johannes Berg
> I agree with that, but there exist also other code in hwsim, which is > tightly coupled with the mac80211 API, as e.g., the usage of > IEEE80211_TX_MAX_RATES, which already broke older versions of > wmediumd or similar implementations. Maybe a review regarding such > things would be good to

[RFC 1/2] ath9k: work around AR_CFG 0xdeadbeef chip hang

2016-11-14 Thread Sven Eckelmann
From: Simon Wunderlich QCA 802.11n chips (especially AR9330/AR9340) sometimes end up in a state in which a read of AR_CFG always returns 0xdeadbeef. This should not happen when when the power_mode of the device is ATH9K_PM_AWAKE. This problem is not yet detected

[RFC 2/2] ath9k: Reset chip on potential deaf state

2016-11-14 Thread Sven Eckelmann
From: Simon Wunderlich The chip is switching seemingly random into a state which can be described as "deaf". No or nearly no interrupts are generated anymore for incoming packets. Existing links either break down after a while and new links will not be

[PATCH 1/5] rsi: Device configuration bootup parameters updated

2016-11-14 Thread Prameela Rani Garnepudi
Switch clock info values are changed in the firmware for both 20MHZ and 40MHZ modes. Hence these values which are configured through boot parameters request frame are updated. Also three other power save related parameters are added to boot up parameters. Signed-off-by: Prameela Rani Garnepudi

RE: [PATCH v2 3/3] mwifiex: Enable WoWLAN for both sdio and pcie

2016-11-14 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Saturday, November 12, 2016 2:13 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com; dmitry.torok...@gmail.com > Subject: Re: [PATCH v2 3/3] mwifiex: Enable

[PATCH] ath10k: add spectral scan support to wmi-tlv

2016-11-14 Thread Michal Kazior
Command structure and event flow doesn't seem to be any different compared to existing implementation for other firmware branches. This patch effectively adds in-driver support for spectral scanning on QCA61x4 and QCA9377. Tested QCA9377 w/ WLAN.TF.1.0-00267-1. Signed-off-by: Michal Kazior

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

2016-11-14 Thread Stanislaw Gruszka
On Mon, Nov 14, 2016 at 09:45:36AM +0100, Stanislaw Gruszka wrote: > Could you check below patch and see if it helps? If it does not, > could you printk sta->ht_cap.ampdu_density and ba_size values > and provide them here. Actually please print parameters from below patch. I think ba_size should

Re: [PATCH 04/10] rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE

2016-11-14 Thread Stanislaw Gruszka
On Sat, Nov 05, 2016 at 01:55:14PM +0100, Mathias Kresin wrote: > 02.11.2016 15:10, Stanislaw Gruszka: > >We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on > >rt2800_init_registers(). > > > >Signed-off-by: Stanislaw Gruszka > >--- > >

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

2016-11-14 Thread Stanislaw Gruszka
On Sat, Nov 05, 2016 at 01:56:58PM +0100, Mathias Kresin wrote: > 02.11.2016 15:11, Stanislaw Gruszka: > > > >-sta_priv = sta_to_rt2x00_sta(sta); > >+txdesc->u.ht.mpdu_density = sta->ht_cap.ampdu_density; > > txdesc->u.ht.wcid = sta_priv->wcid; > >+ > >+

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

2016-11-14 Thread Stanislaw Gruszka
Hi On Mon, Nov 14, 2016 at 08:41:57PM +1100, Julian Calaby wrote: > > - rt2x00_set_field32(, MAX_LEN_CFG_MAX_PSDU, 1); > > + rt2x00_set_field32(, MAX_LEN_CFG_MAX_PSDU, 3; > > You're missing a closing parenthesis, so it isn't going to work unless > it's added back in.

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-14 Thread IgorMitsyanko
Thanks, Johannes. To clarify with you and Kalle, as persons involved with linux-wireless: is my understanding correct that submitting firmware into linux-fimware repository is a prerequisite to accepting new driver into linux-wireless? There is an option to start Quantenna device from

[bug report] iwlwifi: mvm: use dev_coredumpsg()

2016-11-14 Thread Dan Carpenter
Hello Aviya Erenfeld, The patch 7e62a699aafb: "iwlwifi: mvm: use dev_coredumpsg()" from Sep 20, 2016, leads to the following static checker warning: drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c:821 iwl_mvm_fw_error_dump() error: we previously assumed

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

2016-11-14 Thread Johannes Berg
On Mon, 2016-11-14 at 11:26 +0300, IgorMitsyanko wrote: > Thanks, Johannes. > > To clarify with you and Kalle, as persons involved with linux- > wireless: is my understanding correct that submitting firmware into > linux-fimware repository is a prerequisite to accepting new driver > into

Re: [PATCH V3] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

2016-11-14 Thread Johannes Berg
> +++ b/drivers/net/wireless/quantenna/qtnfmac/Kconfig > @@ -0,0 +1,23 @@ > +config QTNFMAC > + tristate "Quantenna WiFi FullMAC WLAN driver" > + default n No need to state that default explicitly, but it also doesn't really matter. > +   it as a module, it will be called

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

2016-11-14 Thread Arend Van Spriel
On 14-11-2016 12:34, Gianfranco Costamagna wrote: > Hi Arend, > > >> Finally response. As it turns out the range was explcitly changed > >> enabling channels 12 and 13 to be used where applicable. They forgot to >> update the comment. > > > so, the struct in net/wireless/reg.c is actually

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

2016-11-14 Thread Gianfranco Costamagna
Hi Arend, >Finally response. As it turns out the range was explcitly changed >enabling channels 12 and 13 to be used where applicable. They forgot to >update the comment. so, the struct in net/wireless/reg.c is actually used in that case? static const struct ieee80211_regdomain world_regdom

Re: Problems with mwifiex_pcie firmware activation

2016-11-14 Thread Stanislaw Gruszka
On Thu, Aug 25, 2016 at 05:06:26PM +0200, Stanislaw Gruszka wrote: > On Fri, Aug 12, 2016 at 10:13:43AM +0200, Stanislaw Gruszka wrote: > > On Fri, Aug 12, 2016 at 07:17:38AM +, Amitkumar Karwar wrote: > > > The problem looks strange. The patch just splits > > > mwifiex_check_fw_status() and

Re: [PATCH 05/10] rt2800: make ba_size depend on ampdu_factor

2016-11-14 Thread Julian Calaby
Hi Stainslaw, On Mon, Nov 14, 2016 at 7:45 PM, Stanislaw Gruszka wrote: > On Sat, Nov 05, 2016 at 01:56:58PM +0100, Mathias Kresin wrote: >> 02.11.2016 15:11, Stanislaw Gruszka: >> > >> >-sta_priv = sta_to_rt2x00_sta(sta); >> >+

Re: [RFC] change mac80211_hwsim tx_rates to ieee80211_tx_rate

2016-11-14 Thread Benjamin Beichler
>> So I would propose to put the whole struct into the netlink messages, > This is a terrible idea, since internal changes to this struct would > break the userland API/ABI. hwsim seems perhaps less important than > most APIs, but there is wmediumd etc. already. I agree with that, but there exist

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

2016-11-14 Thread Gianfranco Costamagna
Hi Arend, >Well, not before you pointed it out ;-). You are welcome to send a patch >fixing it. Otherwise, I will take care of it. attaching a format-patch like version. I don't think we need a Tested-by or whatever, because it is just a typo in a comment. (this is my first contribution,

[PATCH] brcmfmac: update beacon IE when bss up and clear when stopped

2016-11-14 Thread Wright Feng
Firmware doesn't update beacon vendor IEs when bss is down, so move brcmf_config_ap_mgmt_ie after BSS up. And host driver should clear IEs when AP stopped so that the IEs in host side will be synced with in firmware side. Signed-off-by: Wright Feng ---

[RFC 06/12] ath10k: bmi: Added SOC reg read/write functions

2016-11-14 Thread Erik Stromdahl
Added functions implementing the following BMI commands: BMI_READ_SOC_REGISTER BMI_WRITE_SOC_REGISTER Reading and writing BMI registers is sometimes needed for SDIO chipsets. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/bmi.c | 79

[RFC 09/12] ath10k: Mailbox address definitions

2016-11-14 Thread Erik Stromdahl
Address definitions for SDIO/mbox based chipsets. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/hw.h | 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/hw.h

[RFC 01/12] ath10k: htc: made static function public

2016-11-14 Thread Erik Stromdahl
Changed ath10k_htc_notify_tx_completion and ath10k_htc_process_trailer from static to non static. These functions are needed by SDIO/mbox. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.c | 14 --

[RFC 05/12] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB

2016-11-14 Thread Erik Stromdahl
Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h index 589800a..df16a04 100644 ---

[RFC 00/12] ath10k sdio support

2016-11-14 Thread Erik Stromdahl
This patch series adds sdio support to ath10k. Some of the patches affect the existing pcie/ahb code as well. Those are patches 3 and 4 in the series. Overview: A new HIF layer: sdio/mailbox. The current HIF ops are unaltered even though some ops are not applicable for sdio. The HTC layer has

[RFC 02/12] ath10k: htc: rx trailer lookahead support

2016-11-14 Thread Erik Stromdahl
The RX trailer parsing is now capable of parsing lookahead reports. This is needed by SDIO/mbox. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.c | 91 - drivers/net/wireless/ath/ath10k/htc.h | 30 +--

[RFC 07/12] ath10k: Added SDIO dbg masks

2016-11-14 Thread Erik Stromdahl
Debug masks for SDIO HIF layer. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/debug.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/debug.h b/drivers/net/wireless/ath/ath10k/debug.h index 335512b..d35263c

[RFC 12/12] ath10k: Added sdio support

2016-11-14 Thread Erik Stromdahl
Initial HIF sdio/mailbox implementation. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/Kconfig |6 + drivers/net/wireless/ath/ath10k/Makefile |3 + drivers/net/wireless/ath/ath10k/sdio.c | 1855 ++

[RFC 08/12] ath10k: Added ATH10K_BUS_SDIO enum

2016-11-14 Thread Erik Stromdahl
Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/core.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h index b7067cc..8c7b080 100644 ---

[RFC 10/12] ath10k: Added QCA65XX hw definition

2016-11-14 Thread Erik Stromdahl
Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/hw.h |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h index 46142e9..ef45ecf 100644 ---

[RFC 03/12] ath10k: htc: Changed order of wait target and ep connect

2016-11-14 Thread Erik Stromdahl
This patch changes the order in which the driver waits for the target to become ready and the service connect of the HTC control service. The HTC control service is connected before the driver starts waiting for the HTC ready control message. The reason for this is that the HTC ready control

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

2016-11-14 Thread Jes Sorensen
Barry Day writes: > On Mon, Nov 14, 2016 at 08:24:45AM -0500, Jes Sorensen wrote: >> Barry Day writes: >> > The rtl8192e and rtl8723 fail to reconnect to an AP after being >> > disconnected. Ths patch fixes that without affecting the rtl8192cu. >> > I

Re: [PATCH] rtl8xxxu: Fix failure to reconnect to AP

2016-11-14 Thread Barry Day
On Mon, Nov 14, 2016 at 08:24:45AM -0500, Jes Sorensen wrote: > Barry Day writes: > > The rtl8192e and rtl8723 fail to reconnect to an AP after being > > disconnected. Ths patch fixes that without affecting the rtl8192cu. > > I don't have a rtl8723 to test but it has been

[RFC 04/12] ath10k: htc: refactorization

2016-11-14 Thread Erik Stromdahl
Code refactorization: Moved the code for ep 0 in ath10k_htc_rx_completion_handler to ath10k_htc_control_rx_complete. This eases the implementation of SDIO/mbox significantly since the ep_rx_complete cb is invoked directly from the SDIO/mbox hif layer. Since the ath10k_htc_control_rx_complete

[PATCH v5 2/5] wcn36xx: Transition driver to SMD client

2016-11-14 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- Changes since v4: - Added Kconfig

[PATCH v5 4/5] wcn36xx: Implement print_reg indication

2016-11-14 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne Signed-off-by: Bjorn Andersson --- Changes since v4: - None drivers/net/wireless/ath/wcn36xx/hal.h | 16

[PATCH v5 1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-14 Thread Bjorn Andersson
The correct include file for getting errno constants and ERR_PTR() is linux/err.h, rather than linux/errno.h, so fix the include. Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") Acked-by: Andy Gross Signed-off-by: Bjorn Andersson

[PATCH v5 3/5] wcn36xx: Implement firmware assisted scan

2016-11-14 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson --- Changes since v4: - None

[PATCH v5 5/5] wcn36xx: Don't use the destroyed hal_mutex

2016-11-14 Thread Bjorn Andersson
ieee80211_unregister_hw() might invoke operations to stop the interface, that uses the hal_mutex. So don't destroy it until after we're done using it. Signed-off-by: Bjorn Andersson --- With this patch I can successfully (although with a SMD send timeout in the

Re: Outdated wl12xx firmwares

2016-11-14 Thread Luca Coelho
Hi, I'm CCing Maxim, since he seems to be the last developer from TI to post patches for the WiLink drivers here. On Thu, 2016-10-27 at 12:45 +0200, Gary Bisson wrote: > Hi, > > Adding linux-wireless in CC, hoping to get more traction. > > Just checked the MAINTAINERS file of this driver and

Re: [PATCH v3 3/3] mwifiex: Enable WoWLAN for both sdio and pcie

2016-11-14 Thread Brian Norris
On Mon, Nov 14, 2016 at 06:19:12PM +0530, Amitkumar Karwar wrote: > From: Rajat Jain > > Commit ce4f6f0c353b ("mwifiex: add platform specific wakeup interrupt > support") added WoWLAN feature only for sdio. This patch moves that > code to the common module so that all the

Re: [PATCH v3 01/11] mwifiex: check tx_hw_pending before downloading sleep confirm

2016-11-14 Thread Brian Norris
Hi Amit, Kalle, On Fri, Nov 11, 2016 at 06:40:08PM +0530, Amitkumar Karwar wrote: > From: Shengzhen Li > > We may get SLEEP event from firmware even if TXDone interrupt > for last Tx packet is still pending. In this case, we may > end up accessing PCIe memory for handling

Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

2016-11-14 Thread Adrian Chadd
Hiya, maybe the right thing to do is to set a flag that says "please replumb", then do a reset, and have the reset path see if we need to replumb keys and do so? To make locking less terrible, maybe we need to cache the keys in the ath9k driver somewhere so replumbing doesn't require reaching