From: Brian Norris
The device core will not allow suspend() to race with remove().
Signed-off-by: Brian Norris
Tested-by: Xinming Hu
Signed-off-by: Amitkumar Karwar
---
v4: Same as v1, v2, v3
---
to_pci_dev() would just do struct offset arithmetic on struct
device to get 'pdev' pointer. We never get NULL pdev pointer.
Signed-off-by: Amitkumar Karwar
Tested-by: Xinming Hu
Signed-off-by: Brian Norris
---
v4: Same v1, v2, v3
From: Xinming Hu
card->adapter gets initialized in mwifiex_register_dev(). As it's not
cleared in mwifiex_unregister_dev(), we may end up accessing the memory
which is already free in below scenario.
Scenario: Driver initialization is failed due to incorrect firmware or
some
From: Brian Norris
Signed-off-by: Brian Norris
Tested-by: Xinming Hu
Signed-off-by: Amitkumar Karwar
---
v4: Same as v1, v2, v3
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 12 ++--
From: Brian Norris
SDIO and PCIe drivers handle this. Let's imitate it.
Signed-off-by: Brian Norris
Tested-by: Xinming Hu
Signed-off-by: Amitkumar Karwar
---
v4: Same as v1, v2, v3
---
From: Brian Norris
sdio_func is retrieved via container_of() and should never be NULL.
Checking for NULL just makes the logic more confusing than necessary.
Stop doing that.
Signed-off-by: Brian Norris
Tested-by: Xinming Hu
From: Brian Norris
These are never NULL, so stop making people think they might be.
I don't change this for SDIO because SDIO has a racy card-reset handler
that reallocates this struct. I'd rather not touch that mess right now.
Signed-off-by: Brian Norris
From: Brian Norris
It should never be NULL here, and to think otherwise makes things
confusing.
Signed-off-by: Brian Norris
---
v2: Same as v1
v3: Below checkpatch warnings are resolved
WARNING: please, no spaces at the start of a line
#50:
On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_tr...@qti.qualcomm.com wrote:
> From: Tamizh chelvam
>
> There two things done in this patch.
>
> 1) 'btcoex_support' flag for BTCOEX feature support by the hardware.
> 2) 'wlan_btcoex_gpio' is used to fill wlan priority
From: Brian Norris
It's possible for the FW init sequence to fail, which will trigger a
device cleanup sequence in mwifiex_fw_dpc(). This sequence can race with
device suspend() or remove() (e.g., reboot or unbind), and can trigger
use-after-free issues. Currently, this
From: Shengzhen Li
Power save handshake with firmware might be blocked by on-going
data transfer.
this patch check the PS status in main process and complete
previous blocked PS handshake.
this patch also remove redudant check before call
mwifiex_check_ps_cond function.
From: Shengzhen Li
We may get SLEEP event from firmware even if TXDone interrupt
for last Tx packet is still pending. In this case, we may
end up accessing PCIe memory for handling TXDone after power
save handshake is completed. This causes kernel crash with
external abort.
Hi Kalle,
> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless-
> ow...@vger.kernel.org] On Behalf Of Kalle Valo
> Sent: Friday, November 18, 2016 5:01 PM
> To: Amitkumar Karwar
> Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam;
> raja...@google.com;
From: Wei Yongjun
Fixes the following sparse warning:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c:1559:6: warning:
symbol 'rtl8192eu_power_off' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
Signed-off-by: Jes
From: Jes Sorensen
Use the mac80211 provided rate for RTS rather than the hard coded
24Mbps as suggested by the vendor drivers.
Reported-by: Andrea Merello
Signed-off-by: Jes Sorensen
---
From: Jes Sorensen
The 8192eu suffered from two issues when reloading the driver.
The same problems as with the 8723bu where REG_RX_WAIT_CCA bits 22 and
23 didn't get set in rtl8192e_enable_rf().
In addition it also seems prone to issues when setting REG_RF_CTRL to
0
From: Jes Sorensen
A device running without RX package aggregation could return more data
in the USB packet than the actual network packet. In this case the
could would clone the skb but then determine that that there was no
packet to handle and exit without freeing the
From: Jes Sorensen
The full RX descriptor is converted so converting tsfl again would
return it to it's original endian value.
Signed-off-by: Jes Sorensen
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 4 ++--
From: Jes Sorensen
Kalle,
Please find attached a number of patches for the rtl8xxxu
driver.
The issues reported with wpa_supplicant on 8723bu still needs further
investigation.
Note the memory leak issue has only been seen with 8188eu devices so
far, but it's serious
From: Jes Sorensen
The generic disable_rf() function clears bits 22 and 23 in
REG_RX_WAIT_CCA, however we did not re-enable them again in
rtl8723b_enable_rf()
This resolves the problem for me with 8723bu devices not working again
after reloading the driver.
Hi,
With the help of a static bug finder (EBA -
https://github.com/models-team/eba) I have found a potential deadlock
in drivers/net/wireless/st/cw1200/
sta.c. This happens due to a recursive mutex_lock on `priv->conf_mutex'.
If this is indeed a bug, I will be happy to help with a patch.
A
Hello,
I experimented a strange behavior during some data rate tests between
two wireless interfaces in mesh mode. The data rate stuck on 120Mbps
(iperf UDP test) and MCS7 that is the higher MCS of 80211n without
using MIMO, even when the channel is completely free.
My configuration:
two boards
From: Brian Norris
We have a race where the wakeup IRQ might be in flight while we're
calling mwifiex_disable_wake() from resume(). This can leave us
disabling the IRQ twice.
Let's disable the IRQ and enable it in case if we have double-disabled
it.
Signed-off-by:
From: Brian Norris
We don't want to leave the wake IRQ enabled.
Signed-off-by: Brian Norris
Signed-off-by: Amitkumar Karwar
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 1 +
Amitkumar Karwar writes:
> From: Xinming Hu
>
> This patch derives device tree node from pcie bus layer framework.
> Device tree bindings file has been renamed(marvell-sd8xxx.txt ->
> marvell-8xxx.txt) to accommodate PCIe changes.
>
> Signed-off-by:
On Fri, Nov 18, 2016 at 06:21:41PM +0200, Kalle Valo wrote:
> Amitkumar Karwar writes:
>
> > From: Xinming Hu
> >
> > This patch derives device tree node from pcie bus layer framework.
> > Device tree bindings file has been renamed(marvell-sd8xxx.txt ->
>
From: Johannes Berg
Date: Fri, 18 Nov 2016 08:52:00 +0100
> Due to travel/vacation, this is a bit late, but there aren't
> that many fixes either. Most interesting/important are the
> fixes from Felix and perhaps the scan entry limit.
>
> Please pull and let me know
This patch changes the order in which the driver waits for the
target to become ready and the service connect of the HTC
control service.
The HTC control service is connected before the driver starts
waiting for the HTC ready message.
The HTC ready message contains the total number of transmit
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/htc.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/htc.h
b/drivers/net/wireless/ath/ath10k/htc.h
index f94b25a..2963694 100644
---
Initial HIF sdio/mailbox implementation.
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/Kconfig |6 +
drivers/net/wireless/ath/ath10k/Makefile |3 +
drivers/net/wireless/ath/ath10k/sdio.c | 1860 ++
Code refactorization:
Moved the code for ep 0 in ath10k_htc_rx_completion_handler
to ath10k_htc_control_rx_complete.
This eases the implementation of SDIO/mbox significantly since
the ep_rx_complete cb is invoked directly from the SDIO/mbox
hif layer.
Since the ath10k_htc_control_rx_complete
Removed tx_credits_per_max_message and tx_credit_size
from struct ath10k_htc_ep since they are not used
anywhere in the code.
They are just written, never read.
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/htc.c |6 --
Debug masks for SDIO HIF layer.
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/debug.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/debug.h
b/drivers/net/wireless/ath/ath10k/debug.h
index 335512b..d35263c
Address definitions for SDIO/mbox based chipsets.
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/hw.h | 53 ++
1 file changed, 53 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h
The RX trailer parsing is now capable of parsing lookahead reports.
A lookahead contains the first 4 bytes of the next HTC message
(that will be read in the next SDIO read operation).
Lookaheads are used by the SDIO/mbox HIF layer to determine if
the next message is part of a bundle, which
Augmented struct host_interest with more members.
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/targaddrs.h | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/targaddrs.h
Changed ath10k_htc_notify_tx_completion and
ath10k_htc_process_trailer from static to non static.
These functions are needed by SDIO/mbox.
Signed-off-by: Erik Stromdahl
---
drivers/net/wireless/ath/ath10k/htc.c | 14 --
Changes since last version:
The BMI patch (no. 6 in the previous version) has been removed since
it is not used by the last (major) sdio patch.
The QCA65XX enum patch (no. 10 in the previous version) was also
removed since it was considered not necessary.
Added a new patch (no. 3) that removes
On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:
> Bjorn Andersson wrote:
> > The correct include file for getting errno constants and ERR_PTR() is
> > linux/err.h, rather than linux/errno.h, so fix the include.
> >
> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add
* Matt Ranostay [161117 17:55]:
> Allow power sequencing for the Marvell SD8787 Wifi/BT chip.
> This can be abstracted to other chipsets if needed in the future.
Good to see this happening:
Acked-by: Tony Lindgren
Barry Day writes:
> On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> Kalle,
>>
>> Please find attached a number of patches for the rtl8xxxu
>> driver.
>>
>> The issues reported with wpa_supplicant
In order to receive other BSS entries in mesh mode, Monitor vdev
is created whenever filter flag is set with OTHER_BSS. Recently
it is root caused that setting promisc filter for Mesh interface
is causing performance and stability issues. To fix this issue,
firmware will configure appropriate
On Thu, Nov 17, 2016 at 12:56 PM, Arend Van Spriel
wrote:
> On 16-11-2016 23:47, dimitr...@google.com wrote:
>> From 68a9d37a4c7e9dc7a90a6e922cdea52737a98d66 Mon Sep 17 00:00:00 2001
>> From: Dmitry Shmidt
>> Date: Wed, 16 Nov 2016 14:27:26
On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Kalle,
>
> Please find attached a number of patches for the rtl8xxxu
> driver.
>
> The issues reported with wpa_supplicant on 8723bu still needs further
> investigation.
>
On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote:
> Barry Day writes:
> > On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote:
> >> From: Jes Sorensen
> >>
> >> Kalle,
> >>
> >> Please find attached a number of
Amitkumar Karwar wrote:
> From: Rajat Jain
>
> Today all the interface drivers (usb/pcie/sdio) assign the
> adapter->dev in the register_dev() callback, although they
> have this piece of info well before hand.
>
> This patch makes the device structure
Larry Finger wrote:
> From: Ping-Ke Shih
>
> In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module
> parameter"), wifi was fixed for those laptops that have only a single
> antenna but have an incorrectly coded EEPROM. This error
Rajat Jain writes:
> On Fri, Nov 18, 2016 at 8:21 AM, Kalle Valo wrote:
>
> > @@ -10,6 +10,8 @@ Required properties:
> > - compatible : should be one of the following:
> > * "marvell,sd8897"
> > * "marvell,sd8997"
> >
Amitkumar Karwar wrote:
> From: Xinming Hu
>
> This patch derives device tree node from pcie bus layer framework.
> Device tree bindings file has been renamed(marvell-sd8xxx.txt ->
> marvell-8xxx.txt) to accommodate PCIe changes.
>
> Signed-off-by:
Amitkumar Karwar wrote:
> From: Shengzhen Li
>
> We may get SLEEP event from firmware even if TXDone interrupt
> for last Tx packet is still pending. In this case, we may
> end up accessing PCIe memory for handling TXDone after power
> save handshake is
Hi Alexei,
"Lazar, Alexei Avshalom" writes:
> In this context the term "link" does mean connection to AP. There are
> scenarios that require to lose connection faster once reduced link
> quality detected in order maintain better user experience (from both
> sides - AP
Brian Norris writes:
> On Thu, Nov 17, 2016 at 12:39:20PM +, Kalle Valo wrote:
>> Amitkumar Karwar wrote:
>> > From: Xinming Hu
>> >
>> > This patch derives device tree node from pcie bus layer framework.
>> > Device tree
Amitkumar Karwar wrote:
> From: Shengzhen Li
>
> This patch adds power save parameters(hs_wake_interval and
> hs_inactivity_timeout) in host sleep cfg cmd.
>
> Signed-off-by: Shengzhen Li
> Signed-off-by: Cathy Luo
>
Amitkumar Karwar wrote:
> Firmware may reject calibration data from host for certain OTP
> settings. In that case, we should continue initialisation ignoring
> the failure.
>
> Signed-off-by: Amitkumar Karwar
Patch applied to wireless-drivers-next.git,
Amitkumar Karwar wrote:
> From: Rajat Jain
>
> Today all the interface drivers (usb/pcie/sdio) assign the
> adapter->dev in the register_dev() callback, although they
> have this piece of info well before hand.
>
> This patch makes the device structure
Brian Norris wrote:
> The cleanup_if() callback is the inverse of init_if(). We allocate our
> 'card' interface structure in the probe() function, but we free it in
> cleanup_if(). That gives a few problems:
> (a) we leak this memory if probe() fails before we reach
Amitkumar Karwar wrote:
> From: Shengzhen Li
>
> We may get SLEEP event from firmware even if TXDone interrupt
> for last Tx packet is still pending. In this case, we may
> end up accessing PCIe memory for handling TXDone after power
> save handshake is
Hi Kalle,
> From: Kalle Valo [mailto:kv...@codeaurora.org]
> Sent: Friday, November 18, 2016 4:38 PM
> To: Brian Norris
> Cc: Amitkumar Karwar; linux-wireless@vger.kernel.org; Cathy Luo;
> Nishant Sarmukadam; raja...@google.com; dmitry.torok...@gmail.com;
> Xinming Hu
> Subject: Re: [v7] mwifiex:
Transmit power level in a channel is determined based on the dfs region.
To support regulatory rules dfs region should be configured to device during
set channel request. Also antenna gain values are taken from the mac80211
channel parameters instead of fixed values.
Signed-off-by: Prameela Rani
RSI 9113 device supports single antenna for tx and rx. Support for using
external is added. This can be configured from user space using iw.
Signed-off-by: Prameela Rani Garnepudi
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 78 +
Filtering rx frames after connection in station mode avoids the
overhead of processing un-necessary frames. Hence rx filter frame
is added which can be configured to device at suitable times.
Signed-off-by: Prameela Rani Garnepudi
---
TX power can be configured from iwconfig, iw or from mac80211 when
regulatory changes are done. Hence support for configuring tx power
to device is added using the RADIO_PARAMS_UPDATE command frame.
Signed-off-by: Prameela Rani Garnepudi
---
Commit 3935ccc14d2c introduced mwifiex_tm_cmd() which initializes
struct mwifiex_adapter* adapter, but doesn't use it.
Compiling with W=1 gives the following warning, fix it.
mwifiex/cfg80211.c: In function ‘mwifiex_tm_cmd’:
mwifiex/cfg80211.c:3973:26: warning: variable ‘adapter’ set but not used
Commit 92263a841b15 introduced mwifiex_deaggr_sdio_pkt which initializes
variable pkt_type but does not use it. Compiling with W=1 gives the following
warning, fix it.
mwifiex/sdio.c: In function ‘mwifiex_deaggr_sdio_pkt’:
mwifiex/sdio.c:1198:6: warning: variable ‘pkt_type’ set but not used
mwifiex_usb_probe() defines and sets bcd_usb but does not use it,
Compiling with W=1 gives the following warning, fix it.
mwifiex/usb.c: In function ‘mwifiex_usb_probe’:
mwifiex/usb.c:383:41: warning: variable ‘bcd_usb’ set but not used
[-Wunused-but-set-variable]
The unused variable seems to be
mwifiex_sdio_resume() intializes pm_flag, just like mwifiex_sdio_suspend(), but
does not use it. Compiling with W=1 gives the following warning, fix it.
mwifiex/sdio.c: In function ‘mwifiex_sdio_resume’:
mwifiex/sdio.c:234:16: warning: variable ‘pm_flag’ set but not used
On Friday, November 18, 2016 12:43:22 AM CET Kirtika Ruchandani wrote:
> This patchset is part of the effort led by Arnd Bergmann to clean up
> warnings in the kernel. This and following patchsets will focus on
> "-Wunused-but-set-variable" as it among the noisier ones. These were
> found
From: Xinming Hu
This patch derives device tree node from pcie bus layer framework.
Device tree bindings file has been renamed(marvell-sd8xxx.txt ->
marvell-8xxx.txt) to accommodate PCIe changes.
Signed-off-by: Xinming Hu
Signed-off-by: Rajat Jain
Commit bec568ff5107 removed the last remaining usage of struct
mwifiex_private* priv in mwifiex_fw_dpc(), by removing the call to
mwifiex_del_virtual_intf().
Compiling mwifiex/ with W=1 gives the following warning, fix it.
mwifiex/main.c: In function ‘mwifiex_fw_dpc’:
mwifiex/main.c:520:26:
Commit b5413e6b2228 removed all uses of chan_num in mwifiex_config_scan().
Compiling mwifiex with W=1 gives the following warning, fix it.
mwifiex/scan.c: In function ‘mwifiex_config_scan’:
mwifiex/scan.c:830:6: warning: variable ‘chan_num’ set but not used
[-Wunused-but-set-variable]
Fixes:
This patchset is part of the effort led by Arnd Bergmann to clean up
warnings in the kernel. This and following patchsets will focus on
"-Wunused-but-set-variable" as it among the noisier ones. These were
found compiling with W=1.
Kirtika Ruchandani (7):
mwifiex: Removed unused mwifiex_private*
Sending frames in CCK rates on HT can cause performance problems.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
Use RTS/CTS protection for TXOP on all rates modes as default and
disable CCK rates (this cause performance problems).
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Initialize AUTO_RSP_CFG register to similar value as vendor driver does.
Do not set BAC_ACK_POLICY based on short preamble setting, those are
unrelated.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 ++
1 file changed, 2
Those TX_SW_CFG1 values are used in vendor driver.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
We should not reset USB_DMA_CFG on rt2800usb_init_registers() as this
function is called indirectly from rt2800_enable_radio(). If we
do so, we wipe out USB_DMA_CFG settings from rt2800usb_enable_radio().
Signed-off-by: Stanislaw Gruszka
---
Random fixes mostly related to HT performance.
v1 -> v2:
- drop patch "rt2800: make ba_size depend on ampdu_factor"
- fix changelog for patch "rt2800: do not overwrite
WPDMA_GLO_CFG_WP_DMA_BURST_SIZE"
Stanislaw Gruszka (9):
rt2800: correctly report MCS TX parameters
rt2800usb: do not
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index aab59f6..feceb13
We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on
rt2800_init_registers() for USB devices. For PCI devices we will use
HW default setting, which is 2, so patch does not change behaviour
on PCI devices.
Signed-off-by: Stanislaw Gruszka
---
Change default to RTS/CTS protection. This has a cost of transmitting
one more control frame (RTS) however protect us from traffic from
hidden node.
On station mode will use CTS-to-self if AP will configure that
for the network.
Signed-off-by: Stanislaw Gruszka
---
80 matches
Mail list logo