[PATCH v4 05/11] mwifiex: don't pretend to resume while remove()'ing

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris The device core will not allow suspend() to race with remove(). Signed-off-by: Brian Norris Tested-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- v4: Same as v1, v2, v3 ---

[PATCH v4 04/11] mwifiex: remove redundant pdev check in suspend/resume handlers

2016-11-18 Thread Amitkumar Karwar
to_pci_dev() would just do struct offset arithmetic on struct device to get 'pdev' pointer. We never get NULL pdev pointer. Signed-off-by: Amitkumar Karwar Tested-by: Xinming Hu Signed-off-by: Brian Norris --- v4: Same v1, v2, v3

[PATCH v4 07/11] mwifiex: reset card->adapter during device unregister

2016-11-18 Thread Amitkumar Karwar
From: Xinming Hu card->adapter gets initialized in mwifiex_register_dev(). As it's not cleared in mwifiex_unregister_dev(), we may end up accessing the memory which is already free in below scenario. Scenario: Driver initialization is failed due to incorrect firmware or some

[PATCH v4 06/11] mwifiex: resolve suspend() race with async FW init failure

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris Signed-off-by: Brian Norris Tested-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- v4: Same as v1, v2, v3 --- drivers/net/wireless/marvell/mwifiex/pcie.c | 12 ++--

[PATCH v4 08/11] mwifiex: usb: handle HS failures

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris SDIO and PCIe drivers handle this. Let's imitate it. Signed-off-by: Brian Norris Tested-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- v4: Same as v1, v2, v3 ---

[PATCH v4 09/11] mwifiex: sdio: don't check for NULL sdio_func

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris sdio_func is retrieved via container_of() and should never be NULL. Checking for NULL just makes the logic more confusing than necessary. Stop doing that. Signed-off-by: Brian Norris Tested-by: Xinming Hu

[PATCH v4 10/11] mwifiex: stop checking for NULL drvata/intfdata

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris These are never NULL, so stop making people think they might be. I don't change this for SDIO because SDIO has a racy card-reset handler that reallocates this struct. I'd rather not touch that mess right now. Signed-off-by: Brian Norris

[PATCH v4 11/11] mwifiex: pcie: stop checking for NULL adapter->card

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris It should never be NULL here, and to think otherwise makes things confusing. Signed-off-by: Brian Norris --- v2: Same as v1 v3: Below checkpatch warnings are resolved WARNING: please, no spaces at the start of a line #50:

Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt

2016-11-18 Thread Rob Herring
On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > There two things done in this patch. > > 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. > 2) 'wlan_btcoex_gpio' is used to fill wlan priority

[PATCH v4 03/11] mwifiex: resolve races between async FW init (failure) and device removal

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris It's possible for the FW init sequence to fail, which will trigger a device cleanup sequence in mwifiex_fw_dpc(). This sequence can race with device suspend() or remove() (e.g., reboot or unbind), and can trigger use-after-free issues. Currently, this

[PATCH v4 02/11] mwifiex: complete blocked power save handshake in main process

2016-11-18 Thread Amitkumar Karwar
From: Shengzhen Li Power save handshake with firmware might be blocked by on-going data transfer. this patch check the PS status in main process and complete previous blocked PS handshake. this patch also remove redudant check before call mwifiex_check_ps_cond function.

[PATCH v4 01/11] mwifiex: check tx_hw_pending before downloading sleep confirm

2016-11-18 Thread Amitkumar Karwar
From: Shengzhen Li We may get SLEEP event from firmware even if TXDone interrupt for last Tx packet is still pending. In this case, we may end up accessing PCIe memory for handling TXDone after power save handshake is completed. This causes kernel crash with external abort.

RE: [v3, 01/11] mwifiex: check tx_hw_pending before downloading sleep confirm

2016-11-18 Thread Amitkumar Karwar
Hi Kalle, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Kalle Valo > Sent: Friday, November 18, 2016 5:01 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com;

[PATCH 7/7] rtl8xxxu: Fix non static symbol warning

2016-11-18 Thread Jes . Sorensen
From: Wei Yongjun Fixes the following sparse warning: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c:1559:6: warning: symbol 'rtl8192eu_power_off' was not declared. Should it be static? Signed-off-by: Wei Yongjun Signed-off-by: Jes

[PATCH 5/7] rtl8xxxu: Obtain RTS rates from mac80211

2016-11-18 Thread Jes . Sorensen
From: Jes Sorensen Use the mac80211 provided rate for RTS rather than the hard coded 24Mbps as suggested by the vendor drivers. Reported-by: Andrea Merello Signed-off-by: Jes Sorensen ---

[PATCH 4/7] rtl8xxxu: Fix rtl8192eu driver reload issue

2016-11-18 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu suffered from two issues when reloading the driver. The same problems as with the 8723bu where REG_RX_WAIT_CCA bits 22 and 23 didn't get set in rtl8192e_enable_rf(). In addition it also seems prone to issues when setting REG_RF_CTRL to 0

[PATCH 1/7] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

2016-11-18 Thread Jes . Sorensen
From: Jes Sorensen A device running without RX package aggregation could return more data in the USB packet than the actual network packet. In this case the could would clone the skb but then determine that that there was no packet to handle and exit without freeing the

[PATCH 2/7] rtl8xxxu: Fix big-endian problem reporting mactime

2016-11-18 Thread Jes . Sorensen
From: Jes Sorensen The full RX descriptor is converted so converting tsfl again would return it to it's original endian value. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 4 ++--

[PATCH 0/7] rtl8xxxu: Pending patches

2016-11-18 Thread Jes . Sorensen
From: Jes Sorensen Kalle, Please find attached a number of patches for the rtl8xxxu driver. The issues reported with wpa_supplicant on 8723bu still needs further investigation. Note the memory leak issue has only been seen with 8188eu devices so far, but it's serious

[PATCH 3/7] rtl8xxxu: Fix rtl8723bu driver reload issue

2016-11-18 Thread Jes . Sorensen
From: Jes Sorensen The generic disable_rf() function clears bits 22 and 23 in REG_RX_WAIT_CCA, however we did not re-enable them again in rtl8723b_enable_rf() This resolves the problem for me with 8723bu devices not working again after reloading the driver.

Potential deadlock BUG in drivers/net/wireless/st/cw1200/sta.c (Linux 4.9)

2016-11-18 Thread Iago Abal
Hi, With the help of a static bug finder (EBA - https://github.com/models-team/eba) I have found a potential deadlock in drivers/net/wireless/st/cw1200/ sta.c. This happens due to a recursive mutex_lock on `priv->conf_mutex'. If this is indeed a bug, I will be happy to help with a patch. A

ath10k stuck in mesh mode

2016-11-18 Thread Matteo Grandi
Hello, I experimented a strange behavior during some data rate tests between two wireless interfaces in mesh mode. The data rate stuck on 120Mbps (iperf UDP test) and MCS7 that is the higher MCS of 80211n without using MIMO, even when the channel is completely free. My configuration: two boards

[PATCH 2/2] mwifiex: avoid double-disable_irq() race

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris We have a race where the wakeup IRQ might be in flight while we're calling mwifiex_disable_wake() from resume(). This can leave us disabling the IRQ twice. Let's disable the IRQ and enable it in case if we have double-disabled it. Signed-off-by:

[PATCH 1/2] mwifiex: cleanup wake-IRQ handling if suspend fails

2016-11-18 Thread Amitkumar Karwar
From: Brian Norris We don't want to leave the wake IRQ enabled. Signed-off-by: Brian Norris Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/pcie.c | 1 +

Re: [PATCH v8] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Kalle Valo
Amitkumar Karwar writes: > From: Xinming Hu > > This patch derives device tree node from pcie bus layer framework. > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> > marvell-8xxx.txt) to accommodate PCIe changes. > > Signed-off-by:

Re: [PATCH v8] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Rob Herring
On Fri, Nov 18, 2016 at 06:21:41PM +0200, Kalle Valo wrote: > Amitkumar Karwar writes: > > > From: Xinming Hu > > > > This patch derives device tree node from pcie bus layer framework. > > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> >

Re: pull-request: mac80211 2016-11-18

2016-11-18 Thread David Miller
From: Johannes Berg Date: Fri, 18 Nov 2016 08:52:00 +0100 > Due to travel/vacation, this is a bit late, but there aren't > that many fixes either. Most interesting/important are the > fixes from Felix and perhaps the scan entry limit. > > Please pull and let me know

[RFC v2 04/11] ath10k: htc: Changed order of wait target and ep connect

2016-11-18 Thread Erik Stromdahl
This patch changes the order in which the driver waits for the target to become ready and the service connect of the HTC control service. The HTC control service is connected before the driver starts waiting for the HTC ready message. The HTC ready message contains the total number of transmit

[RFC v2 06/11] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB

2016-11-18 Thread Erik Stromdahl
Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h index f94b25a..2963694 100644 ---

[RFC v2 11/11] ath10k: Added sdio support

2016-11-18 Thread Erik Stromdahl
Initial HIF sdio/mailbox implementation. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/Kconfig |6 + drivers/net/wireless/ath/ath10k/Makefile |3 + drivers/net/wireless/ath/ath10k/sdio.c | 1860 ++

[RFC v2 05/11] ath10k: htc: refactorization

2016-11-18 Thread Erik Stromdahl
Code refactorization: Moved the code for ep 0 in ath10k_htc_rx_completion_handler to ath10k_htc_control_rx_complete. This eases the implementation of SDIO/mbox significantly since the ep_rx_complete cb is invoked directly from the SDIO/mbox hif layer. Since the ath10k_htc_control_rx_complete

[RFC v2 03/11] ath10k: htc: Removal of unused struct members

2016-11-18 Thread Erik Stromdahl
Removed tx_credits_per_max_message and tx_credit_size from struct ath10k_htc_ep since they are not used anywhere in the code. They are just written, never read. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.c |6 --

[RFC v2 07/11] ath10k: Added SDIO dbg masks

2016-11-18 Thread Erik Stromdahl
Debug masks for SDIO HIF layer. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/debug.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/debug.h b/drivers/net/wireless/ath/ath10k/debug.h index 335512b..d35263c

[RFC v2 09/11] ath10k: Mailbox address definitions

2016-11-18 Thread Erik Stromdahl
Address definitions for SDIO/mbox based chipsets. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/hw.h | 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/hw.h

[RFC v2 02/11] ath10k: htc: rx trailer lookahead support

2016-11-18 Thread Erik Stromdahl
The RX trailer parsing is now capable of parsing lookahead reports. A lookahead contains the first 4 bytes of the next HTC message (that will be read in the next SDIO read operation). Lookaheads are used by the SDIO/mbox HIF layer to determine if the next message is part of a bundle, which

[RFC v2 10/11] ath10k: Added more host_interest members

2016-11-18 Thread Erik Stromdahl
Augmented struct host_interest with more members. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/targaddrs.h | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/targaddrs.h

[RFC v2 01/11] ath10k: htc: made static function public

2016-11-18 Thread Erik Stromdahl
Changed ath10k_htc_notify_tx_completion and ath10k_htc_process_trailer from static to non static. These functions are needed by SDIO/mbox. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/htc.c | 14 --

[RFC v2 00/11] ath10k sdio support

2016-11-18 Thread Erik Stromdahl
Changes since last version: The BMI patch (no. 6 in the previous version) has been removed since it is not used by the last (major) sdio patch. The QCA65XX enum patch (no. 10 in the previous version) was also removed since it was considered not necessary. Added a new patch (no. 3) that removes

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-18 Thread Bjorn Andersson
On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: > Bjorn Andersson wrote: > > The correct include file for getting errno constants and ERR_PTR() is > > linux/err.h, rather than linux/errno.h, so fix the include. > > > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add

Re: [PATCH] mmc: pwrseq: add support for Marvell SD8787 chip

2016-11-18 Thread Tony Lindgren
* Matt Ranostay [161117 17:55]: > Allow power sequencing for the Marvell SD8787 Wifi/BT chip. > This can be abstracted to other chipsets if needed in the future. Good to see this happening: Acked-by: Tony Lindgren

Re: [PATCH 0/7] rtl8xxxu: Pending patches

2016-11-18 Thread Jes Sorensen
Barry Day writes: > On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Kalle, >> >> Please find attached a number of patches for the rtl8xxxu >> driver. >> >> The issues reported with wpa_supplicant

[PATCH] ath10k: fix monitor vdev for receiving other bss frames

2016-11-18 Thread Rajkumar Manoharan
In order to receive other BSS entries in mesh mode, Monitor vdev is created whenever filter flag is set with OTHER_BSS. Recently it is root caused that setting promisc filter for Mesh interface is causing performance and stability issues. To fix this issue, firmware will configure appropriate

Re: [PATCH] RFC: Universal scan proposal

2016-11-18 Thread Dmitry Shmidt
On Thu, Nov 17, 2016 at 12:56 PM, Arend Van Spriel wrote: > On 16-11-2016 23:47, dimitr...@google.com wrote: >> From 68a9d37a4c7e9dc7a90a6e922cdea52737a98d66 Mon Sep 17 00:00:00 2001 >> From: Dmitry Shmidt >> Date: Wed, 16 Nov 2016 14:27:26

Re: [PATCH 0/7] rtl8xxxu: Pending patches

2016-11-18 Thread Barry Day
On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Kalle, > > Please find attached a number of patches for the rtl8xxxu > driver. > > The issues reported with wpa_supplicant on 8723bu still needs further > investigation. >

Re: [PATCH 0/7] rtl8xxxu: Pending patches

2016-11-18 Thread Barry Day
On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote: > Barry Day writes: > > On Fri, Nov 18, 2016 at 04:44:21PM -0500, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> > >> Kalle, > >> > >> Please find attached a number of

Re: [v4,1/3] mwifiex: Allow mwifiex early access to device structure

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Rajat Jain > > Today all the interface drivers (usb/pcie/sdio) assign the > adapter->dev in the register_dev() callback, although they > have this piece of info well before hand. > > This patch makes the device structure

Re: rtlwifi: rtl8723be: Fix bug in ant_sel code from commit c18d8f509571

2016-11-18 Thread Kalle Valo
Larry Finger wrote: > From: Ping-Ke Shih > > In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module > parameter"), wifi was fixed for those laptops that have only a single > antenna but have an incorrectly coded EEPROM. This error

Re: [PATCH v8] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Kalle Valo
Rajat Jain writes: > On Fri, Nov 18, 2016 at 8:21 AM, Kalle Valo wrote: > > > @@ -10,6 +10,8 @@ Required properties: > >    - compatible : should be one of the following: > >       * "marvell,sd8897" > >       * "marvell,sd8997" > >

Re: [v8] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Xinming Hu > > This patch derives device tree node from pcie bus layer framework. > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> > marvell-8xxx.txt) to accommodate PCIe changes. > > Signed-off-by:

Re: [v4, 01/11] mwifiex: check tx_hw_pending before downloading sleep confirm

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Shengzhen Li > > We may get SLEEP event from firmware even if TXDone interrupt > for last Tx packet is still pending. In this case, we may > end up accessing PCIe memory for handling TXDone after power > save handshake is

Re: cfg80211: add set/get link loss profile

2016-11-18 Thread Kalle Valo
Hi Alexei, "Lazar, Alexei Avshalom" writes: > In this context the term "link" does mean connection to AP. There are > scenarios that require to lose connection faster once reduced link > quality detected in order maintain better user experience (from both > sides - AP

Re: [v7] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Kalle Valo
Brian Norris writes: > On Thu, Nov 17, 2016 at 12:39:20PM +, Kalle Valo wrote: >> Amitkumar Karwar wrote: >> > From: Xinming Hu >> > >> > This patch derives device tree node from pcie bus layer framework. >> > Device tree

Re: mwifiex: add power save parameters in hs_cfg cmd

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Shengzhen Li > > This patch adds power save parameters(hs_wake_interval and > hs_inactivity_timeout) in host sleep cfg cmd. > > Signed-off-by: Shengzhen Li > Signed-off-by: Cathy Luo >

Re: [2/2] mwifiex: ignore calibration data failure

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > Firmware may reject calibration data from host for certain OTP > settings. In that case, we should continue initialisation ignoring > the failure. > > Signed-off-by: Amitkumar Karwar Patch applied to wireless-drivers-next.git,

Re: [v4,1/3] mwifiex: Allow mwifiex early access to device structure

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Rajat Jain > > Today all the interface drivers (usb/pcie/sdio) assign the > adapter->dev in the register_dev() callback, although they > have this piece of info well before hand. > > This patch makes the device structure

Re: mwifiex: don't do unbalanced free()'ing in cleanup_if()

2016-11-18 Thread Kalle Valo
Brian Norris wrote: > The cleanup_if() callback is the inverse of init_if(). We allocate our > 'card' interface structure in the probe() function, but we free it in > cleanup_if(). That gives a few problems: > (a) we leak this memory if probe() fails before we reach

Re: [v3, 01/11] mwifiex: check tx_hw_pending before downloading sleep confirm

2016-11-18 Thread Kalle Valo
Amitkumar Karwar wrote: > From: Shengzhen Li > > We may get SLEEP event from firmware even if TXDone interrupt > for last Tx packet is still pending. In this case, we may > end up accessing PCIe memory for handling TXDone after power > save handshake is

RE: [v7] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Amitkumar Karwar
Hi Kalle, > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Friday, November 18, 2016 4:38 PM > To: Brian Norris > Cc: Amitkumar Karwar; linux-wireless@vger.kernel.org; Cathy Luo; > Nishant Sarmukadam; raja...@google.com; dmitry.torok...@gmail.com; > Xinming Hu > Subject: Re: [v7] mwifiex:

[PATCH 4/4] rsi: Add support for 802.11d

2016-11-18 Thread Prameela Rani Garnepudi
Transmit power level in a channel is determined based on the dfs region. To support regulatory rules dfs region should be configured to device during set channel request. Also antenna gain values are taken from the mac80211 channel parameters instead of fixed values. Signed-off-by: Prameela Rani

[PATCH 3/4] rsi: Add support for antenna selection

2016-11-18 Thread Prameela Rani Garnepudi
RSI 9113 device supports single antenna for tx and rx. Support for using external is added. This can be configured from user space using iw. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 78 +

[PATCH 1/4] rsi: Add support to filter rx frames

2016-11-18 Thread Prameela Rani Garnepudi
Filtering rx frames after connection in station mode avoids the overhead of processing un-necessary frames. Hence rx filter frame is added which can be configured to device at suitable times. Signed-off-by: Prameela Rani Garnepudi ---

[PATCH 2/4] rsi: Add support for configuring tx power

2016-11-18 Thread Prameela Rani Garnepudi
TX power can be configured from iwconfig, iw or from mac80211 when regulatory changes are done. Hence support for configuring tx power to device is added using the RADIO_PARAMS_UPDATE command frame. Signed-off-by: Prameela Rani Garnepudi ---

[PATCH 4/7] mwifiex: Remove unused 'adapter'variable

2016-11-18 Thread Kirtika Ruchandani
Commit 3935ccc14d2c introduced mwifiex_tm_cmd() which initializes struct mwifiex_adapter* adapter, but doesn't use it. Compiling with W=1 gives the following warning, fix it. mwifiex/cfg80211.c: In function ‘mwifiex_tm_cmd’: mwifiex/cfg80211.c:3973:26: warning: variable ‘adapter’ set but not used

[PATCH 6/7] mwifiex: Removed unused 'pkt_type' variable

2016-11-18 Thread Kirtika Ruchandani
Commit 92263a841b15 introduced mwifiex_deaggr_sdio_pkt which initializes variable pkt_type but does not use it. Compiling with W=1 gives the following warning, fix it. mwifiex/sdio.c: In function ‘mwifiex_deaggr_sdio_pkt’: mwifiex/sdio.c:1198:6: warning: variable ‘pkt_type’ set but not used

[PATCH 7/7] mwifiex: Remove unused 'bcd_usb' variable

2016-11-18 Thread Kirtika Ruchandani
mwifiex_usb_probe() defines and sets bcd_usb but does not use it, Compiling with W=1 gives the following warning, fix it. mwifiex/usb.c: In function ‘mwifiex_usb_probe’: mwifiex/usb.c:383:41: warning: variable ‘bcd_usb’ set but not used [-Wunused-but-set-variable] The unused variable seems to be

[PATCH 5/7] mwifiex: Remove unused 'pm_flag' variable

2016-11-18 Thread Kirtika Ruchandani
mwifiex_sdio_resume() intializes pm_flag, just like mwifiex_sdio_suspend(), but does not use it. Compiling with W=1 gives the following warning, fix it. mwifiex/sdio.c: In function ‘mwifiex_sdio_resume’: mwifiex/sdio.c:234:16: warning: variable ‘pm_flag’ set but not used

Re: [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/

2016-11-18 Thread Arnd Bergmann
On Friday, November 18, 2016 12:43:22 AM CET Kirtika Ruchandani wrote: > This patchset is part of the effort led by Arnd Bergmann to clean up > warnings in the kernel. This and following patchsets will focus on > "-Wunused-but-set-variable" as it among the noisier ones. These were > found

[PATCH v8] mwifiex: parse device tree node for PCIe

2016-11-18 Thread Amitkumar Karwar
From: Xinming Hu This patch derives device tree node from pcie bus layer framework. Device tree bindings file has been renamed(marvell-sd8xxx.txt -> marvell-8xxx.txt) to accommodate PCIe changes. Signed-off-by: Xinming Hu Signed-off-by: Rajat Jain

[PATCH 1/7] mwifiex: Removed unused mwifiex_private* 'priv' variable

2016-11-18 Thread Kirtika Ruchandani
Commit bec568ff5107 removed the last remaining usage of struct mwifiex_private* priv in mwifiex_fw_dpc(), by removing the call to mwifiex_del_virtual_intf(). Compiling mwifiex/ with W=1 gives the following warning, fix it. mwifiex/main.c: In function ‘mwifiex_fw_dpc’: mwifiex/main.c:520:26:

[PATCH 2/7] mwifiex: Remove unused 'chan_num' variable

2016-11-18 Thread Kirtika Ruchandani
Commit b5413e6b2228 removed all uses of chan_num in mwifiex_config_scan(). Compiling mwifiex with W=1 gives the following warning, fix it. mwifiex/scan.c: In function ‘mwifiex_config_scan’: mwifiex/scan.c:830:6: warning: variable ‘chan_num’ set but not used [-Wunused-but-set-variable] Fixes:

[PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/

2016-11-18 Thread Kirtika Ruchandani
This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Kirtika Ruchandani (7): mwifiex: Removed unused mwifiex_private*

[PATCH v2 9/9] rt2800: disable CCK rates on HT

2016-11-18 Thread Stanislaw Gruszka
Sending frames in CCK rates on HT can cause performance problems. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH v2 8/9] rt2800: tune *_PROT_CFG parameters

2016-11-18 Thread Stanislaw Gruszka
Use RTS/CTS protection for TXOP on all rates modes as default and disable CCK rates (this cause performance problems). Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH v2 5/9] rt2800: correct AUTO_RSP_CFG

2016-11-18 Thread Stanislaw Gruszka
Initialize AUTO_RSP_CFG register to similar value as vendor driver does. Do not set BAC_ACK_POLICY based on short preamble setting, those are unrelated. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 6 ++ 1 file changed, 2

[PATCH v2 6/9] rt2800: correct TX_SW_CFG1 for 5592

2016-11-18 Thread Stanislaw Gruszka
Those TX_SW_CFG1 values are used in vendor driver. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH v2 2/9] rt2800usb: do not wipe out USB_DMA_CFG settings

2016-11-18 Thread Stanislaw Gruszka
We should not reset USB_DMA_CFG on rt2800usb_init_registers() as this function is called indirectly from rt2800_enable_radio(). If we do so, we wipe out USB_DMA_CFG settings from rt2800usb_enable_radio(). Signed-off-by: Stanislaw Gruszka ---

[PATCH v2 0/9] rt2800: random fixes

2016-11-18 Thread Stanislaw Gruszka
Random fixes mostly related to HT performance. v1 -> v2: - drop patch "rt2800: make ba_size depend on ampdu_factor" - fix changelog for patch "rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE" Stanislaw Gruszka (9): rt2800: correctly report MCS TX parameters rt2800usb: do not

[PATCH v2 3/9] rt2800: OFDM rates are mandatory

2016-11-18 Thread Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index aab59f6..feceb13

[PATCH v2 4/9] rt2800: do not overwrite WPDMA_GLO_CFG_WP_DMA_BURST_SIZE

2016-11-18 Thread Stanislaw Gruszka
We already initlized WPDMA_GLO_CFG_WP_DMA_BURST_SIZE to 3 on rt2800_init_registers() for USB devices. For PCI devices we will use HW default setting, which is 2, so patch does not change behaviour on PCI devices. Signed-off-by: Stanislaw Gruszka ---

[PATCH v2 7/9] rt2800: use RTS/CTS protection instead of CTS-to-self

2016-11-18 Thread Stanislaw Gruszka
Change default to RTS/CTS protection. This has a cost of transmitting one more control frame (RTS) however protect us from traffic from hidden node. On station mode will use CTS-to-self if AP will configure that for the network. Signed-off-by: Stanislaw Gruszka ---