Re: Cubieboard2 + hostapd + 100 wireless devices

2017-05-10 Thread Stanislaw Gruszka
On Sun, May 07, 2017 at 02:19:25PM +0200, Marek Floriańczyk wrote: > Hello all, > > I need to set up such a configuration: > Cubieboard2 with Debian Jessie, Hostapd 2.6 as an AP, usb wifi dongle + 100 > devices with NodeMCU module: >

Re: [PATCH] mac80211: Validate michael MIC before attempting packet decode.

2017-05-10 Thread Johannes Berg
On Tue, 2017-05-09 at 14:16 -0400, Michael Skeffington wrote: > In order to allow wpa_supplicant to correctly identify a perceived > WPA TKIP key > recovery attack the michael MIC must be checked before the packet > decode is > attempted.  A packet with an invalid MIC will always fail a decrypt >

[PATCH] ath9k: check ah->curchan when updating tx power

2017-05-10 Thread Stanislaw Gruszka
When driver fail to reset card ah->curchan value stay NULL. When later driver try to update tx power it oops by using ah->curchan (calltrace is shown below). This problem were reported at various places and for some it was fixed by making ath9k_hw_chip_reset() do not fail. I have this bug report

Re: [PATCH] libertas: Avoid reading past end of buffer

2017-05-10 Thread Joe Perches
On Wed, 2017-05-10 at 12:24 -0700, Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. another bit of trivia: > diff --git

Re: [PATCH] [ath10k] go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-10 Thread Su Kang Yin
On 11 May 2017 at 11:55, Kalle Valo wrote: > Su Kang Yin writes: > >> Without this patch QCA9888 is not working. Also I have to update >> board2.bin from Kalle's git repo. > > More details would be good to know, as the behaviour seems to vary quite > a lot. What platform are you using, x86, some

Re: [PATCH] libertas: Avoid reading past end of buffer

2017-05-10 Thread Kalle Valo
Joe Perches writes: > unrelated trivia: > > lbs_deb_enter is used incorrectly here at > function exit as both enter and leave calls. > > That type of copy/paste defect may be common. > > $ git grep -w lbs_deb_enter | wc -l > 148 > $ git grep -w lbs_deb_leave | wc -l > 71 > >

Re: [PATCH] [ath10k] go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-10 Thread Kalle Valo
Su Kang Yin writes: > Without this patch QCA9888 is not working. Also I have to update > board2.bin from Kalle's git repo. More details would be good to know, as the behaviour seems to vary quite a lot. What platform are you using, x86, some ARM board or what? And what

Re: [PATCH] [ath10k] go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-10 Thread Kalle Valo
Su Kang Yin writes: > On 11 May 2017 at 11:55, Kalle Valo wrote: >> Su Kang Yin writes: >> >>> Without this patch QCA9888 is not working. Also I have to update >>> board2.bin from Kalle's git repo. >> >> More details would be good to know, as the behaviour seems to vary quite

Re: [PATCH] libertas: Avoid reading past end of buffer

2017-05-10 Thread Joe Perches
On Wed, 2017-05-10 at 12:24 -0700, Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means [] > diff --git a/drivers/net/wireless/marvell/libertas/mesh.c > b/drivers/net/wireless/marvell/libertas/mesh.c [] > @@ -1170,17 +1170,11 @@ int

pull-request: iwlwifi firmwares update 2017-05-10

2017-05-10 Thread Luca Coelho
Hi Kyle, The last time we pushed new -22 firmwares, we forgot to update the relevant version for 3168 devices. This pull-request contains only this update. Please pull or let me know if there are any issues. Cheers, Luca. The following changes since commit

Re: Cubieboard2 + hostapd + 100 wireless devices

2017-05-10 Thread Marek Floriańczyk
Dnia środa, 10 maja 2017 11:31:17 CEST Stanislaw Gruszka pisze: > On Sun, May 07, 2017 at 02:19:25PM +0200, Marek Floriańczyk wrote: > > > If RT5370 works for you I would stick with it. RTxxx chips with rt2800 > driver are capable to support up to 190 stations with HW encryption and > 11n

Re: [PATCH] mac80211: Validate michael MIC before attempting packet decode.

2017-05-10 Thread Jouni Malinen
On Tue, May 09, 2017 at 02:16:31PM -0400, Michael Skeffington wrote: > In order to allow wpa_supplicant to correctly identify a perceived WPA TKIP > key > recovery attack the michael MIC must be checked before the packet decode is > attempted. A packet with an invalid MIC will always fail a

Re: [PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Adrian Chadd
grr, no. lemme go re-add that and resubmit. thanks! -a On 10 May 2017 at 09:44, Steve deRosier wrote: > Hi Adrian, > > On Wed, May 10, 2017 at 9:25 AM, Adrian Chadd wrote: > >> diff --git a/drivers/net/wireless/ath/ath10k/debug.h >>

[PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Adrian Chadd
This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * driver debugging and tracing is now configurable at runtime * the debugging / tracing is not run at all (besides a mask check) unless the specific debugging bitmap field is

Re: [PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Steve deRosier
Hi Adrian, On Wed, May 10, 2017 at 9:25 AM, Adrian Chadd wrote: > diff --git a/drivers/net/wireless/ath/ath10k/debug.h > b/drivers/net/wireless/ath/ath10k/debug.h > index 257d10985c6e..7bd461927029 100644 > --- a/drivers/net/wireless/ath/ath10k/debug.h > +++

Re: [v2,1/3] ath9k: Support channels in licensed bands

2017-05-10 Thread Ben Greear
On 05/10/2017 03:30 AM, Tom Psyborg wrote: On 9 May 2017 at 19:50, Adrian Chadd > wrote: (Note note: some of those channels have non-megahertz boundaries, which means ... yeah, hello inter-operability boundaries. Hilarious.)

Re: [PATCH] wcn36xx: Close SMD channel on device removal

2017-05-10 Thread Bjorn Andersson
On Wed 10 May 00:27 PDT 2017, Arend van Spriel wrote: > On 5/10/2017 1:03 AM, Bjorn Andersson wrote: > > On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: > > > > > Bjorn Andersson writes: > > > > > > > The SMD channel is not the primary WCNSS channel and must

Re: [PATCH] wcn36xx: Close SMD channel on device removal

2017-05-10 Thread Arend van Spriel
On 5/10/2017 1:03 AM, Bjorn Andersson wrote: On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: Bjorn Andersson writes: The SMD channel is not the primary WCNSS channel and must explicitly be closed as the device is removed, or the channel will already by open on a

[PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Adrian Chadd
This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * driver debugging and tracing is now configurable at runtime * the debugging / tracing is not run at all (besides a mask check) unless the specific debugging bitmap field is

Re: [PATCH] libertas: Avoid reading past end of buffer

2017-05-10 Thread Kees Cook
On Tue, May 9, 2017 at 9:33 PM, Joe Perches wrote: > On Tue, 2017-05-09 at 16:23 -0700, Kees Cook wrote: >> Using memcpy() from a string that is shorter than the length copied means >> the destination buffer is being filled with arbitrary data from the kernel >> rodata segment.

[PATCH] libertas: Avoid reading past end of buffer

2017-05-10 Thread Kees Cook
Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, redefine the stat strings to be ETH_GSTRING_LEN sizes, like other drivers. This lets us use a single memcpy that does not