Re: [v2 07/20] rsi: correct the logic of deriving queue number

Amitkumar Karwar writes: > Maximum valid queue number is 0x5. So anding with 0x7 should be > ok here. > > Signed-off-by: Amitkumar Karwar The separate From header is missing which you had in v1. -- Kalle Valo

Re: [PATCH v2] rtlwifi: Replace hardcode value with macro

Hi Kalle, On Wed, Jun 28, 2017 at 9:47 PM, Kalle Valo wrote: > Souptick Joarder writes: > >> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >> and hw->max_rate_tries are replaced by macro. >> >> Signed-off-by: Souptick Joarder

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 17:02 +0200, Johannes Berg wrote: > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > The mac80211_hwsim doesn't offer a way to disable the debugging > > output. > > Unfortunately, it's pretty chatty, dumping a lot of stuff into the > > message buffer. > > Why is

[PATCH 22/31] iwlwifi: unify external & internal modparam names

From: Johannes Berg Where possible (all except for "11n_disable", which isn't valid in C) rename the internal names for module parameters to be the same as the externally visible names, to aid finding their use etc. Signed-off-by: Johannes Berg

[PATCH 28/31] iwlwifi: create new subdirectory for FW interaction

From: Johannes Berg There's a lot of mvm code that really should be more generic and part of the iwlwifi module. Start by making a place to keep such code - in the new "fw" subdirectory - and already move the firmware related header files there. Signed-off-by: Johannes

[PATCH 29/31] iwlwifi: move notification wait into fw/

From: Johannes Berg Move the notification wait code into the new fw interaction directory. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/Makefile

[PATCH 30/31] iwlwifi: move configuration into sub-directory

From: Johannes Berg Since we now support 8 device families, move their configuration files into a new subdirectory "cfg". Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 24/31] iwlwifi: pcie: warn if paging is already initialized during init

From: Johannes Berg This appears to happen in some cases, like when iwlmvm is unloaded and loaded again without also unloading iwlwifi. Warn in this case and free the paging data to be able to continue without causing corruption and kernel crashes due to it (otherwise,

[PATCH 26/31] iwlwifi: mvm: fix deduplication start logic

From: Johannes Berg If the first frame on a given TID is received with seqno 0 and needed to be retransmitted, we erroneously drop it because the deduplication data is initialized to zero, and then comparing if (unlikely(ieee80211_has_retry(hdr->frame_control)

[PATCH 20/31] iwlwifi: mvm: change when the BT_COEX is sent

From: Emmanuel Grumbach The BT_COEX command should not be sent to the INIT firmware image starting from 8000 family. The firmware team also requested to send the BT_COEX command after the PHY_DB_CMD and the PHY_CFG_CMD. While at it:

Re: [PATCH] ieee80211: update public action codes

On 28-06-17 00:07, peter...@bowerswilkins.com wrote: > From: Peter Oh > > Update Public Action field values as updated in IEEE Std 802.11-2016, > so that modules/drivers can refer it. Hi Peter, I am pretty sure there are a lot of other definitions in the 802.11 spec

[PATCH 31/31] iwlwifi: mvm: remove version 2 of paging command

From: Johannes Berg Only a000-series devices were going to use this, but actually initialize using the context info, which includes paging, so this code is never invoked; remove it. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho

[PATCH 21/31] iwlwifi: mvm: support multi tid ba notif

From: Liad Kaufman When receiving a BA_NOTIF on new TX API, it can contain BAs for several TIDs. Go over them and reclaim TX for every TID. Note that although the small API change, the API version still isn't bumped forward, as this NIC isn't still officially released.

[PATCH 16/31] iwlwifi: mvm: use proper CDB check in PHY context modify

From: Johannes Berg When the firmware supports CDB, PHY contexts cannot be modified to change their band, but need to be added/remove instead. Instead of relying on iwl_mvm_has_new_tx_api(), check the right FW capa flag IWL_UCODE_TLV_CAPA_BINDING_CDB_SUPPORT and remove

Re: cw1200: add const to hwbus_ops structures

Bhumika Goyal wrote: > Declare hwbus_ops structures as const as they are only passed as an > argument to the function cw1200_core_probe. This argument is of type > const. So, make these structures const. > > Signed-off-by: Bhumika Goyal Patch applied to

Re: libertas: Fix lbs_prb_rsp_limit_set()

Dan Carpenter wrote: > The kstrtoul() test was reversed so this always returned -ENOTSUPP. > > Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with > kstrtoul()") > Signed-off-by: Dan Carpenter > Reviewed-by: James Cameron

Re: [v2 01/20] rsi: changes in eeprom read frame

Amitkumar Karwar writes: > From: Prameela Rani Garnepudi > > EEPROM read frame is sent during device initialization to read mac address. > The format of the frame is modified in firmware to include eeprom length > and offset. This frame does not

brcmfmac: BCM43431 won't get probed on Raspberry Pi Zero W

Hi, i'm currently working on Raspberry Pi Zero W for Mainline. Here is my first patch series [1]. Unfortunately i didn't get brcmfmac (connected via SDIO) probed with this patch series against 4.12.0-rc5-next-20170616+ [8.389167] brcmfmac: F1 signature read @0x1800=0x1541a9a6 [

[PATCH 15/31] iwlwifi: add twelve new 9560 series PCI IDs

From: Tzipi Peres Add twelve new PCI IDs for the 9560 series. Signed-off-by: Tzipi Peres Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 15 ++- 1 file changed, 14

[PATCH 14/31] iwlwifi: add the new a000_2ax series

From: Tzipi Peres Add a new config struct for the new a000 2ax series and add the five PCI ID for it. Signed-off-by: Tzipi Peres Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-a000.c | 10

[PATCH 19/31] iwlwifi: pcie: improve debug in iwl_pcie_rx_handle_rb()

From: Johannes Berg Print the queue for the existing debug message and add a new debug message indicating where the RB ended. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 13/31] iwlwifi: mvm: simplify CHECK_MLME_TRIGGER macro

From: Luca Coelho There's no reason to pass mvm and trig as parameters to the macro, since it will be expanded inside the function itself. Also remove the bogus buf parameter which doesn't exist and is not used. Signed-off-by: Luca Coelho

[PATCH 27/31] iwlwifi: mvm: rename iwl_shared_mem_cfg_v1 to the correct _v2

From: Johannes Berg This structure represents V2, V1 has the three last fields missing. Rename it to be more accurate. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 18/31] iwlwifi: mvm: support aggs of 64 frames in A000 family

From: Liad Kaufman A SCD bug was fixed in the A000 family, allowing to support aggregations of 64 frames (rather than 63). Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho ---

[PATCH 17/31] iwlwifi: pcie: improve "invalid queue" warning

From: Johannes Berg Print out both queue IDs to be able to see what went wrong. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 8 ++-- 1 file changed, 6

[PATCH 23/31] iwlwifi: pcie: make ctxt-info free idempotent

From: Johannes Berg By setting the pointers to NULL at the end, these functions are made idempotent. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info.c | 2

[PATCH 11/31] iwlwifi: pcie: fix 9000-series RF-kill interrupt propagation

From: Johannes Berg A hardware issue on 9000 series devices sometimes causes RF-kill interrupts to not be propagated to the host properly if ASPM is enabled. Work around this by setting the right hardware bit to allow it to interrupt the host for this reason (rfkill).

Re: [PATCH 19/31] iwlwifi: pcie: improve debug in iwl_pcie_rx_handle_rb()

On Wed, 2017-06-28 at 23:13 +0300, Luca Coelho wrote: > Print the queue for the existing debug message and add a new > debug message indicating where the RB ended. trivia: > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c > b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c [] > @@

Re: wl18xx: add checks on wl18xx_top_reg_write() return value

"Gustavo A. R. Silva" wrote: > Check return value from call to wl18xx_top_reg_write(), > so in case of error jump to goto label out and return. > > Also, remove unnecessary value check before goto label out. > > Addresses-Coverity-ID: 1226938 > Signed-off-by: Gustavo

Re: [v2 11/20] rsi: management frame descriptor preparation cleanup

Amitkumar Karwar writes: > From: "pavani.muthyala" > > Currently this descriptor is prepared with the help of __le16 > pointer. This patch makes use of a structure to prepare the > descriptor in a cleaner way. > > Signed-off-by:

Re: [PATCH] ieee80211: update public action codes

On 06/28/2017 01:16 PM, Arend van Spriel wrote: On 28-06-17 00:07, peter...@bowerswilkins.com wrote: From: Peter Oh Update Public Action field values as updated in IEEE Std 802.11-2016, so that modules/drivers can refer it. Hi Peter, I am pretty sure there are

Re: [v2 11/20] rsi: management frame descriptor preparation cleanup

Kalle Valo writes: > Amitkumar Karwar writes: > >> From: "pavani.muthyala" >> >> Currently this descriptor is prepared with the help of __le16 >> pointer. This patch makes use of a structure to prepare the >>

[PATCH 06/31] iwlwifi: mvm: use __le16 even for reserved fields

From: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/31] iwlwifi: mvm: Add debugfs entry to retrieve SAR geographic profile

From: Haim Dreyfuss Add a debugfs entry to get a verbose description of the power settings used in each band with the currently selected SAR geographic profile. Signed-off-by: Haim Dreyfuss Signed-off-by: Luca Coelho

[PATCH 08/31] iwlwifi: mvm: fix a bunch of kernel-doc warnings

From: Johannes Berg Fix the kernel-doc, and remove some fields even the firmware doesn't use in ToF, RX, scan, station and generic FW APIS. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 04/31] iwlwifi: mvm: fix various "Excess ... description" kernel-doc warnings

From: Johannes Berg Fix various "Excess struct/union/enum/typedef member '...' description in '...'" warnings from kernel-doc, mostly caused by typos. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 03/31] iwlwifi: mvm: remove some CamelCase from firmware API

From: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-d3.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h| 4 ++-- 2 files changed,

[PATCH 07/31] iwlwifi: mvm: add documentation for all command IDs

From: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-fw-api.h| 24 ++ drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c| 18 --

[PATCH 01/31] iwlwifi: mvm: refactor geo init

From: Haim Dreyfuss We are going to add debugfs entry to retrieve the current geographic profile being used in the FW. Currently the driver reads those tables from the BIOS and passes them to the FW. To prepare for this retrieving we want to store those tables in the

[PATCH 09/31] iwlwifi: dvm: use macros for format strings

From: Johannes Berg Some static checkers (e.g. smatch) complain if a non-constant format string is used, even if that's a static const variable. Since there's no impact on code generation, just change those format strings to be macros. Signed-off-by: Johannes Berg

[PATCH 10/31] iwlwifi: pcie: only apply retention workaround on 9000-series A-step

From: Johannes Berg Due to a hardware issue, certain power saving had to be disabled. However, this issue was fixed in B-step, so the workaround only needs to apply to A-step. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho

[PATCH 05/31] iwlwifi: mvm: remove various unused command IDs/structs

From: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 28 - drivers/net/wireless/intel/iwlwifi/mvm/ops.c| 11

[PATCH 25/31] iwlwifi: mvm: unconditionally stop device after init

From: Johannes Berg In commit b93b1fe3b532 ("iwlwifi: mvm: fix init_dbg flow to work as expected"), the code was changed to make the stop conditional on not having failed (and on not having init_dbg), which doesn't make sense - we should stop the device regardless of

[PATCH 12/31] iwlwifi: mvm: change sta_id to u8

From: Sharon Dvir The sta_id variable is used as an index in an array, should be unsigned. Found by Klocwork. Fixes: 9f9af3d7d303 ("iwlwifi: mvm: re-aggregate shared queue after unsharing") Signed-off-by: Sharon Dvir Signed-off-by: Luca Coelho

Re: [PATCH 00/31] iwlwifi: updates intended for v4.13 2017-06-28

On Wed, 2017-06-28 at 23:12 +0300, Luca Coelho wrote: > From: Luca Coelho > > Hi Kalle, > > Here is one more batch that I'd like to get into v4.13, hopefully it's > not too late. I'm also going to send some more tomorrow. The changes > are: > > * Some important

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 21:10 +0200, Lubomir Rintel wrote: > On Wed, 2017-06-28 at 17:02 +0200, Johannes Berg wrote: > > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > > The mac80211_hwsim doesn't offer a way to disable the debugging > > > output. > > > Unfortunately, it's pretty

[PATCH 00/31] iwlwifi: updates intended for v4.13 2017-06-28

From: Luca Coelho Hi Kalle, Here is one more batch that I'd like to get into v4.13, hopefully it's not too late. I'm also going to send some more tomorrow. The changes are: * Some important fixes for 9000 HW; * FW API changes for the upcoming -30 ucode release; * A

Re: ti: wl18xx: add checks on wl18xx_top_reg_write() return value

Quoting Kalle Valo : "Gustavo A. R. Silva" wrote: Check return value from call to wl18xx_top_reg_write(), so in case of error jump to goto label out and return. Also, remove unnecessary value check before goto label out.

Re: Adding nfc-next to linux-next

Hi Samuel, On Wed, 28 Jun 2017 09:25:31 +0200 Samuel Ortiz wrote: > > Could you please add the nfc-next tree to linux-next? > > It's here: > > https://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git/ > > and the branch is the master one. Added from today.

brcmfmac4356-pci device not seeing 2.4Ghz channel 12 and 13

Hi, I noticed today that my GPD Win (x86 clamshell mini laptop) which uses a brcmfmac4356-pci wifi does not see an APs which is using channel 13. I've tried updating brcmfmac4356-pci.txt changing "ccode=US" to "ccode=EU" and then rebooted, but that does not help. I believe that the Linux wifi

pull-request: iwlwifi-next 2017-06-28

Hi Kalle, Here's my second pull-request intended for v4.13.  Again, this pull- request includes the last two patchsets I sent out.  It contains generic development work, with improvements, bug fixes and cleanup all around.  More details in the tag description. I have sent this out before, and

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > The mac80211_hwsim doesn't offer a way to disable the debugging output. > Unfortunately, it's pretty chatty, dumping a lot of stuff into the message > buffer. > > This patch changes it to use dyndbg for controlling the debug output. >

Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure

On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote: > Declare thermal_cooling_device_ops structure as const as it is only passed > as an argument to the function thermal_cooling_device_register and this > argument is of type const. So, declare the structure as const. > > Signed-off-by:

Re: [PATCH] iwlwifi: mvm: fix iwl_mvm_sar_find_wifi_pkg corner case

On Tue, 2017-06-27 at 17:24 +0200, Arnd Bergmann wrote: > gcc warns about what it thinks is an uninitialized variable > access: > > drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function > 'iwl_mvm_sar_find_wifi_pkg.isra.14': > drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1102:5: error:

[PATCH] rtlwifi: Remove unused dummy function

Removing unused dummy function Signed-off-by: Souptick Joarder --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 12 drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 3 --- 3 files

[PATCH] mac80211_hwsim: use dyndbg for debug messages

The mac80211_hwsim doesn't offer a way to disable the debugging output. Unfortunately, it's pretty chatty, dumping a lot of stuff into the message buffer. This patch changes it to use dyndbg for controlling the debug output. It's disabled by default, but can be enabled by a module parameter (1),

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > The mac80211_hwsim doesn't offer a way to disable the debugging > output. > Unfortunately, it's pretty chatty, dumping a  lot of stuff into the > message buffer. Why is this a problem? It's pretty much a testing tool only, and much of the

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 06:37 -0700, Joe Perches wrote: > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > The mac80211_hwsim doesn't offer a way to disable the debugging > > output. > > Unfortunately, it's pretty chatty, dumping a  lot of stuff into the > > message > > buffer. > > > >

[PATCH v3 00/10] Set 3 of changes related to updates of btcoexist

To get maximum benefit of the recent changes in btcoexist, changes need to be made in the drivers for the NIC. This is set 3 of those changes. v2 - remove \r characters as suggested by Joe Perches v3 - remove those \r characters missed in v2 Ping-Ke Shih (10): rtlwifi: Fill in_4way field by

[PATCH v3 05/10] rtlwifi: Update 8723be new phy parameters and its parser.

From: Ping-Ke Shih There are new PHY table values for the RTL8723BE. The changes require new parsing code. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH v3 02/10] rtlwifi: Add BT_MP_INFO to c2h handler.

From: Ping-Ke Shih We use H2C to ask BT's status, and C2H will return the status. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc:

[PATCH v3 06/10] rtlwifi: Rename rtl_desc92_rate to rtl_desc_rate

From: Ping-Ke Shih This is a common enumeration, so we use a common name. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu

[PATCH v3 03/10] rtlwifi: Add board type for 8723be and 8192ee

From: Ping-Ke Shih With correct board_type, the phy praser can choose correct parameters. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH v3 01/10] rtlwifi: Fill in_4way field by driver

From: Ping-Ke Shih Because it isn't always correct to use EAPOL to check 4-way, we add a timer to handle exception. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc:

[PATCH v3 04/10] rtlwifi: add amplifier type for 8812ae

From: Ping-Ke Shih With correct amplifier_type, the phy praser can choose correct parameters. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH v3 08/10] rtlwifi: move IS_HARDWARE_TYPE_xxx checker to wifi.h

From: Ping-Ke Shih Use rtlpriv instead of rtlhal as argument, so driver and btcoex use the same definitions. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH v3 07/10] rtlwifi: Uses addr1 instead DA to determine broadcast and multicast addr.

From: Ping-Ke Shih We should check addr1 to indicate a packet as broadcast or multicast in tx desc. An obvious example, a STA transmit an *unicast* ARP packet where addr1 and DA are the addresses of AP and broadcast respectively. Signed-off-by: Ping-Ke Shih

[PATCH v3 10/10] rtlwifi: btcoex: Use seq_file to dump btcoex status

From: Ping-Ke Shih If we use seq_file to dump status, then we can use 'cat' to access debugfs. Other related changes are 1. implement btc_disp_dbg_msg() to access btcoex's common status. 2. remove obsolete field bt_exist Signed-off-by: Ping-Ke Shih

[PATCH v3 09/10] rtlwifi: use debugfs to debug.

From: Ping-Ke Shih Use debugfs to dump register and btcoex status. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu

Re: ath9k: remove useless variable assignment in ath_mci_intr()

"Gustavo A. R. Silva" wrote: > Value assigned to variable offset at line 551 is overwritten at line 562, > before it can be used. This makes such variable assignment useless. > > Addresses-Coverity-ID: 1226941 > Signed-off-by: Gustavo A. R. Silva

Re: [1/3] ath9k: fixed an invalid pointer dereference

miaoqing pan wrote: > The bug was triggered when do suspend/resuming continuously > on Dell XPS L322X/0PJHXN version 9333 (2013) with kernel > 4.12.0-041200rc4-generic. But can't reproduce on DELL > E5440 + AR9300 PCIE chips. > > The warning is caused by accessing

Re: [1/2] ath9k: fix tx99 use after free

miaoqing pan wrote: > One scenario that could lead to UAF is two threads writing > simultaneously to the "tx99" debug file. One of them would > set the "start" value to true and follow to ath9k_tx99_init(). > Inside the function it would set the sc->tx99_state to true >

Re: ath10k: add const to thermal_cooling_device_ops structure

Bhumika Goyal wrote: > Declare thermal_cooling_device_ops structure as const as it is only passed > as an argument to the function thermal_cooling_device_register and this > argument is of type const. So, declare the structure as const. > > Signed-off-by: Bhumika Goyal

Re: [1/3] ath9k: fixed an invalid pointer dereference

miaoqing pan wrote: > The bug was triggered when do suspend/resuming continuously > on Dell XPS L322X/0PJHXN version 9333 (2013) with kernel > 4.12.0-041200rc4-generic. But can't reproduce on DELL > E5440 + AR9300 PCIE chips. > > The warning is caused by accessing

Re: [PATCH v2] rtlwifi: Replace hardcode value with macro

Souptick Joarder writes: > In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval > and hw->max_rate_tries are replaced by macro. > > Signed-off-by: Souptick Joarder > --- > Changes in v2: >- Signed-off was missing in previous one. >

Re: [PATCH] rsi: add in missing RSI_FSM_STATES into array fsm_state

Colin King writes: > From: Colin Ian King > > Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED > and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state > was not updated to match. This can lead to an array

Re: ti: wl18xx: add checks on wl18xx_top_reg_write() return value

"Gustavo A. R. Silva" wrote: > Check return value from call to wl18xx_top_reg_write(), > so in case of error jump to goto label out and return. > > Also, remove unnecessary value check before goto label out. > > Addresses-Coverity-ID: 1226938 > Signed-off-by: Gustavo

Re: [-next] ath10k: fix a bunch of spelling mistakes in messages

Colin Ian King wrote: > Fix the following spelling mistakes in messages: > syncronise -> synchronize > unusally -> unusually > addrress -> address > inverval -> interval > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo

[PATCH] mwifiex: fix spelling mistake: "secuirty" -> "security"

From: Colin Ian King Trivial fix to spelling mistake in mwifiex_dbg message Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/4] brcmfmac: rework headroom check in .start_xmit()

Arend van Spriel writes: > On 27-06-17 16:09, Kalle Valo wrote: >> Arend van Spriel writes: >> >>> Since commit 9cc4b7cb86cb ("brcmfmac: Make skb header writable >>> before use") the headroom usage has been fixed. However, the >>>

Re: pull-request: iwlwifi-next 2017-06-28

Luca Coelho writes: > Hi Kalle, > > Here's my second pull-request intended for v4.13.  Again, this pull- > request includes the last two patchsets I sent out.  It contains generic > development work, with improvements, bug fixes and cleanup all around.  > More details in the tag

Re: [net-next] qtnfmac: fix uninitialized return code in ret

Colin Ian King wrote: > From: Colin Ian King > > The return value ret is unitialized and garbage is being returned > for the three different error conditions when setting up the PCIe > BARs. Fix this by initializing ret to -ENOMEM to

Re: [v2, 1/8] rtlwifi: Fix a2dp choppy while BT RSSI stays on threshold.

Larry Finger wrote: > From: Ping-Ke Shih > > In this case, BTC asks to enter/leave PS mode frequently to cause A2DP > choppy. > > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry Finger > Cc:

Re: mwifiex: Do not change bss_type in change_virtual_intf

Ganapathi Bhat wrote: > When user adds a virtual interface driver will set the > bss_type to the iface_type given by the user. When > supplicant is started on the same interface, a call to > change_virtual_intf will be triggered if if_type is not > NL80211_IFTYPE_STATION. Here

Re: [1/4] brcmfmac: cleanup kerneldoc for struct brcmf_bus

Arend Van Spriel wrote: > A couple of old fields were still described and one field was not > described. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Franky

Re: rsi: add in missing RSI_FSM_STATES into array fsm_state

Colin Ian King wrote: > From: Colin Ian King > > Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED > and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state > was not updated to match. This can lead to an

Re: [PATCH 05/14] mwifiex: re-register wiphy across reset

Hi Brian, > Wow, that's not exactly simple code; I expect it could be pretty > difficult to get that right today on mwifiex. Yeah, I have no doubt. You'd probably have to track a lot of state that you just pass down to the firmware too, and possibly can't even track some state that the firmware

Re: [PATCH 05/14] mwifiex: re-register wiphy across reset

On Tue, 2017-06-27 at 13:48 -0700, Brian Norris wrote: > > There isn't really a good way to do this. You can, of course, call > > wiphy_unregister(), but if you could do that you'd already have the > > problem solved, I think? > > That's probably along the right track. There are still some

[PATCH] rtlwifi: remove dummy function call

_rtl92cu_init_usb_aggregation() can be removed as it is dummy one Signed-off-by: Souptick Joarder --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c

[PATCH] mwifiex: don not update MCS set from hostapd

We should not copy the MCS set from hostapd RX-STBC. We have to just use the MCS set supported by the hardware. This fixes an issue, where mwifiex is advertising wrong MCS sets in beacons. Fixes: 474a41e94 ("mwifiex: update MCS set as per RX-STBC bit from hostapd") Signed-off-by: Ganapathi Bhat

Re: [PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

Hi Geoff, On Thu, Apr 27, 2017 at 05:28:46PM -0400, Geoff Lansberry wrote: > In prior commits the selected clock frequency does not propagate > correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- >

Re: [PATCH 00/17] rsi: station enhancements

On Tue, Jun 27, 2017 at 7:56 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> We have internal management frames(commands) sent to firmware for >> various configurations. This patch defines some common structures >> which can be shared by those