Re: [PATCH] mac80211: support FTM responder configuration/statistics

2018-10-29 Thread Pradeep Kumar Chitrapu
memset(, 0, sizeof(params)); + params.beacon_csa.ftm_responder = -1; Hi Johannes, Agree with the rest, however, I think this may not be needed because ftm_responder is already being set to -1, if NL80211_ATTR_FTM_RESPONDER attribute is not included, in nl80211_parse_beacon,

[PATCH 3/3] mt76x0: phy: use tssi reported value to configure tx power if available

2018-10-29 Thread Lorenzo Bianconi
Use tssi calibrated value to configure tx power gain if tssi is enabled in eeprom data Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x0/eeprom.c| 20 +++ .../net/wireless/mediatek/mt76/mt76x0/phy.c | 2 +- 2 files changed, 17 insertions(+), 5

[PATCH 1/3] mt76: move mt76x02_eeprom_copy in mt76x02-lib module

2018-10-29 Thread Lorenzo Bianconi
Move mt76x02_eeprom_copy utility routine in mt76x02-lib module in order to be reused by mt76x0 driver adding tssi calibration support Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x02_eeprom.c | 12 .../net/wireless/mediatek/mt76/mt76x02_eeprom.h | 3

[PATCH 0/3] mt76x0: add tssi calibration support

2018-10-29 Thread Lorenzo Bianconi
Introduce tssi calibration support in mt76x0 driver. Configure tx power gain according to tssi calibrated value if available Lorenzo Bianconi (3): mt76: move mt76x02_eeprom_copy in mt76x02-lib module mt76x0: phy: introduce tssi calibration support mt76x0: phy: use tssi reported value to

[PATCH 2/3] mt76x0: phy: introduce tssi calibration support

2018-10-29 Thread Lorenzo Bianconi
Run mt76x0 tssi calibration process if enabled in eeprom data. Perform calibration procedure every 4s Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/phy.c | 355 +- drivers/net/wireless/mediatek/mt76/mt76x02.h | 3 +

Re: [PATCH 04/19] wilc: add host_interface.c

2018-10-29 Thread Adham.Abozaeid
On 10/29/18 1:10 PM, Johannes Berg wrote: >>> I'd argue for trying it though as it makes the code MUCH simpler. >> I totally agree that it will be simpler to do the work directly from >> the cfg context rather than scheduling it. >> On a cortex A5 MPU and SPI bus running on 48Mhz, this takes 20ms

Re: [PATCH 04/19] wilc: add host_interface.c

2018-10-29 Thread Johannes Berg
> > I'd argue for trying it though as it makes the code MUCH simpler. > > I totally agree that it will be simpler to do the work directly from > the cfg context rather than scheduling it. > On a cortex A5 MPU and SPI bus running on 48Mhz, this takes 20ms in > the idle case, and 100 to 300ms in

Re: [PATCH 1/3] brcmfmac: calling skb_orphan before sending skb to SDIO bus

2018-10-29 Thread Franky Lin
On Mon, Oct 29, 2018 at 3:27 AM Wright Feng wrote: > > Linux 3.6 introduces TSQ which has a per socket threshold for TCP Tx > packets to reduce latency. In fcmode 1 and fcmode 2, host driver enqueues > skb in hanger and TCP doesn't push new skb until host frees the skb when > receiving fwstatus

Re: [PATCH] mac80211: support FTM responder configuration/statistics

2018-10-29 Thread Pradeep Kumar Chitrapu
Yes, but we may not get there? if (!need_new_beacon) goto skip_beacons; ah!..yes...Thanks..

[PATCH] mt76x2u: init: use common routines for wcid/key initialization

2018-10-29 Thread Lorenzo Bianconi
Use mt76x02_mac_wcid_setup and mt76x02_mac_shared_key_setup for shared keys and wcid table initialization and remove duplicated code Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x2/usb_init.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff

Re: [PATCH 12/19] wilc: add wilc_wfi_cfgoperations.c

2018-10-29 Thread Johannes Berg
Hi, Sorry for the late reply. On Fri, 2018-10-19 at 21:47 +, adham.aboza...@microchip.com wrote: > > Johannes, shadow buffer has 2 more usage that I missed in my first email: > 1- It keeps a copy of scan results to be able to auto-select from if > the cfg80211 didn't supply a specific bssid

Re: [PATCH] mac80211: support FTM responder configuration/statistics

2018-10-29 Thread Johannes Berg
On Mon, 2018-10-29 at 11:59 -0700, Pradeep Kumar Chitrapu wrote: > > memset(, 0, sizeof(params)); > > + params.beacon_csa.ftm_responder = -1; > > Hi Johannes, > > Agree with the rest, however, I think this may not be needed because > ftm_responder is already being set to -1, > if

Re: [PATCH 04/19] wilc: add host_interface.c

2018-10-29 Thread Johannes Berg
On Mon, 2018-10-29 at 21:32 +, adham.aboza...@microchip.com wrote: > > Correct. The speed of executing the work will be the same in both > cases (maybe a little slower in case of deferring the work) > The intuition here was to do minimum work in the cfg's context, but > since this isn't a

Re: [PATCH 12/19] wilc: add wilc_wfi_cfgoperations.c

2018-10-29 Thread Adham.Abozaeid
On 10/29/18 1:11 PM, Johannes Berg wrote: > Hi, > > Sorry for the late reply. No worries! Thanks for taking the time to review the driver. > > On Fri, 2018-10-19 at 21:47 +, adham.aboza...@microchip.com wrote: >> Johannes, shadow buffer has 2 more usage that I missed in my first email: >> 1-

[PATCH 0/3] brcmfmac: throughput enhancement for SDIO and flow control mode

2018-10-29 Thread Wright Feng
These are for throughput enhancement with SDIO bus or with flow control mode enabled, and also introuce a new module parameter to enhance TX throughput as well. Wright Feng (3): brcmfmac: calling skb_orphan before sending skb to SDIO bus brcmfmac: add credit numbers updating support

[PATCH 1/3] brcmfmac: calling skb_orphan before sending skb to SDIO bus

2018-10-29 Thread Wright Feng
Linux 3.6 introduces TSQ which has a per socket threshold for TCP Tx packets to reduce latency. In fcmode 1 and fcmode 2, host driver enqueues skb in hanger and TCP doesn't push new skb until host frees the skb when receiving fwstatus event. So using skb_orphan before sending skb to bus will make

[PATCH 2/3] brcmfmac: add credit numbers updating support

2018-10-29 Thread Wright Feng
The credit numbers are static and tunable per chip in firmware side. However the credit number may be changed that is based on packet pool length and will send BRCMF_E_FIFO_CREDIT_MAP event to notify host driver updates the credit numbers during interface up. The purpose of this patch is making

[PATCH] mt76x0: run calibration after scanning

2018-10-29 Thread Stanislaw Gruszka
If we are associated and scanning is performed , sw_scan_complete callback is done after we get back to operating channel, so we do not perform phy calibration and queue cal work. Fix this by run calibration from sw_scan_complete(). Fixes: bbd10586f0df ("mt76x0: phy: do not run calibration during

[PATCH 3/3] brcmfmac: make firmware frameburst mode a module parameter

2018-10-29 Thread Wright Feng
This patch is for adding a new module parameter "frameburst". With setting "frameburst=1" in module parameters, firmware frameburst mode will be enabled. The feature can enable per-packet framebursting in firmware side and get higher TX throughput in High Throughput(HT) mode. Signed-off-by:

[PATCH v2 0/4] staging: wilc1000: validate input to set_wiphy_param and return proper errors

2018-10-29 Thread Adham.Abozaeid
From: Adham Abozaeid Validate input parameters to set_wiphy_param before scheduling handle_cfg_param() to validate them. This way proper errors can be returned to caller. Also cleaned up unused code in handle_cfg_param. Changes since v1: - Correction spelling in subject of patch#2

[PATCH v2 2/4] staging: wilc1000: validate cfg parameters before scheduling the work

2018-10-29 Thread Adham.Abozaeid
From: Adham Abozaeid Validate cfg parameters after being called by cfg80211 in set_wiphy_params before scheduling the work executed in handle_cfg_param Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 61 ++-

[PATCH v2 1/4] staging: wilc1000: remove unused flags in handle_cfg_param()

2018-10-29 Thread Adham.Abozaeid
From: Adham Abozaeid handle_cfg_param() receives a bit map that describes what to be changed. Some of these bits flags aren't referred to from elsewhere and can be removed. Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 216 --

[PATCH v2 3/4] staging: wilc1000: Don't keep a copy of wiphy parameters in the driver

2018-10-29 Thread Adham.Abozaeid
From: Adham Abozaeid host_if_drv.cfg_values is a write only member, and can be removed Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 13 - drivers/staging/wilc1000/host_interface.h | 1 - 2 files changed, 14 deletions(-) diff --git

[PATCH v2 4/4] staging: wilc1000: Remove unused mutex cfg_values_lock

2018-10-29 Thread Adham.Abozaeid
From: Adham Abozaeid After removing cfg_values member, cfg_values_lock that was used to protect it can also be removed. Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interface.c | 9 - drivers/staging/wilc1000/host_interface.h | 2 -- 2 files changed, 11 deletions(-)

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-29 Thread Ajay.Kathat
On 10/29/2018 8:26 PM, Kalle Valo wrote: > Ajay Singh writes: > >> On 10/9/2018 4:06 PM, Johannes Berg wrote: >>> On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: >>> >> +typedef void (*wilc_remain_on_chan_expired)(void *, u32); >> +typedef void (*wilc_remain_on_chan_ready)(void *);

[PATCH] staging: wilc1000: update wilc1000 driver maintainer ids

2018-10-29 Thread Ajay.Kathat
From: Ajay Singh We would like to update the maintainer email id's for wilc1000 driver. Signed-off-by: Ajay Singh Signed-off-by: Adham Abozaeid --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7c7af53..9647ec7 100644 ---

Re: [PATCH] mt76x0: run calibration after scanning

2018-10-29 Thread Kalle Valo
Stanislaw Gruszka writes: > If we are associated and scanning is performed , sw_scan_complete callback > is done after we get back to operating channel, so we do not perform > phy calibration and queue cal work. Fix this by run calibration from > sw_scan_complete(). > > Fixes: bbd10586f0df

Re: [RFC v3] cfg80211: add peer measurement with FTM API

2018-10-29 Thread Kalle Valo
Johannes Berg writes: > On Sat, 2018-10-13 at 12:55 +0300, Kalle Valo wrote: >> >> > struct cfg80211_ops { >> >int (*suspend)(struct wiphy *wiphy, struct cfg80211_wowlan *wow); >> >> It would be nice to document if these ops can sleep or not. > > I don't think we've documented that

Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets

2018-10-29 Thread Kalle Valo
Sergey Matyukevich writes: >> > +config QTNFMAC_TOPAZ_PCIE >> > + tristate "Quantenna QSR1000/QSR2000 PCIe support" >> > + default n >> > + depends on PCI && CFG80211 >> > + select QTNFMAC >> > + select FW_LOADER >> > + select CRC32 >> > + help >> > + This

[PATCH] mt76x2u: init: remove not useful configuration

2018-10-29 Thread Lorenzo Bianconi
Remove MT_TSO_CTRL and MT_HEADER_TRANS_CTRL_REG initialization since it is already done in mt76_write_mac_initvals routine Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH] mt76x0: use band parameter for LC calibration

2018-10-29 Thread Kalle Valo
Stanislaw Gruszka writes: > We use always 1 as band parameter for MCU_CAL_LC, this break 2GHz, > we should use 0 for this band instead. > > Patch fixes problems happened sometimes when try to associate with 2GHz > AP and manifest by errors like below: > > [14680.920823] wlan0: authenticate with

Re: [PATCH 03/19] wilc: add host_interface.h

2018-10-29 Thread Kalle Valo
Ajay Singh writes: > On 10/9/2018 4:06 PM, Johannes Berg wrote: >> On Tue, 2018-10-09 at 16:04 +0530, Ajay Singh wrote: >> > +typedef void (*wilc_remain_on_chan_expired)(void *, u32); > +typedef void (*wilc_remain_on_chan_ready)(void *); >>> I think as per coding style the typedef for