Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On 7 March 2016 at 19:28, Dave Taht wrote: > On Mon, Mar 7, 2016 at 9:14 AM, Avery Pennarun wrote: >> On Mon, Mar 7, 2016 at 11:54 AM, Dave Taht wrote: [...] >>> the underlying code needs to be striving successfully for per-station >>> airtime fairness for this to work at all, and the driver/car

[PATCH] mwifiex: Empty Tx queue during suspend

In cfg80211 suspend handler, stop the netif queue and wait until all the Tx queues become empty. Start the queues in resume handler. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-)

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On 8 March 2016 at 00:06, Dave Taht wrote: > Dear Michal: > > Going through this patchset... (while watching it compile) > > > + if (!local->hw.txq_cparams.target) > + local->hw.txq_cparams.target = MS2TIME(5); > > MS2TIME(20) for now and/or add something saner to this than !*b

per sta queuing - the ath9k statistics

I have put together some of the patches for fq_codel and per-station queuing inside the mac80211 portion of the stack flying around on linux-wireless, to no real visible effect as yet. Mostly testing uploads at the moment, from an x86 based client. It's not clear if I have the code path enabled, e

[PATCH] ath9k: fix reg dump data bus error

From: Miaoqing Pan Changes: - restrict only dump MAC registers - skip the register memory holes Data bus error, epc == 831d4040, ra == 831d403c Oops[#1]: CPU: 0 PID: 1536 Comm: cat Not tainted 3.14.0 #3 task: 82f87840 ti: 82f88000 task.ti: 82f88000 $ 0 : 0001 deadc0de 1000fc03 $

[PATCH] staging: wilc1000: use mutex instead of semaphore sem_cfg_values

This patch replaces struct semaphore sem_cfg_values with struct mutex cfg_values_lock. It is better to use mutex than semaphore. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 6 insert

[PATCH] ath6kl: ignore WMI_TXE_NOTIFY_EVENTID based on fw capability flags

Certain 6004 firmware releases redefine the WMI_TXE_NOTIFY_EVENTID event number and sends the new event frequently. However it doesn't have the tx-err-notify feature and thus this firmware capability flag isn't set on the firmware package. By guarding the processing of this event by the same method

[PATCH 4/5] ti: wl1251: Convert wl1251_notice to wiphy_info/pr_info

Use the more common logging mechanisms. Convert to wiphy_info as these wl1251_notice uses were actually emitted at KERN_INFO. Signed-off-by: Joe Perches --- drivers/net/wireless/ti/wl1251/main.c | 4 ++-- drivers/net/wireless/ti/wl1251/sdio.c | 2 +- drivers/net/wireless/ti/wl1251/wl1251.h

[PATCH 1/5] ti: Convert wl1271_ logging macros to dev_ or pr_

Use the more common logging mechanism passing wl->dev where appropriate. Remove the macros. Add argument struct wl1271 *wl to some functions to make these logging mechanisms work. Miscellanea: o Coalesce formats, add required trailing \n to formats Some formats already had previously incorrec

[PATCH 5/5] ti: wl1251: Convert wl1251_info to wl1251_debug

These logging messages are always emitted at KERN_DEBUG. Add a DEBUG_ALWAYS enum to the debug type enum and convert the macro and uses from wl1251_info( to wl1251_debug(DEBUG_ALWAYS, Miscellanea: o Remove the now unused wl1251_info macro Signed-off-by: Joe Perches --- drivers/net/wireless/ti/

[PATCH 3/5] ti: wl1251: Convert wl1251_warning to wiphy_warn

Use the more common logging mechanism. Miscellanea: o Coalesce formats o Realign arguments o Reflow to fit 80 columns Signed-off-by: Joe Perches --- drivers/net/wireless/ti/wl1251/acx.c| 91 - drivers/net/wireless/ti/wl1251/cmd.c| 10 ++-- drivers/net/wi

[PATCH 2/5] ti: wl1251: Convert wl1251_error to wiphy_err/pr_err

Use the more common logging mechanisms. Miscellanea: o Coalesce formats o Realign arguments o Reflow to fit 80 columns o Add #define pr_fmt when pr_ is used Signed-off-by: Joe Perches --- drivers/net/wireless/ti/wl1251/acx.c| 6 ++--- drivers/net/wireless/ti/wl1251/boot.c | 18 +++--

[PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Using the normal kernel logging mechanisms makes this code a bit more like other wireless drivers. Joe Perches (5): ti: Convert wl1271_ logging macros to dev_ or pr_ ti: wl1251: Convert wl1251_error to wiphy_err/pr_err ti: wl1251: Convert wl1251_warning to wiphy_warn ti: wl1251: Convert wl

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

Dear Michal: Going through this patchset... (while watching it compile) + if (!local->hw.txq_cparams.target) + local->hw.txq_cparams.target = MS2TIME(5); MS2TIME(20) for now and/or add something saner to this than !*backlog target will not be a constant in the long run. +

Re: About adding support for MT76x2U to Linux kernel

On 2016-03-07 13:41, Johannes Stezenbach wrote: > On Mon, Mar 07, 2016 at 12:51:43PM +0100, Felix Fietkau wrote: >> On 2016-03-07 12:14, Johannes Stezenbach wrote: >> > FWIW, the mt7610u vendor driver >> > doesn't support AP mode, while the mt7612u vendor driver does, >> > but I didn't understand h

Re: [01/21] brcmfmac: change function name forbrcmf_cfg80211_wait_vif_event_timeout()

On Mon, Mar 7, 2016 at 1:49 PM, Kalle Valo wrote: > Kalle Valo writes: > >> 1 patches skipped: >> >> [17/21] brcmfmac: fix sdio sg table alloc crash >> >> There was a conflict so please rebase that patch: >> >> Applying: brcmfmac: fix sdio sg table alloc crash >> fatal: sha1 information is lackin

Re: pull-request: wireless-drivers 2016-03-04

From: Kalle Valo Date: Fri, 04 Mar 2016 18:26:38 +0200 > three more fixes I would like to get to 4.5 still. It's getting late but > I think these are still justified and these have been in linux-next > almost a week. But if you think otherwise please let me know and I'll > pull these to wireless-

Re: [PATCH V11 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature

On Mon, Mar 7, 2016 at 1:52 PM, Kalle Valo wrote: > Arend van Spriel writes: > >> Announce support for nl80211 feature BSS_SELECT and process >> BSS selection behaviour provided in .connect() callback. >> >> Reviewed-by: Hante Meuleman >> Reviewed-by: Franky (Zhenhui) Lin >> Reviewed-by: Pieter

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On Mon, Mar 7, 2016 at 9:14 AM, Avery Pennarun wrote: > On Mon, Mar 7, 2016 at 11:54 AM, Dave Taht wrote: >> If I can just get a coherent patch set that I can build, I will gladly >> join you on the testing ath9k in particular... can probably do ath10k, >> too - and do a bit of code review... thi

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On 03/07/2016 07:15 PM, Avery Pennarun wrote: > On Mon, Mar 7, 2016 at 11:54 AM, Dave Taht wrote: >> If I can just get a coherent patch set that I can build, I will gladly >> join you on the testing ath9k in particular... can probably do ath10k, >> too - and do a bit of code review... this week.

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On Mon, Mar 7, 2016 at 11:54 AM, Dave Taht wrote: > If I can just get a coherent patch set that I can build, I will gladly > join you on the testing ath9k in particular... can probably do ath10k, > too - and do a bit of code review... this week. it's very exciting > watching all this activity... >

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

If I can just get a coherent patch set that I can build, I will gladly join you on the testing ath9k in particular... can probably do ath10k, too - and do a bit of code review... this week. it's very exciting watching all this activity... but I confess that I've totally lost track of what set of t

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On Mon, Mar 7, 2016 at 10:09 AM, Felix Fietkau wrote: > On 2016-03-07 15:05, Avery Pennarun wrote: >> On Fri, Mar 4, 2016 at 1:32 AM, Michal Kazior >> wrote: >>> On 4 March 2016 at 03:48, Tim Shepard wrote: >>> [...] (I am interested in knowing what other mac80211 drivers have been m

Re: [RFC v1] mac80211: Add support for per station rx stats histogram

Hi Johannes and all, kindly share your thoughts regarding the draft change (I can share the test results as well and sample dump). This is an implementation of Rx statistics (histogram for each of the clients connected under mac80211 station debugfs). Attached is a sample dump, tested in Openwrt

[RFC] mac80211: Add support for per station rx stats histogram

From: Mohammed Shafi Shajakhan Enable a provision in mac80211 'MAC80211_DEBUG_PER_STA_RX_STATS' to keep track and dump per station stats. Dump rx pkts / bytes per {MCS, BW, NSS, GI} per station in histogram format. Rx stats provides a history of the receive stats of the stations connected to us.

[RFC v1] mac80211: Add support for per station rx stats histogram

From: Mohammed Shafi Shajakhan Enable a provision in mac80211 'MAC80211_DEBUG_PER_STA_RX_STATS' to keep track and dump per station stats. Dump rx pkts / bytes per {MCS, BW, NSS, GI} per station in histogram format. Rx stats provides a history of the receive stats of the stations connected to us.

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On 2016-03-07 15:05, Avery Pennarun wrote: > On Fri, Mar 4, 2016 at 1:32 AM, Michal Kazior wrote: >> On 4 March 2016 at 03:48, Tim Shepard wrote: >> [...] >>> (I am interested in knowing what other mac80211 drivers have been >>> modified to use the mac80211 intermediate software queues. I know

Re: [PATCH] rtlwifi: Fix size of wireless mode variable

On 03/07/2016 06:38 AM, Kalle Valo wrote: Larry Finger writes: Smatch reports the following warning: CHECK drivers/net/wireless/realtek/rtlwifi/rc.c drivers/net/wireless/realtek/rtlwifi/rc.c:144 _rtl_rc_rate_set_series() warn: impossible condition '(wireless_mode == 256) => (0-255 == 25

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

On Fri, Mar 4, 2016 at 1:32 AM, Michal Kazior wrote: > On 4 March 2016 at 03:48, Tim Shepard wrote: > [...] >> (I am interested in knowing what other mac80211 drivers have been >> modified to use the mac80211 intermediate software queues. I know >> Michal mentioned he has patches for ath10k t

Re: pull request: iwlwifi-next 2016-03-02

"Grumbach, Emmanuel" writes: > This is a pull request for 4.6. It is big because a lot of patches were > waiting for code in mac80211-next which is now in net-next. > As you figured, I need you to pull Johannes's > mac80211-next-for-davem-2016-02-26 before you pull this from me. > Of course, you

Re: About adding support for MT76x2U to Linux kernel

On 2016-03-07 13:41, Johannes Stezenbach wrote: > On Mon, Mar 07, 2016 at 12:51:43PM +0100, Felix Fietkau wrote: >> On 2016-03-07 12:14, Johannes Stezenbach wrote: >> > FWIW, the mt7610u vendor driver >> > doesn't support AP mode, while the mt7612u vendor driver does, >> > but I didn't understand h

Re: [PATCH V11 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature

Arend van Spriel writes: > Announce support for nl80211 feature BSS_SELECT and process > BSS selection behaviour provided in .connect() callback. > > Reviewed-by: Hante Meuleman > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Lei Zhang > Signed-off-by:

Re: [01/21] brcmfmac: change function name forbrcmf_cfg80211_wait_vif_event_timeout()

Kalle Valo writes: > 1 patches skipped: > > [17/21] brcmfmac: fix sdio sg table alloc crash > > There was a conflict so please rebase that patch: > > Applying: brcmfmac: fix sdio sg table alloc crash > fatal: sha1 information is lacking or useless > (drivers/net/wireless/broadcom/brcm80211/brcmf

Re: [PATCH 1/3] bcma: drop unneeded fields from bcma_pflash struct

Rafał Miłecki writes: > Most of info stored in this struct wasn't really used anywhere as we put > all that data in platform data & resource as well. > > Signed-off-by: Rafał Miłecki Manually applied to wireless-drivers-next, thanks. -- Kalle Valo -- To unsubscribe from this list: send the li

Re: About adding support for MT76x2U to Linux kernel

On Mon, Mar 07, 2016 at 12:51:43PM +0100, Felix Fietkau wrote: > On 2016-03-07 12:14, Johannes Stezenbach wrote: > > FWIW, the mt7610u vendor driver > > doesn't support AP mode, while the mt7612u vendor driver does, > > but I didn't understand how their timing of sending buffered > > frames works.

Re: [V3] mt7601u: do not free dma_buf when ivp allocation fails

> From: Colin Ian King > > If the allocation of ivp fails the error handling attempts to > free an uninitialized dma_buf; this data structure just contains > garbage on the stack, so the freeing will cause issues when the > urb, buf and dma fields are free'd. Fix this by not free'ing the > dma_b

Re: [PATCH] rtlwifi: Fix size of wireless mode variable

Larry Finger writes: > Smatch reports the following warning: > > CHECK drivers/net/wireless/realtek/rtlwifi/rc.c > drivers/net/wireless/realtek/rtlwifi/rc.c:144 _rtl_rc_rate_set_series() warn: > impossible condition '(wireless_mode == 256) => (0-255 == 256)' > > This warning arises because c

Re: [1/3] mwifiex: Fixed incorrect indentation issue

> This patch fixes the incorrect indentation of the case label. > > Signed-off-by: Ujjal Roy Thanks, 3 patches applied to wireless-drivers-next.git: 32962d5b43b7 mwifiex: Fixed incorrect indentation issue 3a968d766a63 mwifiex: Removed extra spaces before commas 354a1947a025 mwifiex: Added miss

Re: rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

> Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong > Cc: sta...@vger.kernel.org > Acked-by: Stanislaw Gruszka Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe l

Re: [1/4] mwifiex: add delay when tdls confirm frame is queued

> From: Xinming Hu > > It is observed that driver may send the data packet to tdls peer > before tdls peer receives tdls setup confirm frame. > Similar race condition exists during tdls teardown procedure also. > This patch adds 10 milliseconds delay to resolve the race. > > Signed-off-by: Xinm

Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient

> From: Colin Ian King > > passing rtl_stats by value is inefficient; the structure is over 300 > bytes in size and generally just one field (packet_report_type) > is being accessed, so the pass by value is a relatively large overhead. > This change just affects just the rx_command_packet calls.

Re: at76c50x-usb: avoid double usb_put_dev() after downloading internalfirmware in at76_probe()

> There is no need in usb_put_dev() if at76_load_internal_fw() succeed. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscrib

Re: mwifiex: Use to_delayed_work()

> Introduce the use of to_delayed_work() helper function instead of open > coding it with container_of() > > A simplified version of the Coccinelle semantic patch used to make > this change is: > > // > @@ > expression a; > symbol work; > @@ > - container_of(a, struct delayed_work, work) > + to_

Re: [01/21] brcmfmac: change function name forbrcmf_cfg80211_wait_vif_event_timeout()

> Dropping the '_timeout' from the function name as the fact that a timeout > value is passed makes it obvious a timeout is used. Also helps to keep code > lines a bit shorter and easier to stick to 80 char boundary. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Signed-

Re: rtlwifi: Change long delays to sleeps

> Routine rtl_addr_delay() uses delay statements in code that can > sleep. To improve system responsiveness, the various delay statements > are changed. > > In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are > rewritten to use the code in rtl_addr_delay() for most of their > input val

Re: carl9170: import 1.9.9 firmware headers

> Import new headers from my firmware branch: > > > Signed-off-by: Christian Lamparter Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majo

Re: [PATCH v2 00/15] wil6210 patches

Maya Erez writes: > Changes in V2: > - Fixed oob_mode module parameter description > > This set of patches includes: > - wil6210 bug fixes > - P2P support > - switch to generated wmi.h > - replay attack detection > > Dedy Lansky (1): > wil6210: p2p initial support > > Hamad Kadmany (1): > wil

Post patches for 4.6 NOW

Hi, Linus released 4.5-rc7 yesterday and that's most likely the last -rc release. So the chances are that merge window opens next Sunday and patches for 4.6 should be posted now. And even then I cannot promise anything. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe l

Re: rtlwifi: rtl8821ae: Silence useless log output

> When driver rtl8821ae is loaded but not connected to any AP, it logs > a "firmware not ready to run" message roughly once a minute. To > eliminate logging this massage under normal debug conditions, the > degug level needed to print this message is increased. > > Signed-off-by: Larry Finger T

Re: About adding support for MT76x2U to Linux kernel

On 2016-03-07 12:14, Johannes Stezenbach wrote: > On Wed, Mar 02, 2016 at 09:32:10AM +0200, Tuomas Räsänen wrote: >> On Fri, Aug 14, 2015 at 02:32:29PM +0200, Jakub Kiciński wrote: >> > CC: Linus W who was hacking on mt7630e recently. >> > >> > There is a fourth option: merge mt76 and mt7601u and

Re: About adding support for MT76x2U to Linux kernel

On Wed, Mar 02, 2016 at 09:32:10AM +0200, Tuomas Räsänen wrote: > On Fri, Aug 14, 2015 at 02:32:29PM +0200, Jakub Kiciński wrote: > > CC: Linus W who was hacking on mt7630e recently. > > > > There is a fourth option: merge mt76 and mt7601u and add support for > > mt76x2u along the way ;) > > Btw,

[PATCH v1] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

From: Mohammed Shafi Shajakhan Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration (vendor specific total air time(usecs) for data/management frames from the connected client) via 'drv_sta_statistics' callback Also make sta

[PATCH v1] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

From: Mohammed Shafi Shajakhan Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is vendor specific total air time(usecs) for data/management frames from the connected client. This will get dumped as p

Re: rt2x00queue: rt2800usb: NULL pointer crash while during USB disconnect

On Mon, Mar 7, 2016 at 10:59 AM, Stanislaw Gruszka wrote: > Hi, > > On Tue, Mar 01, 2016 at 11:36:13AM +0100, Vishal Thanki wrote: >> I observed a NULL pointer access crash during my testing on a custom AM33xx >> based board with RT5572 USB wifi module. The kernel log is attached with >> the mail.

Re: rt2x00queue: rt2800usb: NULL pointer crash while during USB disconnect

Hi, On Tue, Mar 01, 2016 at 11:36:13AM +0100, Vishal Thanki wrote: > I observed a NULL pointer access crash during my testing on a custom AM33xx > based board with RT5572 USB wifi module. The kernel log is attached with > the mail. With initial debugging, I think that the USB disconnect > event wa

Re: [PATCH v2 00/11] ath10k: implement push-pull tx model

Michal Kazior writes: > This adds support for the new logic where host > tells firmware how many frames are queued for each > station/tid and then firmware asks host to submit > frames for given station/tid. > > The patch count is a bit high but I tried > splitting the patches as much as possible

Re: [PATCH 1/2] ath10k: fix HTT Tx CE ring size

Michal Kazior writes: > QCA4019 can queue up to 2500 frames at a time. > This means it requires roughly 5000 entires on the > ring to work properly. Otherwise random tx failure > may occur. > > Signed-off-by: Michal Kazior Both patches applied, thanks. -- Kalle Valo-- To unsubscribe from this

Re: [PATCH] rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

On Tue, Feb 23, 2016 at 11:09:22PM +0800, Anthony Wong wrote: > Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong > Cc: sta...@vger.kernel.org Acked-by: Stanislaw Gruszka -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] ath10k: fix firmware assert in monitor mode

Rajkumar Manoharan writes: > commit 166de3f1895d ("ath10k: remove supported chain mask") had revealed > an issue on monitor mode. Configuring NSS upon monitor interface > creation is causing target assert in all qca9888x and qca6174 firmware. > Firmware assert issue can be reproduced by below seq

Re: [PATCH v2 07/11] ath10k: implement wake_tx_queue

Michal Kazior writes: > On 6 March 2016 at 15:27, Valo, Kalle wrote: >> Michal Kazior writes: >> >>> This implements very basic support for software >>> queueing. It also contains some knobs that will be >>> patched later. >>> >>> Signed-off-by: Michal Kazior >> >> Oddly this patch introduces