Re: [PATCH] [wl18xx] Fix memory leakage if kzalloc fails

Souptick Joarder writes: > Hi Julian, > > > On Thu, Oct 6, 2016 at 3:05 PM, Julian Calaby wrote: >> Hi, >> >> On Wed, Oct 5, 2016 at 10:50 PM, Souptick Joarder >> wrote: >>> This patch is added to properly handle memory leak

Non-fatal errors when disabling WiFi - Intel 7260

Hi, since commit b7a08b284dcf ("iwlwifi: pcie: extend device reset delay") I get the following errors when I disable the WiFi: [ 66.702845] iwlwifi :02:00.0: RF_KILL bit toggled to disable radio. [ 66.737893] iwlwifi :02:00.0: Failed to wake NIC for hcmd [ 66.737927] iwlwifi

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

OK the v2 patch is not based on 9340953. If you queue this in 4.10 as planned then just let me know and I'll rev v3 based on top of 9340953. On Thu, Oct 6, 2016 at 3:40 AM, Valo, Kalle wrote: > Marty Faltesek writes: > >> On Mon, Oct 3, 2016 at

Re: [PATCH] [wl18xx] Fix memory leakage if kzalloc fails

Hi Julian, On Thu, Oct 6, 2016 at 3:05 PM, Julian Calaby wrote: > Hi, > > On Wed, Oct 5, 2016 at 10:50 PM, Souptick Joarder > wrote: >> This patch is added to properly handle memory leak if kzalloc fails >> in wl18xx_scan_send() and

[PATCH v4 3/3] mwifiex: check hw_status in suspend and resume handlers

We have observed a kernel crash when system immediately suspends after booting. There is a race between suspend and driver initialization paths. This patch adds hw_status checks in suspend/resume to fix this issue and other corner cases. Signed-off-by: Amitkumar Karwar ---

[PATCH v4 1/3] mwifiex: reset card->adapter during device unregister

From: Xinming Hu card->adapter gets initialized during device registration. As it's not cleared, we may end up accessing invalid memory in some corner cases. This patch fixes the problem. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar

[PATCH v4 2/3] mwifiex: remove redundant pdev check in suspend/resume handlers

to_pci_dev() would just do struct offset arithmetic on struct device to get 'pdev' pointer. We never get NULL pdev pointer Signed-off-by: Amitkumar Karwar --- New patch introduced in v3 as per inputs from Brian Norris. v4: Same as v3 ---

[PATCH v3 3/3] mwifiex: check hw_status in suspend and resume handlers

We have observed a kernel crash when system immediately suspends after booting. There is a race between suspend and driver initialization paths. This patch adds hw_status checks in suspend/resume to fix this issue and other corner cases. Signed-off-by: Amitkumar Karwar ---

[PATCH v3 1/3] mwifiex: reset card->adapter during device unregister

From: Xinming Hu card->adapter gets initialized during device registration. As it's not cleared, we may end up accessing invalid memory in some corner cases. This patch fixes the problem. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar

[PATCH v3 2/3] mwifiex: remove redundant pdev check in suspend/resume handlers

to_pci_dev() would just do struct offset arithmetic on struct device to get 'pdev' pointer. We never get NULL pdev pointer Signed-off-by: Amitkumar Karwar --- New patch prepared as per inputs from Brian Norris. It wasn't part of v1 and v2 series ---

RE: [PATCH v2 2/2] mwifiex: check hw_status in suspend and resume handlers

Hi Brain, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, October 05, 2016 10:12 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com; Xinming Hu > Subject: Re: [PATCH v2 2/2] mwifiex: check hw_status in

RE: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

Hi Brian, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Brian Norris > Sent: Wednesday, October 05, 2016 10:00 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com; Xinming

Re: [PATCH 3/3] mac80211: multicast to unicast conversion

On Thu, 2016-10-06 at 13:53 +0200, michael-dev wrote: > Am 05.10.2016 13:58, schrieb Johannes Berg: > > > > > > Anyway, perhaps this needs to change to take DMS/per-station into > > account? > > > > Then again, this kind of setting - global multicast-to-unicast - > > fundamentally *cannot* be

Re: [PATCH 3/3] mac80211: multicast to unicast conversion

Am 05.10.2016 13:58, schrieb Johannes Berg: Anyway, perhaps this needs to change to take DMS/per-station into account? Then again, this kind of setting - global multicast-to-unicast - fundamentally *cannot* be done on a per-station basis, since if you enable it for one station and not for

Re: [PATCHv4] mac80211: check A-MSDU inner frame source address on AP interfaces

> The rules when to check sa/da should be independent of the driver > and  thus would likely be duplicated by each caller. This is why I > had it in ieee80211_amsdu_to_8023s. That does make sense, I guess. But I feel that it's overly complicated, and most drivers don't actually support all those

Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface"

On Fri, 30 Sep 2016 15:22:15 +0200 Greg KH wrote: > On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote: > > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread > > with workqueue for host interface") > > > > This commit breaks wilc1000

[PATCH v2 1/2] ath10k: clean up HTT tx buffer allocation and free

From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan --- [v2 rebased over top of

Re: [PATCH] [wl18xx] Fix memory leakage if kzalloc fails

Hi, On Wed, Oct 5, 2016 at 10:50 PM, Souptick Joarder wrote: > This patch is added to properly handle memory leak if kzalloc fails > in wl18xx_scan_send() and wl18xx_scan_sched_scan_config() What memory leak? > Signed-off-by: Souptick Joarder >

[PATCH v2 2/2] ath10k: Remove extraneous error message in tx alloc

From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan --- [v2 rebased over top

Re: bcmdhd: Strange Power Save messages

On 6-10-2016 10:07, Gucea Doru wrote: > On Wed, Oct 5, 2016 at 11:12 AM, Arend Van Spriel > wrote: >> On 4-10-2016 13:39, Gucea Doru wrote: >>> On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel wrote: > > > On 29-09-16

Re: bcmdhd: Strange Power Save messages

On Wed, Oct 5, 2016 at 11:12 AM, Arend Van Spriel wrote: > On 4-10-2016 13:39, Gucea Doru wrote: >> On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel >>> wrote: On 29-09-16 13:32, Gucea Doru wrote: > On Tue, Sep 27,

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

Marty Faltesek writes: > On Mon, Oct 3, 2016 at 3:46 AM, Valo, Kalle wrote: >> Marty Faltesek writes: >> >>> Caching calibration data allows it to be accessed when the >>> device is not active. >>> >>> Signed-off-by: Marty

Re: [1/2] ath10k: clean up HTT tx buffer allocation and free

On Thu, Oct 06, 2016 at 09:31:41AM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > cleanup 'ath10k_htt_tx_alloc' by introducing the API's > > 'ath10k_htt_tx_alloc/free_{cont_txbuf,

Re: [1/3] ath6kl: fix busreqs so they can be reused when sg is cleaned up

James Minor wrote: > To reuse the busreqs in case of hardware restart, they must be > properly reinitialized. If the scat_req pointer isn't reset to > 0, __ath6kl_sdio_write_async() will assume there is sg work to be > done (causing a kernel OOPS). > > Signed-off-by: James