Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Kalle Valo
Russell King writes: > Fix these errors reported by the 0-day builder by replacing the > linux/export.h include with linux/module.h. > > In file included from include/linux/platform_device.h:14:0, > from drivers/net/wireless/ath/ath5k/ahb.c:20: > include/linux/device.h:1463:1: wa

Re: [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

2017-01-31 Thread Florian Fainelli
On 01/31/2017 11:17 AM, Russell King - ARM Linux wrote: > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the include itself

Re: [PATCH v2] ath10k: add support for controlling tx power to a station

2017-01-31 Thread kbuild test robot
Hi Ashok, [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.10-rc6 next-20170131] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ashok-Raj-Nagarajan/ath10k-add-support

Re: [PATCH v2] ath10k: add support for controlling tx power to a station

2017-01-31 Thread kbuild test robot
Hi Ashok, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.10-rc6 next-20170130] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ashok-Raj-Nagarajan/ath10k-add-support-for-

Re: [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Timur Tabi
On 01/31/2017 01:19 PM, Russell King wrote: drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + The v

[PATCH v2 2/3] mac80211: Make mesh failure moving average configurable

2017-01-31 Thread Rajkumar Manoharan
Currently mesh moving fail average is calculated based on constant weight factor. In worst case moving average reaches threshold by considering 16 msdu tx ack status and deactivates mesh path. Having a constant weight factor might not be suitable for all environments. So make it tunable parameter a

[PATCH v2 1/3] mac80211: fix mesh moving average stuck

2017-01-31 Thread Rajkumar Manoharan
As moving average is not considering fractional part after certain ratio, it will stuck at the same state. For example with current values, moving average stuck at 96 and it will not move forward. Fortunately current threshold is matching against 95%. If thresold is increased more than 96, mesh pat

[PATCH v2 3/3] mac80211: clear failure average upon mesh path deactivation

2017-01-31 Thread Rajkumar Manoharan
Mesh moving average should be cleared, whenever mesh paths to the given station are deactivated due to bad link. It makes path deactivation logic more robust by considering more tx status before terminating mesh link. Signed-off-by: Rajkumar Manoharan --- v2: * removed paths_deactivated check *

Re: [PATCH 3/3] mac80211: clear failure average upon mesh path deactivation

2017-01-31 Thread Rajkumar Manoharan
On 2017-01-31 11:46, Thomas Pedersen wrote: On Tue, Jan 31, 2017 at 11:33 AM, Rajkumar Manoharan wrote: On 2017-01-31 09:51, Thomas Pedersen wrote: [...] + if (paths_deactivated) + sta->mesh->fail_avg = 0; .. why this indirection? Just reset mesh->fail_avg unconditiona

Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Anna Schumaker
Hi Russell, On 01/31/2017 02:18 PM, Russell King wrote: > Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc > code: > > net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': > net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration

Re: [PATCH 3/3] mac80211: clear failure average upon mesh path deactivation

2017-01-31 Thread Thomas Pedersen
On Tue, Jan 31, 2017 at 11:33 AM, Rajkumar Manoharan wrote: > On 2017-01-31 09:51, Thomas Pedersen wrote: >> >> Hi Rajkumar, >> >> Thanks this looks good, but.. >> >> On Fri, Jan 27, 2017 at 4:01 PM, Rajkumar Manoharan >> wrote: >>> >>> Mesh moving average should be cleared, whenever mesh paths >

Re: [PATCH 3/3] mac80211: clear failure average upon mesh path deactivation

2017-01-31 Thread Rajkumar Manoharan
On 2017-01-31 09:51, Thomas Pedersen wrote: Hi Rajkumar, Thanks this looks good, but.. On Fri, Jan 27, 2017 at 4:01 PM, Rajkumar Manoharan wrote: Mesh moving average should be cleared, whenever mesh paths to the given station are deactivated due to bad link. This will give enough room to anal

Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Bart Van Assche
On Tue, 2017-01-31 at 19:19 +, Russell King wrote: > drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration > of function 'try_module_get' [-Werror=implicit-function-declaration] > > Add linux/module.h to iscsi_target_login.c. > > Signed-off-by: Russell King > --- >

[PATCH 4.10-rc3 04/13] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/usb/lan78xx.c:394:33: sparse: got interface drivers/net/usb/lan78xx.c:403:1: sparse: Expected ; at the end of type decl

[PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1198:2: e

[PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error:

[PATCH 4.10-rc3 07/13] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has initializer but incomplete type drive

[PATCH 4.10-rc3 06/13] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*()

2017-01-31 Thread Russell King
octeon-platform.c can not be built as a module for two reasons: (a) the Makefile doesn't allow it: obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o (b) the multiple *_initcall() statements, each of which are translated to a module_init() call when attempting a module bu

[PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King --- drivers/target/iscsi/iscsi_target_login.c | 1 + 1 file changed, 1 inse

[PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc code: net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]

[PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20: include/linux/device.h:1463:1: warning: data definition has no type

[PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes

2017-01-31 Thread Russell King
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSI

[PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface drivers/net/ethernet/cadence/macb.h:877:1

[PATCH 4.10-rc3 02/13] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King --- net/core/netprio_cgroup.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

2017-01-31 Thread Russell King - ARM Linux
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSI

Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-01-31 Thread Ben Greear
On 01/31/2017 10:41 AM, Ashok Raj Nagarajan wrote: This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated to the AP. The added attributes allow sel

Re: [PATCH v2 2/2] mac80211: store tx power value from user to station

2017-01-31 Thread Ben Greear
On 01/31/2017 10:41 AM, Ashok Raj Nagarajan wrote: This patch introduce a new driver callback drv_sta_set_txpwr. This API will copy the transmit power value passed from user space and call the driver callback to set the tx power for the station. Signed-off-by: Ashok Raj Nagarajan --- include/n

Re: [PATCH v2] ath10k: add support for controlling tx power to a station

2017-01-31 Thread Ben Greear
On 01/31/2017 10:42 AM, Ashok Raj Nagarajan wrote: This patch will add the support to control the transmit power for traffic to a station associated with the AP. Userspace provide the transmit power value in mBm units and the allowed range is from 0 to 70. Underlying FW How did you come up with

[PATCH v2 2/2] mac80211: store tx power value from user to station

2017-01-31 Thread Ashok Raj Nagarajan
This patch introduce a new driver callback drv_sta_set_txpwr. This API will copy the transmit power value passed from user space and call the driver callback to set the tx power for the station. Signed-off-by: Ashok Raj Nagarajan --- include/net/mac80211.h| 6 ++ net/mac80211/cfg.c

[PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated

2017-01-31 Thread Ashok Raj Nagarajan
This patch adds support to set transmit power setting type and transmit power level attributes to NL80211_CMD_SET_STATION in order to facilitate adjusting the transmit power level of a station associated to the AP. The added attributes allow selection of automatic and limited transmit power level,

[PATCH v2] ath10k: add support for controlling tx power to a station

2017-01-31 Thread Ashok Raj Nagarajan
This patch will add the support to control the transmit power for traffic to a station associated with the AP. Userspace provide the transmit power value in mBm units and the allowed range is from 0 to 70. Underlying FW will enforce that the maximum tx power will be based on the regulatory requirem

[PATCH] ath10k: fix reading sram contents for QCA4019

2017-01-31 Thread Ashok Raj Nagarajan
With QCA4019 platform, SRAM address can be accessed directly from host but currently, we are assuming sram addresses cannot be accessed directly and hence we convert the addresses. While there, clean up growing hw checks during conversion of target CPU address to CE address. Now we have function p

Re: [PATCH 3/3] mac80211: clear failure average upon mesh path deactivation

2017-01-31 Thread Thomas Pedersen
Hi Rajkumar, Thanks this looks good, but.. On Fri, Jan 27, 2017 at 4:01 PM, Rajkumar Manoharan wrote: > Mesh moving average should be cleared, whenever mesh paths > to the given station are deactivated due to bad link. This will > give enough room to analysis more tx status than retaining the >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-31 Thread Tony Lindgren
* Kalle Valo [170130 22:36]: > Tony Lindgren writes: > > > * Pavel Machek [170127 11:41]: > >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > >> > Pali Rohár writes: > >> > > >> > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > >> > >> Pali Rohár writes: > >> > >> > >> > >> > 2) I

Re: Packet throughput (and those iperf data rate) with mac80211/ath9k is 20% worse than net80211/madwifi

2017-01-31 Thread Ben Greear
One thing to consider: Older ath9k and maybe madwifi used a different congestion control, and it got higher throughput in optimal situations in our testing. When it was removed from the kernel, there was some effort to improve the minstrel_ht algorithm, but I don't think it ever performed qui

Re: [RFC] ath10k: silence firmware file probing warnings

2017-01-31 Thread Kalle Valo
Michal Kazior wrote: > Firmware files are versioned to prevent older > driver instances to load unsupported firmware > blobs. This is reflected with a fallback logic > which attempts to load several firmware files. > > This however produced a lot of unnecessary > warnings sometimes confusing user

ANNOUNCE: Netdev 2.1 update

2017-01-31 Thread Jamal Hadi Salim
A few announcements: - We expect to open up registration and announce hotel and location next week. - We are pleased to announce the first netdev 2.1 talk has been accepted by the tech committee! The Call for Proposals is still open, submit early to avoid the hazards of last minute traffic. Refe

[PATCH v3] wlcore: disable multicast filter in AP mode

2017-01-31 Thread Iain Hunter
Enable AP support for allmulticast for MDNS. It can be enabled by bringing up the interface with ip command with argument allmulticast on Signed-off-by:Iain Hunter --- PATCH v3: fixes tabbing drivers/net/wireless/ti/wlcore/main.c | 15 +++ 1 file changed, 15 insertions(+) diff --g

Re: Packet throughput (and those iperf data rate) with mac80211/ath9k is 20% worse than net80211/madwifi

2017-01-31 Thread Rafał Miłecki
On 31 January 2017 at 10:52, Wojciech Dubowik wrote: > On 31/01/17 10:46, Klaus Kinski wrote: >> >> BTW, if I read the sources correctly, than IBSS mode uses the TXQ >> parameters from ieee80211_set_wmm_default with enable_qos = false which >> means that qparam.txop = 0, e.g. bursting is disabled.

Re: Intel Pro 4965 wireless

2017-01-31 Thread Stanislaw Gruszka
On Tue, Jan 31, 2017 at 09:36:28AM +0200, Luca Coelho wrote: > On Mon, 2017-01-30 at 21:04 -0500, Mel Stimmel wrote: > > I have a problem that recently arose with my Thinkpad model T61 > > running Ubuntu 16.04 with the Intel Pro 4965 installed. > > This system was working just fine until

Re: [PATCH 1/2] brcmfmac: check brcmf_bus_get_memdump result for error

2017-01-31 Thread Arend Van Spriel
On 30-1-2017 16:09, Rafał Miłecki wrote: > From: Rafał Miłecki > > This method may be unsupported (see: USB bus) or may just fail (see: > SDIO bus). > While at it rework logic in brcmf_sdio_bus_get_memdump function to avoid > too many conditional code nesting levels. Acked-by: Arend van Spriel

Re: [PATCH 2/2] brcmfmac: be more verbose when PSM's watchdog fires

2017-01-31 Thread Arend Van Spriel
On 30-1-2017 16:09, Rafał Miłecki wrote: > From: Rafał Miłecki > > It's important to inform user so he knows things went wrong. He may also > want to get memory dump for further debugging purposes. Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > drivers/net/wireless/broadcom

[PATCH v3] rt2x00: avoid introducing a USB dependency in the

2017-01-31 Thread Stanislaw Gruszka
As reported by Felix: Though protected by an ifdef, introducing an usb symbol dependency in the rt2x00lib module is a major inconvenience for distributions that package kernel modules split into individual packages. Get rid of this unnecessary dependency by calling the usb related function from a

[PATCH] wlcore: disable multicast filter in AP mode

2017-01-31 Thread Iain Hunter
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index 3241e9eba73..7d3f15d5d5c 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_h

[PATCH] wlcore: disable multicast filter in AP mode

2017-01-31 Thread Iain Hunter
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index 3241e9eba73..7d3f15d5d5c 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_h

[PATCH] wlcore: disable multicast filter in AP mode

2017-01-31 Thread Iain Hunter
Enable AP support for allmulticast for MDNS It can be enabled by bringing up the interface with ip command with argument allmulticast on Signed-off-by: Iain Hunter --- PATCH v2: resumbitting to handle error return value drivers/net/wireless/ti/wlcore/main.c | 15 +++ 1 file changed

Re: Packet throughput (and those iperf data rate) with mac80211/ath9k is 20% worse than net80211/madwifi

2017-01-31 Thread Wojciech Dubowik
On 31/01/17 10:46, Klaus Kinski wrote: BTW, if I read the sources correctly, than IBSS mode uses the TXQ parameters from ieee80211_set_wmm_default with enable_qos = false which means that qparam.txop = 0, e.g. bursting is disabled. Am I right? I guess so. But you need to look also at contentio

Re: Unsupported NVRAM on D-Link DIR-885L (affects brcmfmac)

2017-01-31 Thread Rafał Miłecki
On 31 January 2017 at 07:24, Rafał Miłecki wrote: > I just noticed my DIR-885L has some weird NVRAM format. Linux doesn't > support it, it reads only part of it, which may affect brcmfmac. > > There goes the most interesting part: > 46 4c 53 48 50 3e 00 00 3f 01 00 00 4b 01 00 00 |FLSH

Re: Packet throughput (and those iperf data rate) with mac80211/ath9k is 20% worse than net80211/madwifi

2017-01-31 Thread Wojciech Dubowik
Then you need to use CONFIG debug flag. WMM parameters are not set when MESH compile flag is enabled. At least I have had once such problem. Wojtek PS It would be actually nice to have sth like madwifi's wlanconfig ... list wme to print QoS settings in current systems. On 31/01/17 10:38, K

Re: [RFC 3/3] cfg80211: Share Channel DFS state across wiphys of same DFS domain

2017-01-31 Thread Thiagarajan, Vasanthakumar
On Thursday 26 January 2017 03:11 PM, Johannes Berg wrote: > On Wed, 2017-01-25 at 17:01 +0530, Vasanthakumar Thiagarajan wrote: >> Sharing DFS channel state across multiple wiphys (radios) could >> be useful with multiple radios on the system. When one radio >> completes CAC and marks the channel

Re: [RFC 2/3] cfg80211: Disallow moving out of operating DFS channel in non-ETSI

2017-01-31 Thread Thiagarajan, Vasanthakumar
On Thursday 26 January 2017 03:06 PM, Johannes Berg wrote: > >> +static bool cfg80211_off_channel_oper_allowed(struct wireless_dev >> *wdev) >> +{ >> +if (!cfg80211_beaconing_iface_active(wdev)) >> +return true; >> + >> +if (!(wdev->chandef.chan->flags & IEEE80211_CHAN_RADAR)) >

Re: [RFC 1/3] cfg80211: Make pre-CAC results valid only for ETSI domain

2017-01-31 Thread Thiagarajan, Vasanthakumar
On Thursday 26 January 2017 03:04 PM, Johannes Berg wrote: > >> +/* Should we apply the grace period during beaconing >> interface >> + * shutdown also? >> + */ >> +cfg80211_sched_dfs_chan_update(rdev); > > It might make some sense, say if hostapd cra

Re: [RFC 2/3] cfg80211: Disallow moving out of operating DFS channel in non-ETSI

2017-01-31 Thread Thiagarajan, Vasanthakumar
On Wednesday 25 January 2017 11:50 PM, Jean-Pierre Tosoni wrote: >> -Message d'origine- >> De : linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- >> ow...@vger.kernel.org] De la part de Vasanthakumar Thiagarajan >> Envoyé : mercredi 25 janvier 2017 12:31 >> À : johan...@sipsoluti