Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

On Thu, 2017-04-06 at 16:54 -0700, Matthias Kaehlcke wrote: > Hi Joe, > > El Thu, Apr 06, 2017 at 02:29:20PM -0700 Joe Perches ha dit: > > > On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > > > The macro results are assigned to u8 variables/fields. Adding the cast > > > fixes plenty

Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

Hi Joe, El Thu, Apr 06, 2017 at 02:29:20PM -0700 Joe Perches ha dit: > On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > > The macro results are assigned to u8 variables/fields. Adding the cast > > fixes plenty of clang warnings about "implicit conversion from 'int' to > > 'u8'". > >

[PATCH v2] mac80211: Fix clang warning about constant operand in logical operation

When clang detects a non-boolean constant in a logical operation it generates a 'constant-logical-operand' warning. In ieee80211_try_rate_control_ops_get() the result of strlen() is used in a logical operation, clang resolves the expression to an (integer) constant at compile time when clang's

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

On Thu, 2017-04-06 at 15:42 -0700, Matthias Kaehlcke wrote: > > Thanks, it would also require to move the initialization of > ieee80211_default_rc_algo into an ifdef. If you can live with such a > solution I'm happy to change it. I think that'd be something I can live with, yeah. > > git

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

El Thu, Apr 06, 2017 at 11:12:25PM +0200 Johannes Berg ha dit: > On Thu, 2017-04-06 at 12:24 -0700, Matthias Kaehlcke wrote: > > > I agree that the code looks worse :( I hoped to find a fix using a > > preprocessor condition but wasn't successful. > > It's actually easy - just remove the

Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > The macro results are assigned to u8 variables/fields. Adding the cast > fixes plenty of clang warnings about "implicit conversion from 'int' to > 'u8'". > > Signed-off-by: Matthias Kaehlcke > --- >

[PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

The macro results are assigned to u8 variables/fields. Adding the cast fixes plenty of clang warnings about "implicit conversion from 'int' to 'u8'". Signed-off-by: Matthias Kaehlcke --- drivers/net/wireless/ath/ath9k/eeprom.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

On Thu, 2017-04-06 at 12:24 -0700, Matthias Kaehlcke wrote: > I agree that the code looks worse :( I hoped to find a fix using a > preprocessor condition but wasn't successful. It's actually easy - just remove the 'default ""' from Kconfig, and then the symbol won't be defined at all if it

[PATCH 05/11] rtlwifi: btcoex: 23b 2ant: wifi is not actually off in mp mode

From: Yan-Hsuan Chuang In mp mode, the wifi will not turn off and still has control of the PTA, so the driver needs to distinguish whether it is mp mode or not Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger

[PATCH 04/11] rtlwifi: btcoex: 23b 2ant: need those information when scan

From: Yan-Hsuan Chuang For scan notify, we need to supervise some registers to make sure that coexistence is operating as we expected. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih

[PATCH 06/11] rtlwifi: btcoex: 23b 2ant: power on settings for coex

From: Yan-Hsuan Chuang When power on, the wifi could be initiating, force the antenna to transmit bt packets to avoid bt unstable problems Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih

[PATCH 10/11] rtlwifi: btcoex: 23b 2ant: notify more bt information

From: Yan-Hsuan Chuang These bt information are displayed in display coex Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu

[PATCH 11/11] rtlwifi: btcoex: 23b 2ant: some hi-prio pkt will cause hid_exist

From: Yan-Hsuan Chuang Clear the hid_exist flag by monitoring the packet counter. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc:

[PATCH 07/11] rtlwifi: btcoex: 23b 2ant: before firmware ready settings

From: Yan-Hsuan Chuang Before firmware is ready, set GNT_BT to high to let bt transmit Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc:

[PATCH 08/11] rtlwifi: btcoex: 23b 2ant: fine tune for bt pan_edr_a2dp

From: Yan-Hsuan Chuang If we don't limit the rx aggregation size, and set tdma instead, the bt profile can get more stable. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc:

[PATCH 03/11] rtlwifi: btcoex: 23b 2ant: remove debugging code for 0x948

From: Yan-Hsuan Chuang Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting

[PATCH 09/11] rtlwifi: btcoex: 23b 2ant: fine tune for bt hid_a2dp

From: Yan-Hsuan Chuang Let bt control the aggregation size to improve stability. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu

[PATCH 00/11] rtlwifi: btcoex: More update to btcoex

This set of patches completes the updates for btcoex for the RTL8723BE device. These patches follow the 13-patch set previously submitted. Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Pkshih Cc: Birming Chiu

[PATCH 02/11] rtlwifi: btcoex: 23b 2ant: treat too many low prio packets as retry

From: Yan-Hsuan Chuang Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger Cc: Pkshih Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

Hi Johannes, thanks for your comments El Thu, Apr 06, 2017 at 09:11:18PM +0200 Johannes Berg ha dit: > On Thu, 2017-04-06 at 11:56 -0700, Matthias Kaehlcke wrote: > > Clang raises a warning about the expression 'strlen(CONFIG_XXX)' > > being > > used in a logical operation. Clangs' builtin

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

On Thu, 2017-04-06 at 11:56 -0700, Matthias Kaehlcke wrote: > Clang raises a warning about the expression 'strlen(CONFIG_XXX)' > being > used in a logical operation. Clangs' builtin strlen function resolves > the > expression to a constant at compile time, which causes clang to > generate > a

[PATCH] mac80211: Fix clang warning about constant operand in logical operation

Clang raises a warning about the expression 'strlen(CONFIG_XXX)' being used in a logical operation. Clangs' builtin strlen function resolves the expression to a constant at compile time, which causes clang to generate a 'constant-logical-operand' warning. Split the if statement in two to avoid

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

On 04/06/2017 02:32 PM, Larry Finger wrote: On 04/06/2017 04:49 AM, Hans de Goede wrote: Hi, On 06-04-17 11:04, Bastien Nocera wrote: On Thu, 2017-04-06 at 08:55 +0200, Hans de Goede wrote: Good thank you. So what is the plan with the github version ? Note that my submission contains a

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

On 04/06/2017 04:49 AM, Hans de Goede wrote: Hi, On 06-04-17 11:04, Bastien Nocera wrote: On Thu, 2017-04-06 at 08:55 +0200, Hans de Goede wrote: Good thank you. So what is the plan with the github version ? Note that my submission contains a few small fixes on top of the github version,

Re: [PATCH] nfc: fix get_unaligned_...() misuses

On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > * use unaligned.h, not unaligned/access_ok.h ... which got misspelled in that patch, sorry... Fixed variant follows: commit b3e79ba1708c9b74781079c9f8617448fce36b51 Author: Al Viro Date: Thu Apr 6 12:42:14

[PATCH] nfc: fix get_unaligned_...() misuses

* use unaligned.h, not unaligned/access_ok.h * if a local variable of type uint16_t is unaligned, your compiler is FUBAR * the whole point of get_unaligned_... is to avoid memcpy + ..._to_cpu(). Using it *after* memcpy() (into aligned object, no less) is pointless. Signed-off-by: Al Viro

Re: [PATCH] mwifiex: MAC randomization should not be persistent

On Thu, Apr 06, 2017 at 07:02:15AM +0300, Kalle Valo wrote: > Brian Norris writes: > > > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan > > request that should be randomized; the absence of such a flag means we > > should not randomize. However,

Re: [Make-wifi-fast] [PATCH v3] mac80211: Dynamically set CoDel parameters per station

Eric Dumazet writes: > On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote: > >> + >> +if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) { >> +sta->cparams.target = MS2TIME(50); >> +sta->cparams.interval = MS2TIME(300); >>

Re: How to use netlink to determine wifi protection WEP

On Thu, 2017-04-06 at 16:27 +0200, Thomas Thielemann wrote: > Thanks! > > If the sequence is the following: > >  1. Prepare and execute NL80211_CMD_TRIGGER_SCAN >  2. Prepare and execute NL80211_CMD_GET_SCAN >  Together with NL80211_CMD_GET_SCAN a callback is registered.  >  In the callback the

Re: How to use netlink to determine wifi protection WEP

Thanks! If the sequence is the following: 1. Prepare and execute NL80211_CMD_TRIGGER_SCAN 2. Prepare and execute NL80211_CMD_GET_SCAN Together with NL80211_CMD_GET_SCAN a callback is registered. In the callback the raw data are parsed as BSS. The IE's are parsed to. When do I have to fetch

[PATCH 3/6] brcmfmac: remove reference to fwsignal data from struct brcmf_pub

The fwsignal module is part of the bcdc protocol and as such does its instance data is not needed in core structure. Moving it into struct brcmf_bcdc instead. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts

[PATCH 5/6] brcmfmac: remove bogus check in scheduled scan result handler

Checking whether the address of an array element is null is bogus so removing it. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH 2/6] brcmfmac: ignore interfaces when fwsignal is disabled

When brcmf_fws_add_interface() is called the struct brcmf_if::fws_desc field is initialized regardless the state of the fwsignal functionality, ie. the fcmode. This is not needed when fcmode is NONE, which is the default mode. Reviewed-by: Hante Meuleman Reviewed-by:

[PATCH 0/6] brcmfmac: fwsignal and scheduled scan rework

This series is intended for 4.12 including: * rework for fwsignal module. * tighten length checks for scheduled scan result event. * fix duplicate entries in scan request for scheduled scan. The patches apply to the master branch of the wireless-drivers-next repository. Arend van Spriel (6):

[PATCH 1/6] brcmfmac: rename brcmf_fws_{de,}init to brcmf_fws{at,de}tach

This is a non-functional change to align the fwsignal module to the naming pattern used throughout the driver. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin

[PATCH 4/6] brcmfmac: add length checks in scheduled scan result handler

Assure the event data buffer is long enough to hold the array of netinfo items and that SSID length does not exceed the maximum of 32 characters as per 802.11 spec. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts

[PATCH 6/6] brcmfmac: only add channels and ssids once in scan request

When receiving pno results there may be duplicate channels and/or ssids. Assure each is added only once when preparing the internal escan request. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky

Re: brcmfmac: don't warn user if requested nvram fails

Hi, I noticed your patch-series on the lwn.net kernel page, and I took a peek :) I don't think that this patch: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?h=20170329-driver-data-v2-try3=3968dd3031d1ff7e7be4acfb810948c70c2d4490 Is a good idea, specifically

[PATCH] ath9k: Add Dell Wireless 1601 with wowlan capability

Add the Dell Wireless 1601 card as an AR9462 in the ath9k pci list. Note that the wowlan feature is supported and has been tested successfully. Signed-off-by: Damien Thébault --- drivers/net/wireless/ath/ath9k/pci.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Make-wifi-fast] [PATCH v3] mac80211: Dynamically set CoDel parameters per station

On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote: > + > + if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) { > + sta->cparams.target = MS2TIME(50); > + sta->cparams.interval = MS2TIME(300); > + sta->cparams.ecn = false; > + }

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

Hi, On 06-04-17 11:04, Bastien Nocera wrote: On Thu, 2017-04-06 at 08:55 +0200, Hans de Goede wrote: Good thank you. So what is the plan with the github version ? Note that my submission contains a few small fixes on top of the github version, for which I intended to submit a pull-req but

[PATCH v3] mac80211: Dynamically set CoDel parameters per station

CoDel can be too aggressive if a station sends at a very low rate, leading reduced throughput. This gets worse the more stations are present, as each station gets more bursty the longer the round-robin scheduling between stations takes. This adds dynamic adjustment of CoDel parameters per

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

On Thu, 2017-04-06 at 08:55 +0200, Hans de Goede wrote: > > Good thank you. So what is the plan with the github version ? > > Note that my submission contains a few small fixes on top of > the github version, for which I intended to submit a pull-req > but I've not gotten around to that yet,

Re: [PATCH v2] mac80211: Dynamically set CoDel parameters per station

Hi Toke, [auto build test WARNING on mac80211/master] [also build test WARNING on v4.11-rc5 next-20170406] [cannot apply to mac80211-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

RE:] Re: [3/3] mwifiex: pcie: avoid hardcode wifi-only firmware name

Hi Kalle, > -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: 2017年4月5日 18:47 > To: Xinming Hu > Cc: Linux Wireless; Kalle Valo; Brian Norris; Dmitry Torokhov; > raja...@google.com; Amitkumar Karwar; Cathy Luo; Xinming Hu > Subject: [EXT] Re: [3/3] mwifiex: pcie:

RE: [EXT] Re: [PATCH 3/3] mwifiex: pcie: avoid hardcode wifi-only firmware name

Hi Brain, > -Original Message- > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: 2017年4月4日 2:49 > To: Dmitry Torokhov > Cc: Xinming Hu; Linux Wireless; Kalle Valo; Rajat Jain; Amitkumar Karwar; > Cathy > Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 3/3] mwifiex: pcie: avoid

RE: Re: [PATCH 3/3] mwifiex: pcie: avoid hardcode wifi-only firmware name

Hi Dmitry, > -Original Message- > From: Dmitry Torokhov [mailto:d...@google.com] > Sent: 2017年4月1日 6:50 > To: Xinming Hu > Cc: Linux Wireless; Kalle Valo; Brian Norris; Rajat Jain; Amitkumar Karwar; > Cathy Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 3/3] mwifiex: pcie: avoid hardcode

Re: [PATCH v2] mac80211: Dynamically set CoDel parameters per station

Hi Toke, [auto build test ERROR on mac80211/master] [also build test ERROR on v4.11-rc5 next-20170406] [cannot apply to mac80211-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Toke

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

Hi, On 05-04-17 18:32, Larry Finger wrote: On 04/05/2017 04:36 AM, Hans de Goede wrote: Hi, On 05-04-17 01:41, Larry Finger wrote: On 04/04/2017 04:53 PM, Hans de Goede wrote: Hi, On 04/04/2017 11:38 PM, Arend Van Spriel wrote: On 4-4-2017 20:53, Hans de Goede wrote: Hi, On 04/04/2017