RE: [PATCH] iwlwifi: add 4c70 subdevice ID for 7260 series

2014-09-16 Thread Grumbach, Emmanuel
This card appears in an Asus TP300LA laptop (from Chris Mens). lspci output: 02:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1] (rev cb) Subsystem: Intel Corporation Device [8086:4c70] Verified against v3.10.54 and v3.17-rc5-13-g2324067. Cc:

RE: Bug reported in Launchpad: Asus TP300LA no wifi with Intel AC 7260

2014-09-21 Thread Grumbach, Emmanuel
Hello, on my Asus TP300 LA-C 4023H Wifi with the Intel Ac 7260 dosnt work. I have reported the Problem in Launchpad bugs.launchpad.net/ubuntu/+source/linux/+bug/1369701 launchpad.net/ubuntu/+source/linux/+bug/1369701. cat /proc/version Linux version 3.17.0-031700rc5-generic

RE: [PATCH 13/17] iwlwifi: 8000: fix fw name to account for revision

2014-09-22 Thread Grumbach, Emmanuel
Emmanuel Grumbach egrumb...@gmail.com writes: diff --git a/drivers/net/wireless/iwlwifi/iwl-8000.c b/drivers/net/wireless/iwlwifi/iwl-8000.c index 4ae8ba6..e435148 100644 --- a/drivers/net/wireless/iwlwifi/iwl-8000.c +++ b/drivers/net/wireless/iwlwifi/iwl-8000.c @@ -81,7 +81,7 @@

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Grumbach, Emmanuel
Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: + if (vif) + scd_queues = ~BIT(vif-hw_queue[IEEE80211_AC_VO]); I'm backporting this to 3.13, and this part doesn't work unless

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Grumbach, Emmanuel
On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: On Mon, Oct 06, 2014 at 12:35:46PM +, Grumbach, Emmanuel wrote: Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: + if (vif

RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing

2014-10-06 Thread Grumbach, Emmanuel
On Mon, Oct 06, 2014 at 12:47:41PM +, Grumbach, Emmanuel wrote: On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: On Mon, Oct 06, 2014 at 12:35:46PM +, Grumbach, Emmanuel wrote: Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing

RE: [RFC] mac80211: don't flush when probing the AP

2014-10-20 Thread Grumbach, Emmanuel
On Thu, 2014-10-16 at 23:25 +0300, Emmanuel Grumbach wrote: All the callers of ieee80211_mgd_probe_ap_send return right after they call the flush() callback. This means that calling flush() is uneeded since its meaning is to wait until the queues of the device are empty. It is pointless

RE: 3.18-rc0: iwlegacy failed after a while

2014-10-23 Thread Grumbach, Emmanuel
[Changed subject] This is really iwlegacy and not iwlwifi. Hi! Full dmesg is in the attachment, I guess the troubles started with: iwl3945 :03:00.0: Queue 4 stuck for 2004 ms. iwl3945 :03:00.0: On demand firmware reload iwl3945 :03:00.0: Master Disable Timed Out, 100 usec

RE: [Ilw] WARNING: drivers/net/wireless/iwlwifi/mvm/tx.c:197 iwl_mvm_set_tx_params+0x5f4/0x630 [iwlmvm]()

2014-10-23 Thread Grumbach, Emmanuel
Hi, on recent Linus git, I regulary get the following backtrace (since 3.17 around or so). HW is Intel Corporation Wireless 7260 (rev 83) [ 1774.340980] [ cut here ] [ 1774.341003] WARNING: CPU: 2 PID: 2402 at /home/arnd/Projekte/kernel/linux-

RE: [PATCH 07/11] iwlwifi: dvm: Fix probable mask then right shift defect

2014-10-27 Thread Grumbach, Emmanuel
Precedence of and is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Signed-off-by: Joe Perches j...@perches.com --- Applied - thanks. -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH] mac80211: Increase uapsd max SP frames number

2014-11-04 Thread Grumbach, Emmanuel
On Tue, Nov 4, 2014 at 2:10 PM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: From: Andrei Otcheretianski andrei.otcheretian...@intel.com Deliver up to 128 frames during SP instead of 8 if unlimited max SP is specified during association. Signed-off-by: Andrei Otcheretianski

RE: [PATCH] iwlwifi: dvm: Implement sta_rc_update() mac80211 callback

2014-11-12 Thread Grumbach, Emmanuel
Perform rate scaling properly when operating in an IBSS. Prior to this, the 5300 and 6205 devices (at least) would only transmit at 1 Mbps to other stations in an IBSS. This now allows transmission at HT rates. Signed-off-by: David Ward david.w...@ll.mit.edu ---

RE: [PATCH] iwlwifi: dvm: Implement sta_rc_update() mac80211 callback

2014-11-12 Thread Grumbach, Emmanuel
On 12 November 2014 07:26, David Ward david.w...@ll.mit.edu wrote: [...] +static void iwlagn_mac_sta_rc_update(struct ieee80211_hw *hw, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta, u32 +changed) { +

RE: [RFC] mac80211: take reserved vif into account when calculating the min_def

2014-11-30 Thread Grumbach, Emmanuel
On 27 November 2014 at 13:30, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: When we want to calculate the minimal bandwidth needed for a channel context, we need to take into account vifs that have reserved the channel context. I hit an issue with iwlwifi and channel switch as a

RE: [RFC] mac80211: take reserved vif into account when calculating the min_def

2014-11-30 Thread Grumbach, Emmanuel
On 27 November 2014 at 13:30, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: When we want to calculate the minimal bandwidth needed for a channel context, we need to take into account vifs that have reserved the channel context. I hit an issue with iwlwifi and channel

pull request: iwlwifi-next 2014-12-02

2014-12-02 Thread Grumbach, Emmanuel
Hi John, This is a last pull request with content for 3.19. As usual, the details are below. Thanks! The following changes since commit dcad8e4299bf81f8795b44677036dfa490c9fb15: iwlwifi: update the secure mem space and for the CPUs (2014-11-24 08:30:44 +0200) are available in the git

pull request: iwlwifi 2014-12-18

2014-12-17 Thread Grumbach, Emmanuel
Hi Kalle, First congrats on your new role - I am sure we'll find the way to work together in the new layout. John - it was a pleasure. I stepped up as a maintainer of iwlwifi only a bit more than a year ago. You had the patience to bear with me while I was doing my mistakes of the beginning.

Re: [iwlwifi] BUG: unable to handle kernel

2014-12-18 Thread Grumbach, Emmanuel
On Thu, 2014-12-18 at 09:13 -0800, Fengguang Wu wrote: Hi All, I don't see any relationship between the BUG and this bisected commit. Anyway, it's better to report it to the lists than to ignore. Right - but I have to say that I have no clue how this comment can cause the bug you are

Re: [iwlwifi] BUG: unable to handle kernel

2014-12-18 Thread Grumbach, Emmanuel
On Thu, 2014-12-18 at 13:07 -0800, Fengguang Wu wrote: On Fri, Dec 19, 2014 at 03:42:17AM +0800, Grumbach, Emmanuel wrote: On Thu, 2014-12-18 at 09:13 -0800, Fengguang Wu wrote: Hi All, I don't see any relationship between the BUG and this bisected commit. Anyway, it's better

Re: pull request: firmware update for iwlwifi (3160 / 7260 / 7265)

2014-12-21 Thread Grumbach, Emmanuel
with the correct address of the linux firmware maintainers this time... On Sun, 2014-12-21 at 09:58 +0200, Emamnuel Grumbach wrote: Dear Linux firmware maintainers, Here is new release of the -10.ucode firmware for the following Intel Wireless devices: 3160 / 7260 / 7265 / 7265D This

Re: [Ilw] Issue intel 6205 wlan card

2014-12-25 Thread Grumbach, Emmanuel
Hi, Hello, I have a thinkpad t430 with intel 6205 wifi card. I am running slackware 14.1 with kernel 3.10.17 but with other kernels like 3.14.27, 3.17.7 and 3.18.1 is not working. I compiled the kernels with all modules related to intel wifi card. Now I can see wlan0 under

Re: Unable to disable WiFi with 3.19-rc1 - iwlwifi 7260

2014-12-27 Thread Grumbach, Emmanuel
Hi, On Sat, 2014-12-27 at 20:17 +0100, Sedat Dilek wrote: On Sat, Dec 27, 2014 at 8:08 PM, Gabriele Mazzotta gabriele@gmail.com wrote: Hi, since v3.19-rc1 I have problems with WiFi (Intel Corporation Dual Band Wireless-AC 7260) on my laptop. Trying to disable all the radio devices

Re: [PATCH 12/27] iwlwifi: dvm: main: Use setup_timer

2014-12-27 Thread Grumbach, Emmanuel
On Fri, 2014-12-26 at 15:35 +0100, Julia Lawall wrote: Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/)

Re: [patch -next] iwlwifi: use a format string for an snprintf()

2014-12-28 Thread Grumbach, Emmanuel
On Thu, 2014-12-04 at 14:02 +0300, Dan Carpenter wrote: This will make Kees Cook happy if we specify a format string and, who knows, maybe someday there will be a firmware version with a percent character and we'll be glad for this. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

RE: iwlwifi-driver card doesn't work with 3.19-rc2+

2014-12-30 Thread Grumbach, Emmanuel
On 12/30/2014 09:23 AM, Emmanuel Grumbach wrote: On Tue, Dec 30, 2014 at 3:33 PM, Jiri Kosina jkos...@suse.cz wrote: Hi, I just booted current Linus' tree (5faa0154fe33) on my x200s thinkpad, and wifi doesn't work. iwconfig is telling me that wlan0 interface has no wireless

RE: [PATCH] Revert cfg80211: make WEXT compatibility unselectable

2014-12-30 Thread Grumbach, Emmanuel
Subject: [PATCH] Revert cfg80211: make WEXT compatibility unselectable This reverts commit 24a0aa212ee2dbe44360288684478d76a8e20a0a. It's causing severe userspace breakage. Namely, all the utilities from wireless-utils which are relying on CONFIG_WEXT (which means tools like 'iwconfig',

RE: iwlwifi-driver card doesn't work with 3.19-rc2+

2014-12-30 Thread Grumbach, Emmanuel
On Tue, 30 Dec 2014, Larry Finger wrote: If wireless maintainers think otherwise, I'll send a revert request to Linus for consideration. I wonder if the reaction would be like this one: https://lkml.org/lkml/2012/12/23/75 :-) It would be a little like that.

RE: [PATCH] Revert cfg80211: make WEXT compatibility unselectable

2014-12-31 Thread Grumbach, Emmanuel
On 12/30/14 23:52, Jiri Kosina wrote: This reverts commit 24a0aa212ee2dbe44360288684478d76a8e20a0a. It's causing severe userspace breakage. Namely, all the utilities from wireless-utils which are relying on CONFIG_WEXT (which means tools like 'iwconfig', 'iwlist', etc) are not working

pull request: iwlwifi-next 2015-02-03

2015-02-02 Thread Grumbach, Emmanuel
Hi Kalle, Here is probably the last pull request for 3.20. Details below. Since it is probably too late to send patches for 3.19, There are a few patches here that are tagged for stable. Please let me know if you have issues! The following changes since commit

Re: pull request: new firmware for Intel wireless Intel 3160 / 7260 / 7265 / 7265D devices

2015-02-06 Thread Grumbach, Emmanuel
On Fri, 2015-02-06 at 11:31 +0200, Emmanuel Grumbach wrote: On Fri, 2015-02-06 at 04:15 -0500, Kyle McMartin wrote: On Tue, Feb 03, 2015 at 09:39:28PM +, Grumbach, Emmanuel wrote: Hi, This is a pull request for new firmwares for the Intel wireless devices mentioned

Re: pull request: new firmware for Intel wireless Intel 3160 / 7260 / 7265 / 7265D devices

2015-02-06 Thread Grumbach, Emmanuel
On Fri, 2015-02-06 at 04:15 -0500, Kyle McMartin wrote: On Tue, Feb 03, 2015 at 09:39:28PM +, Grumbach, Emmanuel wrote: Hi, This is a pull request for new firmwares for the Intel wireless devices mentioned in the subject. I replace -10.ucode with new ones (that includes bug

[ANN] new firmware for Intel 3160 / 7260 / 7265 / 7265D devices - Core9

2015-02-03 Thread Grumbach, Emmanuel
Hi all, Intel released a new firmware for its WiFi devices listed in the subject. This release includes lots of bug fixes along with new features. The filename is iwlwifi--12.ucode and will be usable on kernel 3.19 and up. We also release release a re-spin of iwlwifi--10.ucode that

pull request: new firmware for Intel wireless Intel 3160 / 7260 / 7265 / 7265D devices

2015-02-03 Thread Grumbach, Emmanuel
Hi, This is a pull request for new firmwares for the Intel wireless devices mentioned in the subject. I replace -10.ucode with new ones (that includes bug fixes). I add the brand new -12.ucode. Please pull. The following changes since commit 38e5405c96d10bb42b629b45210c46166461fc21: cxgb4:

Re: [PATCH] iwlwifi: mvm: abort scheduled scan upon RFKILL

2015-01-18 Thread Grumbach, Emmanuel
On Sun, 2015-01-18 at 23:14 +0100, Arend van Spriel wrote: On 01/18/15 21:18, Emmanuel Grumbach wrote: When we have an active scheduled scan, and the RFKILL interrupt kicks in, the stack will cancel the scheduled scan as part of the down flow. But cancelling scheduled scan usually implies

pull request: iwlwifi 2015-01-15

2015-01-18 Thread Grumbach, Emmanuel
Hi Kalle, One single patch in there, but since it hit Linus's system, and we are in -rc5 already, I didn't want to wait until more stuff accumulates. This is a patch for the bug that Linus reported. Let me know if you have issues! The following changes since commit

pull request: iwlwifi-next 2015-01-22

2015-01-22 Thread Grumbach, Emmanuel
Hi Kalle, Here is another pull request for 3.20. Let me know if you have issues. Note that I had to merge iwlwifi-fixes because of dependencies and it also fixes a conflict. I merged mac80211-next because of a dependency on a patch there. Thanks! The following changes since commit

Re: [IWLMVM] Firmware restart issue with 3.19-rc6-wl with AC 3160, REV=0x164

2015-01-31 Thread Grumbach, Emmanuel
On Sat, 2015-01-31 at 15:16 +0100, Christian Lamparter wrote: Hello, On Fri, Jan 30, 2015 at 9:35 PM, Johannes Berg johan...@sipsolutions.net wrote: On Fri, 2015-01-30 at 21:23 +0100, Christian Lamparter wrote: [6.274625] iwlwifi :01:00.0: 0x0038 | BAD_COMMAND [6.275034]

Re: [PATCH] mac80211: synchronize_net() before flushing the queues

2015-01-23 Thread Grumbach, Emmanuel
On Fri, 2015-01-23 at 10:56 +0100, Johannes Berg wrote: On Thu, 2015-01-22 at 23:30 +0200, Emmanuel Grumbach wrote: When mac80211 disconnects, it drops all the packets on the queues. This happens after the net stack has been notified that we have no link anymore (netif_carrier_off).

RE: pull request: iwlwifi 2015-01-05

2015-01-05 Thread Grumbach, Emmanuel
Grumbach, Emmanuel emmanuel.grumb...@intel.com writes: This is new content for 3.19. Details in the tag. Let me know if you have issues. Thanks! Thanks, pulled. One comment: * fix for 7265D NVM check * fixes

pull request: iwlwifi 2015-01-05

2015-01-05 Thread Grumbach, Emmanuel
Hi Kalle, This is new content for 3.19. Details in the tag. Let me know if you have issues. Thanks! The following changes since commit baa21e834941ee5fbe4bd421c871f7c0c5f9a086: iwlwifi: pcie: limit fw chunk sizes given to fh (2014-12-14 10:20:30 +0200) are available in the git repository

Re: [PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key

2015-01-12 Thread Grumbach, Emmanuel
On Mon, 2015-01-12 at 16:18 -0500, John W. Linville wrote: Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key. This will document that the lack of a break is intentional. Coverity: CID 1260023

pull request: iwlwifi 2015-01-13

2015-01-13 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for 3.19. As usual, the description is in the tag itself. This time, we are already in -rc4, no gray area patches. These are all real bug fixes. Let me know if you have issues with this. BTW - if you wish, I can add the diff in the pull request for -rc cycle.

pull request: iwlwifi 2015-03-22

2015-03-22 Thread Grumbach, Emmanuel
Hi Kalle, A new round of fixes for 4.0. Most of the patches are also CCed to stable. Details in the tag. Thanks! The following changes since commit 4cd4b50cc2429294c23a1998c33fdfd804db0f37: iwlwifi: mvm: BT Coex - fix a NULL pointer exception (2015-03-05 14:13:20 +0200) are available in the

pull request: iwlwifi 2013-03-12

2015-03-12 Thread Grumbach, Emmanuel
Hi Kalle, 2 more fixes for 4.0. Details in the tag. Please pull - thanks! The following changes since commit 4cd4b50cc2429294c23a1998c33fdfd804db0f37: iwlwifi: mvm: BT Coex - fix a NULL pointer exception (2015-03-05 14:13:20 +0200) are available in the git repository at:

Re: [PATCH net-next 0/2] build fixes for iwlwifi

2015-03-07 Thread Grumbach, Emmanuel
On Sat, 2015-03-07 at 09:27 +0200, Kalle Valo wrote: ebied...@xmission.commailto:ebied...@xmission.com (Eric W. Biederman) writes: drivers/net/wireles/iwlwifi/mvm fails to build for me on net-next. Eric W. Biederman (2): iwlwifi: mvm: Fix the build of mvm/mac-ctxt.c with debugfs

pull request: iwlwifi-next 2015-03-07

2015-03-07 Thread Grumbach, Emmanuel
Hi Kalle, This is the fix for the unfortunate compilation problem I caused in iwlwifi-next. Please pull. The following changes since commit 190f1029757346b72f297729cf8e5c562f2e9d8c: iwlwifi: mvm: don't override passive dwell in case of fragmented scan (2015-03-02 08:20:32 +0200) are

pull request: new firmware for Intel wireless Intel 3160 / 7260 / 7265 / 7265D devices

2015-03-08 Thread Grumbach, Emmanuel
Hi, This is a pull request for new firmwares for the Intel wireless devices mentioned in the subject. I replace -10.ucode with new ones (that includes bug fixes). Please pull. The following changes since commit 1e67c28c65137dd1647e597ebef45d8a0c9168f9: ath9k_htc: update versions in WHENCE

Re: [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback()

2015-03-24 Thread Grumbach, Emmanuel
On Mon, 2015-03-23 at 14:07 -0500, Larry Finger wrote: In this routine, kzalloc allocates a memory block. This allocation is freed in the error paths, but not in the normal exit, thus the allocation is leaked. The kmemleak facility was used to find the leak. Picked up - thanks.

pull request: iwlwifi 2015-03-30

2015-03-30 Thread Grumbach, Emmanuel
Hi Kalle, My last pull request for 4.0. This is a fix for a memory leak courtesy of Larry Finger (thanks to him). This patch has already been sent to the ML, so I won't reply to this pull request with git-send-email as I usually do. Please pull. Thanks. The following changes since commit

Re: [PATCH] iwlwifi: mvm: fix usage of debug specific variables

2015-03-04 Thread Grumbach, Emmanuel
Hi, On Wed, 2015-03-04 at 18:59 +0100, Alban Gruin wrote: Some variables in structs iwl_mvm and iwl_mvm_vif are used for debug purpose, and are declared only if CONFIG_IWLWIFI_DEBUGFS is set. However, some of these variables are used even if CONFIG_IWLWIFI_DEBUGFS is not set, resulting in a

pull request: iwlwifi-next 2015-03-01

2015-03-01 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for 4.1. As usual the details are in the tag. Please note that I have another set of 30-ish patch already after this pull request. A dependency in mac80211 was solved, so I can now finally send lots of work that has been made long ago. But that's for the next pull

pull request: iwlwifi 2015-03-05

2015-03-05 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for 4.0. Details in the tag as usual. Thanks! The following changes since commit f5af19d10d151c5a2afae3306578f485c244db25: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2015-02-17 17:41:19 -0800) are available in the git repository at:

Re: iwlwifi: ampdu_factor for iwl-6000 is set to 0

2015-02-22 Thread Grumbach, Emmanuel
Hi, On Sun, 2015-02-22 at 14:15 +0200, Valentin Manea wrote: Hi, Recently I started using kernel 3.19 from Ubuntu ppa and I noticed a big drop in Wifi throughput. After some investigation I found that my router was reporting the AMPDU factor changed from 3(in 3.18) to 0(in 3.19): cat

Re: pull request: new firmware for Intel wireless Intel 3160 / 7260 / 7265 / 7265D devices

2015-02-24 Thread Grumbach, Emmanuel
On Tue, 2015-02-24 at 12:49 -0500, Kyle McMartin wrote: On Fri, Feb 06, 2015 at 09:31:52AM +, Grumbach, Emmanuel wrote: On Fri, 2015-02-06 at 04:15 -0500, Kyle McMartin wrote: On Tue, Feb 03, 2015 at 09:39:28PM +, Grumbach, Emmanuel wrote: Hi, This is a pull request

Re: iwlwifi: ampdu_factor for iwl-6000 is set to 0

2015-02-22 Thread Grumbach, Emmanuel
Hi again (fixed your address, I hope it will not bounce this time...) Please test the patch attached. On Sun, 2015-02-22 at 14:19 +0200, Emmanuel Grumbach wrote: Hi, On Sun, 2015-02-22 at 14:15 +0200, Valentin Manea wrote: Hi, Recently I started using kernel 3.19 from Ubuntu ppa

RE: [PATCH] mac80211: iterate using station list in AP SMPS

2015-02-23 Thread Grumbach, Emmanuel
From: Johannes Berg johannes.b...@intel.com When changing AP SMPS, we need to look up all the stations for this interface, so there's no reason to iterate over hash chains rather than doing the simpler iteration over the station list. Yup - thank you for that. I remember I tried to find a

pull request: iwlwifi-next 2015-04-02

2015-04-02 Thread Grumbach, Emmanuel
Hi Kalle, This is for 4.1. A bunch of work all over from the team. I'll be away for a week or so, but I'll monitor email, but I hope you won't have issues with this. Let me know. Thanks! The following changes since commit 2c44be81f0fc147eed9dc63e2601318b2c007aeb: mac80211: set QoS capability

Re: iwlwifi getting stuck with current Linus' tree (646da63172)

2015-04-23 Thread Grumbach, Emmanuel
On Thu, 2015-04-23 at 14:48 +0200, Piotr Karbowski wrote: Hello, On Thu, Apr 23, 2015 at 11:15 AM, Jiri Kosina jkos...@suse.cz wrote: On Thu, 23 Apr 2015, Grumbach, Emmanuel wrote: I will try it, but I expect the result to be bogus because of this, unfortunately. I can understand

Re: iwlwifi getting stuck with current Linus' tree (646da63172)

2015-04-22 Thread Grumbach, Emmanuel
Hi, On Wed, 2015-04-22 at 22:42 +0200, Jiri Kosina wrote: Hi, I've been running current Linus' tree and have been getting system lockups frequently. After a few silent lockups, I was able to obtain a dmesg before the machine turned dead again (wifi stopped working shortly before that).

Re: iwlwifi getting stuck with current Linus' tree (646da63172)

2015-04-23 Thread Grumbach, Emmanuel
On Thu, 2015-04-23 at 10:15 +0200, Jiri Kosina wrote: On Thu, 23 Apr 2015, Grumbach, Emmanuel wrote: I've been running current Linus' tree and have been getting system lockups frequently. After a few silent lockups, I was able to obtain a dmesg before the machine turned dead

pull request: iwlwifi 2015-04-28

2015-04-28 Thread Grumbach, Emmanuel
Hi Kalle, Here is the first round of fixes for 4.1. As usual, this first round is slightly big. I hope things will settle down later. Please pull. Thanks! The following changes since commit 6c373ca89399c5a3f7ef210ad8f63dc3437da345: Merge

Re: pull request: update for -12.ucode firmware for Intel WiFi devices driven by iwlmvm

2015-05-05 Thread Grumbach, Emmanuel
On Tue, 2015-05-05 at 12:16 -0400, Kyle McMartin wrote: On Sun, May 03, 2015 at 12:32:05PM +, Grumbach, Emmanuel wrote: Dear linux-firmware maintainers, Intel released a new version of the firmware for the devices below: 3160, 7260 and 7265. This release fixes

Re: [BUG 4.1.0-rc6] iwlwifi: Error sending REPLY_TXFIFO_FLUSH: time out after 2000ms

2015-06-04 Thread Grumbach, Emmanuel
On Thu, 2015-06-04 at 22:32 +0300, Kirill A. Shutemov wrote: On Thu, Jun 04, 2015 at 06:13:22PM +, Grumbach, Emmanuel wrote: On Thu, 2015-06-04 at 20:37 +0300, Kirill A. Shutemov wrote: Hi, I've trigered the bug few times after several suspend/resume cycles. Hardware

pull request: iwlwifi-next 2015-06-03

2015-06-03 Thread Grumbach, Emmanuel
Hi Kalle, As promised, here is the enlarged pull request for 4.2. I double checked that the tag is signed this time. I also signed this email, just in case... I'll reply to this pull request with the diff between the previous one and this one. All the other patches have been sent to the ML

RE: pull request: iwlwifi-next 2015-05-28

2015-06-03 Thread Grumbach, Emmanuel
Grumbach, Emmanuel emmanuel.grumb...@intel.com writes: Hi Kalle, this is the same pull request for 4.2 with the typo fixed and without the patches that are now targeted to 4.1 Thanks The following changes since commit bbbe8c8c596b3784a2ed08772900e827f8ba72c5: mac80211

Re: pull request: iwlwifi-next 2015-06-03

2015-06-03 Thread Grumbach, Emmanuel
On Wed, 2015-06-03 at 10:24 +0300, Emmanuel Grumbach wrote: Hi Kalle, As promised, here is the enlarged pull request for 4.2. I double checked that the tag is signed this time. I also signed this email, just in case... I'll reply to this pull request with the diff between the previous one

Re: [RFC 0/5] cfg80211 / mac80211: add support for Neighbor Awareness Networking

2015-06-26 Thread Grumbach, Emmanuel
On Fri, 2015-06-26 at 06:06 +, Amitkumar Karwar wrote: Hi Emmanuel, From: Emmanuel Grumbach emmanuel.grumb...@intel.com Date: Mon, Mar 30, 2015 at 7:44 PM Subject: [RFC 0/5] cfg80211 / mac80211: add support for Neighbor Awareness Networking To: linux-wireless@vger.kernel.org Cc:

[ANN] Support for a new Intel Wireless device: 8260 / 4165

2015-06-18 Thread Grumbach, Emmanuel
Intel just released the firmware for the new Wireless devices: 8260 and 4165. As mentioned in iwlwifi's wiki page [1], these devices are supported starting from kernel 4.1. The firmware is available on that same wiki page [2]. It is also available on Intel wireless's clone of linux-firmware.git

pull request: add -13.ucode firmware for Intel Wireless

2015-06-18 Thread Grumbach, Emmanuel
Hi, This is a pull request for a new version of the firmware for Intel wireless devices. Note that with this new firmware, we are now adding support for 3 new devices: 3165, 8260 and 4165. I had sent a pull request a while ago, this one replaces the older one. Since then, we have added bug fixes

Re: [PATCH] iwlwifi:dvm:Return false if resume command data is not same size as received packet for the function iwl_resume_status_fn

2015-06-10 Thread Grumbach, Emmanuel
On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote: This makes the function iwl_resume_status_fn return false now if the received packet of type iwl_rx_packet is not the same size as the structure pointer, iwl_resume_data's cmd element in order to signal callers about this error and

Re: [PATCH] iwlwifi:dvm:Return false if resume command data is not same size as received packet for the function iwl_resume_status_fn

2015-06-10 Thread Grumbach, Emmanuel
On Wed, 2015-06-10 at 12:58 -0400, Nicholas Krause wrote: On June 10, 2015 12:50:45 PM EDT, Grumbach, Emmanuel emmanuel.grumb...@intel.com wrote: On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote: This makes the function iwl_resume_status_fn return false now if the received packet

Re: pull request: iwlmvm firmware -13.ucode

2015-05-28 Thread Grumbach, Emmanuel
and now with linux-wireless :) On Thu, 2015-05-28 at 20:53 +0300, Emmanuel Grumbach wrote: Signed this time. On Thu, 2015-05-28 at 20:53 +0300, Emmanuel Grumbach wrote: Hello, This is a pull request to include -13.ucode into mainline. This firmware can run on 7260, 3160, 7265,

Re: iwlwifi/iwlmvm dies on resume when rfkill is set

2015-06-01 Thread Grumbach, Emmanuel
On Mon, 2015-06-01 at 15:51 -0700, Andy Lutomirski wrote: If I switch my laptop into airplane mode (hardware switch) and then suspend and resume, my wireless is dead on resume and it spews all over the kernel log (see below). I can rescue it by switching airplane mode off and then suspending

Re: [PATCH 07/39] iwlwifi: dump API to 14

2015-05-27 Thread Grumbach, Emmanuel
On Tue, 2015-05-26 at 21:39 +0200, Rafał Miłecki wrote: On 26 May 2015 at 21:17, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: The iwlmvm driver is now able to handle -14.ucode. Dump? Bump? ;) Ha! Someone actually looking at the patches. Good thing. No, it was not on purpose ;)

RE: pull request: iwlwifi-next 2015-05-26

2015-05-28 Thread Grumbach, Emmanuel
Grumbach, Emmanuel emmanuel.grumb...@intel.com writes: this is a pull request for 4.2. Nothing really stands out besides what I wrote in the tag. Even the diffstat hints what is the biggest part of this pull request :) I see there was a minor comment to one of the patches. Can I

RE: pull request: iwlwifi-next 2015-05-26

2015-05-28 Thread Grumbach, Emmanuel
Grumbach, Emmanuel emmanuel.grumb...@intel.com writes: Note that there are fixes here that didn't make it to my previous pull request for 4.1. I tagged them for stable since the wording of your last pull request for 4.1 to Dave hinted me that you won't send any pull request

pull request: iwlwifi-next 2015-05-28

2015-05-28 Thread Grumbach, Emmanuel
Hi Kalle, this is the same pull request for 4.2 with the typo fixed and without the patches that are now targeted to 4.1 Thanks The following changes since commit bbbe8c8c596b3784a2ed08772900e827f8ba72c5: mac80211: add missing documentation for rate_ctrl_lock (2015-05-06 16:00:32 +0200)

pull request: iwlwifi 2015-05-28

2015-05-28 Thread Grumbach, Emmanuel
Hi Kalle, as we talked, here is the pull request for 4.1. Thanks. The following changes since commit 292208914d8ca5a41cf68c2f1d2810a2ea2044e9: iwlwifi: mvm: avoid use-after-free on iwl_mvm_d0i3_enable_tx() (2015-05-21 22:36:46 +0300) are available in the git repository at:

Re: [linuxwifi] [PATCH] iwlwifi: Remove use of the deprecacted marco, PTR_RET for the function, iwl_mvm_get_regdomain

2015-05-25 Thread Grumbach, Emmanuel
On Sat, 2015-05-23 at 20:53 -0400, Nicholas Krause wrote: This removes the use of the two deprecated calls to the marco, PTR_RET in the function, iwl_mvm_get_regdomain and replaces them both with a call to the function, PTR_ERR_OR_ZERO. Signed-off-by: Nicholas Krause xerofo...@gmail.com

pull request: iwlwifi 2015-05-21

2015-05-21 Thread Grumbach, Emmanuel
Hi Kalle, I am aware that this pull request is quite large for 4.1, but I really think that all these patches are really justified. A few of them fix 3165 and 8260 which will be supported starting from 4.1. Other patches fix random bugs that were discovered just now. Note that my availability is

pull request: iwlwifi-next 2015-05-26

2015-05-26 Thread Grumbach, Emmanuel
Hi Kalle, this is a pull request for 4.2. Nothing really stands out besides what I wrote in the tag. Even the diffstat hints what is the biggest part of this pull request :) Note that there are fixes here that didn't make it to my previous pull request for 4.1. I tagged them for stable since the

pull request: iwlwifi-next 2015-08-18

2015-08-18 Thread Grumbach, Emmanuel
Hi Kalle, This is another pull request for 4.3. As usual, details in the tag. As announced, this needs patches from mac80211-next, so I merged Johanne's tag and you did so as well upon my request (thank you for that). Please pull and let me know if you have issues. The following changes since

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 07:08 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote: I'll look at it. I was almost starting to implement that but then I thought with another (good?) reason to use LSO. LSO gives me the guarantee that the packet is directed to one peer

Re: [RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 05:18 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: The segmentation is done completely in software. The driver creates several MPDUs out of a single large send. Each MPDU is a newly allocated SKB. A page is allocated to create the headers

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 05:24 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
Hi, On 08/19/2015 10:10 PM, Sergei Shtylyov wrote: Hello. On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 10:21 AM, Grumbach, Emmanuel wrote: On 08/19/2015 11:39 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: Hm.. how would net/core/tso.c avoid this? Because a driver using these helpers keep around the original LSO packet and frees

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/19/2015 11:39 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: Hm.. how would net/core/tso.c avoid this? Because a driver using these helpers keep around the original LSO packet and frees it normally at TX completion time. Which is why I can't

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/19/2015 11:39 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: Hm.. how would net/core/tso.c avoid this? Because a driver using these helpers keep around the original LSO packet and frees it normally at TX completion time. I can't see anything

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:11 PM, Eric Dumazet wrote: On Thu, 2015-08-20 at 06:21 +, Grumbach, Emmanuel wrote: On 08/19/2015 11:39 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: Hm.. how would net/core/tso.c avoid this? Because a driver using these helpers

Re: [RFC v3 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:13 PM, Eric Dumazet wrote: On Thu, 2015-08-20 at 11:15 +0300, Emmanuel Grumbach wrote: The segmentation is done completely in software. The driver creates several MPDUs out of a single large send. Each MPDU is a newly allocated SKB. A page is allocated to create the headers

Re: [patch] iwlwifi: mvm: catch underflow error earlier

2015-08-22 Thread Grumbach, Emmanuel
Hi Dan, On 08/21/2015 11:49 AM, Dan Carpenter wrote: My static checker complains that we don't check for underflows in iwl_dbgfs_fw_dbg_conf_write(). This is harmless because we have a sanity check in iwl_mvm_start_fw_dbg_conf(), but we may as well make this unsigned and silence the

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:53 PM, Grumbach, Emmanuel wrote: On 08/20/2015 04:11 PM, Eric Dumazet wrote: On Thu, 2015-08-20 at 06:21 +, Grumbach, Emmanuel wrote: On 08/19/2015 11:39 PM, Eric Dumazet wrote: On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: Hm.. how would net/core

Re: [linuxwifi] Random connection loss

2015-07-29 Thread Grumbach, Emmanuel
Hi, On 07/29/2015 10:57 PM, a...@keemail.me wrote: I'm not quite sure how to trace the problem to its roots. My wireless connection is disconnected and reconnects again. I can't reproduce this nor can I tell at what rate it disconnects. I didn't experience it before upgrading the kernel

RE: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

2015-07-28 Thread Grumbach, Emmanuel
On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index c8ba2e7..a758eb84 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c @@ -97,7 +97,8 @@ static void

Re: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

2015-07-28 Thread Grumbach, Emmanuel
On 07/28/2015 02:35 PM, Grumbach, Emmanuel wrote: On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index c8ba2e7..a758eb84 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c

[no subject]

2015-07-30 Thread Grumbach, Emmanuel
ds dsa -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

pull request: iwlwifi 2015-07-30

2015-07-30 Thread Grumbach, Emmanuel
Hi Kalle, Here is another pull request for 4.2. Three small fixes this time. Let me know if you have any issues. Note that my availability will be limited next week, and the week after I'll be completely offline. Thanks! The following changes since commit

pull request: iwlwifi-next 2015-08-04

2015-08-04 Thread Grumbach, Emmanuel
Hi Kalle, It comes late, but this is the first pull request for 4.3. I have quite a bit for the next one that will come after this one. Please pull - thanks! emmanuel The following changes since commit e0456717e483bb8a9431b80a5bdc99a928b9b003: Merge

Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-13 Thread Grumbach, Emmanuel
Hi, On 08/14/2015 03:36 AM, Adrien Schildknecht wrote: Both loops of this function compare data from the 'chan' array and then check if the index is valid. The 2 conditions should be inverted to avoid an out-of-bounds access. Was that found by a static analyzer or any other automated

  1   2   3   >