On Tue, Jan 26, 2016 at 12:29:57PM +0100, Ilya Dryomov wrote:
>
> LGTM. You want to take it through crypto?
That's probably the easiest route since I'd like to take the first
patch through cryptodev.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Hom
ypto_skcipher_setkey((void *)tfm, key, key_len);
- memcpy(iv, aes_iv, ivsize);
+ memcpy(iv, aes_iv, AES_BLOCK_SIZE);
skcipher_request_set_tfm(req, tfm);
skcipher_request_set_callback(req, 0, NULL, NULL);
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Pag
On Sun, Jan 24, 2016 at 07:10:50PM +0100, Julia Lawall wrote:
> Maybe the goto on line 1726 needs a preceding mutex_unlock?
Good catch! Thanks.
---8<---
This patch replaces uses of ablkcipher and blkcipher with skcipher,
and the long obsolete hash interface with shash.
Signed-off-by: Herb
This patch replaces uses of the long obsolete hash interface with
ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
include/net/tcp.h |6 +-
net/ipv4/tcp.c | 41 ++---
net/ipv4/tcp_fastopen.c |1 +
ne
This patch replaces uses the long obsolete hash interface with ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/net/wireless/intersil/orinoco/mic.c | 29 ++--
drivers/net/wireless/intersil/orinoco/mic.h |4 +--
drivers/net/wi
This patch replaces uses of blkcipher with skcipher, and the long
obsolete hash interface with ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 92 +++---
drivers/staging/rtl8192u/iee
This patch replaces uses of ablkcipher with skcipher, and the long
obsolete hash interface with ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/md/dm-crypt.c | 93 +-
1 file changed, 48 insertions(+), 45 del
This patch replaces uses of blkcipher with skcipher, and the long
obsolete hash interface with ahash. This is a bug-for-bug conversion
and no attempt has been made to fix bugs such as the ignored return
values of the crypto operations.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org
The interfaces blkcipher and hash are obsolete. This patch replaces
them with skcipher and ahash respectively.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 99 ++-
drivers/staging/rt
This patch replaces uses of ablkcipher and blkcipher with skcipher,
and the long obsolete hash interface with shash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
fs/ecryptfs/crypto.c | 107 +---
fs/ecryptfs/ecryptfs_kernel.h | 12 +-
fs/ec
This patch replaces uses of blkcipher with skcipher and the long
obsolete hash interface with either shash (for non-SG users) and
ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
include/linux/sunrpc/gss_krb5.h | 32 +--
net/sunrpc/auth_gss/gss_krb5_crypto.c
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/usb/wusbcore/crypto.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/wusbcore/crypto.c b/drive
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/mac802154/llsec.c | 41 +++--
net/mac802154/llsec.h |3 +--
2 files changed, 24 insertions(+), 20 deletions(-)
diff --git
This patch replaces uses of blkcipher with skcipher and the long
obsolete hash interface with shash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/bluetooth/smp.c | 135
1 file changed, 63 insertions(+), 72 del
This patch replaces uses of the long obsolete hash interface with
shash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
include/net/sctp/auth.h|4 +--
include/net/sctp/structs.h |6 ++---
net/sctp/auth.c| 36 ---
ne
This patch replaces uses of the long obsolete hash interface with
ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/scsi/iscsi_tcp.c| 54 ++--
drivers/scsi/iscsi_tcp.h|4 +--
drivers/scsi/libiscsi_tcp.c
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
fs/cifs/cifsencrypt.c | 32 +---
fs/cifs/smbencrypt.c | 26 +++---
2 files changed, 40 insertions(+), 18 deletions(-)
This patch replaces uses of the long obsolete hash interface with
shash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
fs/nfsd/nfs4recover.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/fs/nfsd/nfs4recover.c b/f
This patch replaces uses of ablkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
fs/ext4/crypto.c | 24 +++-
fs/ext4/crypto_fname.c | 32 +++-
fs/ext4/crypto_key.c
This patch replaces uses of blkcipher with the new skcipher
interface.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/block/cryptoloop.c | 48 +++--
1 file changed, 25 insertions(+), 23 deletions(-)
diff --git a/drivers
.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/xfrm/xfrm_algo.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
index f07224d..250e567 100644
--- a/net/xfrm/xfrm_algo.c
+++ b/net/xfrm/xfrm_algo.c
@
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/rxrpc/ar-internal.h |2
net/rxrpc/ar-key.c | 12 +--
net/rxrpc/rxkad.c | 172 +---
3 files change
This patch replaces uses of blkcipher with skcipher and the long
obsolete hash interface with ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/wireless/lib80211_crypt_tkip.c | 99 -
net/wireless/lib80211_crypt_wep.c
This patch replaces uses of the long obsolete hash interface with
either shash (for non-SG users) or ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/target/iscsi/iscsi_target.c | 86 ++
drivers/target/iscsi/iscsi_target_auth.c
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/ceph/crypto.c | 97 +++---
1 file changed, 56 insertions(+), 41 deletions(-)
diff --git a/net/ceph/crypto.c b/ne
This patch replaces uses of the long obsolete hash interface with
either shash (for non-SG users) or ahash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/block/drbd/drbd_int.h | 16 +-
drivers/block/drbd/drbd_main.c | 16 +-
drivers/bloc
would like
to take these patches through the cryptodev tree so we can proceed
with phasing out the obsolete interfaces.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsub
This patch replaces uses of the long obsolete hash interface with
shash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
drivers/nfc/s3fwrn5/firmware.c | 36 +++-
1 file changed, 27 insertions(+), 9 deletions(-)
diff --git a/drivers/nfc/s
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
security/keys/encrypted-keys/encrypted.c | 82 ++-
1 file changed, 50 insertions(+), 32 deletions(-)
diff --git a/security/keys/encrypte
This patch replaces uses of ablkcipher with skcipher.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
fs/f2fs/crypto.c | 24 +++-
fs/f2fs/crypto_fname.c | 32 +++-
fs/f2fs/crypto_key.c
pend on the two helpers that I posted yesterday
so unfortunately we'll be getting quite a few build errors from
the bot.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
; is, after all, very much a case that "normal" operation doesn't even
> get close to.
I think you should just turn it on everywhere for mac80211. Chain
length checks simply don't make sense when you allow duplicate
keys in the hash table.
Cheers,
--
Email: Herbert Xu <herb...
to do this, then
we have the parameter insecure_elasticity that you can use to
disable the rehashing based on chain length.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscri
urring, unless your chain-length exceeds 2^32.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-wire
il
> hitting a certain number of identical keys, surely that's just me not
> understanding the code rather than anything else :)
It's really simple, rhashtable_insert_fast does not check for dups
while rhashtable_lookup_insert_* do.
Cheers,
--
Email: Herbert Xu <herb...@gondo
times? In particular, __ieee80211_rx_handle_packet would appear
to process the same packet multiple times if this were to happen.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubk
On Thu, Aug 04, 2016 at 03:18:46PM +0800, Herbert Xu wrote:
>
> So the question is can wireless handle seeing an entry multiple
> times? In particular, __ieee80211_rx_handle_packet would appear
> to process the same packet multiple times if this were to happen.
It's worse th
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kerne
efore
I'm ready because I need to work through some crypto patches first.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "
On Tue, Aug 09, 2016 at 11:37:39AM +0200, Stephan Mueller wrote:
> Am Dienstag, 9. August 2016, 17:17:55 CEST schrieb Herbert Xu:
>
> Hi Herbert,
>
> > On Tue, Aug 09, 2016 at 11:02:58AM +0200, Stephan Mueller wrote:
> > > But shouldn't the default of the
On Tue, Aug 09, 2016 at 11:56:08AM +0200, Stephan Mueller wrote:
> Am Dienstag, 9. August 2016, 17:46:56 CEST schrieb Herbert Xu:
>
> Hi Herbert,
> >
> > You're supposed to tweak the quality of the input. In any case,
>
> How is that tweak supposed to happen? The r
On Tue, Aug 09, 2016 at 11:02:58AM +0200, Stephan Mueller wrote:
>
> But shouldn't the default of the rngd then be adjusted a bit?
Please elaborate.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.
en the output
/dev/hw_random. It was always meant to go through some intermediate
processing such as rngd before it is used.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.tx
est a synchronous algorithm (that is, one with the
CRYPTO_ALG_ASYNC bit set to zero), you would set type to 0 and
mask to CRYPTO_ALG_ASYNC.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
for rhlist, including the hash table walker.
One missing feature is nulls marking because AFAIK the only potential
user of it does not need duplicate objects. Should anyone need
this it shouldn't be too hard to add.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
include
to use it. If this works
out I'll then proceed to convert the other insecure_elasticity
users over to this.
I've tested the rhlist code with test_rhashtable but I haven't
tested the mac80211 conversion. So please give it a go and see
if it still works.
Thanks!
--
Email: Herbert
defaults to jhash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/mac80211/ieee80211_i.h |2 -
net/mac80211/rx.c |7 +-
net/mac80211/sta_info.c| 52 ++---
net/mac80211/sta_info.h| 19 ++-
e to run a
> single test ("wpas_ctrl_interface_add_many") to get there.
Aha I see the problem now. The nelems logic on remove is broken.
I'll send out a v3.
Thanks!
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
and see
if it still works.
Thanks!
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
for rhlist, including the hash table walker.
One missing feature is nulls marking because AFAIK the only potential
user of it does not need duplicate objects. Should anyone need
this it shouldn't be too hard to add.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
include
defaults to jhash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/mac80211/ieee80211_i.h |2 -
net/mac80211/rx.c |7 +-
net/mac80211/sta_info.c| 52 ++---
net/mac80211/sta_info.h| 19 ++-
On Mon, Sep 19, 2016 at 11:16:21PM +0200, Thomas Graf wrote:
>
> Nice, I like how this simplifies users! Is this suitable for
> ILA as well?
Does it have duplicate objects and use inelastic_security? If so
then yes it should switch over to rhlist.
Cheers,
--
Email: Herbert
defaults to jhash.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
net/mac80211/ieee80211_i.h |2 -
net/mac80211/rx.c |7 +-
net/mac80211/sta_info.c| 52 ++---
net/mac80211/sta_info.h| 19 ++-
for rhlist, including the hash table walker.
One missing feature is nulls marking because AFAIK the only potential
user of it does not need duplicate objects. Should anyone need
this it shouldn't be too hard to add.
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
---
include
you're seeing but I'll do a v2 posting.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
insecure_elasticity
users over to this.
I've tested the rhlist code with test_rhashtable but I haven't
tested the mac80211 conversion. So please give it a go and see
if it still works.
Thanks!
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
P
On Mon, Sep 19, 2016 at 11:15:30AM +0200, Johannes Berg wrote:
> On Mon, 2016-09-19 at 16:40 +0800, Herbert Xu wrote:
>
> > I've tested the rhlist code with test_rhashtable but I haven't
> > tested the mac80211 conversion. So please give it a go and see
> > if it still w
On Mon, Sep 19, 2016 at 11:27:24AM +0200, Johannes Berg wrote:
>
> I have a feeling there's a bug with ht->nelems, since the crash is
> always in the grow worker, but I haven't quite put my finger on it yet.
Can you show me a stack trace?
Thanks,
--
Email: Herb
he
very first user of async crypto.
mac80211 on the other hand is currently sync-only.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
AES_BLOCK_SIZE);
>
> or
>
> crypto_xor(keystream, src, nbytes);
> memcpy(dst, keystream, nbytes);
What keeping crypto_xor as it is and adding a new entry point for
the 4-argument case?
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.
enerates the secret key in the first
place. AFAICS that's only called in GFP_KERNEL context. What
am I missing?
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
t when the key is generated. That's sctp_endpoint_init
which AFAICS only gets called in GFP_KERNEL context.
Or is there a code-path where sctp_endpoint_init is called in
softirq context?
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PG
or every hashing operation. But so far these are uses have
been very few so there has been no need to provide an API for them.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote:
>
> That was my point. Functions like sctp_pack_cookie shouldn't be
> setting the key in the first place. The setkey should happen at
> the point when the key is generated. That's sctp_endpoint_init
> which AFAICS o
API, rather
than touching actual crypto API code, I think you should handle it
as you do with any other wireless patch.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ould
stay there.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Oct 11, 2018 at 12:08:57PM +0200, Johannes Berg wrote:
>
> Herbert, maybe you can drop the patch from the crypto tree since my
> change also removes the VLA usage?
Sorry but it's too late now.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP
67 matches
Mail list logo
