Re: [PATCH 09/12] wireless-regdb: Add Saint Lucia (LC) regulatory rules

2014-09-04 Thread Johannes Berg
On Wed, 2014-09-03 at 16:15 +0300, Jouni Malinen wrote: Source: http://www.ntrc.org.lc/operational_structures.htm Out of curiosity, I clicked the URL, but it seems empty/dead? :) johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: Anyone working on making iw able to specify MAC address at station creation time?

2014-09-05 Thread Johannes Berg
On Thu, 2014-09-04 at 10:51 -0700, Ben Greear wrote: I'm having issues with udev renaming newly created stations when I have udev rules for wlanX, when wlanX is not already existing. I think specifying MAC on station creation time would solve my problems, but haven't looked closely yet.

[RFC v2] device coredump: add new device coredump class

2014-09-05 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com Many devices run firmware and/or complex hardware, and most of that can have bugs. When it misbehaves, however, it is often much harder to debug than software running on the host. Introduce a device coredump mechanism to allow dumping internal device

Re: [PATCHv5 0/2] configure dynack through mac80211/cfg80211 stack

2014-09-05 Thread Johannes Berg
On Thu, 2014-09-04 at 23:57 +0200, Lorenzo Bianconi wrote: Enable ACK timeout estimation algorithm (dynack) using mac80211 set_coverage_class API. Dynack is activated passing -1 as coverage class to lower drivers and it is automatically disabled setting valid value for coverage class.

Re: [PATCH] mac80211: fix broken use of VHT/20Mhz with some APs

2014-09-05 Thread Johannes Berg
On Thu, 2014-09-04 at 22:37 +0300, Emmanuel Grumbach wrote: From: Eyal Shapira e...@wizery.com commit mac80211: disable 40MHz support in case of 20MHz AP broke working VHT in 20Mhz with APs like Netgear R6300v2 which do not publish support for 40Mhz but allow use of VHT in 20Mhz. The break

Re: [RFC v2] device coredump: add new device coredump class

2014-09-08 Thread Johannes Berg
On Fri, 2014-09-05 at 15:13 -0700, Greg Kroah-Hartman wrote: + /* +* this seems racy, but I don't see a notifier or such on +* a struct device to know when it goes away? +*/ + if (devcd-failing_dev-kobj.sd) + sysfs_delete_link(devcd-failing_dev-kobj,

Re: [PATCH] iwlwifi/iwl-drv.c: fix typo defualt - default

2014-09-09 Thread Johannes Berg
On Tue, 2014-09-09 at 20:08 +0200, Toralf Förster wrote: trivial, but this is user visible b/c it is in the help text Since I saw it I just picked it up into our tree - it'll make it's way through the system. Thanks. johannes -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH net-next] mac80211: Check correct skb for shared states before freeing original

2014-09-10 Thread Johannes Berg
On Wed, 2014-09-10 at 16:06 -0400, Alexander Duyck wrote: The code for cloning the skb for an acknowledgement was checking to see if the cloned skb was shared and if it was it was then freeing the original skb. Since a clone should never really be shared I suspect that the intention was to

Re: [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()

2014-09-11 Thread Johannes Berg
On Thu, 2014-09-11 at 04:02 +, Sharma, Sanjeev wrote: -Original Message- From: Johannes Berg [mailto:johan...@sipsolutions.net] Sent: Friday, August 22, 2014 5:01 PM To: Sharma, Sanjeev Cc: d...@gentoo.org; k...@deine-taler.de; linvi...@tuxdriver.com; linux-wireless

Re: [PATCH net-next 2/2] mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path

2014-09-11 Thread Johannes Berg
On Wed, 2014-09-10 at 18:05 -0400, Alexander Duyck wrote: There is a possible issue with the use, or lack thereof of sk_refcnt and sk_wmem_alloc in the wifi ack status functionality. Specifically if a socket were to request acknowledgements, and the socket were to have sk_refcnt drop to 0

Re: [PATCH 1/4] cfg80211: clear connect keys when freeing them

2014-09-11 Thread Johannes Berg
On Wed, 2014-09-10 at 13:39 +0300, Emmanuel Grumbach wrote: From: Johannes Berg johannes.b...@intel.com When freeing the connect keys, clear the memory to avoid having the key material stick around in memory forever. Applied, except for patch 4 which is actually pointless. johannes

Re: [PATCH] cfg80211: clear nl80211 messages carrying keys after processing

2014-09-11 Thread Johannes Berg
On Wed, 2014-09-10 at 15:00 +0300, Emmanuel Grumbach wrote: From: Johannes Berg johannes.b...@intel.com Clear any nl80211 messages that might contain keys after processing them to avoid leaving their data in memory forever after they've been freed. Applied. johannes -- To unsubscribe from

Re: [PATCH v2 2/2] mac80211: improve minstrel_ht rate sorting by throughput probability

2014-09-11 Thread Johannes Berg
On Tue, 2014-09-09 at 23:22 +0200, Thomas Huehn wrote: This patch improves the way minstrel_ht sorts rates according to throughput and success probability. 3 FOR-loops across the entire rate and mcs group set in function minstrel_ht_update_stats() which where used to determine the fastest,

Re: [PATCH v3 1/2] cfg80211: add ops to query mesh proxy path table

2014-09-11 Thread Johannes Berg
On Fri, 2014-09-05 at 15:06 +0200, Henning Rogge wrote: Add two new cfg80211 operations for querying the content of the the mac80211s proxy path table Please use shorter line lengths, and formulate it in a generic way - this shouldn't be mac80211 specific. johannes -- To unsubscribe from

Re: iw: Add support for mesh proxy path dump

2014-09-11 Thread Johannes Berg
On Mon, 2014-09-01 at 13:34 +0200, Henning Rogge wrote: Add mpp get and mpp dump command to query to mac80211s mesh proxy path table. Signed-off-by: Henning Rogge henning.ro...@fkie.fraunhofer.de --- Makefile | 2 +- mpp.c | 84

Re: [PATCH] cfg80211/mac80211: add wmm info to assoc event

2014-09-11 Thread Johannes Berg
On Tue, 2014-09-09 at 17:09 +0300, Emmanuel Grumbach wrote: From: Eliad Peller el...@wizery.com Userspace might need to know what queues are configured for uapsd (e.g. for setting proper default values in tspecs). Add this bitmap to the association event (inside wmm nested attribute)

Re: [PATCH v3 1/2] cfg80211: add ops to query mesh proxy path table

2014-09-11 Thread Johannes Berg
On Thu, 2014-09-11 at 12:43 +0200, Henning Rogge wrote: On Thu, Sep 11, 2014 at 12:18 PM, Johannes Berg johan...@sipsolutions.net wrote: On Fri, 2014-09-05 at 15:06 +0200, Henning Rogge wrote: Add two new cfg80211 operations for querying the content of the the mac80211s proxy path table

Re: [PATCH 1/3] cfg80211: allow requesting SMPS mode on ap start

2014-09-11 Thread Johannes Berg
On Wed, 2014-09-10 at 14:07 +0300, Emmanuel Grumbach wrote: From: Eliad Peller el...@wizery.com Add feature bits to indicate device support for static-smps and dynamic-smps modes. Add a new NL80211_ATTR_SMPS_MODE attribue to allow configuring the smps mode to be used by the ap (e.g.

[PATCH] device coredump: add new device coredump class

2014-09-12 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com Many devices run firmware and/or complex hardware, and most of that can have bugs. When it misbehaves, however, it is often much harder to debug than software running on the host. Introduce a device coredump mechanism to allow dumping internal device

Re: [PATCH v4 1/2] iw: Allow user to provide freq during mesh join

2014-10-06 Thread Johannes Berg
On Tue, 2014-09-23 at 09:14 +0800, Chun-Yeow Yeoh wrote: Allow user to configure frequency and channel type during mesh join command. I think I saw another v4 of this, was this meant to be v5? johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a

Re: Proper way to use mac80211_hwsim.h in user-space tool?

2014-10-06 Thread Johannes Berg
On Mon, 2014-09-29 at 15:46 -0700, Ben Greear wrote: As far as I can tell, the .h file is not installed anywhere in a normal OS. What is the proper method to get this file sanitized and put into a more common location? You mean from the kernel build? Then you'd have to move it into the

Re: [PATCH v2 1/4] wireless: expose set-wiphy-name method to other modules.

2014-10-06 Thread Johannes Berg
On Fri, 2014-09-26 at 16:24 -0700, gree...@candelatech.com wrote: +/* + * Attempt to rename a device. Acquire RTNL before calling. + */ please add kernel-doc +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname); Should also be const char * And should probably be called

Re: [PATCH v2 4/4] hwsim: support creating wiphy w/out creating wlanX.

2014-10-06 Thread Johannes Berg
You also really need to work on the subject prefixes... They should be 1) cfg80211 2) mac80211-hwsim: 3) mac80211: 4) mac80211-hwsim: johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v6 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions)

2014-10-06 Thread Johannes Berg
On Wed, 2014-09-17 at 01:47 +0200, Steinar H. Gunderson wrote: On Mon, Sep 08, 2014 at 10:53:20AM +0200, Johannes Berg wrote: Linux already supports 802.11h, where the access point can tell the client to reduce its transmission power. However, 802.11h is only defined for 5 GHz, where

Re: [PATCH v2] cfg80211: allow to configure dynamic PS timeout

2014-10-06 Thread Johannes Berg
On Wed, 2014-10-01 at 11:27 +0200, Stanislaw Gruszka wrote: Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug is not possible to set using that tool. That's interesting, what's that bug? Allow to configure PS timeout via nl80211 - add

Re: [PATCH v4 1/2] iw: Allow user to provide freq during mesh join

2014-10-06 Thread Johannes Berg
On Mon, 2014-10-06 at 23:48 +0800, Yeoh Chun-Yeow wrote: Hi, Johannes There are actually two different patches. The latest one, both of them are named as v4. Right, sorry. I'm clearly going through email too quickly. johannes -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/3] mac-hwsim: add ethtool stats support.

2014-10-07 Thread Johannes Berg
On Thu, 2014-09-25 at 14:22 -0700, gree...@candelatech.com wrote: +static const char mac80211_hwsim_gstrings_stats[][ETH_GSTRING_LEN] = { + tx_pkts_nic, + tx_bytes_nic, + rx_pkts_nic, + rx_bytes_nic, + d_tx_dropped, + d_tx_failed, + d_ps_mode, + d_group,

Re: [RFC] mac80211: enable DFS with channel contexts

2014-10-07 Thread Johannes Berg
On Thu, 2014-10-02 at 08:45 +0200, Michal Kazior wrote: It is okay to enable DFS for channel contexts based drivers as long as no combination advertises radar detection and multi-channel operation at the same time. Don't we already check the latter in cfg80211? johannes -- To unsubscribe

Re: [PATCH v2] cfg80211: allow to configure dynamic PS timeout

2014-10-07 Thread Johannes Berg
On Tue, 2014-10-07 at 13:03 +0200, Stanislaw Gruszka wrote: On Mon, Oct 06, 2014 at 05:00:40PM +0200, Johannes Berg wrote: On Wed, 2014-10-01 at 11:27 +0200, Stanislaw Gruszka wrote: Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug

Re: [PATCH v2] cfg80211: allow to configure dynamic PS timeout

2014-10-07 Thread Johannes Berg
On Tue, 2014-10-07 at 18:02 +0530, Krishna Chaitanya wrote: iw/iwconfig tools are not only used by regular users but also used by developers/ engineers. We use it heavily for all our wifi testing, and when debugging performance related issue having a configurable ps timeout is of value. We

Re: [RFC] mac80211: enable DFS with channel contexts

2014-10-07 Thread Johannes Berg
On Tue, 2014-10-07 at 15:43 +0200, Michal Kazior wrote: Correct. However ieee80211_radar_detected() takes only ieee80211_hw as an argument now. Skipping this check in mac80211 might bite later if someone extends cfg80211 later for multi-channel radar detection with non-mac80211 driver in mind

Re: [PATCH 1/5] net: rfkill: gpio: Configurable GPIO idx

2014-10-08 Thread Johannes Berg
On Wed, 2014-10-08 at 10:34 +0200, Loic Poulain wrote: + { BCM2E1A, (kernel_ulong_t)acpi_default_bluetooth }, Shouldn't that be uintptr_t? johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/4] cfg80211: Join and Leave handling for OCB mode

2014-10-09 Thread Johannes Berg
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote: Signed-off-by: Rostislav Lisovy rostislav.lis...@fel.cvut.cz A bit more commit log would be good :) +++ b/include/net/cfg80211.h @@ -375,6 +375,8 @@ static inline enum nl80211_channel_type cfg80211_get_chandef_type(const struct

Re: [PATCH] mac80211: fix warning on htmldocs for last_tdls_pkt_time

2014-10-09 Thread Johannes Berg
On Sun, 2014-09-14 at 21:48 +0300, Emmanuel Grumbach wrote: From: Liad Kaufman liad.kauf...@intel.com Forgot to add an entry to the struct description of sta_info. Applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH v2 2/2] iw: add vendor send command

2014-10-09 Thread Johannes Berg
On Mon, 2014-09-15 at 12:47 +0200, Janusz Dziedzic wrote: + while ((data = fgetc(file)) != EOF) { Why are you using fgetc() rather than just fread() or read()? johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH] mac80211: minstrel_ht: fix MCS_GROUP_RATES usage

2014-10-09 Thread Johannes Berg
On Mon, 2014-09-29 at 02:36 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Commit 4441e8e9 (mac80211: improve minstrel_ht rate sorting by throughput probability) That commit ID doesn't exist? Anyway, I fixed it. I applied the patch - but to mac80211-next since

Re: [PATCH] mac80211: return the vif's chandef in ieee80211_cfg_get_channel()

2014-10-09 Thread Johannes Berg
On Tue, 2014-09-30 at 07:08 +0300, Emmanuel Grumbach wrote: From: Luciano Coelho luciano.coe...@intel.com The chandef of the channel context a vif is using may be different than the chandef of the vif itself. For instance, the bandwidth used by the vif may be narrower than the one

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Is that really trivial? It seems to have some impact on the code, but I can't right now say exactly what the impact is. Can you describe it and say whether I should add it to mac80211 or

Re: [PATCH 1/1 net-next] net: rfkill: kernel-doc warning fixes

2014-10-09 Thread Johannes Berg
Applied, with a somewhat better changelog. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/2] mac80211: implement cfg80211_ops to query mesh proxy path table

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 10:10 +0200, Henning Rogge wrote: I think it should be reasonable safe. The variable is only increased (never decreased) and is used as a information version number for the dumps via netlink to the userspace. I think the current userspace tools ignore the variable

Re: [PATCH v2 1/7] nl80211: sanity check the channel switch counter value

2014-10-09 Thread Johannes Berg
On Wed, 2014-10-08 at 09:48 +0300, Luca Coelho wrote: From: Luciano Coelho luciano.coe...@intel.com The nl80211 channel switch count attribute (NL80211_ATTR_CH_SWITCH_COUNT) is specified as u32, but the specification uses u8 for the counter. To make sure strange things don't happen without

Re: [PATCH v2 0/7] mac80211: some more channel switch work

2014-10-09 Thread Johannes Berg
All applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] cfg80211: set the rates mask in connection probes over specified freq

2014-10-09 Thread Johannes Berg
On Tue, 2014-10-07 at 11:42 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com ATM, specifying the frequency when connecting sends a void 'supported rates' EID. Seems like this should be a stable fix? johannes -- To unsubscribe from this list: send the line

Re: [PATCH] mac80211: Call mgd_prepare_tx before deauthentication

2014-10-09 Thread Johannes Berg
On Thu, 2014-09-18 at 11:19 +0530, Sujith Manoharan wrote: I can see your point and agree that the original intention of the mgd_prepare_tx() callback is as described in the documentation. But with multiple active contexts, flush() becomes a big hammer rather than a simple emptying of the

Re: [PATCH 2/3] mac-hwsim: add ethtool stats support.

2014-10-09 Thread Johannes Berg
On Tue, 2014-10-07 at 06:48 -0700, Ben Greear wrote: On 10/07/2014 01:46 AM, Johannes Berg wrote: On Thu, 2014-09-25 at 14:22 -0700, gree...@candelatech.com wrote: +static const char mac80211_hwsim_gstrings_stats[][ETH_GSTRING_LEN] = { + tx_pkts_nic, + tx_bytes_nic, + rx_pkts_nic

Re: [PATCH] cfg80211: Add support for ACS offloading

2014-10-09 Thread Johannes Berg
On Fri, 2014-10-03 at 14:58 -0700, Kyeyoon Park wrote: From: Peng Xu p...@qca.qualcomm.com Add support for offloading ACS functionality to the driver. A new feature flag NL80211_FEATURE_AP_ACS_OFFLOAD was added to support ACS (Automatic Channel Selection) offload functionality. This flag

Re: [PATCH] mac80211-hwsim: Add support for HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 14:29 +0300, Jukka Rissanen wrote: +struct urelease_work { + struct work_struct w; + u32 portid; +}; Wouldn't it be simpler to embed the work struct in the hwsim data, and just queue that up when the device is affected? you should be able to walk the list in the

Re: [PATCH v2] mac80211-hwsim: Add support for HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 15:27 +0300, Jukka Rissanen wrote: Add support for new attribute HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE which can be set by the user space component. The attribute will cause the kernel to destroy all those radios that were created by a process if that process dies. The old

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 16:06 +0200, Karl Beldan wrote: On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote: On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Is that really trivial? It seems to have some impact on the code

Re: [PATCH v4 1/2] iw: Allow user to provide freq during mesh join

2014-10-09 Thread Johannes Berg
On Tue, 2014-09-23 at 09:14 +0800, Chun-Yeow Yeoh wrote: Allow user to configure frequency and channel type during mesh join command. Both applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More

Re: [PATCHv3 2/2] iw: add auto parameter to set distance command

2014-10-09 Thread Johannes Berg
On Sun, 2014-09-07 at 19:32 +0200, Lorenzo Bianconi wrote: Add auto parameter to set distance command in order to enable ACK timeout estimation algorithm (dynack). Dynack is automatically disabled setting valid value for coverage class. Currently dynack is supported just by ath9k This patch

Re: [PATCH v2] Add mpp get/dump commands

2014-10-09 Thread Johannes Berg
On Fri, 2014-09-12 at 08:59 +0200, Henning Rogge wrote: Add the mpp get and mpp dump command to query to mac80211s mesh proxy path table through nl80211. Applied. nl80211.h | 11 + Please don't send me nl80211.h updates though. johannes -- To unsubscribe from this list: send the

FYI - no patches pending - send reminder if I missed something

2014-10-09 Thread Johannes Berg
I don't have any patches pending in the sense that I neither commented on them nor applied them. However, given the volume of email I had it's entirely possible that I missed some, so please do let me know in that case. johannes -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCHv3 2/2] iw: add auto parameter to set distance command

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 16:46 +0200, Lorenzo Bianconi wrote: Somehow you also changed nl80211.h here - you shouldn't do that at all really :) I will deal with the updates of that file for iw. I added NL80211_ATTR_WIPHY_DYN_ACK flag attribute to nl80211_attrs enumeration and

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: The typo is clearly showing but the faulty behavior clearly demands more detail indeed. It affects non-(V)HT rates and can lead to selecting an rts_cts rate that is not a basic rate or way superior to the reference rate (ATM

Re: [PATCH v2] Add mpp get/dump commands

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 17:35 +0200, Henning Rogge wrote: Had to change it to make the source compile... so next time change it, but not add it to the commit? Yeah, see over on the thread with Lorenzo as well, where I explained this. I just copy nl80211.h from the kernel tree to make sure no

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 18:28 +0200, Karl Beldan wrote: But it's still pretty misbehaving, no? That IMHO warrants fixing and even cc stable. You'd like me to reword with these details in a v2 and cc stable or ? Yes please, if you don't mind. johannes -- To unsubscribe from this list: send

Re: [PATCH] cfg80211: Add support for ACS offloading

2014-10-09 Thread Johannes Berg
On Thu, 2014-10-09 at 19:11 +, Xu, Peng wrote: Hi Johannes, This is because that OBSS scan happens before starting AP and ACS happens within start_ap. So you're saying your patch doesn't work? And it would actually be better to do what I suggested; namely: 1) ask the device to do ACS

Re: [PATCH] cfg80211: set the rates mask in connection probes over specified freq

2014-10-10 Thread Johannes Berg
On Thu, 2014-10-09 at 22:49 +0200, Karl Beldan wrote: Either way - is it worth for 3.18/stable? Your call. I've seen no complaints, and you haven't indicated that you'd like to see it in older kernels, so I've applied it to mac80211-next. johannes -- To unsubscribe from this list: send

Re: [PATCH] cfg80211: set the rates mask in connection probes over specified freq

2014-10-10 Thread Johannes Berg
On Fri, 2014-10-10 at 17:10 +0200, Johannes Berg wrote: On Thu, 2014-10-09 at 22:49 +0200, Karl Beldan wrote: Either way - is it worth for 3.18/stable? Your call. I've seen no complaints, and you haven't indicated that you'd like to see it in older kernels, so I've applied

Re: [PATCH 2/2] cfg80211: Specify frame and reason code for NL80211_CMD_DEL_STATION

2014-10-14 Thread Johannes Berg
On Fri, 2014-10-10 at 20:55 +0300, Jouni Malinen wrote: * @mac: MAC address of the station to remove or NULL to remove all stations + * @subtype: Management frame subtype to use for indicating removal + * (0 = no guidance on whether to indicate the removal to the station is + *

Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

2014-10-20 Thread Johannes Berg
On Sun, 2014-10-19 at 12:22 +0200, Karl Beldan wrote: This would require rebasing [PATCH v3 4/4] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz, and send [PATCH v2] mac80211: minstrels: fix buffer overflow in HT debugfs [PATCH v4 1/4] mac80211: minstrel_ht: Increase the

Re: [PATCH v2 23/23] ath9k: Do not start BA when scanning

2014-10-20 Thread Johannes Berg
On Fri, 2014-10-17 at 07:40 +0530, Sujith Manoharan wrote: From: Sujith Manoharan c_man...@qca.qualcomm.com mac80211 currently has a race which can be hit with this sequence: If it's a mac80211 race, wouldn't it make sense to fix it in mac80211? johannes -- To unsubscribe from this list:

Re: [PATCH] cfg80211: Warn once for delayed scan completion

2014-10-20 Thread Johannes Berg
On Fri, 2014-10-17 at 07:02 +0530, Sujith Manoharan wrote: Yes, the scan cancellation is initiated on interface removal, but it's async. These commits explain the race:

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-20 Thread Johannes Berg
On Thu, 2014-10-16 at 18:33 +0200, Rostislav Lisovy wrote: You are right. I hope the following is a reasonable solution (in form of a patch to my previous patch; comment stolen from some prehistoric version of mesh.c): @@ -127,6 +127,9 @@ void ieee80211_ocb_work(struct ieee80211_sub_if_data

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-20 Thread Johannes Berg
On Thu, 2014-10-16 at 19:20 +0200, Rostislav Lisovy wrote: Now I realized it is not that easy (and I confused interface running and being connected to the network). There seems not to be a solid indication that we are no longer connected to the network. Oops, ignore my previous reply. I

Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2014-10-20 Thread Johannes Berg
On Tue, 2014-10-14 at 15:16 +0300, vadi...@gmail.com wrote: The reason for this was to make possible to change netns for wireless dev via 'ip link' too like for 'iw' util. I just think that changing namespace for netdev should have the generic way. May be you can suggest a better way That's

Re: [PATCH 2/2] cfg80211: Specify frame and reason code for NL80211_CMD_DEL_STATION

2014-10-20 Thread Johannes Berg
On Tue, 2014-10-14 at 10:01 +, Malinen, Jouni wrote: I think I would be fine with cfg80211 default being Deauthentication frame with reason code 2, so if that is what you would like to see here (rather than leaving this to the drivers), I can update the patch to behave in that way. As

Re: [PATCH] cfg80211: Warn once for delayed scan completion

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 15:12 +0530, Sujith Manoharan wrote: Johannes Berg wrote: Those commits say they *fix* the race though, so in case I was wrong you should report the sequence of events so we can look at fixing it properly? The commits fix both the issues (use-after-free, new scan

Re: [PATCH v2 23/23] ath9k: Do not start BA when scanning

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 15:09 +0530, Sujith Manoharan wrote: Johannes Berg wrote: If it's a mac80211 race, wouldn't it make sense to fix it in mac80211? Yes, definitely. :-) But, we also ran into issues where starting a BA session when HW scan was in progress (with MCC enabled) caused

Re: [RFC] mac80211: don't flush when probing the AP

2014-10-20 Thread Johannes Berg
On Thu, 2014-10-16 at 23:25 +0300, Emmanuel Grumbach wrote: All the callers of ieee80211_mgd_probe_ap_send return right after they call the flush() callback. This means that calling flush() is uneeded since its meaning is to wait until the queues of the device are empty. It is pointless to

Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 12:46 +0200, Marcel Holtmann wrote: Maybe relaxing the check and allow ip link to move a wireless netdev into a namespace (and having the wiphy follow) could be allowed if it is the only netdev or the original wlan0 that each wiphy creates. I really do not know if this

Re: [PATCH] cfg80211: Warn once for delayed scan completion

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 16:26 +0530, Sujith Manoharan wrote: Here is a trace log showing the issue - cfg80211_scan_done() is called after NETDEV_DOWN is received in cfg80211_netdev_notifier_call(). http://pastebin.com/raw.php?i=AJqFLtZR I've removed entries to show the issue clearly, if

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-21 Thread Johannes Berg
On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: I still don't know why I don't see the smatch array warnings here, I guess I'll live with that for now. I'm hoping Dan will eventually pick up on it ;-) johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless

[PATCH 3.18] mac80211: properly flush delayed scan work on interface removal

2014-10-21 Thread Johannes Berg
Tested-by: Sujith Manoharan suj...@msujith.org Signed-off-by: Johannes Berg johannes.b...@intel.com --- net/mac80211/iface.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index af237223a8cd..ee0c2ee1d32b 100644 --- a/net/mac80211

Re: [PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove

2014-10-21 Thread Johannes Berg
On Tue, 2014-10-21 at 18:20 +0200, Fabian Frederick wrote: Fix checkpatch warnings: WARNING: debugfs_remove(NULL) is safe this check is probably not required I'll apply this; however, I think that checkpatch is a just tool, and the commit message should reflect why you're changing the

Re: [PATCH v2 3/6] mac80211-hwsim: support creating radios with specific name.

2014-10-21 Thread Johannes Berg
On Mon, 2014-10-20 at 15:49 -0700, gree...@candelatech.com wrote: @@ -2023,7 +2023,7 @@ static int mac80211_hwsim_create_radio(int channels, const char *reg_alpha2, const struct ieee80211_regdomain *regd, bool

Re: [PATCH v2 4/6] cfg80211: support creating wiphy w/out creating wlanX.

2014-10-21 Thread Johannes Berg
This isn't a cfg80211 patch (subject) + * @IEEE80211_HW_NO_AUTO_VDEV: The driver would like for no wlanX to + * be created. It is expected user-space will create vdevs as + * desired (and thus have them named as desired). VDEV isn't a term mac80211 uses anywhere, please use VIF or

Re: [PATCH v2 5/6] mac80211-hwsim: support creating wiphy w/out creating wlanX.

2014-10-21 Thread Johannes Berg
On Mon, 2014-10-20 at 15:49 -0700, gree...@candelatech.com wrote: +u32 portid, char *hwname, bool no_vdev) same comment regarding vdev throughout this patch. Also, there shouldn't be a . at the end of the subject :-) johannes -- To unsubscribe from this

Re: [PATCH v2 6/6] cfg80211: support configuring vdev mac addr on create.

2014-10-21 Thread Johannes Berg
Same comment regarding vdev, here starting from the subject. Also, this patch isn't purely cfg80211 - should probably split it into cfg80211 and mac80211 parts? On Mon, 2014-10-20 at 15:49 -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com This is useful when

Re: [PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove

2014-10-22 Thread Johannes Berg
On Tue, 2014-10-21 at 22:05 +0200, Fabian Frederick wrote: I can also resubmit patch if necessary. No worries, I've already applied the patch (with a modified commit message). johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-22 Thread Johannes Berg
On Wed, 2014-10-22 at 15:54 +0200, Karl Beldan wrote: On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote: On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: I still don't know why I don't see the smatch array warnings here, I guess I'll live with that for now. I'm

Re: mac80211-hwsim question

2014-10-23 Thread Johannes Berg
On Thu, 2014-10-23 at 09:53 -0700, Ben Greear wrote: From what I can tell, when hwsim sends frames to wmediumd using netlink sockets, it does not include any channel/frequency information in the netlink packet. Any reason not to add that? I guess it wasn't needed, and when you RX a frame

pull-request: mac80211 2014-10-23

2014-10-23 Thread Johannes Berg
John, Please pull the below changes for the current 3.18 preparations. More details below. Thanks, johannes --- The following changes since commit 35a9ad8af0bb0fa3525e6d0d20e32551d226f38e: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next (2014-10-08 21:40:54 -0400) are

Re: [PATCH] mac80211: fix network header breakage during encryption

2014-10-23 Thread Johannes Berg
On Wed, 2014-10-22 at 12:33 +0300, Emmanuel Grumbach wrote: From: Arik Nemtsov a...@wizery.com When an IV is generated, only the MAC header is moved back. The network header location remains the same relative to the skb head, as the new IV is using headroom space that was reserved in

Re: [PATCH] mac80211: expose TDLS-initiator value to low level driver

2014-10-23 Thread Johannes Berg
On Wed, 2014-10-22 at 12:32 +0300, Emmanuel Grumbach wrote: From: Arik Nemtsov a...@wizery.com Some drivers need to know which station is the TDLS link initiator. Expose this value via the mac80211 ieee80211_sta structure. Applied. johannes -- To unsubscribe from this list: send the line

Re: [PATCH] mac80211: add stations in order to the station list

2014-10-23 Thread Johannes Berg
On Wed, 2014-10-22 at 12:32 +0300, Emmanuel Grumbach wrote: From: Arik Nemtsov a...@wizery.com During reconfig the station list is traversed in order and station are added back to the driver. Make sure the stations are added to the driver in the same order they were added to mac80211.

Re: [PATCH v3 1/9] mac80211-hwsim: add ethtool stats support

2014-10-23 Thread Johannes Berg
All applied, with some very minor modifications, but please do check and verify them. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mac80211: don't flush when probing the AP

2014-10-24 Thread Johannes Berg
On Mon, 2014-10-20 at 15:57 +0300, Emmanuel Grumbach wrote: All the callers of ieee80211_mgd_probe_ap_send return right after they call the flush() callback. This means that calling flush() is uneeded since its meaning is to wait until the queues of the device are empty. Devices that know

Re: [PATCH v2 2/2] iw: add vendor send command

2014-10-24 Thread Johannes Berg
On Mon, 2014-09-15 at 12:47 +0200, Janusz Dziedzic wrote: This allow to send vendor data to the driver. This command required OUI and SUBCMD parameters. Also optional DATA parameter could be used: Applied, sorry for the delay. johannes -- To unsubscribe from this list: send the line

Re: [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

2014-10-24 Thread Johannes Berg
On Fri, 2014-10-24 at 13:48 +0200, Karl Beldan wrote: Hi, On Tue, Oct 21, 2014 at 10:38:38AM +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com @@ -1026,13 +1184,47 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,

Re: [PATCH] mac80211: minstrel_ht: do not always skip ht rates vht_only is true

2014-10-24 Thread Johannes Berg
On Fri, 2014-10-24 at 14:34 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com When CONFIG_MAC80211_RC_MINSTREL_VHT is set, the module param minstrel_vht_only tells minstrel_ht whether to allow the mix of ht rates with vht rates. ATM, minstrel_ht skips ht rates when

Re: [PATCH] mac80211: add support for driver tx power reporting

2014-10-24 Thread Johannes Berg
On Wed, 2014-10-22 at 17:57 +0200, Felix Fietkau wrote: The configured tx power is often limited by hardware capabilities, channel settings, antenna configuration, etc. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 5 + net/mac80211/cfg.c | 3 +++ 2

Re: Question phy capabilities in 'iw'

2014-10-24 Thread Johannes Berg
On Fri, 2014-10-24 at 09:42 -0700, Ben Greear wrote: Here is the capabilities list from an mac80211_hwsim driver. I am curious what information this is actually trying to convey. For instance, why is AP in two different places, with different values (2048 in first section, 8 in second) ?

Re: [PATCH 0/3] Add mcast event when hwsim radios are created and removed

2014-10-27 Thread Johannes Berg
On Mon, 2014-10-27 at 12:44 +0200, Jukka Rissanen wrote: Hi, patch 1 renames HWSIM_CMD_CREATE_RADIO to HWSIM_CMD_NEW_RADIO and HWSIM_CMD_DESTROY_RADIO to HWSIM_CMD_DEL_RADIO. They are more fitting on how other pieces of the wireless system work. A define to old name is provided for backward

Re: [PATCH] net: rfkill: gpio: Add default GPIO driver mappings for ACPI

2014-10-27 Thread Johannes Berg
Berg johan...@sipsolutions.net Reviewed-by: Johannes Berg johan...@sipsolutions.net johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Add mcast event when hwsim radios are created and removed

2014-10-27 Thread Johannes Berg
On Mon, 2014-10-27 at 13:55 +0200, Jukka Rissanen wrote: That's not particularly hard to figure out, for example by looking at sysfs. Is this really so time-constrained/important/... that you can't do that? It does not seem very practical to dig this information from sysfs as the

Re: [PATCH] ath10k: add tracing for tx ieee80211 header

2014-10-28 Thread Johannes Berg
On Tue, 2014-10-28 at 22:18 +0530, Rajkumar Manoharan wrote: For packet log, the transmitted frame 802.11 header alone is sufficient. Recording entire packet is also consuming lot of disk space. To optimize, add tracepoints for sending tx-ed 802.11 headers alone. FWIW, in iwlwifi I made the

Re: [PATCH] ath10k: handle ieee80211 header and payload tracing separately

2014-10-29 Thread Johannes Berg
On Wed, 2014-10-29 at 19:39 +0530, Rajkumar Manoharan wrote: + u32 hdr_len = ieee80211_hdrlen(hdr-frame_control); + trace_ath10k_rx_hdr(ar, hdr, hdr_len); + trace_ath10k_rx_payload(ar, skb-data + hdr_len, skb-len - hdr_len); Another note, since you're taking my suggestion :-) It

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Johannes Berg
On Tue, 2014-10-28 at 09:31 +0800, Junjie Mao wrote: The driver is not released when ieee80211_register_hw fails in mac80211_hwsim_create_radio, leading to the access to the unregistered (and possibly freed) device in platform_driver_unregister: Applied. johannes -- To unsubscribe from this

  1   2   3   4   5   6   7   8   9   10   >