[PATCH 07/10] iwlwifi: mvm: don't fail when removing a key from an inexisting sta

2017-06-02 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The iwl_mvm_remove_sta_key() function handles removing a key when the sta doesn't exist anymore. Mistakenly, this was changed to return an error while fixing another bug. If the mvm_sta doesn't exist, we continue normally, but just don

[PATCH 01/10] iwlwifi: mvm: rs: start using LQ command color

2017-06-02 Thread Luca Coelho
; Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-rs.h | 5 +++ drivers/net/wireless/intel/iwlwifi/mvm/fw-api-tx.h | 3 ++ drivers/net/wireless/intel/iwlwifi/mvm/rs.c| 46 ++ drivers/net/wireless/intel/iwlwifi/mv

[PATCH 00/10] iwlwifi: some fixes intended for 4.12

2017-06-02 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here some patches that I intend to send in a pull-request for 4.12. Some of the issues solved are: * Some memory leaks; * IBSS support; * Some bugzilla bugs; * Some runtime PM fixes; * Rate-scaling issues; * Some locking problems; As usua

[PATCH 10/10] iwlwifi: fix host command memory leaks

2017-06-02 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c b/drivers/net/wireless/intel/iwlwifi/pc

[PATCH 06/10] iwlwifi: pcie: only use d0i3 in suspend/resume if system_pm is set to d0i3

2017-06-02 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We only need to handle d0i3 entry and exit during suspend resume if system_pm is set to IWL_PLAT_PM_MODE_D0I3, otherwise d0i3 entry failures will cause suspend to fail. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=194791 Signed-off-by

[PATCH 08/10] iwlwifi: mvm: clear new beacon command template struct

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Clear the struct so that all reserved fields are zero when we send the struct down to the device. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless

[PATCH 03/10] iwlwifi: mvm: support ibss in dqa mode

2017-06-02 Thread Luca Coelho
ufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/i

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

2017-06-02 Thread Luca Coelho
On Thu, 2017-05-25 at 19:48 -0700, Marc MERLIN wrote: > Howdy, > > First I tried i...@linux.intel.com which is now dead > Then linuxw...@intel.com, but no reply. > So I'm trying here next. Sorry, Marc. Somehow your emails really slipped through the cracks and I hadn't seen them before. > 3

[PATCH 16/25] iwlwifi: mvm: create/name various enums

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Some values should be in enums so documentation can refer to them, some values should be named for the same reason. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 24/25] iwlwifi: mvm: fix many kernel-doc warnings

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Fix many kernel-doc warnings. In one case, this required adding a new enum value to be able to document things properly. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.co

[PATCH 13/25] iwlwifi: mvm: add documentation links to various fields

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Link various fields to the documentation of the enums that define their values. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/mvm/fw

[PATCH 25/25] iwlwifi: add wait for tx queue empty

2017-06-02 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Now that we have 512 queues, add a wait for single TX queue to gen2. This replaces gen1 wait_tx_queues_empty, which was limited to 32 queues. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 20/25] iwlwifi: Add fw_name_pre_rf_next_step to support different rf steps

2017-06-02 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-9000.c | 6 ++ drivers/net/wireless/intel/iwlwifi/iwl-config.h | 3 +++ drivers/net/wireless/intel/iwlwifi/iwl-csr.h| 5 + drivers/net/wireless/intel/iwlwifi/iwl-drv.c

[PATCH 21/25] iwlwifi: mvm: remove unused TX_CMD_NEXT_FRAME_*

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-tx.h | 25 +- 1 file changed, 1 insertion(+), 24

[PATCH 15/25] iwlwifi: mvm: disentangle binding command versions

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> The comments/size of the different binding commands get lost in documentation, so introduce two different command structs that can be used there. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho

[PATCH 18/25] iwlwifi: mvm: remove wrt support of page dumps in gen2

2017-06-02 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> In gen2, page dumping should be done in transport layer, since the addresses needed for the paging mechanism reside there. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 10/25] iwlwifi: mvm: add documentation to some WoWLAN commands

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Add some documentation for the WoWLAN commands, also linking the correct enums used. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwi

[PATCH 12/25] iwlwifi: mvm: fix some kernel-doc

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> This mostly fixes missing tags/struct names, but also some other things. Lots of issues remain though. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 11/25] iwlwifi: mvm: wait for the flushed queue only

2017-06-02 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> The function flushed only agg queue and no more traffic is queued on it. However, it waits for all queues to empty, which is not necessary and may take more time. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho

[PATCH 23/25] iwlwifi: mvm: remove unused REPLY_MAX

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> This value is unused, and there's no reason we'd ever use it. Just remove it. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/

[PATCH 07/25] iwlwifi: mvm: fix MCC endianness bug

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/nvm.c| 4 ++--

[PATCH 04/25] iwlwifi: mvm: fix endianness in lq_cmd declaration

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> This member doesn't seem to be used, so this doesn't really fix anything, but it's better to have the right type there. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 08/25] iwlwifi: mvm: use u8 for reserved fields

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> There's no saying what kind of type a reserved field will get in the future, so use u8 arrays to reserve space. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- dr

[PATCH 06/25] iwlwifi: mvm: use proper sta_addr in firmware API

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> There's no point to declare an address as a __le32/__le16 and then only take a pointer to it anyway, change that to just a sta_addr[ETH_ALEN]. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 09/25] iwlwifi: mvm: disentangle paging command structs

2017-06-02 Thread Luca Coelho
; Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 29 +++-- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 19 +--- 2 files changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/in

[PATCH 00/25] iwlwifi: updates intended for v4.13 2017-06-02

2017-06-02 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's my first set of patches for v4.13. These are the changes: * A bunch of FW API documentation updates; * Continued work for the new A000 family; * Some small fixes and cleanups here and there. As usual, I'm pushing this to a pending

[PATCH 02/25] iwlwifi: mvm: support getting nvm data from firmware

2017-06-02 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> This API replaces the complex NVM parsing of the iwlwifi module. Instead, we get all needed data from firmware. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 03/25] iwlwifi: mvm: support old method of NVM parsing

2017-06-02 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Add configuration for allowing driver's nvm parsing and bypassing the new host command, for debugging. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless

[PATCH 05/25] iwlwifi: mvm: document which group enums are used with which group ID

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Make it explicit which command definition enum is supposed to be used with which command group, rather than relying on being able to figure it out by name. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho

[PATCH 01/25] iwlwifi: mvm: flush per station for DQA mode

2017-06-02 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Avoid using the global flush and move to flush per station whenever possible in DQA mode. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlw

[PATCH 19/25] iwlwifi: pcie: support page dumping in wrt in gen2

2017-06-02 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> In gen2, page dumping needs to be done in the trans layer, as it is the one with access to the paging pointers. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 22/25] iwlwifi: kernel-doc: make proper links

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Using %enum instead of (and in one case, %struct) results in the wrong parsing. Fix that so that if documentation is generated, the result is clickable links. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by:

[PATCH 17/25] iwlwifi: mvm: document structures used by commands

2017-06-02 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Add documentation to a lot of command IDs that links to the appropriate structure(s) used with those IDs. In one case, actually add and use a new struct for that purpose. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-

[PATCH 14/25] iwlwifi: update device ID for a000 family

2017-06-02 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Three configurations will share device ID 2720, and will be differentiated by RF ID. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwi

Re: [PATCH] net: wireless: intel: iwlwifi: dvm: remove unused defines

2017-06-07 Thread Luca Coelho
On Wed, 2017-06-07 at 01:20 +0200, Seraphime Kirkovski wrote: > Those constants have been unused for quite some time now. > > Signed-off-by: Seraphime Kirkovski > --- > I've compile-tested it. Thanks. I've applied it to our internal tree and it will reach the mainline at

[PATCH 0/4] mac80211 patches from our internal tree 2017-06-10

2017-06-10 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi Johannes, Here are the pending mac80211 patches from our internal tree. There is a couple of bugfixes, a cleanup and a small improvement in tracing. Please review. Cheers, Luca. Emmanuel Grumbach (2): mac80211: don't send SMPS action

[PATCH 4/4] mac80211: add the action to the drv_ampdu_action tracepoint

2017-06-10 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> It is very useful to know what ampdu action is currently happening. Add this information to the tracepoint. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 3/4] mac80211: don't send SMPS action frame in AP mode when not needed

2017-06-10 Thread Luca Coelho
ctual SMPS configuration is SMPS_OFF. Fix that by properly setting bss->req_smps in ieee80211_start_ap. Fixes: f69931748730 ("mac80211: set smps_mode according to ap params") Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@int

[PATCH 1/4] mac80211: set bss_info data before configuring the channel

2017-06-10 Thread Luca Coelho
From: Johannes Berg When mac80211 changes the channel, it also calls into the driver's bss_info_changed() callback, e.g. with BSS_CHANGED_IDLE. The driver may, like iwlwifi does, access more data from bss_info in that case and iwlwifi accesses the basic_rates bitmap, but

[PATCH 2/4] mac80211: remove 5/10 MHz rate code from station MLME

2017-06-10 Thread Luca Coelho
From: Johannes Berg There's no need for the station MLME code to handle bitrates for 5 or 10 MHz channels when it can't ever create such a configuration. Remove the unnecessary code. Signed-off-by: Johannes Berg --- net/mac80211/mlme.c | 24

[PATCH] mac80211: Fix incorrect condition when checking rx timestamp

2017-06-12 Thread Luca Coelho
uot;) Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/mac80211/ieee80211_i.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h index 392fbab73c04..2

Re: [PATCH] iwlwifi: missing error code in iwl_trans_pcie_alloc()

2017-06-14 Thread Luca Coelho
On Wed, 2017-06-14 at 13:44 +0300, Dan Carpenter wrote: > We don't set the error code here so we end up returning ERR_PTR(0) which > is NULL. The caller doesn't expect that so it results in a NULL > dereference. > > Fixes: 2e5d4a8f61dc ("iwlwifi: pcie: Add new configuration to enable MSIX") >

Re: iwlwifi 8260 crash (4.11rc6)

2017-05-08 Thread Luca Coelho
Hi, On Sat, 2017-05-06 at 08:39 +0200, Janusz Dziedzic wrote: > 4.11.0-rc6-next-20170413+ > 04:00.0 Network controller: Intel Corporation Wireless 8260 (rev 3a) > iwlwifi :04:00.0: loaded firmware version 21.302800.0 op_mode iwlmvm > > Scenario: > - iwlwifi configured in monitor mode - up >

[PATCH] iwlwifi: fix merge damage in iwl_req_fw_callback()

2017-05-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> A merge damage happened when applying commit 06a1e85e66ba ("iwlwifi: remove module loading failure message") from our internal tree to iwlwifi-next.git. Fix it. Fixes: 06a1e85e66ba ("iwlwifi: remove module loading failure message

[PATCH 01/25] iwlwifi: mvm: add AMSDU flag to offload assist

2017-06-05 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Enable offload assist for AMSDU when the AMSDU present flag is set. Fixes: a830baba9c2e ("iwlwifi: mvm: support new TX API") Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@in

[PATCH 02/25] iwlwifi: mvm: document RX structures

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Document the structures used in RX and link them to the command ID. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mv

[PATCH 09/25] iwlwifi: add 9000 and A000 device families

2017-06-05 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Add two new device families to differentiate them from 8000. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-9000.c| 2 +- dr

[PATCH 00/25] iwlwifi: updates intended for v4.13 2017-06-05

2017-06-05 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, More patches intended for v4.13. These are the changes: * More FW API documentation updates; * More work for the new A000 family; * Bumped the maximum supported FW API to 31. * Improve the differentiation between 8000, 9000 and A000 fa

[PATCH 05/25] iwlwifi: remove references to 8000 B-step devices

2017-06-05 Thread Luca Coelho
;sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-8000.c | 2 -- drivers/net/wireless/intel/iwlwifi/iwl-config.h | 1 - drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c | 21 - drivers/net/wireless/intel

[PATCH 17/25] iwlwifi: fix a kernel-doc tag

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> The kernel-doc here is on an enum, so don't tag it as struct but correctly as enum instead, preventing an error. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- dr

[PATCH 04/25] iwlwifi: cleanup references to 8000 family in NVM code

2017-06-05 Thread Luca Coelho
m> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-8000.c | 3 +- drivers/net/wireless/intel/iwlwifi/iwl-9000.c | 3 +- drivers/net/wireless/intel/iwlwifi/iwl-a000.c | 3 +- drivers/net/wireless/intel/iwlwifi/iwl-config.h

[PATCH 21/25] iwlwifi: mvm: link to TX commands in documentation

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Link from the TX_CMD enum value to the TX command structs. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 4 +++-

[PATCH 25/25] iwlwifi: remove unnecessary code in iwl_trans_alloc_tx_cmd

2017-06-05 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> When we removed dev_cmd_headroom, the check for dev_cmd_ptr == NULL became unnecessary, since we just return dev_cmd_ptr anyway. Cleanup the function to avoid useless code. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 18/25] iwlwifi: split firmware API from iwl-trans.h

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> In order to more clearly document which parts of this file are firmware API and which are something else, split the firmware API into a separate file to include here. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by:

[PATCH 03/25] iwlwifi: pcie: add AMSDU to gen2

2017-06-05 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> This is essentially the same code as gen1, except that it uses gen2 functions and SW checksum is not included. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 15/25] iwlwifi: mvm: convert ucode_loaded to a status bit

2017-06-05 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 4 ++-- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/dr

[PATCH 20/25] iwlwifi: mvm: document structures used for BEACON_TEMPLATE_CMD

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/

[PATCH 16/25] iwlwifi: mvm: clear firmware running bit earlier

2017-06-05 Thread Luca Coelho
havoc. Clearing it ensures that debugfs can't interfere anymore, and we can safely cancel or flush the work struct. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 11 +

[PATCH 22/25] iwlwifi: mvm: remove SCAN_GROUP

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> The firmware no longer uses this command group, so remove it from the driver as well. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iw

[PATCH 08/25] iwlwifi: mvm: support init flow debugging

2017-06-05 Thread Luca Coelho
s have been completed. This way, we can allow NOT powering down the NIC, while making sure that when the driver is removed we don't try to free resources that haven't been allocated. (This can result in a kernel panic.) Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by:

[PATCH 07/25] iwlwifi: mvm: add TLV for NAN API differentiation

2017-06-05 Thread Luca Coelho
From: Beni Lev <beni@intel.com> Due to NAN FW API change, add TLV in order to distiguish between the 2 API versions Signed-off-by: Beni Lev <beni@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-fw-file.h | 2

[PATCH 06/25] iwlwifi: add dbgc_supported to transport configuration

2017-06-05 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> Use transport configuration to determine DBGC support instead of relying on device family. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwif

[PATCH 19/25] iwlwifi: mvm: link queue cmd docs to A000 command structs

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Document which structures are used with the command for the A000 hardware flavour. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwif

[PATCH 11/25] iwlwifi: mvm: disable prph collection in a000 hw

2017-06-05 Thread Luca Coelho
allow collecting the rest of the debug data. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff -

[PATCH 14/25] iwlwifi: mvm: add and use iwl_mvm_device_running()

2017-06-05 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> This will help refactor this later. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 25 ++- dr

[PATCH 12/25] iwlwifi: mvm: check firmware is up in debugfs

2017-06-05 Thread Luca Coelho
iately. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 55 +--- 1 file changed, 49 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless

[PATCH 13/25] iwlwifi: mvm: use schedule_delayed_work()

2017-06-05 Thread Luca Coelho
Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 6 +++--- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 4

[PATCH 23/25] iwlwifi: fw-api: cleanup cycle includes

2017-06-05 Thread Luca Coelho
From: Mordechai Goodstein <mordechay.goodst...@intel.com> The include in the deleted file are included in the fw-api.h file. Which caused a cycle include in the dependencies. Signed-off-by: Mordechai Goodstein <mordechay.goodst...@intel.com> Signed-off-by: Luca Coelho <luciano.c

pull-request: iwlwifi-next 2017-06-06

2017-06-06 Thread Luca Coelho
(5): iwlwifi: mvm: remove wrt support of page dumps in gen2 iwlwifi: pcie: support page dumping in wrt in gen2 iwlwifi: mvm: support init flow debugging iwlwifi: pcie: support dumping FH in a000 hw iwlwifi: mvm: disable prph collection in a000 hw Luca Coelho (2

pull-request: iwlwifi 2017-09-15

2017-09-15 Thread Luca Coelho
on the probe queue iwlwifi: mvm: wake the correct mac80211 queue David Spinadel (1): iwlwifi: mvm: Flush non STA TX queues Luca Coelho (4): iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast addresses iwlwifi: mvm

[PATCH 04/10] iwlwifi: add a new a000 device

2017-09-15 Thread Luca Coelho
From: Oren Givon <oren.gi...@intel.com> Add a new a000 device with PCI ID (0x2720, 0x0030). Signed-off-by: Oren Givon <oren.gi...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insert

[PATCH 02/10] iwlwifi: trans: move ref/unref code to the common part of the transport

2017-09-15 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> De-inline iwl_trans_ref/unref and move it to common transport code in preparation for more common code to come to these functions. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-

[PATCH 01/10] iwlwifi: mvm: add dbgfs entry for fw info

2017-09-15 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> Add a dbgfs entry for an easy way during runtime to check what FW file was loaded, and get some general FW-related data. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 09/10] iwlwifi: pcie: dynamic Tx command queue size

2017-09-15 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/a000.c | 3 ++- drivers/net/wireless/intel/iwlwifi/iwl-config.h| 3 +++ .../net/wireless/intel/iwlwifi/pcie/ctxt-info.c| 2 +- drivers/net/wireless/intel/iwlwifi/pc

[PATCH 05/10] iwlwifi: mvm: Add new quota command API

2017-09-15 Thread Luca Coelho
From: David Spinadel <david.spina...@intel.com> New quota command adds a field indicating low latency direction per quota. A TLV API bit was added to indicate the new API. Signed-off-by: David Spinadel <david.spina...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.co

[PATCH 06/10] iwlwifi: mvm: remove support for Link Quality Measurements

2017-09-15 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> This was never used by any product. Remove it. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/fw/api

[PATCH 10/10] iwlwifi: remove redundant reading from NVM file

2017-09-15 Thread Luca Coelho
From: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> The driver reads xtal_calib from NVM file, but actually never uses it. This is only used in dvm driver. Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 07/10] iwlwifi: mvm: support firmware debug trigger on frame reorder timeout

2017-09-15 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> The trigger that collects data when a frame is released because of the timer of the reordering buffer was not implemented for 9000 devices. Fix this. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

[PATCH 03/10] iwlwifi: fix wrong struct for a000 device

2017-09-15 Thread Luca Coelho
From: Oren Givon <oren.gi...@intel.com> The PCI ID (0x2720, 0x0070) was set with the config struct iwla000_2ax_cfg_hr instead of iwla000_2ac_cfg_hr_cdb. Fixes: 175b87c69253 ("iwlwifi: add the new a000_2ax series") Signed-off-by: Oren Givon <oren.gi...@intel.com> Sign

[PATCH 00/10] iwlwifi: updates intended for v4.15 2017-09-15

2017-09-15 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's my first set of patches intended for 4.15. Nothing major here, these are the changes: * Cleanups: - remove an unused value that we read from the NVM; - remove link quality measurement code that was never used; * One FW c

[PATCH 08/10] iwlwifi: Add few debug prints to the WRT dump flow

2017-09-15 Thread Luca Coelho
From: Ilan Peer <ilan.p...@intel.com> This would enable to better catch timing issues with cases that WRT dump takes too much time. Signed-off-by: Ilan Peer <ilan.p...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwl

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 12:38 -0700, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > > > > > In any case, your patch introduces a regression on systems. Please get > > > it reverted now, and then you can come up with a new approach to fix the > > >

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: > On 09/15/2017 01:38 PM, Linus Torvalds wrote: > > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > > > > > > > In any case, your patch introduces a regression on systems. Please get > > > > it reverted now, and then

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 13:32 -0600, Jens Axboe wrote: > On 09/14/2017 02:36 PM, Jens Axboe wrote: > > On 09/14/2017 02:04 PM, Srinath Mannam wrote: > > > Hi Jens Axboe, > > > > > > > > > On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: > > > > On 09/14/2017 11:35 AM, Jens

[PATCH 0/9] ] iwlwifi: updates intended for v4.15 2017-10-13

2017-10-13 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's the third set of patches intended for 4.15. A few small fixes, but mostly just code cleanups. These are the changes: * Allocate reorder buffer dynamically to save memory; * Fix a FW dump problem in the A000 family; * Fix for a stat

[PATCH 1/9] iwlwifi: mvm: allocate reorder buffer according to need

2017-10-13 Thread Luca Coelho
a max of 16 queues). However, this comes at the expense of complicating the code a bit to calculate the right entry structure to use for each frame. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless

[PATCH 5/9] iwlwifi: mvm: move umac_error_event_table validity check to where it's set

2017-10-13 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There's no point in checking the validity of the umac_error_event_table pointer every time we generate a dump. It's cleaner to do so when we read the value, namely when we receive the alive data. Signed-off-by: Luca Coelho <luciano.coe...@

pull-request: iwlwifi firmwares update 2017-10-13

2017-10-13 Thread Luca Coelho
. Luca Coelho (1): iwlwifi: update firmwares for 3160, 3168, 7265D, 8000C and 8265 WHENCE | 12 ++-- iwlwifi-3160-17.ucode | Bin 918268 -> 918268 bytes iwlwifi-3168-29.ucode | Bin 1036372 -> 1036372 bytes iwlwifi-7260-17.ucode | Bin 1049340 ->

[PATCH] mac80211: don't track HT capability changes

2017-10-13 Thread Luca Coelho
From: Johannes Berg The code here (more or less accidentally) tracks the HT capability of the AP when connected, and we found at least one AP that erroneously toggles its 20/40 capability bit when changing between 20/40 MHz. The connection to the AP is then broken

[PATCH 9/9] iwlwifi: pcie: remove set but not used variable tcph

2017-10-13 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> This variable is never used, so remove the code to set it. After this, the variable 'iph' also has the same fate. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- dr

[PATCH 3/9] iwlwifi: mvm: pass baid_data to iwl_mvm_release_frames()

2017-10-13 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> All callers of iwl_mvm_release_frames() already have the baid_data pointer, so we don't need to (re)calculate it inside the function. Just pass it instead. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho

[PATCH 8/9] iwlwifi: pcie: sort IDs for the 9000 series for easier comparisons

2017-10-13 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> It's hard to find values that are missing in the list, so sorting the values and comparing them makes it much easier. To simplify this task, sort the devices in the list. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 6/9] iwlwifi: define minimum valid address for umac_error_event_table in cfg

2017-10-13 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We now have two different minimum valid values for umac_error_event_table. To avoid hardcoding the minimum value in the driver, add a value to cfg where it can be read from. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

pull-request: iwlwifi-next 2017-10-06

2017-10-06 Thread Luca Coelho
statistics size Liad Kaufman (1): iwlwifi: mvm: add dbgfs entry for fw info Luca Coelho (11): iwlwifi: trans: move ref/unref code to the common part of the transport iwlwifi: acpi: add common code to read from ACPI iwlwifi: acpi: move ACPI method definitions to acpi.h

Re: pull-request: iwlwifi-next 2017-10-06

2017-10-06 Thread Luca Coelho
On Fri, 2017-10-06 at 15:03 +0300, Luca Coelho wrote: > Hi Kalle, > > Here's my first pull-request intended for v4.15. It > contains the last two patch sets I sent out. > > I have sent this out before and kbuildbot reported success. > > Please let me know if there are a

[PATCH v2 05/18] iwlwifi: pcie: dump registers when HW becomes inaccessible

2017-10-06 Thread Luca Coelho
087096] Timeout waiting for hardware access (CSR_GP_CNTRL 0x) Signed-off-by: Rajat Jain <raja...@google.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 1 + drivers/net/wireless/intel/iwlwifi/pc

pull-request: iwlwifi 2017-10-06

2017-10-06 Thread Luca Coelho
): iwlwifi: nvm-parse: unify channel flags printing Luca Coelho (1): iwlwifi: mvm: return -ENODATA when reading the temperature with the FW down Shaul Triebitz (1): iwlwifi: mvm: do not print security error in monitor mode drivers/net/wireless/intel/iwlwifi/cfg/7000.c | 1

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

2017-10-17 Thread Luca Coelho
Hi, On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN wrote: > Was broken in 4.11, still broken in 4.12. This is crippling, I'm not > running linux so that I have to reboot it to reload an intel wireless > driver :-/ Can you report a bug in https://bugzilla.kernel.org so it's easier to track this?

[PATCH 4/9] iwlwifi: mvm: allow reading UMAC error data from SMEM in A000 devices

2017-10-13 Thread Luca Coelho
From: Beni Lev <beni@intel.com> Currently, UMAC error data reading is restricted to DCCM. A000 NICs use SMEM for this data. Signed-off-by: Beni Lev <beni@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/utils

[PATCH 2/9] iwlwifi: mvm: remove duplicated fields in mvm reorder buffer

2017-10-13 Thread Luca Coelho
emoved. This save some space and some code. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 4 drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 7 --- drivers/net/wireless

<    6   7   8   9   10   11   12   13   14   15   >