Re: [PATCH] cfg80211: Add support for user configurable beacon data rate

2016-08-26 Thread Johannes Berg
On Wed, 2016-08-24 at 12:30 +, Undekari, Sunil Dutt wrote: > > It also doesn't check that you specified exactly one rate, but it's > > not clear how else this would work? > I can think of the following options here .  > 1. Consider these rates as only the preference ( in order ) to the > host

RE: [PATCH] cfg80211: Add support for user configurable beacon data rate

2016-08-24 Thread Undekari, Sunil Dutt
<amarn...@qca.qualcomm.com> Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate On Sat, 2016-08-06 at 04:38 +, Undekari, Sunil Dutt wrote: > > > > Doesn't this have to check that it actually got information for the > > right band? > Hi

RE: [PATCH] cfg80211: Add support for user configurable beacon data rate

2016-08-06 Thread Undekari, Sunil Dutt
lt;gane...@qti.qualcomm.com>; Kalikot Veetil, Mahesh Kumar <mkali...@qca.qualcomm.com>; Hullur Subramanyam, Amarnath <amarn...@qca.qualcomm.com> Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate On Fri, 2016-08-05 at 10:05 +0530, Pu

Re: [PATCH] cfg80211: Add support for user configurable beacon data rate

2016-08-06 Thread Johannes Berg
On Sat, 2016-08-06 at 04:38 +, Undekari, Sunil Dutt wrote: > > > > Doesn't this have to check that it actually got information for the > > right band? > Hi Johannes , > nl80211_parse_tx_bitrate_mask ( a new wrapper to the existing > functionality in nl80211_set_tx_bitrate_mask ) does this ,

Re: [PATCH] cfg80211: Add support for user configurable beacon data rate

2016-08-05 Thread Johannes Berg
On Fri, 2016-08-05 at 10:05 +0530, Purushottam Kushwaha wrote: >  > +static int nl80211_parse_tx_bitrate_mask(struct genl_info *info, > +  struct cfg80211_bitrate_mask *mask); I think you should move the function instead. > @@ -3457,6 +3459,11 @@ static int

Re: [PATCH] cfg80211: Add support for user configurable beacon data rate

2016-07-08 Thread Johannes Berg
On Fri, 2016-07-08 at 15:58 +0530, Purushottam Kushwaha wrote: >  >   * > + * @NL80211_ATTR_BEACON_TXRATE: User configurable beacon data rate > (u32). This is > + * used to set beacon tx rate. > It seems this should be nested from enum nl80211_tx_rate_attributes, to perhaps allow HT/VHT beacons

[PATCH] cfg80211: Add support for user configurable beacon data rate

2016-07-08 Thread Purushottam Kushwaha
This will allow user to configure beacon tx rate from userspace. This adds new nl80211 attribute as NL80211_ATTR_BEACON_RATE. Signed-off-by: Purushottam Kushwaha --- include/net/cfg80211.h | 3 ++- include/uapi/linux/nl80211.h | 5 + net/wireless/nl80211.c