Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-09 Thread Luca Coelho
Hi Arend, On Sat, 2014-11-08 at 14:33 +0100, Arend van Spriel wrote: > On 11/07/14 20:37, Luca Coelho wrote: > > On November 7, 2014 9:15:21 PM EET, Johannes > > Berg wrote: > >> On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: > >> > +#if 0 > +struct ieee80211_vendor_rad

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-08 Thread Arend van Spriel
On 11/07/14 20:37, Luca Coelho wrote: On November 7, 2014 9:15:21 PM EET, Johannes Berg wrote: On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: +#if 0 + struct ieee80211_vendor_radiotap *rtap; + + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4); + /* +* Don

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-07 Thread Luca Coelho
On November 7, 2014 9:15:21 PM EET, Johannes Berg wrote: >On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: > >> > +#if 0 >> > + struct ieee80211_vendor_radiotap *rtap; >> > + >> > + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4); >> > + /* >> > + * Don't enable this code by default

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-07 Thread Johannes Berg
On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: > > +#if 0 > > + struct ieee80211_vendor_radiotap *rtap; > > + > > + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4); > > + /* > > +* Don't enable this code by default as the OUI 00:00:00 > > +* is registered to Xerox so we sh

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-07 Thread Luca Coelho
On Thu, 2014-11-06 at 23:29 +0100, Johannes Berg wrote: > From: Johannes Berg > > Radiotap vendor namespace data might still be useful, but we > reverted it because it used too much space in the RX status. > Put it back, but address the space problem by using a single > but only and putting every

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-06 Thread Johannes Berg
On Thu, 2014-11-06 at 14:31 -0800, Ben Greear wrote: > On 11/06/2014 02:29 PM, Johannes Berg wrote: > > From: Johannes Berg > > > > Radiotap vendor namespace data might still be useful, but we > > reverted it because it used too much space in the RX status. > > Put it back, but address the space

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-06 Thread Ben Greear
On 11/06/2014 02:29 PM, Johannes Berg wrote: > From: Johannes Berg > > Radiotap vendor namespace data might still be useful, but we > reverted it because it used too much space in the RX status. > Put it back, but address the space problem by using a single > but only and putting everything else

[PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-06 Thread Johannes Berg
From: Johannes Berg Radiotap vendor namespace data might still be useful, but we reverted it because it used too much space in the RX status. Put it back, but address the space problem by using a single but only and putting everything else into the skb->data. Signed-off-by: Johannes Berg --- d