Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-12 Thread Johannes Berg
On Wed, 2014-12-10 at 00:21 +0200, Vadim Kochan wrote: It allows to identify the wlan kind of device for the user application, Applied, +static struct rtnl_link_ops wireless_link_ops __read_mostly = { + .kind = wlan, +}; but I've made this const. It only needs to be non-const

Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-10 Thread Marcel Holtmann
Hi Johannes, have we considered also exposing the mode of this netdev. So for example sta,ap,p2p-go,p2p-client etc. If we can send dynamic updates via RTNL, we could easily tell the networking management system what type of wireless device we have here. I am thinking about it like

Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-10 Thread Marcel Holtmann
Hi Vadim, It allows to identify the wlan kind of device for the user application, e.g.: # ip -d link 1: lo: LOOPBACK,UP,LOWER_UP mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 2:

[PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-09 Thread Vadim Kochan
It allows to identify the wlan kind of device for the user application, e.g.: # ip -d link 1: lo: LOOPBACK,UP,LOWER_UP mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 2: enp0s25:

Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-09 Thread Marcel Holtmann
Hi Johannes, On Dec 9, 2014, at 23:21, Vadim Kochan vadi...@gmail.com wrote: It allows to identify the wlan kind of device for the user application, e.g.: # ip -d link 1: lo: LOOPBACK,UP,LOWER_UP mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default

Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute

2014-12-09 Thread vadim4j
On Wed, Dec 10, 2014 at 12:23:14AM +0100, Marcel Holtmann wrote: Hi Johannes, On Dec 9, 2014, at 23:21, Vadim Kochan vadi...@gmail.com wrote: It allows to identify the wlan kind of device for the user application, e.g.: # ip -d link 1: lo: LOOPBACK,UP,LOWER_UP mtu 65536