Re: [PATCH] mac80211: Adjust TSQ pacing shift

2018-02-14 Thread Toke Høiland-Jørgensen
On 14 February 2018 01:43:25 CET, Ryan Hsu wrote: >On 02/02/2018 07:11 AM, Toke Høiland-Jørgensen wrote: > >> Since we now have the convenient helper to do so, actually adjust the >> TSQ pacing shift for packets going out over a WiFi interface. This >> significantly improves throughput for local

Re: [Make-wifi-fast] [PATCH] mac80211: Adjust TSQ pacing shift

2018-02-14 Thread Jonathan Morton
> On 14 Feb, 2018, at 10:18 am, Toke Høiland-Jørgensen wrote: > > Why does the CPU usage go up >7? Just as a guess, it's generating extra packets which are then laboriously discarded and retransmitted. - Jonathan Morton

RE: mac80211 scan results, signal value not reliable

2018-02-14 Thread Jean Pierre TOSONI
> -Message d'origine- > De : Johannes Berg [mailto:johan...@sipsolutions.net] > Envoyé : samedi 10 février 2018 22:09 > À : Jean Pierre TOSONI; linux-wireless@vger.kernel.org > Objet : Re: mac80211 scan results, signal value not reliable > > On Thu, 2018-02-08 at 09:49 +, Jean Pierre

Re: mac80211 scan results, signal value not reliable

2018-02-14 Thread Johannes Berg
On Wed, 2018-02-14 at 10:10 +, Jean Pierre TOSONI wrote: > > > > However, it looks like you're right and ieee80211_bss_info_update() > > doesn't take the flag into account. Bit strange that we even have > > the flag I guess, since we treat 0 as an invalid value in various > > places, being too

Max clients on wifi access point with 7265

2018-02-14 Thread Mickaël PANNEQUIN
Hi, I use a Intel Dual Band Wireless-N 7265. The OS is Linux Debian 8 (Kernel 3.16.0-4_amd64). Do you know the limit of the number of users connected at the same time on the wifi? Works fine with 14 connected devices but not more. How to increase it? This limit is hardware? I can't find

[PATCH v2] ath9k: fix DFS detector synchronization

2018-02-14 Thread Timothy Redaelli
some userspace programs (e.g. hostapd) need to set the regulatory domain before selecting the operating channel. Synchronize DFS detector regardless of the value of ah->curchan, to avoid situations where wireless scan can't be done on some 5GHz sub-bands, because dfs_region is constantly UNSET. Ac

Re: Max clients on wifi access point with 7265

2018-02-14 Thread Johannes Berg
On Wed, 2018-02-14 at 10:55 +, Mickaël PANNEQUIN wrote: > Do you know the limit of the number of users connected at the same > time on the wifi? Works fine with 14 connected devices but not more. > > How to increase it? You can't. > This limit is hardware? More or less, yes. The HW/FW can

[PATCH] mt7601u: Fix system freeze after resuming from hibernation

2018-02-14 Thread cantabile
The firmware running on the device sometimes survives a reboot (firmware_running returns 1). When this happens the driver never calls request_firmware, which means the kernel's firmware handling code doesn't know this firmware should be cached before hibernating. Upon resuming from several hour

Re: Make brcmfmac repeat authentication requests

2018-02-14 Thread Daniel Drake
Hi, Thanks for the fast response. On Tue, Feb 13, 2018 at 12:50 PM, Arend van Spriel wrote: > I tried to find info about that access point equipment, but not getting any > hits apart from a olivetti laser printer, but I doubt it is that. Can you > provide more details. The device itself is basi

[PATCH] mac80211: inform wireless layer when frame RSSI is invalid

2018-02-14 Thread Jean Pierre TOSONI
When the low-level driver returns an invalid RSSI indication, set the signal value to 0 as an indication to the upper layer. Also, skip average level computation if signal is invalid. Signed-off-by: Jean Pierre TOSONI --- WARNING: This patch applies to wireless-testing retrieved on Feb 14, 2018

[PATCH] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread Jean Pierre TOSONI
ath9k returns a wrong RSSI value for frames received in a 30ms time window after a channel change. The correct value is typically 10dB below the returned value. This was found with a Atheros AR9300 Rev:3 chip (WLE350NX / JWX6083 cards), during offchannel scans. Mark the signal value as invalid in

[PATCH 2/6] staging: wilc1000: removed the unnecessary commented code

2018-02-14 Thread Ajay Singh
Cleanup patch to remove the unused commented code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c index 5d0de4e..66b6aea 100644 --- a/drivers/sta

[PATCH 0/6] fix line over 80 char & coding style in wilc_spi.c

2018-02-14 Thread Ajay Singh
This patch series contains changes to remove "fix line over 80 char" issues found by checkpatch.pl script. Also, few changes code changes are done to follow Linux coding style. Ajay Singh (6): staging: wilc1000: modified code comments as per linux coding style staging: wilc1000: removed the un

[PATCH 1/6] staging: wilc1000: modified code comments as per linux coding style

2018-02-14 Thread Ajay Singh
Cleanup patch to follow the comments style as per the Linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 151 1 file changed, 82 insertions(+), 69 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/s

[PATCH 4/6] staging: wilc1000: fix line over 80 characters in wilc_spi_init()

2018-02-14 Thread Ajay Singh
Modified wilc_spi_init() to fix the line over 80 char issues reported by checkpatch.pl script. To overcome the checkpatch.pl reported issue modified debug logs and comments used in wilc_spi_init(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 18 +++--- 1 file

[PATCH 3/6] staging: wilc1000: fix line over 80 characters in spi_cmd_complete()

2018-02-14 Thread Ajay Singh
Refactor spi_cmd_complete() to fix the line over 80 char issues reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 250 ++-- 1 file changed, 124 insertions(+), 126 deletions(-) diff --git a/drivers/staging/wilc10

[PATCH 5/6] staging: wilc1000: fix line over 80 characters in wilc_spi_read_int()

2018-02-14 Thread Ajay Singh
Refactor wilc_spi_read_int() to fix the line over 80 char issues reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 57 +++-- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/staging/wilc100

[PATCH 6/6] staging: wilc1000: fix line over 80 chars in wilc_spi_clear_int_ext()

2018-02-14 Thread Ajay Singh
Refactor wilc_spi_clear_int_ext() to fix the "line over 80 char" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 113 +--- 1 file changed, 54 insertions(+), 59 deletions(-) diff --git a/drivers/staging/w

Re: [PATCH] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread Kalle Valo
Jean Pierre TOSONI writes: > ath9k returns a wrong RSSI value for frames received in a 30ms time window > after > a channel change. The correct value is typically 10dB below the returned > value. > > This was found with a Atheros AR9300 Rev:3 chip (WLE350NX / JWX6083 cards), > during offchannel

[PATCH v2] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread Jean Pierre TOSONI
ath9k returns a wrong RSSI value for frames received in a 30ms time window after a channel change. The correct value is typically 10dB below the returned value. This was found with a Atheros AR9300 Rev:3 chip (WLE350NX / JWX6083 cards), during offchannel scans. Mark the signal value as invalid in

Re: [PATCH v2] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread Steve deRosier
On Wed, Feb 14, 2018 at 8:26 AM, Jean Pierre TOSONI wrote: > ath9k returns a wrong RSSI value for frames received in a 30ms time > window after a channel change. The correct value is typically 10dB > below the returned value. > > This was found with a Atheros AR9300 Rev:3 chip (WLE350NX / JWX6083

Re: [PATCH v2] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread James Cameron
On Wed, Feb 14, 2018 at 04:26:42PM +, Jean Pierre TOSONI wrote: > ath9k returns a wrong RSSI value for frames received in a 30ms time > window after a channel change. The correct value is typically 10dB > below the returned value. How was your correct value determined? > This was found with a

Re: Max clients on wifi access point with 7265

2018-02-14 Thread Samuel Sieb
On 02/14/2018 03:30 AM, Johannes Berg wrote: On Wed, 2018-02-14 at 10:55 +, Mickaël PANNEQUIN wrote: Do you know the limit of the number of users connected at the same time on the wifi? Works fine with 14 connected devices but not more. How to increase it? You can't. This limit is ha

Re: Max clients on wifi access point with 7265

2018-02-14 Thread Johannes Berg
On Wed, 2018-02-14 at 14:04 -0800, Samuel Sieb wrote: > > As a general question, is there a standard way to determine this limit > for any particular hardware? That's a good question, but I don't think there is. johannes

Re: Max clients on wifi access point with 7265

2018-02-14 Thread Steve deRosier
On Wed, Feb 14, 2018 at 2:04 PM, Samuel Sieb wrote: > On 02/14/2018 03:30 AM, Johannes Berg wrote: >> >> On Wed, 2018-02-14 at 10:55 +, Mickaël PANNEQUIN wrote: >> >>> >>> Do you know the limit of the number of users connected at the same >>> time on the wifi? Works fine with 14 connected devi

Re: [PATCH] mt7601u: Fix system freeze after resuming from hibernation

2018-02-14 Thread Jakub Kicinski
On Wed, 14 Feb 2018 13:34:38 +0200, cantabile wrote: > The firmware running on the device sometimes survives a reboot > (firmware_running returns 1). When this happens the driver never calls > request_firmware, which means the kernel's firmware handling code > doesn't know this firmware should b

World roaming ath10k fails to manually set country codes in kernel

2018-02-14 Thread Guy Trailblant
Hello, TLDR: My world roaming Qualcom Atheros QCA9882 wifi card in my AP cannot be manually configured to use any specific country's regdomain without beacon hints, causing service denial. Please excuse the lengthy email, but I wanted to provide as much information as possible, including log and

Re: [PATCH v2] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread Kalle Valo
James Cameron writes: > On Wed, Feb 14, 2018 at 04:26:42PM +, Jean Pierre TOSONI wrote: >> ath9k returns a wrong RSSI value for frames received in a 30ms time >> window after a channel change. The correct value is typically 10dB >> below the returned value. > > How was your correct value dete

Re: [PATCH v2] ath9k: mark RSSI as invalid if frame received during channel setup

2018-02-14 Thread James Cameron
On Thu, Feb 15, 2018 at 07:51:28AM +0200, Kalle Valo wrote: > James Cameron writes: > > > On Wed, Feb 14, 2018 at 04:26:42PM +, Jean Pierre TOSONI wrote: > >> ath9k returns a wrong RSSI value for frames received in a 30ms time > >> window after a channel change. The correct value is typically

[PATCH] rtl8187: Fix NULL pointer dereference in priv->conf_mutex

2018-02-14 Thread Sudhir Sreedharan
This can be reproduced by bind/unbind the driver multiple times in AM3517 board. Analysis revealed that rtl8187_start() was invoked before probe finishes(ie. before the mutex is initialized). INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off th

Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default

2018-02-14 Thread Luciano Coelho
On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote: > 'default false' should be 'default n', though they happen to have the > same effect here, due to undefined symbols ('false' in this case) > evaluating to n in a tristate sense. > > Remove the default instead of changing it. bool and tristat