Sebastian Gottschall writes:
> Am 05.04.2018 um 16:44 schrieb Kalle Valo:
>> s.gottsch...@dd-wrt.com writes:
>>
>>> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984
>>> based chipsets with on chipset connected led's using WMI Firmware API.
>>> The LED device will get available n
Sebastian Gottschall writes:
> i have some comments about your check warnings.
> some of them are bogus. for instance they advise to use "unsigned int"
> instead of "unsigned". this might be better, but
> the original kernel header uses "unsigned" as api definition. so i
> decided to use the same
(adding back the lists, please don't top post and trim your quotes)
Sebastian Gottschall writes:
> okay. ath10k-check is buggy and doesnt work. so it doesnt help much
> with code styles
>
> root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check
> global: 'drivers/net/wireless/ath/ath10k/Kconfig'
Am 06.04.2018 um 10:07 schrieb Kalle Valo:
Sebastian Gottschall writes:
i have some comments about your check warnings.
some of them are bogus. for instance they advise to use "unsigned int"
instead of "unsigned". this might be better, but
the original kernel header uses "unsigned" as api defi
Am 06.04.2018 um 10:09 schrieb Kalle Valo:
(adding back the lists, please don't top post and trim your quotes)
Sebastian Gottschall writes:
okay. ath10k-check is buggy and doesnt work. so it doesnt help much
with code styles
root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check
global: 'driv
Sebastian Gottschall writes:
> Am 06.04.2018 um 10:09 schrieb Kalle Valo:
>> (adding back the lists, please don't top post and trim your quotes)
>>
>> Sebastian Gottschall writes:
>>
>>> okay. ath10k-check is buggy and doesnt work. so it doesnt help much
>>> with code styles
>>>
>>> root@seg-des
The issue here is that we allocate "data" and then set
"data = PTR_ALIGN(data, 8);" and then we free the aligned pointer
instead of the original pointer.
kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or
more on everything except certain Xtensa variants. We decided that if
t
On 4/6/2018 10:37 AM, Dan Carpenter wrote:
The issue here is that we allocate "data" and then set
"data = PTR_ALIGN(data, 8);" and then we free the aligned pointer
instead of the original pointer.
kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or
more on everything except c
Arend van Spriel writes:
> On 4/6/2018 10:37 AM, Dan Carpenter wrote:
>> The issue here is that we allocate "data" and then set
>> "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer
>> instead of the original pointer.
>>
>> kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned
(adding back lists)
Sebastian Gottschall writes:
> Am 06.04.2018 um 10:25 schrieb Kalle Valo:
>> Sebastian Gottschall writes:
>>
>>> Am 06.04.2018 um 10:09 schrieb Kalle Valo:
(adding back the lists, please don't top post and trim your quotes)
Sebastian Gottschall writes:
>
Each DXE control block is associated to a specific channel.
The channel lock is always taken before accessing a control block.
There is no need to have an extra (useless) spinlock for the control
block skb.
Signed-off-by: Loic Poulain
---
drivers/net/wireless/ath/wcn36xx/dxe.c | 8 +---
driv
From: Sanjay Kumar Konduri
Signed-off-by: Sanjay Kumar Konduri
---
ubuntu/rsi/rsi_91x_main.c | 1 +
ubuntu/rsi/rsi_91x_mgmt.c | 5 +
ubuntu/rsi/rsi_main.h | 1 +
3 files changed, 7 insertions(+)
diff --git a/ubuntu/rsi/rsi_91x_main.c b/ubuntu/rsi/rsi_91x_main.c
index 2350dbb..49b98cd 1
On Fri, Apr 6, 2018 at 5:11 PM, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri
>
> Signed-off-by: Sanjay Kumar Konduri
> ---
> ubuntu/rsi/rsi_91x_main.c | 1 +
> ubuntu/rsi/rsi_91x_mgmt.c | 5 +
> ubuntu/rsi/rsi_main.h | 1 +
> 3 files changed, 7 insertions(+)
>
> diff --git a/ubu
From: Sebastian Gottschall
Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
chipsets with on chipset connected led's using WMI Firmware API. The LED
device will get available named as "ath10k-phyX" at sysfs and can be controlled
with various triggers. adds also debugfs i
Kalle Valo writes:
> From: Sebastian Gottschall
>
> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
> chipsets with on chipset connected led's using WMI Firmware API. The LED
> device will get available named as "ath10k-phyX" at sysfs and can be
> controlled
> with var
Hello Kalle
you removed the call to leds_start from certain locations but you seem
to have ignored the comment i wrote above the function call.
there is a reason why i reinitialize the gpio output state in these
locations. the firmware for 9984 and 99xx resets the gpio registers
at certain poin
On Fri, Apr 6, 2018 at 7:54 AM, Siva Rebbagondla wrote:
> From: Amitkumar Karwar
>
> These images will be loaded by rsi driver based on operating mode.
> Firmware version is 1.6.1
>
> rs9113_ap_bt_dual_mode.rps - AP and BT functionality
> rs9113_wlan_bt_dual_mode.rps - station and BT functionalit
On Thu, 2018-04-05 at 16:55 +0200, Daniel Borkmann wrote:
> Hey guys,
Hi Daniel,
> after upgrading to 4608f064532c ("Merge
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next")
> my kernel log gets constantly flooded with the below message and
> wireless stops
> working ... just in
18 matches
Mail list logo
