[PATCH] mwifiex: correct histogram data with appropriate index

Correct snr/nr/rssi data index to avoid possible buffer underflow. Signed-off-by: Xinming Hu --- drivers/net/wireless/marvell/mwifiex/util.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/util.c

Re: [bug report] mwifiex: add rx histogram statistics support

Hi Dan, Thanks for the report! We also notice it recently, and have already fix it. Just upstream the below fix https://patchwork.kernel.org/patch/10408353/ Regards, Simon From: Dan Carpenter Sent: Thursday, May 17, 2018 17:27

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: > __cfg80211_bss_expire function was incorrectly used to flush the BSS > entries from the previous scan results, causing NL80211_SCAN_FLAG_FLUSH > flag to have no effect. Hmm. I guess I'm not convinced - what's the bug? We flush anything that's

Re: [PATCH V3 0/5] Update brcm firmware files

Hi, On 15-05-18 10:43, Arend van Spriel wrote: On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: Update brcm firmware files and WHENCE accordingly. Hi

[PATCH] ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: fix memdup.cocci warnings

linuxfoundation.org> Signed-off-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Greg-KH/NFC-pn533-don-t-send-USB-data-off-of-the-stack/20180518-100416 :: branch date: 54 minutes ago

Re: [RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info

On Fri, 2018-05-18 at 11:37 +0200, Arend van Spriel wrote: > On 5/18/2018 11:25 AM, Johannes Berg wrote: > > On Thu, 2018-05-10 at 13:50 +0200, Arend van Spriel wrote: > > > > > > Here an alternative approach. Currently the only cfg80211-based driver > > > providing per-tid stats is mac80211.

[PATCH v2] wcn36xx: Add support for Factory Test Mode (FTM)

From: Eyal Ilsar Introduce infrastructure for supporting Factory Test Mode (FTM) of the wireless LAN subsystem. In order for the user space to access the firmware in test mode the relevant netlink channel needs to be exposed from the kernel driver. The above is achieved

Re: [PATCH 00/10] Some more patches for wcn36xx

On Wednesday, May 16, 2018 04:08 PM, Daniel Mack wrote: Hence I believe that some sort of firmware internal buffer is overrun if too many SMD requests fly in in a short amount of time. The firmware does, however, still ack all packets just fine on the SMD channels, and also the DXE communication

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

On 5/17/2018 6:46 PM, Greg KH wrote: On Thu, May 17, 2018 at 06:40:04PM +0200, Greg KH wrote: Adding the network and NFC developers as this really is a NFC driver bug, not a USB core issue... On Thu, May 17, 2018 at 04:12:17PM +0200, Greg KH wrote: On Thu, May 17, 2018 at 02:10:57PM +0100,

Re: [PATCH V3 0/5] Update brcm firmware files

On 5/18/2018 9:04 AM, Hans de Goede wrote: Hi, On 15-05-18 10:43, Arend van Spriel wrote: On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: Update brcm firmware files and

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

On Fri, May 18, 2018 at 10:56:25AM +0200, Arend van Spriel wrote: > On 5/17/2018 6:46 PM, Greg KH wrote: > > On Thu, May 17, 2018 at 06:40:04PM +0200, Greg KH wrote: > > > Adding the network and NFC developers as this really is a NFC driver > > > bug, not a USB core issue... > > > > > > On Thu,

[PATCH 1/2] mac80211: allocate and fill tidstats only when needed

From: Johannes Berg This fixes memory leaks in the case where we just have the station info on the stack for internal usage without sending it to cfg80211. Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info") Signed-off-by: Johannes

[PATCH 2/2] cfg80211: release station info tidstats where needed

From: Johannes Berg This fixes memory leaks in cases where we got the station info but failed sending it out properly. Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info") Signed-off-by: Johannes Berg ---

Re: [PATCH 2/2] cfg80211: release station info tidstats where needed

On 5/18/2018 11:47 AM, Johannes Berg wrote: From: Johannes Berg This fixes memory leaks in cases where we got the station info but failed sending it out properly. Reviewed-by: Arend van Spriel Fixes: 8689c051a201 ("cfg80211:

Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

On 17 May 2018 at 21:37, Jeff Johnson wrote: > On 2018-05-17 04:32, Ramon Fried wrote: >> >> From: Eyal Ilsar > > ... >> >> +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn, >> + struct ieee80211_vif *vif, void

[PATCH v3] NFC: pn533: don't send USB data off of the stack

It's amazing that this driver ever worked, but now that x86 doesn't allow USB data to be sent off of the stack, it really does not work at all. Fix this up by properly allocating the data for the small "commands" that get sent to the device. The USB stack will free the buffer when the data has

[PATCH 12/14] rtlwifi: use sk_buff to queue C2H commands

From: Ping-Ke Shih We use 'struct rtl_c2hcmd' to store C2H commands originally, and the code is slightly complex to enqueue and dequeue and also wastes time to allocate and memcpy data. Since C2H commands are asynchronous events, they can be processed in work queue, so RX ISR

[PATCH 03/14] rtlwifi: remove duplicate rx_packet_type definition

From: Ping-Ke Shih Move duplicate definitions from def.h of ic folder to wifi.h Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/def.h | 7 --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/def.h | 8

[PATCH 04/14] rtlwifi: rename register-based C2H command IDs to V0

From: Ping-Ke Shih Current chips use packet-based C2H commands whose IDs differ from old ones, so this commit simply gives C2H_V0_ as prefix of command IDs. Signed-off-by: Ping-Ke Shih --- .../net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c | 6 +++---

[PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

From: Ping-Ke Shih The format of C2H data is ID(1 byte) + Length(1 byte) + value, and it is more readable to use macros to access C2H data. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 8

[PATCH 14/14] rtlwifi: fix btmpinfo timeout while processing C2H_BT_INFO

From: Ping-Ke Shih In former patch, I enqueu all C2H commands and processed by a workqueue. In case C2H_BT_INFO will issue a H2C command to set BT reg, and wait for a C2H ack. But it is totally impossible that C2H workqueue waits for a C2H command, so kernel log warn

[PATCH 00/14] rtlwifi: remove duplicate C2H handlers

From: Ping-Ke Shih The goal of patch 1/14 and 2/14 is to use keep-alive mechanism in mac80211 stack that needs accurate TX ack status for null frame reported by firmware through C2H. The remaining patches are step by step to remove duplicate C2H handlers that widely

Re: [RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info

On 5/18/2018 11:25 AM, Johannes Berg wrote: On Thu, 2018-05-10 at 13:50 +0200, Arend van Spriel wrote: Here an alternative approach. Currently the only cfg80211-based driver providing per-tid stats is mac80211. This patch only changes mac80211 and the other driver can keep using stack

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

On Fri, 2018-05-18 at 10:56 +0200, Arend van Spriel wrote: > > > + buffer = kmalloc(sizeof(cmd), GFP_KERNEL); > > + if (!buffer) > > + return -ENOMEM; > > + memcpy(buffer, cmd, sizeof(cmd)); It should also use kmemdup() ;-) johannes

Re: [RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info

On Thu, 2018-05-10 at 13:50 +0200, Arend van Spriel wrote: > > Here an alternative approach. Currently the only cfg80211-based driver > providing per-tid stats is mac80211. This patch only changes mac80211 > and the other driver can keep using stack allocation. Even mac80211 could > if wanted,

Re: [PATCH V3 0/5] Update brcm firmware files

Hi, On 18-05-18 11:00, Arend van Spriel wrote: On 5/18/2018 9:04 AM, Hans de Goede wrote: Hi, On 15-05-18 10:43, Arend van Spriel wrote: On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 3/16/2018 3:08 PM,

Re: [PATCH] ath10k: add dynamic vlan support

On Mon, 2018-04-23 at 21:18 +0200, Sebastian Gottschall wrote: > this patch makes no sense at some points. AP_VLAN must be enabled always > (it is enabled by mac80211 by default, but is now disabled in very > latest git version for drivers which announce sw_crypto support) > if its disabled wds

Re: [PATCH] ath10k: add dynamic vlan support

Am 18.05.2018 um 11:53 schrieb Johannes Berg: On Mon, 2018-04-23 at 21:18 +0200, Sebastian Gottschall wrote: this patch makes no sense at some points. AP_VLAN must be enabled always (it is enabled by mac80211 by default, but is now disabled in very latest git version for drivers which

[PATCH 02/14] rtlwifi: remove CONNECTION_MONITOR flag

From: Ping-Ke Shih To use keep-alive mechanism in mac80211 stack, since driver supports reporting accurate nullfunc frame tx ack now. Signed-off-by: Tzu-En Huang Signed-off-by: Ping-Ke Shih ---

[PATCH 09/14] rtlwifi: remove duplicate C2H handler

From: Ping-Ke Shih Merge duplicate C2H handler and implement the handler in base.c. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c| 72 + drivers/net/wireless/realtek/rtlwifi/base.h| 3 +

[PATCH 10/14] rtlwifi: remove hal_op rx_command_packet

From: Ping-Ke Shih Because the hal_op rx_command_packet does C2H handler if rx packet type is C2H, and the handler have been moved to base.c so we can call the handler directly. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/pci.c

[PATCH 01/14] rtlwifi: support accurate nullfunc frame tx ack report

From: Tzu-En Huang In order to realize the keep-alive mechanism in mac80211 stack, reporting accurate tx ack status for nullfunc frame is added in this commit. If current frame is nullfunc frame, we ask firmware to report by filling TX report bit in TX descriptor. After

[PATCH 07/14] rtlwifi: remove dummy hal_op rx_command_packet from rtl8188ee and rtl8723ae

From: Ping-Ke Shih The caller of hal_op rx_command_packet will assert function pointer before calling, so we can remove dummy functions safely. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 2 --

[PATCH 08/14] rtlwifi: Add hal_op c2h_ra_report_handler for special process

From: Ping-Ke Shih We're going to merge C2H handler into one, but one special case is to handle RA_REPORT that implements in individual IC folder. So this commit adds a hal_op for caller in common code. Signed-off-by: Ping-Ke Shih ---

[PATCH 05/14] rtlwifi: remove duplicate C2H definition

From: Ping-Ke Shih Move C2H definition to wifi.h, because the definitions of 8192ee, 8723be and 8821ae are the same. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c | 16

[PATCH 06/14] rtlwifi: remove unused fw C2H command ID

From: Ping-Ke Shih The IDs are defined by driver and map to the fw C2H IDs, but they aren't used now result in removal. Signed-off-by: Ping-Ke Shih --- .../net/wireless/realtek/rtlwifi/rtl8188ee/def.h | 25 --

[PATCH 11/14] rtlwifi: remove hal_op c2h_content_parsing

From: Ping-Ke Shih Similar to rx_command_packet, we can call rtl_c2h_content_parsing so the hal_op isn't necessary. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 7 +++

Re: [PATCH] ath10k: add dynamic vlan support

On Fri, 2018-05-04 at 12:20 +0530, Manikanta Pubbisetty wrote: > Johannes, > > It seems like commit db3bdcb9c3ff ("mac80211: allow AP_VLAN operation on > crypto controlled devices") has broken 4-addr operation on crypto > controlled devices as reported by sebastian. > The commit was mainly

Re: [PATCH] ath10k: add dynamic vlan support

Am 18.05.2018 um 11:54 schrieb Johannes Berg: On Fri, 2018-05-04 at 12:20 +0530, Manikanta Pubbisetty wrote: Johannes, It seems like commit db3bdcb9c3ff ("mac80211: allow AP_VLAN operation on crypto controlled devices") has broken 4-addr operation on crypto controlled devices as reported by

Re: [RFC 0/2] nl80211/mac80211 Add support for per-rate rx statistics

On Wed, 2018-05-16 at 10:04 +0530, Sriram R wrote: > But, I wanted to avoid, > 1. Static indexing and memory allocation based on MCS count((8x3)24 > entries for HT and (10x3)30 for VHT within allocated 36 entries) so that > it's scalable. Do you expect that the rate control on the other

Re: [PATCH 2/2] cfg80211: release station info tidstats where needed

On Fri, 2018-05-18 at 12:25 +0200, Arend van Spriel wrote: > On 5/18/2018 11:47 AM, Johannes Berg wrote: > > From: Johannes Berg > > > > This fixes memory leaks in cases where we got the station > > info but failed sending it out properly. > > Reviewed-by: Arend van

Re: [PATCH 00/10] Some more patches for wcn36xx

Daniel Mack writes: > On Wednesday, May 16, 2018 04:08 PM, Daniel Mack wrote: >> Hence I believe that some sort of firmware internal buffer is overrun if >> too many SMD requests fly in in a short amount of time. The firmware >> does, however, still ack all packets just fine

[mac80211-next:master 20/20] net/wireless/nl80211.c:4802:48: sparse: incorrect type in argument 1 (different base types)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 commit: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 [20/20] cfg80211: release station info tidstats where needed reproduce: # apt-get install sparse

Re: [PATCH v3] NFC: pn533: don't send USB data off of the stack

On Fri, May 18, 2018 at 12:38:11PM +0200, Greg Kroah-Hartman wrote: > It's amazing that this driver ever worked, but now that x86 doesn't > allow USB data to be sent off of the stack, it really does not work at > all. Fix this up by properly allocating the data for the small > "commands" that get

[PATCH 1/3] MAINTAINERS: update Kalle's email address

I switched to use my codeaurora.org address. Signed-off-by: Kalle Valo --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6d21f2f74578..4be9ff892ec0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2345,7

[PATCH 3/3] MAINTAINERS: change Kalle as wcn36xx maintainer

Eugene hasn't worked on wcn36xx for some time now. Signed-off-by: Kalle Valo --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5dace1734086..c1b15dde5a46 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH 2/3] MAINTAINERS: change Kalle as ath.ko maintainer

Luis hasn't worked on ath.ko for some time now. Acked-by: Luis R. Rodriguez Signed-off-by: Kalle Valo --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4be9ff892ec0..5dace1734086 100644

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, On 05/18/2018 03:13 AM, Johannes Berg wrote: On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: __cfg80211_bss_expire function was incorrectly used to flush the BSS entries from the previous scan results, causing NL80211_SCAN_FLAG_FLUSH flag to have no effect. Hmm. I guess I'm

[mac80211-next:master 20/20] net/wireless/nl80211.c:4802:34: error: incompatible type for argument 1 of 'cfg80211_sinfo_release_content'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 commit: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 [20/20] cfg80211: release station info tidstats where needed config: x86_64-randconfig-x004-201819 (attached as

[RFC 2/3] radiotap: add structs for HE

From: Luca Coelho Add radiotap structures for HE. Signed-off-by: Liad Kaufman Signed-off-by: Johannes Berg Signed-off-by: Ilan Peer Signed-off-by: Ido Yariv Signed-off-by:

[RFC 3/3] mac80211: add support for HE

From: Luca Coelho Add support for HE in mac80211 conforming with P802.11ax_D1.4. Signed-off-by: Liad Kaufman Signed-off-by: Johannes Berg Signed-off-by: Ilan Peer Signed-off-by: Ido Yariv

[RFC 0/3] cfg80211/mac80211: add support for IEEE802.11ax

From: Luca Coelho Hi, This series contain a squashed version of our internal series of patches that add support for IEEE802.11ax draft v1.4. It is a combination of over 40 patches, so I may have made some mistakes when squashing and splitting parts of to the right

[RFC 1/3] cfg80211: Add support for HE

From: Luca Coelho Add support for the HE in cfg80211 and also add userspace API to nl80211 to send rate information out, conforming with P802.11ax_D1.4. Additionally, remove the IEEE80211_MAX_AMPDU_BUF definition from some realtek drivers in staging because they are

[PATCH] wireless-regdb: Fix comparison of WmmRule with NoneType in python 3

Python 3 gives errors as a result of the changes to add wmm rules since Permission.wmmrule can be set to None: TypeError: '<' not supported between instances of 'WmmRule' and 'NoneType' To fix this, supply compairson methods for WmmRule instead of using the ones provided by attrs. Doing this

[PATCH] wireless-regdb: Update rules for Panama (PA) and add 60 GHz rule

Updates are based on the information in http://www.asep.gob.pa/images/telecomunicaciones/Anexos/PNAF-dic2015.pdf. Signed-off-by: Seth Forshee --- db.txt | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/db.txt b/db.txt index

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

On Wed, 2018-05-16 at 15:36 +0300, Kalle Valo wrote: > Pkshih writes: >  > > On Mon, 2018-04-30 at 14:03 +0530, Krishna Chaitanya wrote: > >> On Mon, Apr 30, 2018 at 8:10 AM, Pkshih wrote: > >> > > >> > > >> > > -Original Message- > >> > > From:

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Arend, On 05/18/2018 01:54 PM, Arend van Spriel wrote: On 5/18/2018 6:47 PM, Denis Kenzior wrote: Hi Johannes, On 05/18/2018 03:13 AM, Johannes Berg wrote: On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: __cfg80211_bss_expire function was incorrectly used to flush the BSS entries

[RFC] mac80211: add stop/start logic for software TXQs

Sometimes, it is required to stop the transmissions momentarily and resume it later; stopping the txqs becomes very critical in scenarios where the packet transmission has to be ceased completely. For example, during the hardware restart, during off channel operations, when initiating CSA(upon

[PATCH] wireless-regdb: Fix iteration in create_wmms() for python 3

The iteration in this function is over countries.itervalues(), which is not compatible with python 3. Switch to iterating over contries.values() instead. Signed-off-by: Seth Forshee --- db2fw.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On 5/18/2018 6:47 PM, Denis Kenzior wrote: Hi Johannes, On 05/18/2018 03:13 AM, Johannes Berg wrote: On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: __cfg80211_bss_expire function was incorrectly used to flush the BSS entries from the previous scan results, causing NL80211_SCAN_FLAG_FLUSH