[PATCH] ath10k: Cleanup ath10k_mac_register() error handling

2015-10-08 Thread Jeff Johnson
The logic in the error-handling path of ath10k_mac_register() is divergent from the logic in ath10k_mac_unregister(). Update the ath10k_mac_register() error handling logic to align with the ath10k_mac_unregister() logic. Signed-off-by: Jeff Johnson --- drivers/net/wireless/ath/ath10k/mac.c

Re: [PATCH v2] ath10k: remove variables which set but not used

2018-05-08 Thread Jeff Johnson
On 2018-05-07 02:39, Kenneth Lu wrote: Variable buf_len and num_vdev_stats are bging assigned but never read. typo: bging => being

Re: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture

2018-05-09 Thread Jeff Johnson
On 2018-05-09 09:42, Larry Finger wrote: Some MPIS-based SoCs use chips driven by b43 for wireless capability. typo: MPIS=>MIPS

Re: [PATCH 1/3] ath10k: Add ath10k-ct firmware feature flags and descriptions.

2018-05-11 Thread Jeff Johnson
On 2018-05-11 14:42, gree...@candelatech.com wrote: From: Ben Greear These feature flags are used by ath10k-ct firmware. Add these so we can use them in future patches and so there are no warings typo: warings => warnings

Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-17 Thread Jeff Johnson
On 2018-05-17 04:32, Ramon Fried wrote: From: Eyal Ilsar ... +static int wcn36xx_smd_process_ptt_msg_rsp(void *buf, size_t len, + void **p_ptt_rsp_msg) +{ + struct wcn36xx_hal_process_ptt_msg_rsp_msg *rsp; + int ret = 0; why initialize 're

Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-17 Thread Jeff Johnson
On 2018-05-17 04:32, Ramon Fried wrote: From: Eyal Ilsar ... +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn, + struct ieee80211_vif *vif, void *ptt_msg, size_t len, + void **ptt_rsp_msg) +{ + struct wcn36xx_hal_process_ptt_msg_req_msg *p

Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

2018-05-17 Thread Jeff Johnson
On 2018-05-17 06:25, Dedy Lansky wrote: From: Dedy Lansky Allocation size of nlmsg in cfg80211_ft_event is based on ric_ies_len and doesn't take into account ies_len. This leads to NL80211_CMD_FT_EVENT message construction failure in case ft_event contains large enough ies buffer. Add ies_len t

Re: [RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band

2019-05-30 Thread Jeff Johnson
On 2019-05-20 05:00, Arend van Spriel wrote: [...snip...] enum nl80211_band { NL80211_BAND_2GHZ, NL80211_BAND_5GHZ, + NL80211_BAND_6GHZ, NL80211_BAND_60GHZ, NUM_NL80211_BANDS, Is it not a concern that this changes the value of NL80211_BAND_60GHZ and henc

Re: [RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band

2019-05-30 Thread Jeff Johnson
On 2019-05-30 09:07, Arend Van Spriel wrote: Sigh! Obviously that is a concern. Johannes already mentioned it. Sorry, overlooked his comment on the [0/8] patch. I'll climb back under my rock.

Re: [PATCH] cfg80211: VLAN offload support for set_key and set_sta_vlan

2019-08-15 Thread Jeff Johnson
On 2019-08-15 06:38, Jouni Malinen wrote: From: Gurumoorthi Gnanasambandhan [...] By setting NL80211_EXT_FEATURE_VLAN_OFFLOAD flag the driver indicates support for a single netdev with VLAN tagged frames. Separate VLAN-specific netdevs are added using vcongig similar to Ethernet. nit: s/vcongi

Re: [RFC 0/1] Allow MAC change on up interface

2019-08-15 Thread Jeff Johnson
On 2019-08-15 11:57, James Prestwood wrote: - Adds a new NL80211_ATTR for including a "random mac" to CMD_CONNECT. This MAC is passed down the stack and gets set to the net_device's address. My initial reaction is that I'd avoid using the term "random". For some use cases the address may

Re: [PATCH] cfg80211: Add new helper function for channels

2019-08-30 Thread Jeff Johnson
On 2019-08-30 04:03, Arend Van Spriel wrote: On 8/30/2019 12:41 PM, Johannes Berg wrote: On Fri, 2019-08-30 at 12:40 +0200, Arend Van Spriel wrote: +EXPORT_SYMBOL(ieee80211_channel_op_class_to_frequency); The function ieee80211_operating_class_to_band() uses ranges within switch statement, e

Re: [PATCH v2 02/49] ath11k: add Kconfig

2019-10-21 Thread Jeff Johnson
On 2019-10-20 03:03, Kalle Valo wrote: [...snip...] +config ATH11K_TRACING + bool "ath11k tracing support" + depends on ATH11K && EVENT_TRACING + ---help--- + Select this to ath11k use tracing infrastructure. Help text does not parse